aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | | Fix a failing testJean Chalard2013-12-271-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | How/when did this happen? How was it not noticed? Change-Id: I352a8dad65f8c27bf5120d567e96d9a12cfa8496
* | | | | | | | | am d05ea8bd: Merge "[IL48] Move onEndBatchInputAsyncInternal to InputLogic."Jean Chalard2013-12-272-35/+43
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'd05ea8bd829da4110e86c38629fba94b4f560033': [IL48] Move onEndBatchInputAsyncInternal to InputLogic.
| * | | | | | | | Merge "[IL48] Move onEndBatchInputAsyncInternal to InputLogic."Jean Chalard2013-12-272-35/+43
| |\ \ \ \ \ \ \ \
| | * | | | | | | | [IL48] Move onEndBatchInputAsyncInternal to InputLogic.Jean Chalard2013-12-272-35/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 8636060 Change-Id: Idfabf7231a80e21786ce1910b5140bb3dddcac7d
* | | | | | | | | | am af26a441: Merge "[IL47] Inline getSuggestedWordsGestureLocked"Jean Chalard2013-12-271-23/+10
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'af26a44102c004844546cb8d049aa43b629f3598': [IL47] Inline getSuggestedWordsGestureLocked
| * | | | | | | | | Merge "[IL47] Inline getSuggestedWordsGestureLocked"Jean Chalard2013-12-271-23/+10
| |\| | | | | | | |
| | * | | | | | | | [IL47] Inline getSuggestedWordsGestureLockedJean Chalard2013-12-271-23/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This method is confusing with the *Locked convention, and the two-step call creates a useless callback object. This is better inlined both for readability and for performance. Bug: 8636060 Change-Id: I7c427c3ca4e831388a6d54de6728b32206a45d80
* | | | | | | | | | am 51e79fb4: Merge "[IL46] Remove a useless message passing."Jean Chalard2013-12-261-20/+2
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '51e79fb4b2025985f7cc29f43357d60c6889e3ff': [IL46] Remove a useless message passing.
| * | | | | | | | | Merge "[IL46] Remove a useless message passing."Jean Chalard2013-12-271-20/+2
| |\| | | | | | | |
| | * | | | | | | | [IL46] Remove a useless message passing.Jean Chalard2013-12-271-20/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The only point of this message is to send the processing on another thread. However, this will be accomplished later. Here is the exact call graph: 0. onUpdateBatchInput 1. -> MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP 2. -> updateBatchInputSync 3. -> getSuggestedWordsGestureLocked 4. -> MSG_GET_SUGGESTED_WORDS 5. -> LatinIME#getSuggestedWords The point of both step 1. and step 4. is to make sure the processing is happening on the InputUpdater thread. Thus, it's useless to do it twice. Bug: 11326092 Bug: 8636060 Change-Id: Iceebb9e8879a8f15b73c987f5fd3489f27699be4
* | | | | | | | | | am 2fc1cc09: Merge "[IL45] Remove lingering messages"Jean Chalard2013-12-261-4/+9
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '2fc1cc099f27442c9a3f93f8a49dd333c83a2abe': [IL45] Remove lingering messages
| * | | | | | | | | Merge "[IL45] Remove lingering messages"Jean Chalard2013-12-271-4/+9
| |\| | | | | | | |
| | * | | | | | | | [IL45] Remove lingering messagesJean Chalard2013-12-271-4/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 8636060 And possibly bug: 12085864 Change-Id: I867036bc3d8bd255dc8ceebdd30e28b4b3dc4b2d
* | | | | | | | | | am 0d212235: Merge "[IL44] Some factorization"Jean Chalard2013-12-262-27/+63
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '0d212235211e5860242baf4c77a25ae2166b5498': [IL44] Some factorization
| * | | | | | | | | Merge "[IL44] Some factorization"Jean Chalard2013-12-272-27/+63
| |\| | | | | | | | | | |/ / / / / / / | |/| | | | | | |
| | * | | | | | | [IL44] Some factorizationJean Chalard2013-12-272-27/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This sheds some light on what's happening here. Some comments were at least misleading, maybe indicating something is not sequenced as intended. Bug: 8636060 Change-Id: Ia74feb457a39fe4a672c27fe4203264fda940f04
* | | | | | | | | am c197b9ed: Merge "Make setAdditionalDictionaries private."Keisuke Kuroyanagi2013-12-263-52/+91
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'c197b9ed902f6ea8f14764bbe04c9f1541bfb8f5': Make setAdditionalDictionaries private.
| * | | | | | | | Merge "Make setAdditionalDictionaries private."Keisuke Kuroyanagi2013-12-273-52/+91
| |\ \ \ \ \ \ \ \
| | * | | | | | | | Make setAdditionalDictionaries private.Keisuke Kuroyanagi2013-12-273-52/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 8187060 Change-Id: I17be7b77ff89972d3ca6823b087b7bf35105af56
* | | | | | | | | | am 86da47e8: Fix possible NPE in FileUtils.Keisuke Kuroyanagi2013-12-261-2/+8
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '86da47e8d72f275b7f6e111930dfe205cb34423f': Fix possible NPE in FileUtils.
| * | | | | | | | | Fix possible NPE in FileUtils.Keisuke Kuroyanagi2013-12-271-2/+8
| | |/ / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I503f91e266c71e2370a5807d171e2254c334f7cb
* | | | | | | | | am 6bca9ac4: Fix a bug where predictions would not pop upon manual pickJean Chalard2013-12-263-3/+41
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '6bca9ac43d0db9a83b02577783cc609ecf13e3f4': Fix a bug where predictions would not pop upon manual pick
| * | | | | | | | Fix a bug where predictions would not pop upon manual pickJean Chalard2013-12-263-3/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 12295276 Change-Id: Id359c92acde44758b12929e7bac719d5c9c7577b
* | | | | | | | | am 33b2aaaf: Merge "Fix a code path that looks ridiculous"Jean Chalard2013-12-262-12/+12
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '33b2aaafc25acbfae1a670435ceb7cd7fe624a1c': Fix a code path that looks ridiculous
| * | | | | | | | Merge "Fix a code path that looks ridiculous"Jean Chalard2013-12-262-12/+12
| |\ \ \ \ \ \ \ \
| | * | | | | | | | Fix a code path that looks ridiculousJean Chalard2013-12-262-12/+12
| | |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 12295276 Change-Id: I187016b59213d351c943c6e0b9a2ad3708499646
* | | | | | | | | am f441047f: [IL43] Small cleanupJean Chalard2013-12-262-9/+8
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'f441047fadd6bc60b05274ca4a7195e4ff4b680d': [IL43] Small cleanup
| * | | | | | | | [IL43] Small cleanupJean Chalard2013-12-262-9/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | All calls are already passing this Bug: 8636060 Change-Id: I13accefd7c17039dc5ec12dc9e8133ebc86451ad
* | | | | | | | | am c28f0288: [IL42] Inline getSuggestedWordsOrOlderSuggestionsAsyncJean Chalard2013-12-262-39/+34
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'c28f02880c307c1bf7c11a755765ea6354150bd4': [IL42] Inline getSuggestedWordsOrOlderSuggestionsAsync
| * | | | | | | | [IL42] Inline getSuggestedWordsOrOlderSuggestionsAsyncJean Chalard2013-12-262-39/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 8636060 Change-Id: I5c47370a3ea5962caff4d40db2faa62accfc7147
* | | | | | | | | am 70433efc: [IL41] Remove a useless call and trampoline.Jean Chalard2013-12-261-14/+14
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '70433efc41970b4dc475b7e446388430aaf801b9': [IL41] Remove a useless call and trampoline.
| * | | | | | | | [IL41] Remove a useless call and trampoline.Jean Chalard2013-12-261-14/+14
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | No point in calling maybeRetrieveOlderSuggestions now that the same work is done right here. The callback is also useless now. Bug: 8636060 Change-Id: Ic14849cb6f6e6293a42cfe068f5c6b18b7677bc0
* | | | | | | | am be147f1f: Remove DictionaryFacilitatorForSuggest.getMainDictionary().Keisuke Kuroyanagi2013-12-263-30/+20
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'be147f1fdcfb5d192f64eb97e508b43da1fd9509': Remove DictionaryFacilitatorForSuggest.getMainDictionary().
| * | | | | | | Remove DictionaryFacilitatorForSuggest.getMainDictionary().Keisuke Kuroyanagi2013-12-263-30/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 8187060 Change-Id: Ide087f1e39b24695b610bd2b3c464b7e3cb9cd29
* | | | | | | | am a3744827: Extract dict operations from Suggest to a new class.Keisuke Kuroyanagi2013-12-266-360/+426
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'a374482719ef9f38395e7e39884433cc72e9cdb7': Extract dict operations from Suggest to a new class.
| * | | | | | | Extract dict operations from Suggest to a new class.Keisuke Kuroyanagi2013-12-266-360/+426
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 8187060 Change-Id: I77775aa50763158d99753c2312fa11fe14267aef
* | | | | | | | am 5c45ff12: [IL39] Change a test.Jean Chalard2013-12-261-5/+5
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '5c45ff12140c801448d0bef1991d803edc674fb8': [IL39] Change a test.
| * | | | | | | [IL39] Change a test.Jean Chalard2013-12-261-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I don't see why we would want to remove other suggestions just because the only suggestion happens to be a dictionary word. That's just inconsistent. Bug: 8636060 Change-Id: Ie2d990e5785273d625e6e5518026364165a8f2df
* | | | | | | | am 98140faa: [IL38] Fix a wrong double callJean Chalard2013-12-261-7/+7
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '98140faac34ad2250c38c5f651788308adbedb2d': [IL38] Fix a wrong double call
| * | | | | | | [IL38] Fix a wrong double callJean Chalard2013-12-261-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This only gives bad results if a gesture results in only one suggestion. Change-Id: I5a2f27f83f6901a5a9ecf22f02bdfc9cca6d9f1d
* | | | | | | | am d77ad190: Fix NPE in a unit test.Keisuke Kuroyanagi2013-12-261-0/+4
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'd77ad1902be50def82596d9c6c84c5fc988444aa': Fix NPE in a unit test.
| * | | | | | | Fix NPE in a unit test.Keisuke Kuroyanagi2013-12-261-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I0dfc23232ed77e1ff1aedecfa6ac022020cb1c19
* | | | | | | | am 65e3ae6f: Merge "Remove useless method call for spell checker."Keisuke Kuroyanagi2013-12-253-25/+22
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '65e3ae6f153a136902eaaf4da217496802c1daa1': Remove useless method call for spell checker.
| * | | | | | | Merge "Remove useless method call for spell checker."Keisuke Kuroyanagi2013-12-263-25/+22
| |\ \ \ \ \ \ \
| | * | | | | | | Remove useless method call for spell checker.Keisuke Kuroyanagi2013-12-263-25/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 8187060 Change-Id: I2f91da12ba2a9e7ce28abd06f314e0e6125d08dc
* | | | | | | | | am 3fbcf485: Merge "Add BatchInputArbiter"Tadashi G. Takaoka2013-12-254-109/+271
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '3fbcf48591e2803dfe5e8540bed2f992c3c43925': Add BatchInputArbiter
| * | | | | | | | Merge "Add BatchInputArbiter"Tadashi G. Takaoka2013-12-264-109/+271
| |\ \ \ \ \ \ \ \
| | * | | | | | | | Add BatchInputArbiterTadashi G. Takaoka2013-12-264-109/+271
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Move the logic that determines how to handle gesture typing from PointerTracker to BatchInputArbiter class. This change must be checked in together with Ia7db8f4fb7. Change-Id: I5e9f786de58d8a3cb0407ae562af707710ec37fb
* | | | | | | | | | am 30a72da4: [IL37] Small simplificationJean Chalard2013-12-253-12/+7
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '30a72da42c479adb4cedff5d7a40846a3103ac9b': [IL37] Small simplification
| * | | | | | | | | [IL37] Small simplificationJean Chalard2013-12-263-12/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 8636060 Change-Id: I08a6c04986a0bd86ce4c232893e804766ebeebb9