| Commit message (Expand) | Author | Files | Lines |
2014-02-21 | Add ImportantNoticeDialog•••Change-Id: Icaeb7dddd16362cd4a6384d295f89c7fbabc8b35
|  Tadashi G. Takaoka | 2 | -45/+93 |
2014-02-21 | Support versioned important notice•••This change must be checked in together with If38a754d00.
Bug: 10587358
Change-Id: I91580f9468bc5ee7ed1694d7852a60dc6793dac0
|  Tadashi G. Takaoka | 3 | -22/+38 |
2014-02-20 | Fix a bug where suggestions would not be updated.•••Also fix a small cosmetic bug where the suggestion strip
would flash.
Bug: 12951777
Change-Id: I68b7bb9175571de9c718f737eebd9f67ea04a931
|  Jean Chalard | 1 | -14/+33 |
2014-02-20 | Don't distrust the cursor pos so much as to bug on IPC delay•••When the cursor is moved by the user, the RichInputConnection
is told about it. However, to work around a framework bug, it
also looks at how many characters are in the buffer before the
cursor, and if that's more than the value it's been passed, it
deduces that's a framework bug and there are at least as many
characters as seen before the cursor, so it puts the expected
cursor position there.
When you move the cursor, TextView calls onUpdateSelection,
and when you move it fast, you'll get rapid-fire calls to
onUpdateSelection. This is fine, the RIC is equipped to
deal with that.
However, these calls take some time to make it to the IME. In
this instance, when the first call gets through and the IME
calls TextView (synchronously) for text before the cursor, the
cursor has already moved in the app, and TextView returns more
characters than the cursor position was declared to be in this
instance, so the RIC sets that as the expected cursor position.
Sure enough, a split second later, the second call to
onUpdateSelection arrives, with the new cursor position set
where the RIC had found it too early. The RIC takes that as an
"expected" cursor move, and the input does not get reset.
Luckily, we have a way out. As far as we know, the framework bug
only manifests itself upon rotation, which means we should only
have to adjust for it in onStartInputView. Doing it in
onUpdateSelection is too zealous (and probably too distrustful of
the app to send the correct cursor positions).
So we should just take care of the rotation case (by calling
tryFixLyingCursorPosition in onStartInputView) and remove the
compensating code in resetCachesUponCursorMoves.
Bug: 12982502
Change-Id: Ic3c1408a1ec45deaea63b01d98376a79ae567d77
|  Jean Chalard | 2 | -17/+6 |
2014-02-20 | Add test only methods to test personalized dicts.•••Bug: 11122480
Change-Id: I79a4a73ff09a2d34d4ca094d705e901fb4bc855c
|  Keisuke Kuroyanagi | 3 | -6/+33 |
2014-02-20 | Fix: UserHistoryDictionaryTests.testDecaying().•••Bug: 13106697
Change-Id: If81f77c3cefdefae94cb9145aa9f700494f8237a
|  Keisuke Kuroyanagi | 1 | -4/+14 |
2014-02-20 | Record reading error during traversing dictionaries.•••Bug: 12916055
Change-Id: I439f21aa87cfa1f71e0354370a1514af03d68f6c
|  Keisuke Kuroyanagi | 7 | -16/+59 |
2014-02-20 | Add final and volatile for members of InputLogic.•••Bug: 13107471
Change-Id: I47df79bc6f015c212d1b6d2f63b2efc5da24294e
|  Keisuke Kuroyanagi | 1 | -2/+3 |
2014-02-20 | Add user history dictionary decaying test.•••Bug: 10667710
Change-Id: Ib2be57d8c4cbbb34f64555d84ea6fd571cfdd247
|  Keisuke Kuroyanagi | 2 | -2/+64 |
2014-02-20 | Throw IOException when dict header cannot be read.•••Bug: 13106638
Change-Id: Ib48ef0a191a436552c49b6e817dfa13fe1567ae8
|  Keisuke Kuroyanagi | 1 | -0/+4 |
2014-02-20 | Change important notice version preference file•••This CL also reset the notice version to 1.
This CL must be checked in together with Iea8d9ff038.
Change-Id: I838f7b5b295388d64d6aba90f50b06654eba16e5
|  Tadashi G. Takaoka | 5 | -47/+38 |
2014-02-20 | Fix build due to Ib4c472756f•••Change-Id: I27aad91d3f821b5c0d6a3c6405b4a9d03c5bd814
|  Tadashi G. Takaoka | 1 | -1/+1 |
2014-02-20 | Revert "Turn off personalization default settings"•••This reverts commit 0a4ac795d6fdd117b590902d7f5901f0db12d25c.
Bug: 10587358
Change-Id: Ib4c472756fb9a6ebba4a66d34a9652f1b5afc714
|  Tadashi G. Takaoka | 3 | -4/+4 |
2014-02-20 | Check all enabled IME's subtypes to enable personalization.•••Bug: 13067743
Change-Id: I6fc68b5151430a5ab51777f4c381e20f5a657924
|  Keisuke Kuroyanagi | 2 | -6/+22 |
2014-02-20 | Remove a call to a deprecated method•••...that would cause a crash
Bug: 13082186
Change-Id: Ie12575c27dfdd2029bc9d5f0647e444f69770afc
|  Jean Chalard | 4 | -7/+5 |
2014-02-20 | Tweak key popup animation parameters•••Key popup show up start scale 98%
Key popup dismiss end scale 94%
Key popup show up duration 17ms
Key popup dismiss duration 53ms
Bug: 11518021
Change-Id: Icfde99969163f05cfaed1050ea074545d44db13b
|  Tadashi G. Takaoka | 1 | -4/+4 |
2014-02-20 | Comments improvements•••Typo fixes and clarifications
Change-Id: I0f7e0b6e665232bb995172fff10521c7f17599eb
|  Jean Chalard | 1 | -2/+2 |
2014-02-19 | Call PersonalizationDictionarySessionRegistrar.init().•••Wrongly removed in I1f50cb137b6054dc9.
Bug: 13067743
Change-Id: I27cd221cb7f6e403c3fc128d65d14dbf628b6f55
|  Keisuke Kuroyanagi | 1 | -0/+4 |
2014-02-19 | Fix: crash when opening a broken dictionary.•••Bug: 13085169
Change-Id: Icfb6184dfefc6a336432203c071d9e30ae8bf990
|  Keisuke Kuroyanagi | 3 | -7/+13 |
2014-02-19 | Remove personalization dicts for multilingual users.•••Bug: 13067743
Change-Id: I1f50cb137b6054dc9442237586b70fc0aa2bf427
|  Keisuke Kuroyanagi | 3 | -13/+26 |
2014-02-19 | Use AlertDialog.setOnDismissListener•••AlertDialog.Builder.setOnDismissListener is supported from API 17.
Bug: 10587358
Change-Id: Ie8ce8e283b803f7f6bb58ced446e676339f980eb
|  Tadashi G. Takaoka | 1 | -2/+2 |
2014-02-19 | Turn personalization on when important notice dialog is displayed•••This change must be checked in together with Ifde70b1d3b.
Bug: 10587358
Change-Id: I9dc48f9d521e0e6f6269e4f184389ba805f3053f
|  Tadashi G. Takaoka | 6 | -24/+77 |
2014-02-19 | Fix IllegalStateException raied by monkey•••Bug: 13082467
Change-Id: I9290974821d22067e7ddd60dce441b11ca533a0f
|  Tadashi G. Takaoka | 4 | -33/+36 |
2014-02-19 | Throw exception when the header cannot be read.•••Bug: 13066902
Change-Id: I8fd0f361a4ca55aaab8a2bd2e11f48f92b87fc93
|  Keisuke Kuroyanagi | 1 | -0/+3 |
2014-02-19 | Fix: Use old suggest after reloading.•••Change-Id: Icb2821f61c4203254b7d573cad5ce71fbf0ed841
|  Keisuke Kuroyanagi | 1 | -1/+3 |
2014-02-19 | Turn off personalization default settings•••Because the previous personalization settings default value was on,
this CL changes the preference key of the personalization settings.
Bug: 10587358
Change-Id: I80233e8af4b532d8c67d8fb184c2865862bb35dd
|  Tadashi G. Takaoka | 3 | -4/+4 |
2014-02-19 | Fix: using wrong method to call ArrayList.add.•••bug: 13072808
Change-Id: I60dc5ae1e535f2f0b3784a12c40ac082560a436f
|  Keisuke Kuroyanagi | 1 | -4/+4 |
2014-02-18 | Fix wrong Java method call function•••bug: 13072808
Change-Id: I189fda85b59ce40e3657bfbbcc313e7e1225a0da
|  Ken Wakasa | 1 | -2/+2 |
2014-02-18 | Fix build•••This is a forgotten rebase
Change-Id: I7c7c381775488ed9239dc284bd9c31247a86a972
|  Jean Chalard | 1 | -1/+1 |
2014-02-18 | Straighten out database cursors behavior.•••Some were never closed, other closed twice. This change
makes all Cursor instances behave, having the #close()
call in a finally{} clause, and puts the burden of closing
the cursor squarely on the creator rather than in the
called methods.
There is however one exception that is beyond the scope
of this change: UserDictionarySettings have a Cursor
member, it's never closed, and fixing the problem is not
obvious. This change adds a TODO for now.
It's not very clear if this change actually helps with
bug#12670151, but it may be related and it's a good
think to do anyway.
Bug: 12670151
Change-Id: I87cc44387e7dee3da1488671b93a28d9d73f7dc0
|  Jean Chalard | 8 | -136/+178 |
2014-02-18 | Fix a bug where the cache would be out of sync•••During recorrection, the cursor position when calling
commitText is not necessarily at the end of the
composing text.
Besides, RichInputConnection assumes the cursor is
always after any composing text. This is not correct,
but in the practice, it seems all code paths work.
We should fix this in the future.
Bug: 13060691
Change-Id: I15f71fff62d36e80cf6e4a022c5e78af634b199d
|  Jean Chalard | 2 | -1/+54 |
2014-02-18 | Cleanup.•••Less code, less chance of stuff escaping, and a bit of a clarification.
Yay.
Change-Id: I3193fd8ad7ac28195260cbc231c4e498a63a460c
|  Jean Chalard | 6 | -27/+12 |
2014-02-18 | Some cosmetic fixes in LatinIME.java•••Change-Id: Ia2d04ab992f5a0cc736150b2691b2f8ae8f0955d
|  Ken Wakasa | 1 | -40/+38 |
2014-02-18 | Avoid crashing when the Content URL is not found.•••I'm not sure when this can happen, but it seems it does
at least on older versions of the platform. Let's avoid
crashing.
Bug: 11618402
Change-Id: If730b5bd8f20e0f60b884eab5900099116afc5f0
|  Jean Chalard | 1 | -0/+10 |
2014-02-18 | Cosmetic fixes•••Change-Id: I6c755565ba7689357d02d26cc0e92a93031953e8
|  Ken Wakasa | 1 | -23/+30 |
2014-02-17 | Import translations. DO NOT MERGE•••Change-Id: I2025fbb4b811c98f520ec048e4df4973da651709
Auto-generated-cl: translation import
|  Baligh Uddin | 57 | -663/+453 |
2014-02-17 | Import translations. DO NOT MERGE•••Change-Id: I2dc0e76dc4c696c1a7e9748b55e1badd273aea09
Auto-generated-cl: translation import
|  Baligh Uddin | 57 | -57/+114 |
2014-02-18 | Refactor InputAttributes a bit•••Change-Id: I43d65be6de64ba86f83e8528a138e20c4fa1e3ed
|  Tadashi G. Takaoka | 1 | -117/+155 |
2014-02-18 | Set neutral suggestions should be called after load settings•••Bug: 13058751
Change-Id: Iba49e86b90d595473d91753827d499e551dad45c
|  Tadashi G. Takaoka | 3 | -41/+51 |
2014-02-18 | Update important notice version even when user select Settings•••Bug: 13060852
Change-Id: I463fdf3d51cacf99693fcde2998ea751046d1cc5
|  Tadashi G. Takaoka | 1 | -1/+1 |
2014-02-17 | Don't resume suggestion on links.•••Bug: 11447084
Change-Id: I5bd558b9dd85d1505aa918f44e8ac3e52ec42d97
|  Jean Chalard | 4 | -3/+26 |
2014-02-17 | Stop overriding InputView.dispatchTouchEvent•••Bug: 11721001
Bug: 11976254
Change-Id: I950f13ec4084da7fd9c1c25fd7abed1e5d31ed4c
|  Tadashi G. Takaoka | 1 | -56/+63 |
2014-02-17 | Catch exceptions we can't do anything about.•••This also abstracts away the "package deactivated" case for
simpler and safer code.
Bug: 11072561
Change-Id: Idaaf2ae8d8d5b2c4a15de641bbf2f8c5c7cc9410
|  Jean Chalard | 4 | -44/+118 |
2014-02-17 | Make dotted i the base character of dotless i.•••This is already the case for the capital version, and natives
Turkish speakers seem to think it should be the case. An
important reason to make it so is that the Turkish keyboard
has only the dotless i as a "more keys" key, so it's really
hard to type words with a dotless i without this, especially
those with several of them.
Bug: 11519119
Change-Id: I4df2a289783e4eb3c1291b8ad0a2ba5947bf7671
|  Jean Chalard | 1 | -1/+2 |
2014-02-17 | Consider non-breaking spaces separators.•••Bug: 13056209
Change-Id: I6100b3ee21cf143140398757d9f7e7445067877a
|  Jean Chalard | 4 | -4/+4 |
2014-02-17 | Stop overriding SuggestionStripView.dispatchTouchEvent•••Bug: 11721001
Bug: 11976254
Change-Id: Idfdeafe45abb16ca54be529b4f4b2c38c22a7fac
|  Tadashi G. Takaoka | 1 | -24/+23 |
2014-02-17 | Remove unnecessary override of MainKeyboardView.dispatchTouchEvent•••Bug: 11721001
Bug: 11976254
Change-Id: I762bd9e76ea31d67b3e31c3a0a19ee9f040015b8
|  Tadashi G. Takaoka | 2 | -21/+0 |
2014-02-17 | Add InputMethodSubtypeCompatUtils.isAsciiCapable()•••Change-Id: I8145f090486f6fe30ef1e992db374cfba0c31012
|  Tadashi G. Takaoka | 3 | -6/+20 |
2014-02-17 | Don't show important notice on password field•••Bug: 10587358
Change-Id: Ieff7960e5e2b8609fddeb173af578a5d9b2c4d98
|  Tadashi G. Takaoka | 4 | -12/+27 |
2014-02-17 | Stop using deprecated InputMethodSubtype constructor•••The constructors of InputMethodSubtype were deprecated in API level 19.
However we cannot yet switch to a new InputMethodSubtypeBuilder style
due to our minimum support API level.
As an intermediate solution, this patch replaces the these API calls
with InputMethodSubtypeCompatUtils.newInputMethodSubtype so that
these legacy API call can be consolidated at the same place.
BUG: 13030512
Change-Id: I561a585f5dbea56c337680b645be5ef07015a0b1
|  Yohei Yukawa | 1 | -11/+20 |