| Commit message (Expand) | Author | Files | Lines |
|---|
| 2011-12-14 | Fix a long-standing race condition.•••Upon autocorrection, there is visual feedback in the text
view that quickly flashes the background of the text that
just changed. This fixes a race condition that happens
upon autocorrection when typing fast, and that results in
flashing one character too far left (typically, the flashing
area includes the whitespace before the corrected word and
not the last character of the corrected word).
This happens because the call to commitCorrection may
happen before or after the IPC sent by sendKeyChar, but the
arguments are fit only for the case where it arrives first.
Change-Id: I9b5442a665aad5a9bc66cd49228075b9056b37fa
|   Jean Chalard | 1 | -15/+15 |
| 2011-12-14 | Add a note of documentation to the sample word list•••Change-Id: I95f09da03457933a14b549e04575d566de97dd49
| Jean Chalard | 1 | -2/+3 |
| 2011-12-13 | Decouple member logic from control flow•••This place is very confusing because a member variable with
a consistent meaning is hijacked for the duration of a function
to mean something else. This is in the way of easy-to-understand
refactoring.
Change-Id: If79bc771950d6bfc0ad5f0e9c51c7ef1dbb45b66
| Jean Chalard | 1 | -4/+8 |
| 2011-12-13 | Various mini-cleanups•••- Stop the word composer from escaping - take a page from the law
of Demeter and only report what is actually needed.
- Fix typos in comments.
- Add a comment for a fishy processing.
- Remove a useless local variable.
Change-Id: I5fa78901cbb5483fc9683bfb7094f47244b85df6
| Jean Chalard | 4 | -10/+11 |
| 2011-12-13 | Reorganize LatinIME native build directory structure. Now it got NDK friendly.•••Change-Id: I0f62ce8a6a4d2b6134db698f8b8d0576616e524d
|   Ken Wakasa | 7 | -71/+119 |
| 2011-12-13 | Remove the input connection sidework from handleCharacter•••Change-Id: I3d376dfda3acd8864274390de3ff5752b18456e0
| Jean Chalard | 1 | -6/+10 |
| 2011-12-13 | Move mBestWord to the word composer.•••mBestWord has a confusing name - it's actually an auto-correction.
It's cleaner if it lives in the word composer because an
auto-correction should be tied to a specific user input, and
should be reset each time the user input changes to avoid
race conditions.
Change-Id: I718d29395bc747372067e6440e090c6a181994ae
| Jean Chalard | 2 | -19/+55 |
| 2011-12-13 | Introduce KeyboardSet to hold related KeyboardIds•••This change moves
* KeyboardSwitcher.getKeyboardId to KeyboardSet.<init> and
KeyboardSet.getKeyboardId.
* KeyboardSwitcher.getF2KeyMode to KeyboardSet.
This is the first step to get rid of shift state from Keyboard.
Bug: 5002108
Bug: 5679585
Change-Id: I2a5a97e5e89277bc606916d45c1afbc8d105d773
|   Tadashi G. Takaoka | 2 | -80/+144 |
| 2011-12-13 | Consolidate underlining code under one function.•••Change-Id: I4393ff1ec28a6b3118d1344dd6d82d04899dea42
| Jean Chalard | 1 | -18/+17 |
| 2011-12-13 | Tighten conditions for space-related cancelling•••Instead of ignoring silently a found bug, throw an exception.
Change-Id: I0aa96d0cab022b6a5e7cffe8a592dcc443c3c7a8
| Jean Chalard | 1 | -4/+10 |
| 2011-12-13 | Extract the jni library name•••Change-Id: Icc58ccea1178d9f35f5be0dceebab67bbb965b7f
|   satok | 2 | -2/+28 |
| 2011-12-13 | Remove KeyboardSwitcher.updateShiftLockState method•••Change-Id: I032fc50a62a573ba4258530e695c8c88467783c6
| Tadashi G. Takaoka | 1 | -15/+7 |
| 2011-12-13 | Remove a useless return•••Change-Id: Iefe10e94e2d88171387351a5b6cab52e281d0f76
| Jean Chalard | 1 | -3/+0 |
| 2011-12-13 | Use priority queue for native string buffer•••+1 2
-6 2
Performance
before
==== test finished, terminate logcat =====
(0) 100.34 (0.26%)
(1) 37149.26 (95.30%)
(2) 8.43 (0.02%)
(3) 11.18 (0.03%)
(4) 9.92 (0.03%)
(5) 1330.60 (3.41%)
(6) 250.46 (0.64%)
(20) 12.41 (0.03%)
Total 38982.50 (sum of others 38872.59)
after
==== test finished, terminate logcat =====
(0) 97.65 (0.26%)
(1) 35427.43 (95.32%)
(2) 10.30 (0.03%)
(3) 8.95 (0.02%)
(4) 11.01 (0.03%)
(5) 1224.67 (3.30%)
(6) 243.76 (0.66%)
(20) 40.91 (0.11%)
Total 37167.04 (sum of others 37064.68)
Change-Id: Id4d3b88a9cdef765affc52973aeac951ecc6a8ca
| satok | 5 | -85/+178 |
| 2011-12-13 | Simplification•••Both tests have the same meaning. They should be merged.
Also, if "deleteLast()" deletes more than one char (which
never happens in the current implementation, but it's not
guaranteed), the new code is more correct.
Change-Id: I216df7cd45f4a7d76d1d5d6aa7f8d7f9a6e35ea3
| Jean Chalard | 1 | -4/+2 |
| 2011-12-13 | Refactoring•••If mHasUncommittedTypedChars is true, then
mWordSavedForAutoCorrectCancellation must always be null, and
spaceState must always be SPACE_STATE_NONE.
Hence, this change is supposed to be very no-op.
Change-Id: I2716f7372d996cc4dec40a4b7ac1ee7f5f4afe91
| Jean Chalard | 1 | -21/+18 |
| 2011-12-13 | Refactor + small bugfix•••postUpdateShiftKeyState used to be called also when
mEnteredText is not null => this is a bugfix.
The rest does not change the logic, as posting a message can
be done anywhere within the function with no impact.
Change-Id: I7888797c0778702d64f96701e35b611a55a6a259
| Jean Chalard | 1 | -4/+3 |
| 2011-12-13 | Refactoring•••Change-Id: I57b2232f7fde32df5f6e1925aad1df988def34f9
| Jean Chalard | 1 | -7/+5 |
| 2011-12-13 | Remove current keyboard id variable•••Change-Id: Iec19af98209e1ea8ecd176d3be04d628d4b38950
| Tadashi G. Takaoka | 1 | -5/+3 |
| 2011-12-12 | Fix a bug where revert auto-correct would revert too much•••If there are no uncommitted chars, we shouldn't enter any of
the tests that follow. We didn't use to, but a change today
made it possible - it should not happen.
There is no point in doing the rest of the tests, they are
sure to fail.
Change-Id: I580dd104aff3585de72a93b38989bfd9713f615b
| Jean Chalard | 1 | -8/+24 |
| 2011-12-12 | Remove a useless function call•••Change-Id: I1a775cbf90dca301e1e6b596ddac64fdbc023199
| Jean Chalard | 1 | -1/+0 |
| 2011-12-12 | Remove a useless variable•••This can be just read when it's needed.
Change-Id: I00753fe55645c244db5d4a96e7fdb8f5325475d9
| Jean Chalard | 1 | -3/+2 |
| 2011-12-12 | Move a settings var to the settings class•••Change-Id: I1331ad6dec3a9d64a77e314f8a1f4c29282df31b
| Jean Chalard | 2 | -2/+3 |
| 2011-12-12 | Remove a messy and unused class.•••Today is a happy day
Change-Id: I3ef484bd258d5a59815bfcb0bd35ea3606b32430
| Jean Chalard | 2 | -225/+0 |
| 2011-12-12 | Remove side-effects from TextEntryState•••Change-Id: Ib98eea9e791e426435cfdfd0c9ab3ed9061664aa
| Jean Chalard | 3 | -12/+41 |
| 2011-12-12 | Add special handling for "Phone number" layout.•••Bug: 5743584
Change-Id: I821b837a2078afb64b460191c98b28f7733cf2c1
| Tadashi G. Takaoka | 1 | -0/+6 |
| 2011-12-12 | Remove a useless variable.•••Change-Id: Iea5ce5cfc05bad8b1d9085438e90147bd54b7e9c
| Jean Chalard | 1 | -5/+1 |
| 2011-12-12 | Straighten out logic for revert word paths•••This also includes a new memorized string with simpler
logic that will allow to remove other members
Change-Id: I0b97243084902e68fcb835b6163c86fef8190ebc
| Jean Chalard | 1 | -30/+67 |
| 2011-12-12 | Add unit test of KeyboardState•••Bug: 5708602
Change-Id: I1a8a9f4320948bb500a96df8773b0bfa1a1d4167
| Tadashi G. Takaoka | 2 | -3/+263 |
| 2011-12-12 | Move KeyDetector.printableCode to Keyboard•••Change-Id: I9cde21fbb45c1e5f1a568bb97b1b1a76524f4bf2
| Tadashi G. Takaoka | 3 | -10/+23 |
| 2011-12-12 | Assign Key.mCode from the label only when outputText is not specified•••Bug: 5742827
Change-Id: I72b55ce246b14a2d8f4fd16211b71dc716db30b2
| Tadashi G. Takaoka | 1 | -1/+8 |
| 2011-12-12 | Remove unused Keyboard.CODE_CANCEL•••Change-Id: Ic2eab17e525901a1cf7096ebe7d24ae78624ed2e
| Tadashi G. Takaoka | 2 | -6/+0 |
| 2011-12-12 | Remove a duplicated variable.•••This is awesome cleanup.
Change-Id: I35ce8940a13f3084630dc26d6e7e397acfdaac36
| Jean Chalard | 3 | -37/+27 |
| 2011-12-10 | Build God Mode keyboard with API level 14•••Change-Id: I29ab9e9041c9faac91dc303175625221bfdb3af8
| Ken Wakasa | 2 | -1/+46 |
| 2011-12-10 | Fix isResearcherPackage•••Change-Id: I286450fe89a37d75cb398f17d300ddc6f5857ffd
| satok | 2 | -3/+2 |
| 2011-12-10 | Some tweaks for Researcher Mode•••Change-Id: I6b16dd2fe6d7356c747ba0ee2da5976738003ded
| Ken Wakasa | 3 | -4/+10 |
| 2011-12-09 | Add a functionality to attach a log file to Gmail app•••Bug: 5722703
Change-Id: I089f944bdbf2cbb036eb59dd9b5b414370c770f1
| satok | 1 | -27/+85 |
| 2011-12-09 | Resolve TODOs: add members to hold preferences•••Change-Id: I34f6c76bf9318e1fbe8eb5ffab6772a98ff824e0
| Jean Chalard | 1 | -3/+9 |
| 2011-12-09 | Remove unused public methods from KeyboardState and KeyboardSwitcher•••Bug: 5708602
Change-Id: I3dbc3cd00aa9ddf611e2078ff2cfea8945fa09bf
| Tadashi G. Takaoka | 3 | -75/+42 |
| 2011-12-09 | Resolve TODOs: add some members to store prefs•••Change-Id: Idf09cb5d801e8008eb63cbb5138058faeb7db136
| Jean Chalard | 2 | -11/+21 |
| 2011-12-09 | Resolve TODOs: add members to store raw settings•••Change-Id: I481eadb6a73faf239e24d05b7e220fcb01194fa4
| Jean Chalard | 1 | -17/+17 |
| 2011-12-09 | Read options in the declaration order•••Change-Id: I1a7c4d0bcaedad6d4045c36c79280c23234db5b3
| Jean Chalard | 1 | -3/+2 |
| 2011-12-09 | Straighten out prefs reading code•••Change-Id: Ibf9113a8ef07ac720100ee32d2e5ef321e8ddd98
| Jean Chalard | 2 | -20/+31 |
| 2011-12-09 | Straighten out members extracted from resources.•••Change-Id: I9b9602ec5b379b44b0f0663d4f065dbcf88fd352
| Jean Chalard | 1 | -23/+29 |
| 2011-12-09 | Match constant names to option names•••Change-Id: I7586fa342d7a39412d656890f7b525139c45ea4a
| Jean Chalard | 2 | -28/+28 |
| 2011-12-09 | Reorder members in SettingsValues.•••Reorder so that they match the order in the preference xml
file. Also add TODOs for missing raw variables.
Change-Id: I06332c131a624d6c359512d75c808f3f7313fa91
| Jean Chalard | 2 | -32/+33 |
| 2011-12-09 | Move settings variables to the settings class•••Change-Id: Ifa7033a84b08ea626eb44cf6d04ba8e28c250bea
| Jean Chalard | 3 | -21/+18 |
| 2011-12-09 | KeyboardState keeps track of isAlphabetMode and isSymbolShifted•••Bug: 5708602
Change-Id: I181cdeb90d24984ce6f6c993b278293aae7364eb
| Tadashi G. Takaoka | 2 | -71/+70 |
| 2011-12-09 | Stop a flag from escaping.•••The ultimate intent is to close it up in the settings, as it does not
change while typing, only when the keyboard is open again.
Change-Id: I12ff56e7482c1584877fe5531473bf03e95a60f6
| Jean Chalard | 4 | -33/+26 |
| 2011-12-09 | Move settings method from Utils to SettingsValues•••Change-Id: I633378a41f63cd492b8c9345d550e07254df5e5a
| Jean Chalard | 4 | -42/+42 |
