| Commit message (Expand) | Author | Files | Lines |
2014-01-08 | Fix a race condition, take 2.•••Don't use absolute cursor positions when making edits,
this leads to race conditions.
This is a bit ugly and will need to be fixed soon. Plans are
underway to clean this up.
Bug: 12390573
Change-Id: Ib42d4149343c642b1b5c1937b424e8afdbd4cc1f
|  Jean Chalard | 2 | -5/+18 |
2014-01-08 | Revert "Revert "Fix a race condition.""•••This reverts commit 38401272446dbaec785e656b921cfbd31162ba09.
Change-Id: I7f0d975ec9e18d94fe3505250360c2b79ccbe96d
|  Jean Chalard | 1 | -2/+5 |
2014-01-08 | Rename InputPointers.addPointer and ResizableIntArray.add•••Change-Id: I5580250c91b29f93ed886b080ce33845b3b67ace
|  Tadashi G. Takaoka | 6 | -21/+19 |
2014-01-08 | Fix ResizableIntArrayTests readability•••Change-Id: I68862b98f228210f1d76fef4fd7454edbfd8e01d
|  Tadashi G. Takaoka | 2 | -69/+90 |
2014-01-08 | Fix InputPointersTests•••InputPointers.getTime(int) has a validity check of time values. And
the check is enabled when LatinImeLogger.sDBG is on. Such situation
may occur while unit testing. This change ensure that time values are
monotonic while unit testing.
Change-Id: I9ff2cff2bcd253de0e8206dd3be964fe565170fa
|  Tadashi G. Takaoka | 2 | -95/+163 |
2014-01-08 | Fix: NPE in LatinIME.loadSettnigs().•••Change-Id: Icae6c74401a7a8f4da6015737f09f557640c0cca
|  Keisuke Kuroyanagi | 1 | -2/+4 |
2014-01-08 | Separate spacing and punctuation related settings values•••Bug: 12179576
Change-Id: Ibafd824a0ea2251843b388e95dcbd8f9bca92d5c
|  Tadashi G. Takaoka | 6 | -85/+153 |
2014-01-07 | Revert "Fix a race condition."•••This reverts commit 42e83c7f06a1683b27a11564aeb9f3999b10382f.
Bug: 12434783
Change-Id: Id01b6d14906430b13e64f5fc4d7fb01572d0a960
|  Victoria Lease | 1 | -5/+2 |
2014-01-07 | Import translations. DO NOT MERGE•••Change-Id: Ia0ef830a5bb3ed6fee1a5d113b2baec60bb51a97
Auto-generated-cl: translation import
|  Baligh Uddin | 55 | -10/+120 |
2014-01-07 | Import translations. DO NOT MERGE•••Change-Id: I3e0560396e087669ff484b6c15d0f0eb03c02de5
Auto-generated-cl: translation import
|  Baligh Uddin | 2 | -10/+10 |
2014-01-07 | Prepare using dictionaryFacilitator for amanatto updates.•••Bug: 11736529
Change-Id: I0d9d9b1c1108b11064163df7c2089f53e92cd7ad
|  Keisuke Kuroyanagi | 2 | -4/+12 |
2014-01-07 | Update personalized dict only when single subtype is used.•••Bug: 12424891
Change-Id: If041d1ab45988dbf9b878ae3367fee0fbc8a8988
|  Keisuke Kuroyanagi | 3 | -3/+19 |
2014-01-07 | Fix a race condition.•••Don't use absolute cursor positions, this leads to race
conditions.
Bug: 12390573
Change-Id: I6f04f07a46babbc3d51cb94c7eaee21bed242396
|  Jean Chalard | 1 | -2/+5 |
2014-01-06 | Fix possible NPE.•••Bug: 11933670
Change-Id: Ib0ce853e691bdadffb73874ea9f188cfbec8bc93
|  Keisuke Kuroyanagi | 3 | -2/+19 |
2014-01-06 | Remove language switch key from symbols and symbols shift keyboard•••This change also fixes the background color of the left keys of the space key.
Bug: 12407208
Change-Id: Id869605146e9f72835f892c3c7ae14f118177394
|  Tadashi G. Takaoka | 5 | -47/+8 |
2014-01-06 | Add description of disabled voice input key option•••Bug: 12377179
Change-Id: I44d35c6fa82883710674ecca6f630d09076472fe
|  Tadashi G. Takaoka | 2 | -2/+10 |
2014-01-06 | Update shortcut IME info before checking availability of it•••Bug: 12377179
Change-Id: I4e2de78dc7e21f3f34eb56c790160b77cfc7584c
|  Tadashi G. Takaoka | 1 | -2/+6 |
2014-01-06 | Add DictionaryFacilitatorForSuggest constructor for testing•••This change must be checked in together with I00b6e79d6b.
Change-Id: Id5f87a8d0286eb44958381fefd428f16896dc0d4
|  Tadashi G. Takaoka | 3 | -11/+51 |
2013-12-27 | [IL52] Remove a useless method.•••This old method doesn't even re-read the old suggestions. It used to
recompute them without the coordinates.
Re-using the recorrection code, which is much more advanced, is
the right thing to do here.
Also, refining the test. It's no use trying to resume suggestion
if we don't have a suggestion strip, since we aren't going to
auto-correct anything anyway.
Not the motivation for this change, but this also fixes
Bug: 11620256
Change-Id: Id49efa32e293c49837c61fdc752c86bbac1d2c88
|  Jean Chalard | 5 | -80/+32 |
2013-12-27 | [IL51] Make private what can be made private•••Bug: 8636060
Change-Id: Ifa027de465a421b67897d51e9ad47666dda117ad
|  Jean Chalard | 1 | -6/+4 |
2013-12-27 | [IL50] Move the InputUpdater out of LatinIME.•••...at last
Bug: 8636060
Change-Id: If5e27a9d28ff64d318dd76792f55edfc8a78d2d7
|  Jean Chalard | 3 | -201/+168 |
2013-12-27 | [IL49] Move InputLogic-related init code to InputLogic.•••Bug: 8636060
Change-Id: Ie5027512f066d9c530a686ac559e4649a39bf439
|  Jean Chalard | 2 | -19/+22 |
2013-12-27 | Fix a failing test•••How/when did this happen? How was it not noticed?
Change-Id: I352a8dad65f8c27bf5120d567e96d9a12cfa8496
|  Jean Chalard | 1 | -2/+3 |
2013-12-27 | [IL48] Move onEndBatchInputAsyncInternal to InputLogic.•••Bug: 8636060
Change-Id: Idfabf7231a80e21786ce1910b5140bb3dddcac7d
|  Jean Chalard | 2 | -35/+43 |
2013-12-27 | [IL47] Inline getSuggestedWordsGestureLocked•••This method is confusing with the *Locked convention, and
the two-step call creates a useless callback object. This is
better inlined both for readability and for performance.
Bug: 8636060
Change-Id: I7c427c3ca4e831388a6d54de6728b32206a45d80
|  Jean Chalard | 1 | -23/+10 |
2013-12-27 | [IL46] Remove a useless message passing.•••The only point of this message is to send the processing on another
thread. However, this will be accomplished later.
Here is the exact call graph:
0. onUpdateBatchInput
1. -> MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP
2. -> updateBatchInputSync
3. -> getSuggestedWordsGestureLocked
4. -> MSG_GET_SUGGESTED_WORDS
5. -> LatinIME#getSuggestedWords
The point of both step 1. and step 4. is to make sure the processing
is happening on the InputUpdater thread. Thus, it's useless to do
it twice.
Bug: 11326092
Bug: 8636060
Change-Id: Iceebb9e8879a8f15b73c987f5fd3489f27699be4
|  Jean Chalard | 1 | -20/+2 |
2013-12-27 | [IL45] Remove lingering messages•••Bug: 8636060
And possibly bug: 12085864
Change-Id: I867036bc3d8bd255dc8ceebdd30e28b4b3dc4b2d
|  Jean Chalard | 1 | -4/+9 |
2013-12-27 | [IL44] Some factorization•••This sheds some light on what's happening here. Some
comments were at least misleading, maybe indicating something
is not sequenced as intended.
Bug: 8636060
Change-Id: Ia74feb457a39fe4a672c27fe4203264fda940f04
|  Jean Chalard | 2 | -27/+63 |
2013-12-27 | Fix possible NPE in FileUtils.•••Change-Id: I503f91e266c71e2370a5807d171e2254c334f7cb
|  Keisuke Kuroyanagi | 1 | -2/+8 |
2013-12-27 | Make setAdditionalDictionaries private.•••Bug: 8187060
Change-Id: I17be7b77ff89972d3ca6823b087b7bf35105af56
|  Keisuke Kuroyanagi | 3 | -52/+91 |
2013-12-26 | Fix a bug where predictions would not pop upon manual pick•••Bug: 12295276
Change-Id: Id359c92acde44758b12929e7bac719d5c9c7577b
|  Jean Chalard | 3 | -3/+41 |
2013-12-26 | Fix a code path that looks ridiculous•••Bug: 12295276
Change-Id: I187016b59213d351c943c6e0b9a2ad3708499646
|  Jean Chalard | 2 | -12/+12 |
2013-12-26 | [IL43] Small cleanup•••All calls are already passing this
Bug: 8636060
Change-Id: I13accefd7c17039dc5ec12dc9e8133ebc86451ad
|  Jean Chalard | 2 | -9/+8 |
2013-12-26 | [IL42] Inline getSuggestedWordsOrOlderSuggestionsAsync•••Bug: 8636060
Change-Id: I5c47370a3ea5962caff4d40db2faa62accfc7147
|  Jean Chalard | 2 | -39/+34 |
2013-12-26 | [IL41] Remove a useless call and trampoline.•••No point in calling maybeRetrieveOlderSuggestions now that the
same work is done right here. The callback is also useless now.
Bug: 8636060
Change-Id: Ic14849cb6f6e6293a42cfe068f5c6b18b7677bc0
|  Jean Chalard | 1 | -14/+14 |
2013-12-26 | Remove DictionaryFacilitatorForSuggest.getMainDictionary().•••Bug: 8187060
Change-Id: Ide087f1e39b24695b610bd2b3c464b7e3cb9cd29
|  Keisuke Kuroyanagi | 3 | -30/+20 |
2013-12-26 | Extract dict operations from Suggest to a new class.•••Bug: 8187060
Change-Id: I77775aa50763158d99753c2312fa11fe14267aef
|  Keisuke Kuroyanagi | 6 | -360/+426 |
2013-12-26 | [IL39] Change a test.•••I don't see why we would want to remove other suggestions just because
the only suggestion happens to be a dictionary word. That's just
inconsistent.
Bug: 8636060
Change-Id: Ie2d990e5785273d625e6e5518026364165a8f2df
|  Jean Chalard | 1 | -5/+5 |
2013-12-26 | [IL38] Fix a wrong double call•••This only gives bad results if a gesture results in only one suggestion.
Change-Id: I5a2f27f83f6901a5a9ecf22f02bdfc9cca6d9f1d
|  Jean Chalard | 1 | -7/+7 |
2013-12-26 | Fix NPE in a unit test.•••Change-Id: I0dfc23232ed77e1ff1aedecfa6ac022020cb1c19
|  Keisuke Kuroyanagi | 1 | -0/+4 |
2013-12-26 | Remove useless method call for spell checker.•••Bug: 8187060
Change-Id: I2f91da12ba2a9e7ce28abd06f314e0e6125d08dc
|  Keisuke Kuroyanagi | 3 | -25/+22 |
2013-12-26 | Add BatchInputArbiter•••Move the logic that determines how to handle gesture typing from
PointerTracker to BatchInputArbiter class.
This change must be checked in together with Ia7db8f4fb7.
Change-Id: I5e9f786de58d8a3cb0407ae562af707710ec37fb
|  Tadashi G. Takaoka | 4 | -109/+271 |
2013-12-26 | [IL37] Small simplification•••Bug: 8636060
Change-Id: I08a6c04986a0bd86ce4c232893e804766ebeebb9
|  Jean Chalard | 3 | -12/+7 |
2013-12-26 | [IL36] Inline setAutoCorrection•••There are far too many one-use methods.
Bug: 8636060
Change-Id: I84e0669b8d2cc5a2817c42b089e874dc60e84769
|  Jean Chalard | 1 | -14/+9 |
2013-12-25 | [IL35] Preparative cleanup•••Bug: 8636060
Change-Id: Id6791085816891c78289b0223bf0807db2da6300
|  Jean Chalard | 2 | -13/+14 |
2013-12-25 | Remove "Boost personalization dictionary" from settings.•••Change-Id: Iab05e42e947610f358472cd95d0319d0ab3f0b31
|  Keisuke Kuroyanagi | 3 | -10/+0 |
2013-12-25 | Use SettingsValues instead of Settings in Suggest.•••Bug: 8187060
Change-Id: Idba1e708d67c036072b728949d17f8bd98ae0115
|  Keisuke Kuroyanagi | 4 | -29/+7 |
2013-12-25 | Move dict operations to Suggest.•••Bug: 8187060
Change-Id: Iabe13abcd43b381360f7080b3f4ee0533f246160
|  Keisuke Kuroyanagi | 4 | -98/+96 |
2013-12-25 | Separate GestureStrokeDrawingPoints from GestureStrokeRecognitionPoints•••This change must be checked in together with Ibed5330614.
Change-Id: I20ba79fd20e8ea0aa3ac596c011ec5bfea528ace
|  Tadashi G. Takaoka | 3 | -39/+37 |
2013-12-25 | [IL34] Introduce InputLogicHandler•••Bug: 8636060
Change-Id: I5d08ed5d69cdb03bd188e36b7014de03f04fa72f
|  Jean Chalard | 2 | -0/+55 |