Commit message (Expand) | Author | Files | Lines | |
---|---|---|---|---|
2013-12-27 | [IL49] Move InputLogic-related init code to InputLogic.•••Bug: 8636060 Change-Id: Ie5027512f066d9c530a686ac559e4649a39bf439 | 2 | -19/+22 | |
2013-12-27 | Fix a failing test•••How/when did this happen? How was it not noticed? Change-Id: I352a8dad65f8c27bf5120d567e96d9a12cfa8496 | 1 | -2/+3 | |
2013-12-27 | [IL48] Move onEndBatchInputAsyncInternal to InputLogic.•••Bug: 8636060 Change-Id: Idfabf7231a80e21786ce1910b5140bb3dddcac7d | 2 | -35/+43 | |
2013-12-27 | [IL47] Inline getSuggestedWordsGestureLocked•••This method is confusing with the *Locked convention, and the two-step call creates a useless callback object. This is better inlined both for readability and for performance. Bug: 8636060 Change-Id: I7c427c3ca4e831388a6d54de6728b32206a45d80 | 1 | -23/+10 | |
2013-12-27 | [IL46] Remove a useless message passing.•••The only point of this message is to send the processing on another thread. However, this will be accomplished later. Here is the exact call graph: 0. onUpdateBatchInput 1. -> MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP 2. -> updateBatchInputSync 3. -> getSuggestedWordsGestureLocked 4. -> MSG_GET_SUGGESTED_WORDS 5. -> LatinIME#getSuggestedWords The point of both step 1. and step 4. is to make sure the processing is happening on the InputUpdater thread. Thus, it's useless to do it twice. Bug: 11326092 Bug: 8636060 Change-Id: Iceebb9e8879a8f15b73c987f5fd3489f27699be4 | 1 | -20/+2 | |
2013-12-27 | [IL45] Remove lingering messages•••Bug: 8636060 And possibly bug: 12085864 Change-Id: I867036bc3d8bd255dc8ceebdd30e28b4b3dc4b2d | 1 | -4/+9 | |
2013-12-27 | [IL44] Some factorization•••This sheds some light on what's happening here. Some comments were at least misleading, maybe indicating something is not sequenced as intended. Bug: 8636060 Change-Id: Ia74feb457a39fe4a672c27fe4203264fda940f04 | 2 | -27/+63 | |
2013-12-27 | Fix possible NPE in FileUtils.•••Change-Id: I503f91e266c71e2370a5807d171e2254c334f7cb | 1 | -2/+8 | |
2013-12-27 | Make setAdditionalDictionaries private.•••Bug: 8187060 Change-Id: I17be7b77ff89972d3ca6823b087b7bf35105af56 | 3 | -52/+91 | |
2013-12-26 | Fix a bug where predictions would not pop upon manual pick•••Bug: 12295276 Change-Id: Id359c92acde44758b12929e7bac719d5c9c7577b | 3 | -3/+41 | |
2013-12-26 | Fix a code path that looks ridiculous•••Bug: 12295276 Change-Id: I187016b59213d351c943c6e0b9a2ad3708499646 | 2 | -12/+12 | |
2013-12-26 | [IL43] Small cleanup•••All calls are already passing this Bug: 8636060 Change-Id: I13accefd7c17039dc5ec12dc9e8133ebc86451ad | 2 | -9/+8 | |
2013-12-26 | [IL42] Inline getSuggestedWordsOrOlderSuggestionsAsync•••Bug: 8636060 Change-Id: I5c47370a3ea5962caff4d40db2faa62accfc7147 | 2 | -39/+34 | |
2013-12-26 | [IL41] Remove a useless call and trampoline.•••No point in calling maybeRetrieveOlderSuggestions now that the same work is done right here. The callback is also useless now. Bug: 8636060 Change-Id: Ic14849cb6f6e6293a42cfe068f5c6b18b7677bc0 | 1 | -14/+14 | |
2013-12-26 | Remove DictionaryFacilitatorForSuggest.getMainDictionary().•••Bug: 8187060 Change-Id: Ide087f1e39b24695b610bd2b3c464b7e3cb9cd29 | 3 | -30/+20 | |
2013-12-26 | Extract dict operations from Suggest to a new class.•••Bug: 8187060 Change-Id: I77775aa50763158d99753c2312fa11fe14267aef | 6 | -360/+426 | |
2013-12-26 | [IL39] Change a test.•••I don't see why we would want to remove other suggestions just because the only suggestion happens to be a dictionary word. That's just inconsistent. Bug: 8636060 Change-Id: Ie2d990e5785273d625e6e5518026364165a8f2df | 1 | -5/+5 | |
2013-12-26 | [IL38] Fix a wrong double call•••This only gives bad results if a gesture results in only one suggestion. Change-Id: I5a2f27f83f6901a5a9ecf22f02bdfc9cca6d9f1d | 1 | -7/+7 | |
2013-12-26 | Fix NPE in a unit test.•••Change-Id: I0dfc23232ed77e1ff1aedecfa6ac022020cb1c19 | 1 | -0/+4 | |
2013-12-26 | Remove useless method call for spell checker.•••Bug: 8187060 Change-Id: I2f91da12ba2a9e7ce28abd06f314e0e6125d08dc | 3 | -25/+22 | |
2013-12-26 | Add BatchInputArbiter•••Move the logic that determines how to handle gesture typing from PointerTracker to BatchInputArbiter class. This change must be checked in together with Ia7db8f4fb7. Change-Id: I5e9f786de58d8a3cb0407ae562af707710ec37fb | 4 | -109/+271 | |
2013-12-26 | [IL37] Small simplification•••Bug: 8636060 Change-Id: I08a6c04986a0bd86ce4c232893e804766ebeebb9 | 3 | -12/+7 | |
2013-12-26 | [IL36] Inline setAutoCorrection•••There are far too many one-use methods. Bug: 8636060 Change-Id: I84e0669b8d2cc5a2817c42b089e874dc60e84769 | 1 | -14/+9 | |
2013-12-25 | [IL35] Preparative cleanup•••Bug: 8636060 Change-Id: Id6791085816891c78289b0223bf0807db2da6300 | 2 | -13/+14 | |
2013-12-25 | Remove "Boost personalization dictionary" from settings.•••Change-Id: Iab05e42e947610f358472cd95d0319d0ab3f0b31 | 3 | -10/+0 | |
2013-12-25 | Use SettingsValues instead of Settings in Suggest.•••Bug: 8187060 Change-Id: Idba1e708d67c036072b728949d17f8bd98ae0115 | 4 | -29/+7 | |
2013-12-25 | Move dict operations to Suggest.•••Bug: 8187060 Change-Id: Iabe13abcd43b381360f7080b3f4ee0533f246160 | 4 | -98/+96 | |
2013-12-25 | Separate GestureStrokeDrawingPoints from GestureStrokeRecognitionPoints•••This change must be checked in together with Ibed5330614. Change-Id: I20ba79fd20e8ea0aa3ac596c011ec5bfea528ace | 3 | -39/+37 | |
2013-12-25 | [IL34] Introduce InputLogicHandler•••Bug: 8636060 Change-Id: I5d08ed5d69cdb03bd188e36b7014de03f04fa72f | 2 | -0/+55 | |
2013-12-25 | Fix NPE in SettingsValues.•••Change-Id: I96fc381d2b45881aeb342d33207cd7fe82f5077c | 1 | -1/+1 | |
2013-12-25 | Fix typo in a unit test.•••Change-Id: I9222533704722265511b9fe6fb5caf99765e198b | 1 | -1/+1 | |
2013-12-25 | Rename gesture related classes•••Change-Id: I5cb03576bb7221f1864e157857d872880a0a58f8 | 8 | -155/+228 | |
2013-12-25 | Remove personalized dicts when the option is turned off.•••Bug: 11757851 Change-Id: I94f32859d862fe41e39845ab2bfc2d396c6aea0f | 7 | -11/+85 | |
2013-12-24 | Comprehensive memory deallocation•••Change-Id: I4673543c96eb342c3c977e00d44772a0d719a23e | 6 | -13/+21 | |
2013-12-24 | Rename classes related to AbstractDrawingPreview•••Change-Id: Ife2e2c08b2b6fbf9ec33cf259f276878816b291c | 6 | -50/+53 | |
2013-12-24 | Separate GestureStrokePreviewParams to top level class•••Change-Id: I4c6ac12dac9636760128625bb5b7138b7d56f3d1 | 3 | -37/+51 | |
2013-12-24 | Make GestureStrokeParams as a top level class•••Change-Id: I540a2d3a6c6ce6ecdcccecd38df6b3c23fcf8d95 | 3 | -75/+94 | |
2013-12-24 | [IL33] Opportunistically remove some KeyboardSwitcher•••Bug: 8636060 Change-Id: I0480ac03b9902e940f566b5558b8499647983968 | 2 | -22/+20 | |
2013-12-24 | Clean up batch input related code a bit•••Change-Id: I3b6a95fdb82bd15e2b636b1374a96d8987d5d8cf | 1 | -54/+60 | |
2013-12-24 | Remove duplicate code•••Change-Id: Ia33ea2dc4bb063ec5bf282c656ccc1f11ac967fe | 1 | -1/+1 | |
2013-12-20 | [IL32] Remove a useless variable•••Change-Id: I8f5d8fd8c1627a568df57255dc3dceda26c4720c | 1 | -3/+2 | |
2013-12-20 | [IL31] Move *BatchInput to InputLogic•••Bug: 8636060 Change-Id: If0309be038518a71d735108b78ac9efbfe38c82b | 2 | -107/+128 | |
2013-12-20 | [IL30] Minor refactoring•••Change-Id: I8a8aa9f703c6fca5e25ec573b41f325680ac92dc | 1 | -3/+3 | |
2013-12-20 | [IL29] Move retryResetCaches and tryFixLyingCursorPosition•••Bug: 8636060 Change-Id: I45b322e4844f023e91b80f9c2e0f7fa0166bcc59 | 2 | -66/+73 | |
2013-12-20 | [IL28] Remove useless code•••I don't understand why this was checked in. The tests are completely useless, that makes the variables write-only, and the only side effect is useless as the keyboard commits suicide upon exiting debug settings. Change-Id: I4eb25295183f43a2e947a6a0467ea168d023c18a | 1 | -25/+0 | |
2013-12-20 | [IL27] Some refactoring•••Bug: 8636060 Change-Id: Iedfdf71350f5fe3ab451fc5ec6e3c9901f71e50f | 2 | -6/+9 | |
2013-12-20 | [IL26] Move restartSuggestionsOnWordTouchedByCursor•••Bug: 8636060 Change-Id: I373874585f4fa663b4207b9a02d751805259eb36 | 2 | -111/+132 | |
2013-12-20 | [IL25] Inline handleClose•••Only ever used here. Bug: 8636060 Change-Id: Ia98c8bbe1c63ad4d057efe1cee87829b06124479 | 1 | -12/+6 | |
2013-12-20 | [IL24] Move mDisplayOrientation to SettingsValues.•••Bug: 8636060 Change-Id: Id57ced0cca9dc9e5e85c3a53683588feb28c1402 | 3 | -25/+30 | |
2013-12-20 | Fix an NPE•••Change-Id: I6307c1545d9d48cdea66d08f8efc1b7fbb08ee42 | 1 | -2/+6 |