| Commit message (Expand) | Author | Age | Files | Lines |
|---|
| ... | |
| * | | Make isSettingsSuggestionStripOn final.•••Change-Id: Iabb99a7f8f3f1777f9a87ae2bddff9795a50fa92
|   Jean Chalard | 2011-12-16 | 1 | -12/+12 |
| * | | Small refactoring•••This helps to make following changes smaller
Change-Id: I95ba2901ac3bf1ed70a748c35a0babdd9af1df63
| Jean Chalard | 2011-12-16 | 1 | -5/+12 |
| * | | Make insertSpaceOnPickSuggestionManually final.•••Change-Id: I32fce0ea8c5c58b6f920d0758c8bf57769f39a12
| Jean Chalard | 2011-12-16 | 1 | -16/+18 |
| * | | Use temporary variables for computing editor attributes•••The ultimate intent is to make these variables final,
which will allow to move the computing function to the
InputAttributes class.
Change-Id: Ifb1fc7321a19b10d60aa63fa0daaa2708deda2cf
| Jean Chalard | 2011-12-16 | 1 | -17/+24 |
| * | | Create a class for input attributes.•••Change-Id: I834390c83865aac59fb758d5c66cf9b74103abd8
| Jean Chalard | 2011-12-16 | 1 | -35/+37 |
| |/ |
|
| * | Merge "Make the word composer aware of commits." | Jean Chalard | 2011-12-15 | 1 | -2/+6 |
| |\ |
|
| | * | Make the word composer aware of commits.•••Change-Id: I04e691fbc9227d4df195429bca89edea93575347
| Jean Chalard | 2011-12-16 | 1 | -2/+6 |
| * | | Add com.android.inputmethod.latin.suggestions package•••Change-Id: If4b823768ab9c073625da3034ecc8091be1df230
|   Tadashi G. Takaoka | 2011-12-16 | 1 | -0/+1 |
| |/ |
|
| * | Merge "Cleanup unused variables and parameters" | Tadashi G. Takaoka | 2011-12-15 | 1 | -3/+3 |
| |\ |
|
| | * | Cleanup unused variables and parameters•••Change-Id: Iad756a7a775c93f3344c6962e7b3456ef8339490
| Tadashi G. Takaoka | 2011-12-15 | 1 | -3/+3 |
| * | | Fix auto correction spacebar LED•••Change-Id: I4894d188d5612380cc9f8eec7cb72544e37fb2b0
| Tadashi G. Takaoka | 2011-12-15 | 1 | -14/+23 |
| |/ |
|
| * | Cleanup•••Change-Id: I724df0be7ac07ffb9f1f4974175aed5a2606221b
| Jean Chalard | 2011-12-14 | 1 | -6/+5 |
| * | Move some code inside a function to simplify flow•••Also rename the function to reflect better the behavior.
An upcoming change will clean up the remnants
Change-Id: I19bdf0d9e95f62ee749e1f64fe17132c4a5ef0bc
| Jean Chalard | 2011-12-14 | 1 | -12/+8 |
| * | Fail faster in case of a bug•••Change-Id: Ibea64133f200dce80034c641d4798b62843a2512
| Jean Chalard | 2011-12-14 | 1 | -4/+4 |
| * | Refactoring.•••Small simplification of the code.
Change-Id: I1f67ae529bbb2c9316bf5e083d367c57040ea22c
| Jean Chalard | 2011-12-14 | 1 | -17/+15 |
| * | Merge "Record onStartInputView" | Tadashi G. Takaoka | 2011-12-13 | 1 | -0/+1 |
| |\ |
|
| | * | Record onStartInputView•••Bug: 5722703
Change-Id: I56bcf6ccde82b4176093de4f197a8736b0cc8c10
| Tadashi G. Takaoka | 2011-12-14 | 1 | -0/+1 |
| * | | Merge "Fix a long-standing race condition." | Jean Chalard | 2011-12-13 | 1 | -15/+15 |
| |\ \
| |/
|/| |
|
| | * | Fix a long-standing race condition.•••Upon autocorrection, there is visual feedback in the text
view that quickly flashes the background of the text that
just changed. This fixes a race condition that happens
upon autocorrection when typing fast, and that results in
flashing one character too far left (typically, the flashing
area includes the whitespace before the corrected word and
not the last character of the corrected word).
This happens because the call to commitCorrection may
happen before or after the IPC sent by sendKeyChar, but the
arguments are fit only for the case where it arrives first.
Change-Id: I9b5442a665aad5a9bc66cd49228075b9056b37fa
| Jean Chalard | 2011-12-14 | 1 | -15/+15 |
| * | | Merge "Decouple member logic from control flow" | Jean Chalard | 2011-12-13 | 1 | -4/+8 |
| |\ \ |
|
| | * | | Decouple member logic from control flow•••This place is very confusing because a member variable with
a consistent meaning is hijacked for the duration of a function
to mean something else. This is in the way of easy-to-understand
refactoring.
Change-Id: If79bc771950d6bfc0ad5f0e9c51c7ef1dbb45b66
| Jean Chalard | 2011-12-13 | 1 | -4/+8 |
| | |/ |
|
| * / | Various mini-cleanups•••- Stop the word composer from escaping - take a page from the law
of Demeter and only report what is actually needed.
- Fix typos in comments.
- Add a comment for a fishy processing.
- Remove a useless local variable.
Change-Id: I5fa78901cbb5483fc9683bfb7094f47244b85df6
| Jean Chalard | 2011-12-13 | 1 | -7/+8 |
| |/ |
|
| * | Merge "Remove the input connection sidework from handleCharacter" | Jean Chalard | 2011-12-13 | 1 | -6/+10 |
| |\ |
|
| | * | Remove the input connection sidework from handleCharacter•••Change-Id: I3d376dfda3acd8864274390de3ff5752b18456e0
| Jean Chalard | 2011-12-13 | 1 | -6/+10 |
| * | | Move mBestWord to the word composer.•••mBestWord has a confusing name - it's actually an auto-correction.
It's cleaner if it lives in the word composer because an
auto-correction should be tied to a specific user input, and
should be reset each time the user input changes to avoid
race conditions.
Change-Id: I718d29395bc747372067e6440e090c6a181994ae
| Jean Chalard | 2011-12-13 | 1 | -18/+25 |
| |/ |
|
| * | Merge "Tighten conditions for space-related cancelling" | Jean Chalard | 2011-12-13 | 1 | -4/+10 |
| |\ |
|
| | * | Tighten conditions for space-related cancelling•••Instead of ignoring silently a found bug, throw an exception.
Change-Id: I0aa96d0cab022b6a5e7cffe8a592dcc443c3c7a8
| Jean Chalard | 2011-12-13 | 1 | -4/+10 |
| * | | Consolidate underlining code under one function.•••Change-Id: I4393ff1ec28a6b3118d1344dd6d82d04899dea42
| Jean Chalard | 2011-12-13 | 1 | -18/+17 |
| |/ |
|
| * | Remove a useless return•••Change-Id: Iefe10e94e2d88171387351a5b6cab52e281d0f76
| Jean Chalard | 2011-12-13 | 1 | -3/+0 |
| * | Simplification•••Both tests have the same meaning. They should be merged.
Also, if "deleteLast()" deletes more than one char (which
never happens in the current implementation, but it's not
guaranteed), the new code is more correct.
Change-Id: I216df7cd45f4a7d76d1d5d6aa7f8d7f9a6e35ea3
| Jean Chalard | 2011-12-13 | 1 | -4/+2 |
| * | Refactoring•••If mHasUncommittedTypedChars is true, then
mWordSavedForAutoCorrectCancellation must always be null, and
spaceState must always be SPACE_STATE_NONE.
Hence, this change is supposed to be very no-op.
Change-Id: I2716f7372d996cc4dec40a4b7ac1ee7f5f4afe91
| Jean Chalard | 2011-12-13 | 1 | -21/+18 |
| * | Refactor + small bugfix•••postUpdateShiftKeyState used to be called also when
mEnteredText is not null => this is a bugfix.
The rest does not change the logic, as posting a message can
be done anywhere within the function with no impact.
Change-Id: I7888797c0778702d64f96701e35b611a55a6a259
| Jean Chalard | 2011-12-13 | 1 | -4/+3 |
| * | Refactoring•••Change-Id: I57b2232f7fde32df5f6e1925aad1df988def34f9
| Jean Chalard | 2011-12-13 | 1 | -7/+5 |
| * | Merge "Fix a bug where revert auto-correct would revert too much" | Jean Chalard | 2011-12-12 | 1 | -8/+24 |
| |\ |
|
| | * | Fix a bug where revert auto-correct would revert too much•••If there are no uncommitted chars, we shouldn't enter any of
the tests that follow. We didn't use to, but a change today
made it possible - it should not happen.
There is no point in doing the rest of the tests, they are
sure to fail.
Change-Id: I580dd104aff3585de72a93b38989bfd9713f615b
| Jean Chalard | 2011-12-12 | 1 | -8/+24 |
| * | | Remove a useless function call•••Change-Id: I1a775cbf90dca301e1e6b596ddac64fdbc023199
| Jean Chalard | 2011-12-12 | 1 | -1/+0 |
| |/ |
|
| * | Merge "Move a settings var to the settings class" | Jean Chalard | 2011-12-12 | 1 | -2/+1 |
| |\ |
|
| | * | Move a settings var to the settings class•••Change-Id: I1331ad6dec3a9d64a77e314f8a1f4c29282df31b
| Jean Chalard | 2011-12-12 | 1 | -2/+1 |
| * | | Remove a useless variable•••This can be just read when it's needed.
Change-Id: I00753fe55645c244db5d4a96e7fdb8f5325475d9
| Jean Chalard | 2011-12-12 | 1 | -3/+2 |
| * | | Remove a messy and unused class.•••Today is a happy day
Change-Id: I3ef484bd258d5a59815bfcb0bd35ea3606b32430
| Jean Chalard | 2011-12-12 | 1 | -25/+0 |
| |/ |
|
| * | Merge "Remove side-effects from TextEntryState" | Jean Chalard | 2011-12-12 | 1 | -2/+17 |
| |\ |
|
| | * | Remove side-effects from TextEntryState•••Change-Id: Ib98eea9e791e426435cfdfd0c9ab3ed9061664aa
| Jean Chalard | 2011-12-12 | 1 | -2/+17 |
| * | | Remove a useless variable.•••Change-Id: Iea5ce5cfc05bad8b1d9085438e90147bd54b7e9c
| Jean Chalard | 2011-12-12 | 1 | -5/+1 |
| |/ |
|
| * | Straighten out logic for revert word paths•••This also includes a new memorized string with simpler
logic that will allow to remove other members
Change-Id: I0b97243084902e68fcb835b6163c86fef8190ebc
| Jean Chalard | 2011-12-12 | 1 | -30/+67 |
| * | Merge "Remove a duplicated variable." | Jean Chalard | 2011-12-11 | 1 | -32/+24 |
| |\ |
|
| | * | Remove a duplicated variable.•••This is awesome cleanup.
Change-Id: I35ce8940a13f3084630dc26d6e7e397acfdaac36
| Jean Chalard | 2011-12-12 | 1 | -32/+24 |
| * | | Remove unused Keyboard.CODE_CANCEL•••Change-Id: Ic2eab17e525901a1cf7096ebe7d24ae78624ed2e
| Tadashi G. Takaoka | 2011-12-12 | 1 | -5/+0 |
| |/ |
|
| * | Merge "Remove unused public methods from KeyboardState and KeyboardSwitcher" | Tadashi G. Takaoka | 2011-12-09 | 1 | -21/+3 |
| |\ |
|
| | * | Remove unused public methods from KeyboardState and KeyboardSwitcher•••Bug: 5708602
Change-Id: I3dbc3cd00aa9ddf611e2078ff2cfea8945fa09bf
| Tadashi G. Takaoka | 2011-12-09 | 1 | -21/+3 |
| * | | Resolve TODOs: add some members to store prefs•••Change-Id: Idf09cb5d801e8008eb63cbb5138058faeb7db136
| Jean Chalard | 2011-12-09 | 1 | -3/+2 |
| |/ |
|
