| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
With this CL, the previously used commit indicator was reverted.
Instead we use the add-to-dictionary indicator only at the moment.
This CL also fixes the indicator position in bidi context.
BUG: 17335734
Change-Id: I5f7cf173ddc30876e2b01320acaff8ba4265edf6
|
|
|
|
|
| |
Bug: 16733686
Change-Id: I7a9f79a81e33a1f5bf5f3daf0b78d0f1e4447e7a
|
|
|
|
|
|
|
|
| |
This is a follow up CL for API signature change in
I772c48ff18918e48a81e807b48ff907614485c09
BUG: 17320996
Change-Id: Ic8b6162bda12bf74fae79af212c5d81c400eb9e8
|
|
|
|
|
|
|
|
|
|
| |
With this CL, the text highlight color is applied
when the commit indicator is displayed.
Note that the underline is not rendered when the
background color is enabled. This is a known issue.
Change-Id: Ia19355e1303e3a10e8a7d69bc47c779feb70248a
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When CursorAnchorInfo is unavailable, we shouldn't try to show
the commit indicator and set the text highlight color.
With this CL, RichInputConnection can be used to track if the
application responded that it does support CursorAnchorInfo or
not. This result will be taken into consideration when
InputLogic needs to determine whether the commit indicator
should be displayed or not.
Change-Id: I945d70eeb02a7a5f3d9b22459b23d7028508910f
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an optional optimization to reduce the UI latency.
Imagine that the commit indicator is now displayed and the
composing text is being updated, it is highly likely that
the commit indicator will disappear unless the application
rejects the setComposingText request.
If we assume that the application will accept the new
composing text without any modifications, we can hide the
indicator without waiting for the arrival of new
CursorAnchorInfo event.
This optimization isn't dangerous because we can show the
indicator again when we receive new CursorAnchorInfo event
and the assumption is turned out to be invalid.
Change-Id: Id59c6607a1029782410611e768791af9984f14ac
|
|
|
|
|
|
|
|
|
|
| |
This CL introduces commit/add-to-dictionary indicators.
Note that the text is not yet highlighted when the commit
indicator is displayed. It will be addressed in subsequent
CLs.
Change-Id: I7e9b0fcfdc0776a50a1d8cfb41ee0add813317dd
|
|
|
|
|
|
|
|
|
|
| |
This is because prediction can't be easily distinguished in
style. This fixes the bug by simulating the right members,
but some refactoring should be done to remove useless
booleans.
Bug: 17271923
Change-Id: Ib88f3fb95678021624e59535492926dd315d26fb
|
|
|
|
| |
Change-Id: I597ab26db70387b80ddcd7d51de6ae751380030d
|
|\
| |
| |
| | |
lmp-dev
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This CL slightly extends the condition when "Add to dictionary"
hint is dismissed.
With this CL, "Add to dictionary hint" will be dismissed by any
non-special char event. This is more comfortable especially if
we start using more intrusive UIs such as indicator and/or
background color with the text hint in the suggestion strip.
Change-Id: I2ea0fa40d9c6663ebf5d5439be3eca2a2cbd5166
|
| |
| |
| |
| |
| |
| |
| |
| | |
This is a groundwork for subsequent CLs where we need to
call this method from multiple places. This CL does not
change any existing behaviors.
Change-Id: Id8fa0360305d7383571edffab6752b2240367cf9
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a groundwork for subsequent CLs where we need to
add/remove background color to/from the commited text.
In this CL, we use Spanned#SPAN_COMPOSING so that we can easily
remove such a background color by calling
InputConnection#finishComposingText. To make this operation easy
and realiable, we need to track whether we have specified the
background color to the commited text or not at one place. Here
we use RichInputConnection for this purpose.
Change-Id: I5f9bc4425c5d1b80a719a20e5baf336729ec08d2
|
|
|
|
| |
Change-Id: I81f37d08659d449822b027d3d5912e11eec8b8ff
|
|
|
|
|
|
|
| |
This reverts commit 93b00a314e307cb257abf1cab88cb24d57ff3885.
Bug: 16830599
Change-Id: I955e7da77978c3a495660aa29247e010d489c36b
|
|
|
|
|
|
|
|
|
|
| |
There is a bug in ICS where the input connection won't take
any writing commands after rotation until the cursor moves.
This fixes it by wiggling the cursor position once before trying
to do anything.
Bug: 16810766
Change-Id: Ib14c70bd0550420cecfa86dea501d13a1a91e296
|
|
|
|
|
| |
Bug: 8152758
Change-Id: Ida05df7d151ceb582886e2ad06c5bdf0b59978ee
|
|
|
|
| |
Change-Id: I4e1e4f101050ebda77c629a61c548d3c8efb330f
|
|
|
|
|
|
|
|
| |
It's probably cleaner to just pass the events rather than read
them from a transaction, especially when a transaction may be
associated with several events in a chain.
Change-Id: I27830f0f3f3f32fe77ea8b9cad505b7ebee648af
|
|
|
|
|
|
|
| |
Do away with the didAutoCorrect local variables which are
unnatural to return out of all these functions.
Change-Id: I22024004d2c489de018beff812c2c589bfd8ca32
|
|
|
|
| |
Change-Id: I503c5403dcaea5db632eba85ae3fae9ba9a1f946
|
|
|
|
| |
Change-Id: I1619f6132f8f71bc1291fd6a5604a5e1e3431ae2
|
|
|
|
| |
Change-Id: Ia866d3f9a5981c687766f8c39979fb6091018e44
|
|
|
|
| |
Change-Id: I5f7932097627766e907764a99a5e9c170f725bc0
|
|
|
|
|
|
| |
The 'processedEvent' variables will ultimately disappear entirely.
Change-Id: I612c5ce7dedc341b64921a86ac028fe91b75359b
|
|
|
|
| |
Change-Id: I18021b7ec1588fc52533c48b7d8774bec7764822
|
|
|
|
|
|
| |
...take 2
Change-Id: I9d13b6d51e13ce2e76ae3febebfb8c310eba509d
|
|
|
|
|
|
|
|
| |
This reverts commit 1db3d860ca0d7380c5a6a3a0f95751565f23043b.
Reverting due to a few critical bugs and unit test failures.
Change-Id: I5e2d02300320438ef9c29577ec5b0860ea91d822
|
|
|
|
|
|
| |
If anyone has better names for those...
Change-Id: Ia2dfc75381816bd688948647e2c50c10657b9e89
|
|
|
|
|
|
|
|
|
|
|
|
| |
Formerly "Show correction suggestions" had three options, "always
show", "show in portrait mode", and "always hide". The reason behind
"show in portrait mode" was that there may not be enough screen estate
in landscape mode to show suggestions. Because recent phone devices
have relatively large screen, we decide to remove "show in portrait
mode" option.
Bug: 15780939
Change-Id: I896d737452c3893d43ce20bd88127f10c1eb3d83
|
|
|
|
|
| |
Bug: 15318007
Change-Id: Ic0268fd12865c9a692a5e7110a9beb76cb8b6d7f
|
|
|
|
|
| |
Bug: 15758242
Change-Id: I703dc2703afdf9402c5d2ac27411b74ece993dba
|
|\ |
|
| |
| |
| |
| | |
Change-Id: I66ed277751272eb3ae2fd5e55e9f3e413970082f
|
|\| |
|
| |
| |
| |
| | |
Change-Id: I5436432c0da86ed1e33b3c9d40204f4ea013ff55
|
|\ \
| |/
|/| |
|
| |
| |
| |
| |
| |
| |
| | |
When switching languages, we need to wait until the dictionary is
loaded to compute suggestions.
Change-Id: I7c32a900b297cd6302bfdc020842581315f3007f
|
|/
|
|
|
|
|
| |
...also implement the check for Hebrew and Arabic.
Bug: 15840116
Change-Id: Ia6433d7d98038ade64c171be4fe4b3f094111fac
|
|
|
|
|
| |
Bug: 15840116
Change-Id: I1123426fbd9d420c1be64ccc917a5f870e70e6fa
|
|
|
|
|
|
|
| |
This reverts commit 1d300239612591879d535c20ade1f2712048170e that broke the build.
Bug: 15840116
Change-Id: I0a5fa7dea2b418d19df24b2b31ed96bf192d45c0
|
|
|
|
|
| |
Bug: 15840116
Change-Id: Ib3380cfc9d343c6f8953bba03af3801142bc3bdb
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
...otherwise we can't recompute the composition when we
change scripts.
This also fixes when we register that we need to take note
that the current subtype was used. Luckily this is a good
occasion for some cleanup that I've wanted to do for some
time: use InputTransaction for onTextInput (with the goal
to ultimately remove it entirely)
Bug: 15840116
Change-Id: Ie4f4f9157b66b79237eeb3db75535803124d3e19
|
|
|
|
|
| |
Bug: 15840116
Change-Id: If2073e76fed74ae6e1cdd7670013e0e985b0e630
|
|\ |
|
| |
| |
| |
| |
| |
| | |
Bug: 14425059
Change-Id: Ieace636334a9b2a094527341d4fcfc05958296c5
|
|\ \
| |/
|/| |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
With hardware events, we do have some events that
have both a keycode and a code point, so we need
a better way of distinguishing between auto-insert
keystrokes and others.
Change-Id: Ia23042989b4dca9d3a7d4a4c06bcebdabe324a7a
|
|\ \
| |/
|/| |
|
| |
| |
| |
| |
| | |
Bug: 14425059
Change-Id: I2bd6a872904a44b80f638a13d91a97559217cc1a
|