aboutsummaryrefslogtreecommitdiffstats
path: root/java/src/com/android/inputmethod/latin (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Merge "Fix a long-standing race condition."Jean Chalard2011-12-131-15/+15
|\
| * Fix a long-standing race condition.Jean Chalard2011-12-141-15/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Upon autocorrection, there is visual feedback in the text view that quickly flashes the background of the text that just changed. This fixes a race condition that happens upon autocorrection when typing fast, and that results in flashing one character too far left (typically, the flashing area includes the whitespace before the corrected word and not the last character of the corrected word). This happens because the call to commitCorrection may happen before or after the IPC sent by sendKeyChar, but the arguments are fit only for the case where it arrives first. Change-Id: I9b5442a665aad5a9bc66cd49228075b9056b37fa
* | Merge "Decouple member logic from control flow"Jean Chalard2011-12-131-4/+8
|\ \
| * | Decouple member logic from control flowJean Chalard2011-12-131-4/+8
| |/ | | | | | | | | | | | | | | | | This place is very confusing because a member variable with a consistent meaning is hijacked for the duration of a function to mean something else. This is in the way of easy-to-understand refactoring. Change-Id: If79bc771950d6bfc0ad5f0e9c51c7ef1dbb45b66
* / Various mini-cleanupsJean Chalard2011-12-134-10/+11
|/ | | | | | | | | | - Stop the word composer from escaping - take a page from the law of Demeter and only report what is actually needed. - Fix typos in comments. - Add a comment for a fishy processing. - Remove a useless local variable. Change-Id: I5fa78901cbb5483fc9683bfb7094f47244b85df6
* Merge "Remove the input connection sidework from handleCharacter"Jean Chalard2011-12-131-6/+10
|\
| * Remove the input connection sidework from handleCharacterJean Chalard2011-12-131-6/+10
| | | | | | | | Change-Id: I3d376dfda3acd8864274390de3ff5752b18456e0
* | Move mBestWord to the word composer.Jean Chalard2011-12-132-19/+55
|/ | | | | | | | | | mBestWord has a confusing name - it's actually an auto-correction. It's cleaner if it lives in the word composer because an auto-correction should be tied to a specific user input, and should be reset each time the user input changes to avoid race conditions. Change-Id: I718d29395bc747372067e6440e090c6a181994ae
* Merge "Tighten conditions for space-related cancelling"Jean Chalard2011-12-131-4/+10
|\
| * Tighten conditions for space-related cancellingJean Chalard2011-12-131-4/+10
| | | | | | | | | | | | Instead of ignoring silently a found bug, throw an exception. Change-Id: I0aa96d0cab022b6a5e7cffe8a592dcc443c3c7a8
* | Merge "Consolidate underlining code under one function."Jean Chalard2011-12-131-18/+17
|\ \
| * | Consolidate underlining code under one function.Jean Chalard2011-12-131-18/+17
| |/ | | | | | | Change-Id: I4393ff1ec28a6b3118d1344dd6d82d04899dea42
* / Extract the jni library namesatok2011-12-132-2/+28
|/ | | | Change-Id: Icc58ccea1178d9f35f5be0dceebab67bbb965b7f
* Remove a useless returnJean Chalard2011-12-131-3/+0
| | | | Change-Id: Iefe10e94e2d88171387351a5b6cab52e281d0f76
* SimplificationJean Chalard2011-12-131-4/+2
| | | | | | | | | Both tests have the same meaning. They should be merged. Also, if "deleteLast()" deletes more than one char (which never happens in the current implementation, but it's not guaranteed), the new code is more correct. Change-Id: I216df7cd45f4a7d76d1d5d6aa7f8d7f9a6e35ea3
* RefactoringJean Chalard2011-12-131-21/+18
| | | | | | | | | If mHasUncommittedTypedChars is true, then mWordSavedForAutoCorrectCancellation must always be null, and spaceState must always be SPACE_STATE_NONE. Hence, this change is supposed to be very no-op. Change-Id: I2716f7372d996cc4dec40a4b7ac1ee7f5f4afe91
* Refactor + small bugfixJean Chalard2011-12-131-4/+3
| | | | | | | | | postUpdateShiftKeyState used to be called also when mEnteredText is not null => this is a bugfix. The rest does not change the logic, as posting a message can be done anywhere within the function with no impact. Change-Id: I7888797c0778702d64f96701e35b611a55a6a259
* RefactoringJean Chalard2011-12-131-7/+5
| | | | Change-Id: I57b2232f7fde32df5f6e1925aad1df988def34f9
* Merge "Fix a bug where revert auto-correct would revert too much"Jean Chalard2011-12-121-8/+24
|\
| * Fix a bug where revert auto-correct would revert too muchJean Chalard2011-12-121-8/+24
| | | | | | | | | | | | | | | | | | | | If there are no uncommitted chars, we shouldn't enter any of the tests that follow. We didn't use to, but a change today made it possible - it should not happen. There is no point in doing the rest of the tests, they are sure to fail. Change-Id: I580dd104aff3585de72a93b38989bfd9713f615b
* | Remove a useless function callJean Chalard2011-12-121-1/+0
|/ | | | Change-Id: I1a775cbf90dca301e1e6b596ddac64fdbc023199
* Merge "Move a settings var to the settings class"Jean Chalard2011-12-122-2/+3
|\
| * Move a settings var to the settings classJean Chalard2011-12-122-2/+3
| | | | | | | | Change-Id: I1331ad6dec3a9d64a77e314f8a1f4c29282df31b
* | Remove a useless variableJean Chalard2011-12-121-3/+2
| | | | | | | | | | | | This can be just read when it's needed. Change-Id: I00753fe55645c244db5d4a96e7fdb8f5325475d9
* | Remove a messy and unused class.Jean Chalard2011-12-122-225/+0
|/ | | | | | Today is a happy day Change-Id: I3ef484bd258d5a59815bfcb0bd35ea3606b32430
* Merge "Remove side-effects from TextEntryState"Jean Chalard2011-12-123-12/+41
|\
| * Remove side-effects from TextEntryStateJean Chalard2011-12-123-12/+41
| | | | | | | | Change-Id: Ib98eea9e791e426435cfdfd0c9ab3ed9061664aa
* | Remove a useless variable.Jean Chalard2011-12-121-5/+1
|/ | | | Change-Id: Iea5ce5cfc05bad8b1d9085438e90147bd54b7e9c
* Straighten out logic for revert word pathsJean Chalard2011-12-121-30/+67
| | | | | | | This also includes a new memorized string with simpler logic that will allow to remove other members Change-Id: I0b97243084902e68fcb835b6163c86fef8190ebc
* Merge "Remove a duplicated variable."Jean Chalard2011-12-113-37/+27
|\
| * Remove a duplicated variable.Jean Chalard2011-12-123-37/+27
| | | | | | | | | | | | This is awesome cleanup. Change-Id: I35ce8940a13f3084630dc26d6e7e397acfdaac36
* | Remove unused Keyboard.CODE_CANCELTadashi G. Takaoka2011-12-121-5/+0
|/ | | | Change-Id: Ic2eab17e525901a1cf7096ebe7d24ae78624ed2e
* Build God Mode keyboard with API level 14Ken Wakasa2011-12-101-1/+3
| | | | Change-Id: I29ab9e9041c9faac91dc303175625221bfdb3af8
* Fix isResearcherPackagesatok2011-12-102-3/+2
| | | | Change-Id: I286450fe89a37d75cb398f17d300ddc6f5857ffd
* Some tweaks for Researcher ModeKen Wakasa2011-12-103-4/+10
| | | | Change-Id: I6b16dd2fe6d7356c747ba0ee2da5976738003ded
* Merge "Add a functionality to attach a log file to Gmail app Bug: 5722703"satok2011-12-091-27/+85
|\
| * Add a functionality to attach a log file to Gmail appsatok2011-12-091-27/+85
| | | | | | | | | | | | Bug: 5722703 Change-Id: I089f944bdbf2cbb036eb59dd9b5b414370c770f1
* | Merge "Remove unused public methods from KeyboardState and KeyboardSwitcher"Tadashi G. Takaoka2011-12-091-21/+3
|\ \
| * | Remove unused public methods from KeyboardState and KeyboardSwitcherTadashi G. Takaoka2011-12-091-21/+3
| |/ | | | | | | | | Bug: 5708602 Change-Id: I3dbc3cd00aa9ddf611e2078ff2cfea8945fa09bf
* | Resolve TODOs: add members to hold preferencesJean Chalard2011-12-091-3/+9
| | | | | | | | Change-Id: I34f6c76bf9318e1fbe8eb5ffab6772a98ff824e0
* | Resolve TODOs: add some members to store prefsJean Chalard2011-12-092-11/+21
| | | | | | | | Change-Id: Idf09cb5d801e8008eb63cbb5138058faeb7db136
* | Resolve TODOs: add members to store raw settingsJean Chalard2011-12-091-17/+17
| | | | | | | | Change-Id: I481eadb6a73faf239e24d05b7e220fcb01194fa4
* | Read options in the declaration orderJean Chalard2011-12-091-3/+2
| | | | | | | | Change-Id: I1a7c4d0bcaedad6d4045c36c79280c23234db5b3
* | Straighten out prefs reading codeJean Chalard2011-12-092-20/+31
| | | | | | | | Change-Id: Ibf9113a8ef07ac720100ee32d2e5ef321e8ddd98
* | Straighten out members extracted from resources.Jean Chalard2011-12-091-23/+29
| | | | | | | | Change-Id: I9b9602ec5b379b44b0f0663d4f065dbcf88fd352
* | Match constant names to option namesJean Chalard2011-12-092-28/+28
| | | | | | | | Change-Id: I7586fa342d7a39412d656890f7b525139c45ea4a
* | Reorder members in SettingsValues.Jean Chalard2011-12-092-32/+33
|/ | | | | | | Reorder so that they match the order in the preference xml file. Also add TODOs for missing raw variables. Change-Id: I06332c131a624d6c359512d75c808f3f7313fa91
* Move settings variables to the settings classJean Chalard2011-12-093-21/+18
| | | | Change-Id: Ifa7033a84b08ea626eb44cf6d04ba8e28c250bea
* Merge "Stop a flag from escaping."Jean Chalard2011-12-082-21/+11
|\
| * Stop a flag from escaping.Jean Chalard2011-12-092-21/+11
| | | | | | | | | | | | | | The ultimate intent is to close it up in the settings, as it does not change while typing, only when the keyboard is open again. Change-Id: I12ff56e7482c1584877fe5531473bf03e95a60f6
generated by cgit v1.2.3-83-g751a (git 2.47.1) at 2025-06-05 18:05:54 +0000