aboutsummaryrefslogtreecommitdiffstats
path: root/java/src (unfollow)
Commit message (Collapse)AuthorFilesLines
2014-02-21Add ImportantNoticeDialogTadashi G. Takaoka2-45/+93
Change-Id: Icaeb7dddd16362cd4a6384d295f89c7fbabc8b35
2014-02-21Support versioned important noticeTadashi G. Takaoka3-22/+38
This change must be checked in together with If38a754d00. Bug: 10587358 Change-Id: I91580f9468bc5ee7ed1694d7852a60dc6793dac0
2014-02-20Fix a bug where suggestions would not be updated.Jean Chalard1-14/+33
Also fix a small cosmetic bug where the suggestion strip would flash. Bug: 12951777 Change-Id: I68b7bb9175571de9c718f737eebd9f67ea04a931
2014-02-20Don't distrust the cursor pos so much as to bug on IPC delayJean Chalard2-17/+6
When the cursor is moved by the user, the RichInputConnection is told about it. However, to work around a framework bug, it also looks at how many characters are in the buffer before the cursor, and if that's more than the value it's been passed, it deduces that's a framework bug and there are at least as many characters as seen before the cursor, so it puts the expected cursor position there. When you move the cursor, TextView calls onUpdateSelection, and when you move it fast, you'll get rapid-fire calls to onUpdateSelection. This is fine, the RIC is equipped to deal with that. However, these calls take some time to make it to the IME. In this instance, when the first call gets through and the IME calls TextView (synchronously) for text before the cursor, the cursor has already moved in the app, and TextView returns more characters than the cursor position was declared to be in this instance, so the RIC sets that as the expected cursor position. Sure enough, a split second later, the second call to onUpdateSelection arrives, with the new cursor position set where the RIC had found it too early. The RIC takes that as an "expected" cursor move, and the input does not get reset. Luckily, we have a way out. As far as we know, the framework bug only manifests itself upon rotation, which means we should only have to adjust for it in onStartInputView. Doing it in onUpdateSelection is too zealous (and probably too distrustful of the app to send the correct cursor positions). So we should just take care of the rotation case (by calling tryFixLyingCursorPosition in onStartInputView) and remove the compensating code in resetCachesUponCursorMoves. Bug: 12982502 Change-Id: Ic3c1408a1ec45deaea63b01d98376a79ae567d77
2014-02-20Add test only methods to test personalized dicts.Keisuke Kuroyanagi3-6/+33
Bug: 11122480 Change-Id: I79a4a73ff09a2d34d4ca094d705e901fb4bc855c
2014-02-20Fix: UserHistoryDictionaryTests.testDecaying().Keisuke Kuroyanagi1-4/+14
Bug: 13106697 Change-Id: If81f77c3cefdefae94cb9145aa9f700494f8237a
2014-02-20Record reading error during traversing dictionaries.Keisuke Kuroyanagi7-16/+59
Bug: 12916055 Change-Id: I439f21aa87cfa1f71e0354370a1514af03d68f6c
2014-02-20Add final and volatile for members of InputLogic.Keisuke Kuroyanagi1-2/+3
Bug: 13107471 Change-Id: I47df79bc6f015c212d1b6d2f63b2efc5da24294e
2014-02-20Add user history dictionary decaying test.Keisuke Kuroyanagi2-2/+64
Bug: 10667710 Change-Id: Ib2be57d8c4cbbb34f64555d84ea6fd571cfdd247
2014-02-20Throw IOException when dict header cannot be read.Keisuke Kuroyanagi1-0/+4
Bug: 13106638 Change-Id: Ib48ef0a191a436552c49b6e817dfa13fe1567ae8
2014-02-20Change important notice version preference fileTadashi G. Takaoka5-47/+38
This CL also reset the notice version to 1. This CL must be checked in together with Iea8d9ff038. Change-Id: I838f7b5b295388d64d6aba90f50b06654eba16e5
2014-02-20Fix build due to Ib4c472756fTadashi G. Takaoka1-1/+1
Change-Id: I27aad91d3f821b5c0d6a3c6405b4a9d03c5bd814
2014-02-20Revert "Turn off personalization default settings"Tadashi G. Takaoka3-4/+4
This reverts commit 0a4ac795d6fdd117b590902d7f5901f0db12d25c. Bug: 10587358 Change-Id: Ib4c472756fb9a6ebba4a66d34a9652f1b5afc714
2014-02-20Check all enabled IME's subtypes to enable personalization.Keisuke Kuroyanagi2-6/+22
Bug: 13067743 Change-Id: I6fc68b5151430a5ab51777f4c381e20f5a657924
2014-02-20Remove a call to a deprecated methodJean Chalard4-7/+5
...that would cause a crash Bug: 13082186 Change-Id: Ie12575c27dfdd2029bc9d5f0647e444f69770afc
2014-02-20Tweak key popup animation parametersTadashi G. Takaoka1-4/+4
Key popup show up start scale 98% Key popup dismiss end scale 94% Key popup show up duration 17ms Key popup dismiss duration 53ms Bug: 11518021 Change-Id: Icfde99969163f05cfaed1050ea074545d44db13b
2014-02-20Comments improvementsJean Chalard1-2/+2
Typo fixes and clarifications Change-Id: I0f7e0b6e665232bb995172fff10521c7f17599eb
2014-02-19Call PersonalizationDictionarySessionRegistrar.init().Keisuke Kuroyanagi1-0/+4
Wrongly removed in I1f50cb137b6054dc9. Bug: 13067743 Change-Id: I27cd221cb7f6e403c3fc128d65d14dbf628b6f55
2014-02-19Fix: crash when opening a broken dictionary.Keisuke Kuroyanagi3-7/+13
Bug: 13085169 Change-Id: Icfb6184dfefc6a336432203c071d9e30ae8bf990
2014-02-19Remove personalization dicts for multilingual users.Keisuke Kuroyanagi3-13/+26
Bug: 13067743 Change-Id: I1f50cb137b6054dc9442237586b70fc0aa2bf427
2014-02-19Use AlertDialog.setOnDismissListenerTadashi G. Takaoka1-2/+2
AlertDialog.Builder.setOnDismissListener is supported from API 17. Bug: 10587358 Change-Id: Ie8ce8e283b803f7f6bb58ced446e676339f980eb
2014-02-19Turn personalization on when important notice dialog is displayedTadashi G. Takaoka6-24/+77
This change must be checked in together with Ifde70b1d3b. Bug: 10587358 Change-Id: I9dc48f9d521e0e6f6269e4f184389ba805f3053f
2014-02-19Fix IllegalStateException raied by monkeyTadashi G. Takaoka4-33/+36
Bug: 13082467 Change-Id: I9290974821d22067e7ddd60dce441b11ca533a0f
2014-02-19Throw exception when the header cannot be read.Keisuke Kuroyanagi1-0/+3
Bug: 13066902 Change-Id: I8fd0f361a4ca55aaab8a2bd2e11f48f92b87fc93
2014-02-19Fix: Use old suggest after reloading.Keisuke Kuroyanagi1-1/+3
Change-Id: Icb2821f61c4203254b7d573cad5ce71fbf0ed841
2014-02-19Turn off personalization default settingsTadashi G. Takaoka3-4/+4
Because the previous personalization settings default value was on, this CL changes the preference key of the personalization settings. Bug: 10587358 Change-Id: I80233e8af4b532d8c67d8fb184c2865862bb35dd
2014-02-19Fix: using wrong method to call ArrayList.add.Keisuke Kuroyanagi1-4/+4
bug: 13072808 Change-Id: I60dc5ae1e535f2f0b3784a12c40ac082560a436f
2014-02-18Fix wrong Java method call functionKen Wakasa1-2/+2
bug: 13072808 Change-Id: I189fda85b59ce40e3657bfbbcc313e7e1225a0da
2014-02-18Fix buildJean Chalard1-1/+1
This is a forgotten rebase Change-Id: I7c7c381775488ed9239dc284bd9c31247a86a972
2014-02-18Straighten out database cursors behavior.Jean Chalard8-136/+178
Some were never closed, other closed twice. This change makes all Cursor instances behave, having the #close() call in a finally{} clause, and puts the burden of closing the cursor squarely on the creator rather than in the called methods. There is however one exception that is beyond the scope of this change: UserDictionarySettings have a Cursor member, it's never closed, and fixing the problem is not obvious. This change adds a TODO for now. It's not very clear if this change actually helps with bug#12670151, but it may be related and it's a good think to do anyway. Bug: 12670151 Change-Id: I87cc44387e7dee3da1488671b93a28d9d73f7dc0
2014-02-18Fix a bug where the cache would be out of syncJean Chalard2-1/+54
During recorrection, the cursor position when calling commitText is not necessarily at the end of the composing text. Besides, RichInputConnection assumes the cursor is always after any composing text. This is not correct, but in the practice, it seems all code paths work. We should fix this in the future. Bug: 13060691 Change-Id: I15f71fff62d36e80cf6e4a022c5e78af634b199d
2014-02-18Cleanup.Jean Chalard6-27/+12
Less code, less chance of stuff escaping, and a bit of a clarification. Yay. Change-Id: I3193fd8ad7ac28195260cbc231c4e498a63a460c
2014-02-18Some cosmetic fixes in LatinIME.javaKen Wakasa1-40/+38
Change-Id: Ia2d04ab992f5a0cc736150b2691b2f8ae8f0955d
2014-02-18Avoid crashing when the Content URL is not found.Jean Chalard1-0/+10
I'm not sure when this can happen, but it seems it does at least on older versions of the platform. Let's avoid crashing. Bug: 11618402 Change-Id: If730b5bd8f20e0f60b884eab5900099116afc5f0
2014-02-18Cosmetic fixesKen Wakasa1-23/+30
Change-Id: I6c755565ba7689357d02d26cc0e92a93031953e8
2014-02-17Import translations. DO NOT MERGEBaligh Uddin57-663/+453
Change-Id: I2025fbb4b811c98f520ec048e4df4973da651709 Auto-generated-cl: translation import
2014-02-17Import translations. DO NOT MERGEBaligh Uddin57-57/+114
Change-Id: I2dc0e76dc4c696c1a7e9748b55e1badd273aea09 Auto-generated-cl: translation import
2014-02-18Refactor InputAttributes a bitTadashi G. Takaoka1-117/+155
Change-Id: I43d65be6de64ba86f83e8528a138e20c4fa1e3ed
2014-02-18Set neutral suggestions should be called after load settingsTadashi G. Takaoka3-41/+51
Bug: 13058751 Change-Id: Iba49e86b90d595473d91753827d499e551dad45c
2014-02-18Update important notice version even when user select SettingsTadashi G. Takaoka1-1/+1
Bug: 13060852 Change-Id: I463fdf3d51cacf99693fcde2998ea751046d1cc5
2014-02-17Don't resume suggestion on links.Jean Chalard4-3/+26
Bug: 11447084 Change-Id: I5bd558b9dd85d1505aa918f44e8ac3e52ec42d97
2014-02-17Stop overriding InputView.dispatchTouchEventTadashi G. Takaoka1-56/+63
Bug: 11721001 Bug: 11976254 Change-Id: I950f13ec4084da7fd9c1c25fd7abed1e5d31ed4c
2014-02-17Catch exceptions we can't do anything about.Jean Chalard4-44/+118
This also abstracts away the "package deactivated" case for simpler and safer code. Bug: 11072561 Change-Id: Idaaf2ae8d8d5b2c4a15de641bbf2f8c5c7cc9410
2014-02-17Make dotted i the base character of dotless i.Jean Chalard1-1/+2
This is already the case for the capital version, and natives Turkish speakers seem to think it should be the case. An important reason to make it so is that the Turkish keyboard has only the dotless i as a "more keys" key, so it's really hard to type words with a dotless i without this, especially those with several of them. Bug: 11519119 Change-Id: I4df2a289783e4eb3c1291b8ad0a2ba5947bf7671
2014-02-17Consider non-breaking spaces separators.Jean Chalard4-4/+4
Bug: 13056209 Change-Id: I6100b3ee21cf143140398757d9f7e7445067877a
2014-02-17Stop overriding SuggestionStripView.dispatchTouchEventTadashi G. Takaoka1-24/+23
Bug: 11721001 Bug: 11976254 Change-Id: Idfdeafe45abb16ca54be529b4f4b2c38c22a7fac
2014-02-17Remove unnecessary override of MainKeyboardView.dispatchTouchEventTadashi G. Takaoka2-21/+0
Bug: 11721001 Bug: 11976254 Change-Id: I762bd9e76ea31d67b3e31c3a0a19ee9f040015b8
2014-02-17Add InputMethodSubtypeCompatUtils.isAsciiCapable()Tadashi G. Takaoka3-6/+20
Change-Id: I8145f090486f6fe30ef1e992db374cfba0c31012
2014-02-17Don't show important notice on password fieldTadashi G. Takaoka4-12/+27
Bug: 10587358 Change-Id: Ieff7960e5e2b8609fddeb173af578a5d9b2c4d98
2014-02-17Stop using deprecated InputMethodSubtype constructorYohei Yukawa1-11/+20
The constructors of InputMethodSubtype were deprecated in API level 19. However we cannot yet switch to a new InputMethodSubtypeBuilder style due to our minimum support API level. As an intermediate solution, this patch replaces the these API calls with InputMethodSubtypeCompatUtils.newInputMethodSubtype so that these legacy API call can be consolidated at the same place. BUG: 13030512 Change-Id: I561a585f5dbea56c337680b645be5ef07015a0b1