aboutsummaryrefslogtreecommitdiffstats
path: root/java/src (unfollow)
Commit message (Collapse)AuthorFilesLines
2011-12-14Fix a long-standing race condition.Jean Chalard1-15/+15
Upon autocorrection, there is visual feedback in the text view that quickly flashes the background of the text that just changed. This fixes a race condition that happens upon autocorrection when typing fast, and that results in flashing one character too far left (typically, the flashing area includes the whitespace before the corrected word and not the last character of the corrected word). This happens because the call to commitCorrection may happen before or after the IPC sent by sendKeyChar, but the arguments are fit only for the case where it arrives first. Change-Id: I9b5442a665aad5a9bc66cd49228075b9056b37fa
2011-12-14Add a note of documentation to the sample word listJean Chalard1-2/+3
Change-Id: I95f09da03457933a14b549e04575d566de97dd49
2011-12-13Decouple member logic from control flowJean Chalard1-4/+8
This place is very confusing because a member variable with a consistent meaning is hijacked for the duration of a function to mean something else. This is in the way of easy-to-understand refactoring. Change-Id: If79bc771950d6bfc0ad5f0e9c51c7ef1dbb45b66
2011-12-13Various mini-cleanupsJean Chalard4-10/+11
- Stop the word composer from escaping - take a page from the law of Demeter and only report what is actually needed. - Fix typos in comments. - Add a comment for a fishy processing. - Remove a useless local variable. Change-Id: I5fa78901cbb5483fc9683bfb7094f47244b85df6
2011-12-13Reorganize LatinIME native build directory structure. Now it got NDK friendly.Ken Wakasa7-71/+119
Change-Id: I0f62ce8a6a4d2b6134db698f8b8d0576616e524d
2011-12-13Remove the input connection sidework from handleCharacterJean Chalard1-6/+10
Change-Id: I3d376dfda3acd8864274390de3ff5752b18456e0
2011-12-13Move mBestWord to the word composer.Jean Chalard2-19/+55
mBestWord has a confusing name - it's actually an auto-correction. It's cleaner if it lives in the word composer because an auto-correction should be tied to a specific user input, and should be reset each time the user input changes to avoid race conditions. Change-Id: I718d29395bc747372067e6440e090c6a181994ae
2011-12-13Introduce KeyboardSet to hold related KeyboardIdsTadashi G. Takaoka2-80/+144
This change moves * KeyboardSwitcher.getKeyboardId to KeyboardSet.<init> and KeyboardSet.getKeyboardId. * KeyboardSwitcher.getF2KeyMode to KeyboardSet. This is the first step to get rid of shift state from Keyboard. Bug: 5002108 Bug: 5679585 Change-Id: I2a5a97e5e89277bc606916d45c1afbc8d105d773
2011-12-13Consolidate underlining code under one function.Jean Chalard1-18/+17
Change-Id: I4393ff1ec28a6b3118d1344dd6d82d04899dea42
2011-12-13Tighten conditions for space-related cancellingJean Chalard1-4/+10
Instead of ignoring silently a found bug, throw an exception. Change-Id: I0aa96d0cab022b6a5e7cffe8a592dcc443c3c7a8
2011-12-13Extract the jni library namesatok2-2/+28
Change-Id: Icc58ccea1178d9f35f5be0dceebab67bbb965b7f
2011-12-13Remove KeyboardSwitcher.updateShiftLockState methodTadashi G. Takaoka1-15/+7
Change-Id: I032fc50a62a573ba4258530e695c8c88467783c6
2011-12-13Remove a useless returnJean Chalard1-3/+0
Change-Id: Iefe10e94e2d88171387351a5b6cab52e281d0f76
2011-12-13Use priority queue for native string buffersatok5-85/+178
+1 2 -6 2 Performance before ==== test finished, terminate logcat ===== (0) 100.34 (0.26%) (1) 37149.26 (95.30%) (2) 8.43 (0.02%) (3) 11.18 (0.03%) (4) 9.92 (0.03%) (5) 1330.60 (3.41%) (6) 250.46 (0.64%) (20) 12.41 (0.03%) Total 38982.50 (sum of others 38872.59) after ==== test finished, terminate logcat ===== (0) 97.65 (0.26%) (1) 35427.43 (95.32%) (2) 10.30 (0.03%) (3) 8.95 (0.02%) (4) 11.01 (0.03%) (5) 1224.67 (3.30%) (6) 243.76 (0.66%) (20) 40.91 (0.11%) Total 37167.04 (sum of others 37064.68) Change-Id: Id4d3b88a9cdef765affc52973aeac951ecc6a8ca
2011-12-13SimplificationJean Chalard1-4/+2
Both tests have the same meaning. They should be merged. Also, if "deleteLast()" deletes more than one char (which never happens in the current implementation, but it's not guaranteed), the new code is more correct. Change-Id: I216df7cd45f4a7d76d1d5d6aa7f8d7f9a6e35ea3
2011-12-13RefactoringJean Chalard1-21/+18
If mHasUncommittedTypedChars is true, then mWordSavedForAutoCorrectCancellation must always be null, and spaceState must always be SPACE_STATE_NONE. Hence, this change is supposed to be very no-op. Change-Id: I2716f7372d996cc4dec40a4b7ac1ee7f5f4afe91
2011-12-13Refactor + small bugfixJean Chalard1-4/+3
postUpdateShiftKeyState used to be called also when mEnteredText is not null => this is a bugfix. The rest does not change the logic, as posting a message can be done anywhere within the function with no impact. Change-Id: I7888797c0778702d64f96701e35b611a55a6a259
2011-12-13RefactoringJean Chalard1-7/+5
Change-Id: I57b2232f7fde32df5f6e1925aad1df988def34f9
2011-12-13Remove current keyboard id variableTadashi G. Takaoka1-5/+3
Change-Id: Iec19af98209e1ea8ecd176d3be04d628d4b38950
2011-12-12Fix a bug where revert auto-correct would revert too muchJean Chalard1-8/+24
If there are no uncommitted chars, we shouldn't enter any of the tests that follow. We didn't use to, but a change today made it possible - it should not happen. There is no point in doing the rest of the tests, they are sure to fail. Change-Id: I580dd104aff3585de72a93b38989bfd9713f615b
2011-12-12Remove a useless function callJean Chalard1-1/+0
Change-Id: I1a775cbf90dca301e1e6b596ddac64fdbc023199
2011-12-12Remove a useless variableJean Chalard1-3/+2
This can be just read when it's needed. Change-Id: I00753fe55645c244db5d4a96e7fdb8f5325475d9
2011-12-12Move a settings var to the settings classJean Chalard2-2/+3
Change-Id: I1331ad6dec3a9d64a77e314f8a1f4c29282df31b
2011-12-12Remove a messy and unused class.Jean Chalard2-225/+0
Today is a happy day Change-Id: I3ef484bd258d5a59815bfcb0bd35ea3606b32430
2011-12-12Remove side-effects from TextEntryStateJean Chalard3-12/+41
Change-Id: Ib98eea9e791e426435cfdfd0c9ab3ed9061664aa
2011-12-12Add special handling for "Phone number" layout.Tadashi G. Takaoka1-0/+6
Bug: 5743584 Change-Id: I821b837a2078afb64b460191c98b28f7733cf2c1
2011-12-12Remove a useless variable.Jean Chalard1-5/+1
Change-Id: Iea5ce5cfc05bad8b1d9085438e90147bd54b7e9c
2011-12-12Straighten out logic for revert word pathsJean Chalard1-30/+67
This also includes a new memorized string with simpler logic that will allow to remove other members Change-Id: I0b97243084902e68fcb835b6163c86fef8190ebc
2011-12-12Add unit test of KeyboardStateTadashi G. Takaoka2-3/+263
Bug: 5708602 Change-Id: I1a8a9f4320948bb500a96df8773b0bfa1a1d4167
2011-12-12Move KeyDetector.printableCode to KeyboardTadashi G. Takaoka3-10/+23
Change-Id: I9cde21fbb45c1e5f1a568bb97b1b1a76524f4bf2
2011-12-12Assign Key.mCode from the label only when outputText is not specifiedTadashi G. Takaoka1-1/+8
Bug: 5742827 Change-Id: I72b55ce246b14a2d8f4fd16211b71dc716db30b2
2011-12-12Remove unused Keyboard.CODE_CANCELTadashi G. Takaoka2-6/+0
Change-Id: Ic2eab17e525901a1cf7096ebe7d24ae78624ed2e
2011-12-12Remove a duplicated variable.Jean Chalard3-37/+27
This is awesome cleanup. Change-Id: I35ce8940a13f3084630dc26d6e7e397acfdaac36
2011-12-10Build God Mode keyboard with API level 14Ken Wakasa2-1/+46
Change-Id: I29ab9e9041c9faac91dc303175625221bfdb3af8
2011-12-10Fix isResearcherPackagesatok2-3/+2
Change-Id: I286450fe89a37d75cb398f17d300ddc6f5857ffd
2011-12-10Some tweaks for Researcher ModeKen Wakasa3-4/+10
Change-Id: I6b16dd2fe6d7356c747ba0ee2da5976738003ded
2011-12-09Add a functionality to attach a log file to Gmail appsatok1-27/+85
Bug: 5722703 Change-Id: I089f944bdbf2cbb036eb59dd9b5b414370c770f1
2011-12-09Resolve TODOs: add members to hold preferencesJean Chalard1-3/+9
Change-Id: I34f6c76bf9318e1fbe8eb5ffab6772a98ff824e0
2011-12-09Remove unused public methods from KeyboardState and KeyboardSwitcherTadashi G. Takaoka3-75/+42
Bug: 5708602 Change-Id: I3dbc3cd00aa9ddf611e2078ff2cfea8945fa09bf
2011-12-09Resolve TODOs: add some members to store prefsJean Chalard2-11/+21
Change-Id: Idf09cb5d801e8008eb63cbb5138058faeb7db136
2011-12-09Resolve TODOs: add members to store raw settingsJean Chalard1-17/+17
Change-Id: I481eadb6a73faf239e24d05b7e220fcb01194fa4
2011-12-09Read options in the declaration orderJean Chalard1-3/+2
Change-Id: I1a7c4d0bcaedad6d4045c36c79280c23234db5b3
2011-12-09Straighten out prefs reading codeJean Chalard2-20/+31
Change-Id: Ibf9113a8ef07ac720100ee32d2e5ef321e8ddd98
2011-12-09Straighten out members extracted from resources.Jean Chalard1-23/+29
Change-Id: I9b9602ec5b379b44b0f0663d4f065dbcf88fd352
2011-12-09Match constant names to option namesJean Chalard2-28/+28
Change-Id: I7586fa342d7a39412d656890f7b525139c45ea4a
2011-12-09Reorder members in SettingsValues.Jean Chalard2-32/+33
Reorder so that they match the order in the preference xml file. Also add TODOs for missing raw variables. Change-Id: I06332c131a624d6c359512d75c808f3f7313fa91
2011-12-09Move settings variables to the settings classJean Chalard3-21/+18
Change-Id: Ifa7033a84b08ea626eb44cf6d04ba8e28c250bea
2011-12-09KeyboardState keeps track of isAlphabetMode and isSymbolShiftedTadashi G. Takaoka2-71/+70
Bug: 5708602 Change-Id: I181cdeb90d24984ce6f6c993b278293aae7364eb
2011-12-09Stop a flag from escaping.Jean Chalard4-33/+26
The ultimate intent is to close it up in the settings, as it does not change while typing, only when the keyboard is open again. Change-Id: I12ff56e7482c1584877fe5531473bf03e95a60f6
2011-12-09Move settings method from Utils to SettingsValuesJean Chalard4-42/+42
Change-Id: I633378a41f63cd492b8c9345d550e07254df5e5a
generated by cgit v1.2.3-83-g751a (git 2.47.1) at 2025-07-15 21:48:33 +0000