| Commit message (Collapse) | Author | Files | Lines |
|
This is not exactly the same logically speaking, because it's
theoretically possible that the composing state changed in between
the message enqueueing and it's retrieval. However in the practice,
if the composing state changed the message *must* have been
cancelled and resent, else the behavior breaks. So this actually
is more robust, and removes some obscure requirements on the
calling code.
In the practice, it should also make the cancelUpdateSuggestionStrip
message useless, although this change does not yet remove it.
Change-Id: I75141920ce64e38e2f92e9c02b6c979936eee9a9
|
|
Change-Id: I2a77e437795fbbea47fd2e604ee6c26f8d0e458a
|
|
Change-Id: I4b91414190b3786065ebd962a76299b605e5797e
|
|
Change-Id: Ica9b875d119dea2f8dc237fd63e5b4eaa5e1c400
|
|
Change-Id: Iff03fe7c4a8eec17c00a2fe99197e0cf21a0630a
|
|
Change-Id: I588d7acc6f64360404440ad8dc2c00296046b09d
|
|
Change-Id: I46c6a6e1c1536599cb909bf81297001b238f2ec8
|
|
Change-Id: I1061da0edfdb05c64c5711717d4ef9fa9681e568
|
|
Bug: 6785706
Change-Id: Ic7bf242ef058d116b986d47ad197b6d2802e2342
|
|
We just resetted the composing state - updating suggestions
is sure to yield no results. We may as well not call
updateSuggestions at all.
We should however still cancel any lingering timer from a
previous input field, to avoid this useless processing.
Change-Id: Ic1a19d577903d792bb797c837cc517ea8d430e75
|
|
Change-Id: I7c16e28ffce4fe0965b756bf2b00ee63b77dd039
|
|
If the separator is not a space, then we will always call
setPunctuationSuggestions and reset the suggestion strip anyway.
If the separator is a space, then the cursor has a space on
the left, which means isCursorTouchingWord depends only on
whether it touches a word on the right. If we were displaying
the "add to dictionary hint", it means a suggestion was just
chosen, so it had to be displayed, and that requires a composing
word and no non-separator at the right of the cursor.
In the end, if we go through this postUpdateSuggestions call,
we are sure we will reset the suggestions later in this method,
either by calling postUpdateBigramPredictions, or
setPunctuationSuggestions.
Change-Id: I95d5f77a5d0ac6d1a6ced8d67d6ac8f650db4a32
|
|
Change-Id: I606270a0387787445b7cd6b94e4830bfc144b49e
|
|
This reverts commit 48a436081fc6886dbeecf1f2b25fd754952f0fe1.
|
|
Change-Id: Iff324c705b46cfae27ea9b6b8dc8b0a0d56a193d
|
|
Change-Id: I117e2429c5f5e75a6ffe84b5869afb2e033f2b2d
|
|
Just after this, clear() will be called, removing the suggestion
strip from the screen. It will later be displayed again through
onStartInputView, which will update its content.
Change-Id: I15c23ad2adecab76b0791d7fc222d15b6533f3bd
|
|
Change-Id: I99e912d3edfc7dd3f17ee835331d5fcba976750c
|
|
The responsivity is better like this. This does not seem to
feel slow as the previous comment seemed to indicate.
Also remove a stale comment.
Change-Id: I4e7bf9fe28716e112db182e44b3fa88ee4526bb4
|
|
After reverting an auto-correct we always have a separator after
the previously inserted word, and the cursor is never touching
a word. Showing predictions is the right thing to do, while
calling postUpdateSuggestions will invariably yield an invariably
blank suggestion strip, which is not very helpful.
Likewise, after we pick a suggestion, we should be showing the
predictions unless showing the addToDictionary hint. There was
a bug here in the corner case that the word would be a candidate
for user dictionary, but the user dictionary provider is not
available: in this case we should be showing predictions, but
we were showing an unhelpful empty suggestion bar.
Change-Id: I287bb5eb4af762bd5a433e85e185fab6d203e91a
|
|
We stopped cancelling manual picks a few weeks ago. This code
is dead.
Change-Id: I4032fcc3c95e9379f1839fe860a1b8a9bd7d0bc7
|
|
Bug: 6766059
Change-Id: I378f9d35c4904c4f373260bda5863235d833eb31
|
|
If suggestion and prediction messages both happen to be in
the queue, the latest one will win (update the suggestion strip
later than the other, overwriting any previous suggestions).
So when we enqueue either one, it is always safe to cancel
all messages of both types.
Change-Id: Iad9dd06d08c49f60cac16b88edcc9531a18ec02e
|
|
Change-Id: I9974b88923b85cd6bec74f7607067c660f36f040
|
|
Bug: 6781106
Change-Id: I22f04af4fabf93346ab6f72c1841f096afaccb96
|
|
Change-Id: If36b5375b04f68deeb72bcece3cb8d37aed57f59
|
|
Change-Id: If711074fdcb586e35d02e421c845f2c9024ca718
|
|
Change-Id: I56bc5b9b584de5a14b41fc32c19f7fefb3b12e88
|
|
Change-Id: If1589e29728df20713c75e08df7f47f0de9202d4
|
|
Change-Id: I0b62098308169b5c44ced25ffb902766e3732fbf
|
|
Also add some comment to clarify what's happening inside those
methods
Change-Id: I5b9b1e105b3145f0b050f35d12c5b6ca6e4a4d8c
|
|
Bug: 6435484
Change-Id: Iffe459c117ad438e96ec6f5c7e64fb80b32d227e
|
|
Bug: 6773873
Change-Id: I1a533c729c312a53663fb142cb6fcb4915b53206
|
|
This is a follow up of Id962e670.
Change-Id: I9e8542bff9e8faf57f934051fe612463c99ad61f
|
|
The goal is to have those converge, as they contain almost 100%
duplicated code.
Change-Id: I6921791d47efce9fb396efd9626839d706664a91
|
|
Change-Id: Ibc2d28f9f95966f77d4d7bdf9ae4688baaed5989
|
|
...if there aren't any for the exact case version.
Bug: 6752830
Change-Id: I2737148b01ba04a64febe009ceb2ef53c265d224
|
|
Change-Id: Ie6af46acba18a2d1cf3ddd1578d60ded4c90f89a
|
|
Change-Id: I722b9e981389f660db928b7fd5ced1b82371fbf3
|
|
Change-Id: Ie8792f4f5d3593c25c992fc72cf219daeaa70beb
|
|
Change-Id: I6ab1462f62b2d53a157494d27342a832ec1f15f7
|
|
It's simpler to check the safety net directly inside the
function that checks for auto-correction threshold.
This introduces one very slight change in behavior. The value
checked by the safety net is not any more the "typed word" but the
"considered word", the difference being any possibly appended
single quotes.
E.g. the user types "this'''" : the typed word is "this'''" but
the considered word is "this".
This change in behavior can be considered a bugfix.
Change-Id: Ia7ab4bc933183dfbd41bb00328e4c0b5ab76bc63
|
|
Change-Id: Iec791d061f237f60992dd6048c4a37b46f4cb9aa
|
|
Change-Id: I9c9bbd6dda1e978e29e985296cb624035d45497d
Auto-generated-cl: translation import
|
|
Change-Id: I13c7109bb886ef2860cbb4fc24650dd2b8badbcb
Auto-generated-cl: translation import
|
|
Change-Id: Iabb6caa620cb587110a3d88ce7129ed978eea83a
|
|
Change-Id: Ia2ab54651ef96521fce01fe4755147909b818803
|
|
We internally use the string "zz" to mean no locale, but
the user dictionary service does not understand that and
words added with this locale pitifully end being added to
a "zz" user dictionary, which makes no sense to the user.
This change fixes things so that words added when the
keyboard is in a "no locale" layout, the words are added
to the global, all-locales user dictionary.
Bug: 6645306
Change-Id: Iec3cdd1fe3d5bc43427a43ef9ae9bf89e12be1f2
|
|
Change-Id: Ib0b6f36999518096819ada2f19365767cb5f9931
|
|
If allowsAutoCorrected is false, there is no point in making
hasAutoCorrection true, since in the only place where we use
it again, it's &&'ed with allowsAutoCorrected !
Well that was extremely obscure, good thing refactoring allowed
to realize this was useless >.>
Change-Id: I34936d445f1ced17c7bd04a9524bf608f9e8b9c8
|