aboutsummaryrefslogtreecommitdiffstats
path: root/java/src (follow)
Commit message (Collapse)AuthorAgeFilesLines
...
* | Remove useless code (A61)Jean Chalard2012-07-061-3/+0
| | | | | | | | | | | | | | | | Just after this, clear() will be called, removing the suggestion strip from the screen. It will later be displayed again through onStartInputView, which will update its content. Change-Id: I15c23ad2adecab76b0791d7fc222d15b6533f3bd
* | Simplification (A60)Jean Chalard2012-07-061-9/+3
| | | | | | | | Change-Id: I99e912d3edfc7dd3f17ee835331d5fcba976750c
* | Simplification & UI improvement (A59)Jean Chalard2012-07-061-6/+2
| | | | | | | | | | | | | | | | | | The responsivity is better like this. This does not seem to feel slow as the previous comment seemed to indicate. Also remove a stale comment. Change-Id: I4e7bf9fe28716e112db182e44b3fa88ee4526bb4
* | Show predictions in the right cases (A58)Jean Chalard2012-07-061-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After reverting an auto-correct we always have a separator after the previously inserted word, and the cursor is never touching a word. Showing predictions is the right thing to do, while calling postUpdateSuggestions will invariably yield an invariably blank suggestion strip, which is not very helpful. Likewise, after we pick a suggestion, we should be showing the predictions unless showing the addToDictionary hint. There was a bug here in the corner case that the word would be a candidate for user dictionary, but the user dictionary provider is not available: in this case we should be showing predictions, but we were showing an unhelpful empty suggestion bar. Change-Id: I287bb5eb4af762bd5a433e85e185fab6d203e91a
* | Cleanup (A57)Jean Chalard2012-07-062-18/+11
| | | | | | | | | | | | | | We stopped cancelling manual picks a few weeks ago. This code is dead. Change-Id: I4032fcc3c95e9379f1839fe860a1b8a9bd7d0bc7
* | Merge "Fix a bug where the caps mode would not be changed"Jean Chalard2012-07-052-8/+19
|\ \
| * | Fix a bug where the caps mode would not be changedJean Chalard2012-07-062-8/+19
| | | | | | | | | | | | | | | Bug: 6766059 Change-Id: I378f9d35c4904c4f373260bda5863235d833eb31
* | | Simplification (A56)Jean Chalard2012-07-051-14/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If suggestion and prediction messages both happen to be in the queue, the latest one will win (update the suggestion strip later than the other, overwriting any previous suggestions). So when we enqueue either one, it is always safe to cancel all messages of both types. Change-Id: Iad9dd06d08c49f60cac16b88edcc9531a18ec02e
* | | Remove an unused method (A55)Jean Chalard2012-07-052-30/+0
| | | | | | | | | | | | Change-Id: I9974b88923b85cd6bec74f7607067c660f36f040
* | | Merge "Remove a useless method, rename another. (A54)"Jean Chalard2012-07-052-7/+3
|\ \ \
| * | | Remove a useless method, rename another. (A54)Jean Chalard2012-07-052-7/+3
| | | | | | | | | | | | | | | | Change-Id: If36b5375b04f68deeb72bcece3cb8d37aed57f59
* | | | Merge "Initialize SubtypeLocale from Settings"Tadashi G. Takaoka2012-07-052-1/+11
|\ \ \ \
| * | | | Initialize SubtypeLocale from SettingsTadashi G. Takaoka2012-07-052-1/+11
| | | | | | | | | | | | | | | | | | | | | | | | | Bug: 6781106 Change-Id: I22f04af4fabf93346ab6f72c1841f096afaccb96
* | | | | Merge "Remove a redundant test (A53)"Jean Chalard2012-07-051-11/+4
|\ \ \ \ \ | | |/ / / | |/| | |
| * | | | Remove a redundant test (A53)Jean Chalard2012-07-051-11/+4
| | | | | | | | | | | | | | | | | | | | Change-Id: If711074fdcb586e35d02e421c845f2c9024ca718
* | | | | Merge "Small simplification (A52)"Jean Chalard2012-07-051-8/+4
|\| | | |
| * | | | Small simplification (A52)Jean Chalard2012-07-051-8/+4
| | | | | | | | | | | | | | | | | | | | Change-Id: I56bc5b9b584de5a14b41fc32c19f7fefb3b12e88
* | | | | Merge "Put some more code in common (A51)"Jean Chalard2012-07-051-23/+18
|\| | | |
| * | | | Put some more code in common (A51)Jean Chalard2012-07-051-23/+18
| | | | | | | | | | | | | | | | | | | | Change-Id: If1589e29728df20713c75e08df7f47f0de9202d4
* | | | | Merge "Pull up a common variable into the wrapping method (A50)"Jean Chalard2012-07-051-8/+10
|\| | | |
| * | | | Pull up a common variable into the wrapping method (A50)Jean Chalard2012-07-051-8/+10
| | | | | | | | | | | | | | | | | | | | Change-Id: I0b62098308169b5c44ced25ffb902766e3732fbf
* | | | | Merge "Factorize some common code (A49)"Jean Chalard2012-07-051-30/+16
|\| | | | | |/ / / |/| | |
| * | | Factorize some common code (A49)Jean Chalard2012-07-051-30/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Also add some comment to clarify what's happening inside those methods Change-Id: I5b9b1e105b3145f0b050f35d12c5b6ca6e4a4d8c
* | | | Merge "Fix tab key's navigation behavior"Tadashi G. Takaoka2012-07-054-13/+4
|\ \ \ \
| * | | | Fix tab key's navigation behaviorTadashi G. Takaoka2012-07-054-13/+4
| | | | | | | | | | | | | | | | | | | | | | | | | Bug: 6435484 Change-Id: Iffe459c117ad438e96ec6f5c7e64fb80b32d227e
* | | | | Merge "Fix upper case Eszett more key"Tadashi G. Takaoka2012-07-051-3/+11
|\ \ \ \ \ | |_|/ / / |/| | | |
| * | | | Fix upper case Eszett more keyTadashi G. Takaoka2012-07-051-3/+11
| |/ / / | | | | | | | | | | | | | | | | Bug: 6773873 Change-Id: I1a533c729c312a53663fb142cb6fcb4915b53206
* | | | Merge "Add a wrapper to updateSuggestions / Predictions (A48)"Jean Chalard2012-07-041-7/+15
|\ \ \ \ | |/ / / |/| | |
| * | | Add a wrapper to updateSuggestions / Predictions (A48)Jean Chalard2012-07-051-7/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The goal is to have those converge, as they contain almost 100% duplicated code. Change-Id: I6921791d47efce9fb396efd9626839d706664a91
* | | | Merge "Fix Keyboard.getKey as thread safe"Tadashi G. Takaoka2012-07-041-10/+12
|\ \ \ \ | |/ / / |/| | |
| * | | Fix Keyboard.getKey as thread safeTadashi G. Takaoka2012-07-051-10/+12
| |/ / | | | | | | | | | | | | | | | This is a follow up of Id962e670. Change-Id: I9e8542bff9e8faf57f934051fe612463c99ad61f
* / / Refactoring which will help with future changes (A47)Jean Chalard2012-07-051-2/+5
|/ / | | | | | | Change-Id: Ibc2d28f9f95966f77d4d7bdf9ae4688baaed5989
* | Search bigrams for the lower case version of the word (A46)Jean Chalard2012-07-042-15/+5
| | | | | | | | | | | | | | ...if there aren't any for the exact case version. Bug: 6752830 Change-Id: I2737148b01ba04a64febe009ceb2ef53c265d224
* | Merge "Remove WordComposer.add(int, int, int, KeyDetector) method"Tadashi G. Takaoka2012-07-045-24/+26
|\ \
| * | Remove WordComposer.add(int, int, int, KeyDetector) methodTadashi G. Takaoka2012-07-045-24/+26
| | | | | | | | | | | | Change-Id: Ie6af46acba18a2d1cf3ddd1578d60ded4c90f89a
* | | Merge "Use Keyboard.getKey"Tadashi G. Takaoka2012-07-041-7/+6
|\ \ \ | |/ / |/| |
| * | Use Keyboard.getKeyTadashi G. Takaoka2012-07-041-7/+6
| | | | | | | | | | | | Change-Id: I722b9e981389f660db928b7fd5ced1b82371fbf3
* | | Merge "Get rid of redundant CharSequence member from SuggestedWordInfo"Tadashi G. Takaoka2012-07-041-10/+8
|\ \ \
| * | | Get rid of redundant CharSequence member from SuggestedWordInfoTadashi G. Takaoka2012-07-041-10/+8
| |/ / | | | | | | | | | Change-Id: Ie8792f4f5d3593c25c992fc72cf219daeaa70beb
* | | Consolidate a method inside another (A45)Jean Chalard2012-07-042-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's simpler to check the safety net directly inside the function that checks for auto-correction threshold. This introduces one very slight change in behavior. The value checked by the safety net is not any more the "typed word" but the "considered word", the difference being any possibly appended single quotes. E.g. the user types "this'''" : the typed word is "this'''" but the considered word is "this". This change in behavior can be considered a bugfix. Change-Id: Ia7ab4bc933183dfbd41bb00328e4c0b5ab76bc63
* | | Move the safety net function to AutoCorrection (A44)Jean Chalard2012-07-043-40/+38
| | | | | | | | | | | | Change-Id: Iec791d061f237f60992dd6048c4a37b46f4cb9aa
* | | Merge "Refactoring (A43)"Jean Chalard2012-07-031-3/+3
|\ \ \ | |/ / |/| |
| * | Refactoring (A43)Jean Chalard2012-07-021-3/+3
| | | | | | | | | | | | Change-Id: Ib0b6f36999518096819ada2f19365767cb5f9931
* | | Merge "Remove useless code (A42)"Jean Chalard2012-07-021-5/+0
|\| |
| * | Remove useless code (A42)Jean Chalard2012-07-021-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If allowsAutoCorrected is false, there is no point in making hasAutoCorrection true, since in the only place where we use it again, it's &&'ed with allowsAutoCorrected ! Well that was extremely obscure, good thing refactoring allowed to realize this was useless >.> Change-Id: I34936d445f1ced17c7bd04a9524bf608f9e8b9c8
* | | Merge "Clarify some code and fix a bug (A41)"Jean Chalard2012-07-021-10/+13
|\| |
| * | Clarify some code and fix a bug (A41)Jean Chalard2012-07-021-10/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The test against hasMainDictionary is a test to know if we should auto-correct or not. Its result should be recorded in hasAutoCorrection, not in allowsToBeAutoCorrected. Actually, this value being inserted in allowsToBeAutoCorrected was causing a bug that nobody noticed: when typing in a language with no dictionary, the word in the middle of the suggestion strip would always be bold, as if it was going to auto-correct to itself ! This change fixes this bug. Change-Id: Ia1f08efd7089b9c5cbede910c5b0951d83e698d2
* | | Merge "Fix a bug with the user dictionary locale."Jean Chalard2012-07-021-2/+10
|\ \ \ | |/ / |/| |
| * | Fix a bug with the user dictionary locale.Jean Chalard2012-07-021-2/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We internally use the string "zz" to mean no locale, but the user dictionary service does not understand that and words added with this locale pitifully end being added to a "zz" user dictionary, which makes no sense to the user. This change fixes things so that words added when the keyboard is in a "no locale" layout, the words are added to the global, all-locales user dictionary. Bug: 6645306 Change-Id: Iec3cdd1fe3d5bc43427a43ef9ae9bf89e12be1f2
* | | Small refactoring (A39)Jean Chalard2012-07-021-14/+14
| | | | | | | | | | | | Change-Id: I3c45b5a6571f986acc7adb3a8fe17b210303f7ea