aboutsummaryrefslogtreecommitdiffstats
path: root/java/src (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Simplification (A31)Jean Chalard2012-06-291-6/+2
| | | | Change-Id: I9e4d030974ccec1a6256de6ca87610870e404149
* Small refactoring (A30)Jean Chalard2012-06-291-4/+4
| | | | Change-Id: I41b413986a3c5bb6697bb7bbced17ed1e361913c
* Remove a useless parameter (A29)Jean Chalard2012-06-294-6/+1
| | | | Change-Id: I52625e707abf61da9b95e542f0814c66b532f483
* Remove a useless variable (A28)Jean Chalard2012-06-292-5/+0
| | | | Change-Id: I1058123d233540fb72a94028987a43740224f635
* Fix a small bug (A27)Jean Chalard2012-06-291-1/+1
| | | | | | | | | TypedWordValid and AllowsToBeAutoCorrected are almost the same thing; the difference is whether the word is also a whitelist entry or not. In this case, TypedWordValid was the right one to test. Change-Id: I695fe5b9f6bbe9d3ba314c646da3a25742c9f4ed
* Optimization (A26)Jean Chalard2012-06-291-9/+2
| | | | Change-Id: I1d7790289635729645995fb8c38868259ab1b3be
* Remove useless code (A25)Jean Chalard2012-06-291-4/+1
| | | | | | | | | | | | | | | | | | | | isWhitelistedOrNotAWord takes an 'ignoreCase' argument. By looking at the contents of the wordcomposer here, there is only one case where its output will be different : when the word is typed with a capital, but the lower case version exists in the dictionary. E.g. the user typed "This". In this case, isWhitelistedOrNotAWord in line 235 will return false instead of true, so the test will score a true instead of a false, so hasAutoCorrection may be true instead of false in this specific case and that's the only case where it's different. But in this case, allowsToBeAutoCorrected is certain to be false, which means the result will not have changed if hasAutoCorrection was true in the first place. So in the end this change is sure not to change the behavior. Change-Id: Ic41cf959c20c19165f84d9b8ff006731fa595d84
* Add a few comments for future reference (A24)Jean Chalard2012-06-291-0/+6
| | | | Change-Id: Ia356130b8a95ec9cf676bc6be05d801c13f14b64
* Rename a method for readability (A23)Jean Chalard2012-06-292-2/+2
| | | | Change-Id: I6f569322e645d36bc82fddf4ec2fd621972e3b47
* Revert a test for readability (A22)Jean Chalard2012-06-291-14/+12
| | | | Change-Id: I1df4cef5ae2736a22273843dce67f0012181bfd3
* Remove a useless variable (A21)Jean Chalard2012-06-291-4/+4
| | | | Change-Id: I901e6b0e2b994128da19d68233b9f68bb308cb95
* Remove a useless variable (A20)Jean Chalard2012-06-291-6/+4
| | | | Change-Id: Ifc37462f5243563693c8cd7cbeb401ff054daa52
* Rename a method for readability (A19)Jean Chalard2012-06-292-3/+3
| | | | Change-Id: I0b8c06d1fd0bfb3caf363c048acc7048abed1752
* Remove a useless test (A18)Jean Chalard2012-06-291-2/+2
| | | | | | | | allowsToBeAutoCorrected always returns false if the word is empty. This is because the whitelist never contains an empty string, and isValidWord returns false if the word is empty. Change-Id: I34ecc2a1563aea6db5b2f12796f251f6598576a2
* Inline a method (A17)Jean Chalard2012-06-292-8/+2
| | | | | | This will allow us to remove unnecessary processing Change-Id: I251dfdaffb077906186686ebe65fd82e1e360bd2
* Make a function a one-liner (A16)Jean Chalard2012-06-291-2/+2
| | | | | | ...to better inline it Change-Id: I88496b8f18b81f0c05e4bbf2d1039de1f93e0c25
* Inline a simple method (A15)Jean Chalard2012-06-292-5/+1
| | | | Change-Id: Ib74fcbf33c680bf02c39a9896e30e3afbcfd149a
* Inline a method (A14)Jean Chalard2012-06-292-23/+14
| | | | | | | The new code is worse than the old one, but this is a necessary step to make things prettier. Change-Id: If6e8a139bb85e6920c749743c78792a22a8acb45
* Don't special-case 1-letter words (A13)Jean Chalard2012-06-291-8/+6
| | | | | | | There is no reason to prevent 1-letter words to auto-correct to themselves, or to dictionary words. Don't do it. Change-Id: Iceada847ae632336026ada29afed0353cd9c51b5
* Fix a theoretical bug (A12)Jean Chalard2012-06-291-5/+3
| | | | | | | | | If a word is a dictionary word but still has no suggestion, this method should return true. In the practice, it makes no difference since a word without suggestion won't be changed anyway. Change-Id: Ib1f5ef254b7da7e5cedb2f973529ad431beb93f9
* Rename a terribly-named method for clarity (A11)Jean Chalard2012-06-291-2/+3
| | | | Change-Id: Id180000404dc6929d80f98c0e9cd2026230ad2d1
* Merge "Small readability improvement (A10)"Jean Chalard2012-06-281-1/+3
|\
| * Small readability improvement (A10)Jean Chalard2012-06-291-1/+3
| | | | | | | | Change-Id: Iba326921711e1c4eab38264e66b6b44a64fec398
* | Refactoring and add debug prints (A9)Jean Chalard2012-06-291-4/+13
|/ | | | Change-Id: I46497bff107f0def0dfa2b043b20d9a0b0cde040
* Optimization (A8)Jean Chalard2012-06-291-9/+13
| | | | Change-Id: I2b9e8cc6a13fd9af84a5189e4d3fbb2b05c68d46
* Cleanup (A7)Jean Chalard2012-06-281-4/+2
| | | | Change-Id: Iba97e0062b702c005ab3ff9ce59f181d19ab7c98
* Stop special-casing a single suggestion (A6)Jean Chalard2012-06-281-13/+12
| | | | | | Treat it like the others Change-Id: Ic24e40ada0e75773c3ece9470ab61c350697be5d
* Cleanup (A5)Jean Chalard2012-06-282-18/+0
| | | | Change-Id: I06134145b47c46bbc6c340ca539f34a01e2ca163
* Transform the whitelist suggestion like the others (A4)Jean Chalard2012-06-281-16/+7
| | | | | | ...instead of having a different code path Change-Id: Icd177e2151e45d25300000d4b63d4fba1f52b6a8
* Small refactoring (A3)Jean Chalard2012-06-281-6/+8
| | | | | | This will help make upcoming changes clearer Change-Id: Ida8d4935f7315e5da6007ad364124694da3112d0
* Don't pass everything to a function that needs only the head (A2)Jean Chalard2012-06-282-13/+14
| | | | Change-Id: Ic367836202ab8071c1a9a02eaf0651b0da947d51
* Merge "Use a TreeSet to sort suggestions instead of doing it by hand (A1)"Jean Chalard2012-06-282-28/+57
|\
| * Use a TreeSet to sort suggestions instead of doing it by hand (A1)Jean Chalard2012-06-282-28/+57
| | | | | | | | Change-Id: I16ba39321107e87ad48a99c2410a15995a66f23c
* | am 5e5cf045: am 7f7947c9: Keep subtypes in method.xml the same as pre-JellyBeanTadashi G. Takaoka2012-06-271-1/+20
|\ \ | |/ |/| | | | | * commit '5e5cf045ca6debafcc29ae1c47afda4a3a152326': Keep subtypes in method.xml the same as pre-JellyBean
| * Keep subtypes in method.xml the same as pre-JellyBeanTadashi G. Takaoka2012-06-281-1/+20
| | | | | | | | | | | | | | | | This change prevents Android Keyboard subtypes being mistakenly disabled when upgrading from pre-JellyBean to JellyBean. Bug: 6750906 Change-Id: I05de6c512e7aa17356e415476e5248986c7d4253
* | Convert local members to local variablesJean Chalard2012-06-271-17/+13
| | | | | | | | Change-Id: I852787986c79502a4de7effe9c8281a4cf2d519d
* | Optimization.Jean Chalard2012-06-271-7/+11
| | | | | | | | | | | | | | It's useless to do this for all suggestions including those that will be ousted from the list. Change-Id: I7bd63d783e21984a269e4b1ae17e9b9d8c0859e3
* | Read the suggestion type from the suggestionJean Chalard2012-06-271-4/+5
| | | | | | | | | | | | ...instead of dirtily passing it from the dictionary loop Change-Id: I92ddbd7451609b69f6d4dc31bf89d614423b2016
* | Remember the source dictionary for each suggestion.Jean Chalard2012-06-276-14/+22
| | | | | | | | Change-Id: I3c63372bd5572a479a67eaecfe8c8ea1cabc70d9
* | Move constants to a better place.Jean Chalard2012-06-278-29/+29
| | | | | | | | Change-Id: I5c27a3ed99b17f850e26a8503de16f001c7111c1
* | CleanupJean Chalard2012-06-271-17/+8
| | | | | | | | Change-Id: I575f22330bf6881af1d9a35f22b51b7bf2198113
* | Remove unused stuff.Jean Chalard2012-06-273-28/+2
| | | | | | | | Change-Id: Ifd0d5b6978f76b841574a6e10157c32d0cd656b6
* | Cleanup the dictionary type.Jean Chalard2012-06-2712-37/+40
| | | | | | | | | | | | | | Stop storing an int in each of the different class types, and just store a string in the top class. Change-Id: I2af1832743e6fe78e5c1364f6d9cc21252bf5831
* | Merge "Update the prototype of onAddSuggestedWord - calling side."Jean Chalard2012-06-273-14/+7
|\ \
| * | Update the prototype of onAddSuggestedWord - calling side.Jean Chalard2012-06-273-14/+7
| | | | | | | | | | | | | | | | | | We want to get rid of all those IDs in Latin IME. Change-Id: Ibe08100a5e2976c80abb049889233b4047a686f3
* | | Small cleanupsKen Wakasa2012-06-273-6/+6
|/ / | | | | | | Change-Id: Ic1a198ab1b4f0323fde9e4245729fd0e6011b914
* | Merge "Use binarySearch instead of a hand-written linear search"Jean Chalard2012-06-261-9/+5
|\ \
| * | Use binarySearch instead of a hand-written linear searchJean Chalard2012-06-271-9/+5
| | | | | | | | | | | | | | | | | | Yay. Change-Id: Icf686eb2d675da959f19edc856b521e6288dcea3
* | | Merge "Implement a comparator for SuggestedWordInfos."Jean Chalard2012-06-261-4/+18
|\| |
| * | Implement a comparator for SuggestedWordInfos.Jean Chalard2012-06-271-4/+18
| | | | | | | | | | | | Change-Id: Ic4b0ae05cd98a1aec5806c5e4b744158e73aea7a