| Commit message (Expand) | Author | Age | Files | Lines |
|---|
| ... | |
| | * | | | Fix a bug where spaces would be forgotten•••Bug: 6785706
Change-Id: Ic7bf242ef058d116b986d47ad197b6d2802e2342
|   Jean Chalard | 2012-07-06 | 1 | -1/+2 |
| * | | | | Refinement (A64)•••Change-Id: I7c16e28ffce4fe0965b756bf2b00ee63b77dd039
| Jean Chalard | 2012-07-06 | 1 | -1/+1 |
| * | | | | Remove useless code (A63)•••If the separator is not a space, then we will always call
setPunctuationSuggestions and reset the suggestion strip anyway.
If the separator is a space, then the cursor has a space on
the left, which means isCursorTouchingWord depends only on
whether it touches a word on the right. If we were displaying
the "add to dictionary hint", it means a suggestion was just
chosen, so it had to be displayed, and that requires a composing
word and no non-separator at the right of the cursor.
In the end, if we go through this postUpdateSuggestions call,
we are sure we will reset the suggestions later in this method,
either by calling postUpdateBigramPredictions, or
setPunctuationSuggestions.
Change-Id: I95d5f77a5d0ac6d1a6ced8d67d6ac8f650db4a32
| Jean Chalard | 2012-07-06 | 1 | -5/+0 |
| | |/ /
|/| | |
|
| * | | | Simplification (A62)•••Change-Id: I606270a0387787445b7cd6b94e4830bfc144b49e
| Jean Chalard | 2012-07-06 | 1 | -9/+4 |
| |/ / |
|
| * | | Remove useless code (A61)•••Just after this, clear() will be called, removing the suggestion
strip from the screen. It will later be displayed again through
onStartInputView, which will update its content.
Change-Id: I15c23ad2adecab76b0791d7fc222d15b6533f3bd
| Jean Chalard | 2012-07-06 | 1 | -3/+0 |
| * | | Simplification (A60)•••Change-Id: I99e912d3edfc7dd3f17ee835331d5fcba976750c
| Jean Chalard | 2012-07-06 | 1 | -9/+3 |
| * | | Simplification & UI improvement (A59)•••The responsivity is better like this. This does not seem to
feel slow as the previous comment seemed to indicate.
Also remove a stale comment.
Change-Id: I4e7bf9fe28716e112db182e44b3fa88ee4526bb4
| Jean Chalard | 2012-07-06 | 1 | -6/+2 |
| * | | Show predictions in the right cases (A58)•••After reverting an auto-correct we always have a separator after
the previously inserted word, and the cursor is never touching
a word. Showing predictions is the right thing to do, while
calling postUpdateSuggestions will invariably yield an invariably
blank suggestion strip, which is not very helpful.
Likewise, after we pick a suggestion, we should be showing the
predictions unless showing the addToDictionary hint. There was
a bug here in the corner case that the word would be a candidate
for user dictionary, but the user dictionary provider is not
available: in this case we should be showing predictions, but
we were showing an unhelpful empty suggestion bar.
Change-Id: I287bb5eb4af762bd5a433e85e185fab6d203e91a
| Jean Chalard | 2012-07-06 | 1 | -2/+4 |
| * | | Cleanup (A57)•••We stopped cancelling manual picks a few weeks ago. This code
is dead.
Change-Id: I4032fcc3c95e9379f1839fe860a1b8a9bd7d0bc7
| Jean Chalard | 2012-07-06 | 2 | -18/+11 |
| * | | Merge "Fix a bug where the caps mode would not be changed" | Jean Chalard | 2012-07-05 | 2 | -8/+19 |
| |\ \ |
|
| | * | | Fix a bug where the caps mode would not be changed•••Bug: 6766059
Change-Id: I378f9d35c4904c4f373260bda5863235d833eb31
| Jean Chalard | 2012-07-06 | 2 | -8/+19 |
| * | | | Simplification (A56)•••If suggestion and prediction messages both happen to be in
the queue, the latest one will win (update the suggestion strip
later than the other, overwriting any previous suggestions).
So when we enqueue either one, it is always safe to cancel
all messages of both types.
Change-Id: Iad9dd06d08c49f60cac16b88edcc9531a18ec02e
| Jean Chalard | 2012-07-05 | 1 | -14/+7 |
| * | | | Remove an unused method (A55)•••Change-Id: I9974b88923b85cd6bec74f7607067c660f36f040
| Jean Chalard | 2012-07-05 | 2 | -30/+0 |
| * | | | Merge "Remove a useless method, rename another. (A54)" | Jean Chalard | 2012-07-05 | 2 | -7/+3 |
| |\ \ \ |
|
| | * | | | Remove a useless method, rename another. (A54)•••Change-Id: If36b5375b04f68deeb72bcece3cb8d37aed57f59
| Jean Chalard | 2012-07-05 | 2 | -7/+3 |
| * | | | | Merge "Initialize SubtypeLocale from Settings" |   Tadashi G. Takaoka | 2012-07-05 | 2 | -1/+11 |
| |\ \ \ \ |
|
| | * | | | | Initialize SubtypeLocale from Settings•••Bug: 6781106
Change-Id: I22f04af4fabf93346ab6f72c1841f096afaccb96
| Tadashi G. Takaoka | 2012-07-05 | 2 | -1/+11 |
| * | | | | | Merge "Remove a redundant test (A53)" | Jean Chalard | 2012-07-05 | 1 | -11/+4 |
| |\ \ \ \ \
| | |/ / /
| |/| | | |
|
| | * | | | | Remove a redundant test (A53)•••Change-Id: If711074fdcb586e35d02e421c845f2c9024ca718
| Jean Chalard | 2012-07-05 | 1 | -11/+4 |
| * | | | | | Merge "Small simplification (A52)" | Jean Chalard | 2012-07-05 | 1 | -8/+4 |
| |\| | | | |
|
| | * | | | | Small simplification (A52)•••Change-Id: I56bc5b9b584de5a14b41fc32c19f7fefb3b12e88
| Jean Chalard | 2012-07-05 | 1 | -8/+4 |
| * | | | | | Merge "Put some more code in common (A51)" | Jean Chalard | 2012-07-05 | 1 | -23/+18 |
| |\| | | | |
|
| | * | | | | Put some more code in common (A51)•••Change-Id: If1589e29728df20713c75e08df7f47f0de9202d4
| Jean Chalard | 2012-07-05 | 1 | -23/+18 |
| * | | | | | Merge "Pull up a common variable into the wrapping method (A50)" | Jean Chalard | 2012-07-05 | 1 | -8/+10 |
| |\| | | | |
|
| | * | | | | Pull up a common variable into the wrapping method (A50)•••Change-Id: I0b62098308169b5c44ced25ffb902766e3732fbf
| Jean Chalard | 2012-07-05 | 1 | -8/+10 |
| * | | | | | Merge "Factorize some common code (A49)" | Jean Chalard | 2012-07-05 | 1 | -30/+16 |
| |\| | | |
| |/ / /
|/| | | |
|
| | * | | | Factorize some common code (A49)•••Also add some comment to clarify what's happening inside those
methods
Change-Id: I5b9b1e105b3145f0b050f35d12c5b6ca6e4a4d8c
| Jean Chalard | 2012-07-05 | 1 | -30/+16 |
| * | | | | Merge "Fix tab key's navigation behavior" | Tadashi G. Takaoka | 2012-07-05 | 4 | -13/+4 |
| |\ \ \ \ |
|
| | * | | | | Fix tab key's navigation behavior•••Bug: 6435484
Change-Id: Iffe459c117ad438e96ec6f5c7e64fb80b32d227e
| Tadashi G. Takaoka | 2012-07-05 | 4 | -13/+4 |
| * | | | | | Merge "Fix upper case Eszett more key" | Tadashi G. Takaoka | 2012-07-05 | 1 | -3/+11 |
| |\ \ \ \ \
| |_|/ / /
|/| | | | |
|
| | * | | | | Fix upper case Eszett more key•••Bug: 6773873
Change-Id: I1a533c729c312a53663fb142cb6fcb4915b53206
| Tadashi G. Takaoka | 2012-07-05 | 1 | -3/+11 |
| | |/ / / |
|
| * | | | | Merge "Add a wrapper to updateSuggestions / Predictions (A48)" | Jean Chalard | 2012-07-04 | 1 | -7/+15 |
| |\ \ \ \
| |/ / /
|/| | | |
|
| | * | | | Add a wrapper to updateSuggestions / Predictions (A48)•••The goal is to have those converge, as they contain almost 100%
duplicated code.
Change-Id: I6921791d47efce9fb396efd9626839d706664a91
| Jean Chalard | 2012-07-05 | 1 | -7/+15 |
| * | | | | Merge "Fix Keyboard.getKey as thread safe" | Tadashi G. Takaoka | 2012-07-04 | 1 | -10/+12 |
| |\ \ \ \
| |/ / /
|/| | | |
|
| | * | | | Fix Keyboard.getKey as thread safe•••This is a follow up of Id962e670.
Change-Id: I9e8542bff9e8faf57f934051fe612463c99ad61f
| Tadashi G. Takaoka | 2012-07-05 | 1 | -10/+12 |
| | |/ / |
|
| * / / | Refactoring which will help with future changes (A47)•••Change-Id: Ibc2d28f9f95966f77d4d7bdf9ae4688baaed5989
| Jean Chalard | 2012-07-05 | 1 | -2/+5 |
| |/ / |
|
| * | | Search bigrams for the lower case version of the word (A46)•••...if there aren't any for the exact case version.
Bug: 6752830
Change-Id: I2737148b01ba04a64febe009ceb2ef53c265d224
| Jean Chalard | 2012-07-04 | 2 | -15/+5 |
| * | | Merge "Remove WordComposer.add(int, int, int, KeyDetector) method" | Tadashi G. Takaoka | 2012-07-04 | 5 | -24/+26 |
| |\ \ |
|
| | * | | Remove WordComposer.add(int, int, int, KeyDetector) method•••Change-Id: Ie6af46acba18a2d1cf3ddd1578d60ded4c90f89a
| Tadashi G. Takaoka | 2012-07-04 | 5 | -24/+26 |
| * | | | Merge "Use Keyboard.getKey" | Tadashi G. Takaoka | 2012-07-04 | 1 | -7/+6 |
| |\ \ \
| |/ /
|/| | |
|
| | * | | Use Keyboard.getKey•••Change-Id: I722b9e981389f660db928b7fd5ced1b82371fbf3
| Tadashi G. Takaoka | 2012-07-04 | 1 | -7/+6 |
| * | | | Merge "Get rid of redundant CharSequence member from SuggestedWordInfo" | Tadashi G. Takaoka | 2012-07-04 | 1 | -10/+8 |
| |\ \ \ |
|
| | * | | | Get rid of redundant CharSequence member from SuggestedWordInfo•••Change-Id: Ie8792f4f5d3593c25c992fc72cf219daeaa70beb
| Tadashi G. Takaoka | 2012-07-04 | 1 | -10/+8 |
| | |/ / |
|
| * | | | Consolidate a method inside another (A45)•••It's simpler to check the safety net directly inside the
function that checks for auto-correction threshold.
This introduces one very slight change in behavior. The value
checked by the safety net is not any more the "typed word" but the
"considered word", the difference being any possibly appended
single quotes.
E.g. the user types "this'''" : the typed word is "this'''" but
the considered word is "this".
This change in behavior can be considered a bugfix.
Change-Id: Ia7ab4bc933183dfbd41bb00328e4c0b5ab76bc63
| Jean Chalard | 2012-07-04 | 2 | -3/+3 |
| * | | | Move the safety net function to AutoCorrection (A44)•••Change-Id: Iec791d061f237f60992dd6048c4a37b46f4cb9aa
| Jean Chalard | 2012-07-04 | 3 | -40/+38 |
| * | | | Merge "Refactoring (A43)" | Jean Chalard | 2012-07-03 | 1 | -3/+3 |
| |\ \ \
| |/ /
|/| | |
|
| | * | | Refactoring (A43)•••Change-Id: Ib0b6f36999518096819ada2f19365767cb5f9931
| Jean Chalard | 2012-07-02 | 1 | -3/+3 |
| * | | | Merge "Remove useless code (A42)" | Jean Chalard | 2012-07-02 | 1 | -5/+0 |
| |\| | |
|
| | * | | Remove useless code (A42)•••If allowsAutoCorrected is false, there is no point in making
hasAutoCorrection true, since in the only place where we use
it again, it's &&'ed with allowsAutoCorrected !
Well that was extremely obscure, good thing refactoring allowed
to realize this was useless >.>
Change-Id: I34936d445f1ced17c7bd04a9524bf608f9e8b9c8
| Jean Chalard | 2012-07-02 | 1 | -5/+0 |
| * | | | Merge "Clarify some code and fix a bug (A41)" | Jean Chalard | 2012-07-02 | 1 | -10/+13 |
| |\| | |
|
