| Commit message (Expand) | Author | Age | Files | Lines |
|---|
| ... | |
| * | | | Merge "Cleanup KeyboardId's hasCode method" |   Tadashi G. Takaoka | 2011-12-14 | 1 | -30/+36 |
| |\ \ \ |
|
| | * | | | Cleanup KeyboardId's hasCode method•••Change-Id: I5fd8f6ac0f42152fb0e2aaaedc6092f6d82fe677
| Tadashi G. Takaoka | 2011-12-14 | 1 | -30/+36 |
| * | | | | Merge "Move some code inside a function to simplify flow" |   Jean Chalard | 2011-12-14 | 1 | -12/+8 |
| |\ \ \ \
| | |/ /
| |/| | |
|
| | * | | | Move some code inside a function to simplify flow•••Also rename the function to reflect better the behavior.
An upcoming change will clean up the remnants
Change-Id: I19bdf0d9e95f62ee749e1f64fe17132c4a5ef0bc
| Jean Chalard | 2011-12-14 | 1 | -12/+8 |
| * | | | | Merge "Fail faster in case of a bug" | Jean Chalard | 2011-12-14 | 1 | -4/+4 |
| |\| | | |
|
| | * | | | Fail faster in case of a bug•••Change-Id: Ibea64133f200dce80034c641d4798b62843a2512
| Jean Chalard | 2011-12-14 | 1 | -4/+4 |
| * | | | | Merge "Cleanup settings key related stuff" | Tadashi G. Takaoka | 2011-12-14 | 3 | -48/+40 |
| |\ \ \ \
| |/ / /
|/| / /
| |/ / |
|
| | * / | Cleanup settings key related stuff•••Change-Id: Ie0d1204e94fcdf9d578974256bf2ae3e87797f13
| Tadashi G. Takaoka | 2011-12-14 | 3 | -48/+40 |
| | |/ |
|
| * / | Refactoring.•••Small simplification of the code.
Change-Id: I1f67ae529bbb2c9316bf5e083d367c57040ea22c
| Jean Chalard | 2011-12-14 | 1 | -17/+15 |
| |/ |
|
| * | Merge "Record onStartInputView" | Tadashi G. Takaoka | 2011-12-13 | 2 | -4/+9 |
| |\ |
|
| | * | Record onStartInputView•••Bug: 5722703
Change-Id: I56bcf6ccde82b4176093de4f197a8736b0cc8c10
| Tadashi G. Takaoka | 2011-12-14 | 2 | -4/+9 |
| * | | Merge "Utilize KeyboardSet XML definitions" | Tadashi G. Takaoka | 2011-12-13 | 6 | -58/+193 |
| |\ \ |
|
| | * | | Utilize KeyboardSet XML definitions•••This change introduces KeyboardSet and SubKeyboard XML definitions to
represent a set of keyboard layouts.
Bug: 5002108
Bug: 5679585
Change-Id: Ib6c8d5936187381bb6725c9fe574e93871c01a86
| Tadashi G. Takaoka | 2011-12-14 | 6 | -58/+193 |
| * | | | Merge "Fix a long-standing race condition." | Jean Chalard | 2011-12-13 | 1 | -15/+15 |
| |\ \ \
| |_|/
|/| | |
|
| | * | | Fix a long-standing race condition.•••Upon autocorrection, there is visual feedback in the text
view that quickly flashes the background of the text that
just changed. This fixes a race condition that happens
upon autocorrection when typing fast, and that results in
flashing one character too far left (typically, the flashing
area includes the whitespace before the corrected word and
not the last character of the corrected word).
This happens because the call to commitCorrection may
happen before or after the IPC sent by sendKeyChar, but the
arguments are fit only for the case where it arrives first.
Change-Id: I9b5442a665aad5a9bc66cd49228075b9056b37fa
| Jean Chalard | 2011-12-14 | 1 | -15/+15 |
| * | | | Merge "Decouple member logic from control flow" | Jean Chalard | 2011-12-13 | 1 | -4/+8 |
| |\ \ \ |
|
| | * | | | Decouple member logic from control flow•••This place is very confusing because a member variable with
a consistent meaning is hijacked for the duration of a function
to mean something else. This is in the way of easy-to-understand
refactoring.
Change-Id: If79bc771950d6bfc0ad5f0e9c51c7ef1dbb45b66
| Jean Chalard | 2011-12-13 | 1 | -4/+8 |
| | |/ / |
|
| * / / | Various mini-cleanups•••- Stop the word composer from escaping - take a page from the law
of Demeter and only report what is actually needed.
- Fix typos in comments.
- Add a comment for a fishy processing.
- Remove a useless local variable.
Change-Id: I5fa78901cbb5483fc9683bfb7094f47244b85df6
| Jean Chalard | 2011-12-13 | 4 | -10/+11 |
| |/ / |
|
| * | | Merge "Remove the input connection sidework from handleCharacter" | Jean Chalard | 2011-12-13 | 1 | -6/+10 |
| |\ \ |
|
| | * | | Remove the input connection sidework from handleCharacter•••Change-Id: I3d376dfda3acd8864274390de3ff5752b18456e0
| Jean Chalard | 2011-12-13 | 1 | -6/+10 |
| * | | | Move mBestWord to the word composer.•••mBestWord has a confusing name - it's actually an auto-correction.
It's cleaner if it lives in the word composer because an
auto-correction should be tied to a specific user input, and
should be reset each time the user input changes to avoid
race conditions.
Change-Id: I718d29395bc747372067e6440e090c6a181994ae
| Jean Chalard | 2011-12-13 | 2 | -19/+55 |
| |/ / |
|
| * | | Merge "Tighten conditions for space-related cancelling" | Jean Chalard | 2011-12-13 | 1 | -4/+10 |
| |\ \ |
|
| | * | | Tighten conditions for space-related cancelling•••Instead of ignoring silently a found bug, throw an exception.
Change-Id: I0aa96d0cab022b6a5e7cffe8a592dcc443c3c7a8
| Jean Chalard | 2011-12-13 | 1 | -4/+10 |
| * | | | Merge "Consolidate underlining code under one function." | Jean Chalard | 2011-12-13 | 1 | -18/+17 |
| |\ \ \
| |_|/
|/| | |
|
| | * | | Consolidate underlining code under one function.•••Change-Id: I4393ff1ec28a6b3118d1344dd6d82d04899dea42
| Jean Chalard | 2011-12-13 | 1 | -18/+17 |
| | |/ |
|
| * | | Merge "Introduce KeyboardSet to hold related KeyboardIds" | Tadashi G. Takaoka | 2011-12-13 | 2 | -80/+144 |
| |\ \ |
|
| | * | | Introduce KeyboardSet to hold related KeyboardIds•••This change moves
* KeyboardSwitcher.getKeyboardId to KeyboardSet.<init> and
KeyboardSet.getKeyboardId.
* KeyboardSwitcher.getF2KeyMode to KeyboardSet.
This is the first step to get rid of shift state from Keyboard.
Bug: 5002108
Bug: 5679585
Change-Id: I2a5a97e5e89277bc606916d45c1afbc8d105d773
| Tadashi G. Takaoka | 2011-12-13 | 2 | -80/+144 |
| * | | | Merge "Extract the jni library name" |   satok | 2011-12-13 | 2 | -2/+28 |
| |\ \ \
| |/ /
|/| | |
|
| | * | | Extract the jni library name•••Change-Id: Icc58ccea1178d9f35f5be0dceebab67bbb965b7f
| satok | 2011-12-13 | 2 | -2/+28 |
| | |/ |
|
| * | | Merge "Remove KeyboardSwitcher.updateShiftLockState method" | Tadashi G. Takaoka | 2011-12-13 | 1 | -15/+7 |
| |\ \
| |/
|/| |
|
| | * | Remove KeyboardSwitcher.updateShiftLockState method•••Change-Id: I032fc50a62a573ba4258530e695c8c88467783c6
| Tadashi G. Takaoka | 2011-12-13 | 1 | -15/+7 |
| * | | Remove a useless return•••Change-Id: Iefe10e94e2d88171387351a5b6cab52e281d0f76
| Jean Chalard | 2011-12-13 | 1 | -3/+0 |
| * | | Merge "Simplification" | Jean Chalard | 2011-12-12 | 1 | -4/+2 |
| |\ \ |
|
| | * | | Simplification•••Both tests have the same meaning. They should be merged.
Also, if "deleteLast()" deletes more than one char (which
never happens in the current implementation, but it's not
guaranteed), the new code is more correct.
Change-Id: I216df7cd45f4a7d76d1d5d6aa7f8d7f9a6e35ea3
| Jean Chalard | 2011-12-13 | 1 | -4/+2 |
| * | | | Merge "Refactoring" | Jean Chalard | 2011-12-12 | 1 | -21/+18 |
| |\| | |
|
| | * | | Refactoring•••If mHasUncommittedTypedChars is true, then
mWordSavedForAutoCorrectCancellation must always be null, and
spaceState must always be SPACE_STATE_NONE.
Hence, this change is supposed to be very no-op.
Change-Id: I2716f7372d996cc4dec40a4b7ac1ee7f5f4afe91
| Jean Chalard | 2011-12-13 | 1 | -21/+18 |
| * | | | Merge changes I7888797c,I57b2232f•••* changes:
Refactor + small bugfix
Refactoring
| Jean Chalard | 2011-12-12 | 1 | -11/+8 |
| |\| |
| |/
|/| |
|
| | * | Refactor + small bugfix•••postUpdateShiftKeyState used to be called also when
mEnteredText is not null => this is a bugfix.
The rest does not change the logic, as posting a message can
be done anywhere within the function with no impact.
Change-Id: I7888797c0778702d64f96701e35b611a55a6a259
| Jean Chalard | 2011-12-13 | 1 | -4/+3 |
| | * | Refactoring•••Change-Id: I57b2232f7fde32df5f6e1925aad1df988def34f9
| Jean Chalard | 2011-12-13 | 1 | -7/+5 |
| * | | Remove current keyboard id variable•••Change-Id: Iec19af98209e1ea8ecd176d3be04d628d4b38950
| Tadashi G. Takaoka | 2011-12-13 | 1 | -5/+3 |
| |/ |
|
| * | Merge "Fix a bug where revert auto-correct would revert too much" | Jean Chalard | 2011-12-12 | 1 | -8/+24 |
| |\ |
|
| | * | Fix a bug where revert auto-correct would revert too much•••If there are no uncommitted chars, we shouldn't enter any of
the tests that follow. We didn't use to, but a change today
made it possible - it should not happen.
There is no point in doing the rest of the tests, they are
sure to fail.
Change-Id: I580dd104aff3585de72a93b38989bfd9713f615b
| Jean Chalard | 2011-12-12 | 1 | -8/+24 |
| * | | Remove a useless function call•••Change-Id: I1a775cbf90dca301e1e6b596ddac64fdbc023199
| Jean Chalard | 2011-12-12 | 1 | -1/+0 |
| |/ |
|
| * | Merge "Move a settings var to the settings class" | Jean Chalard | 2011-12-12 | 2 | -2/+3 |
| |\ |
|
| | * | Move a settings var to the settings class•••Change-Id: I1331ad6dec3a9d64a77e314f8a1f4c29282df31b
| Jean Chalard | 2011-12-12 | 2 | -2/+3 |
| * | | Remove a useless variable•••This can be just read when it's needed.
Change-Id: I00753fe55645c244db5d4a96e7fdb8f5325475d9
| Jean Chalard | 2011-12-12 | 1 | -3/+2 |
| * | | Remove a messy and unused class.•••Today is a happy day
Change-Id: I3ef484bd258d5a59815bfcb0bd35ea3606b32430
| Jean Chalard | 2011-12-12 | 2 | -225/+0 |
| |/ |
|
| * | Merge "Remove side-effects from TextEntryState" | Jean Chalard | 2011-12-12 | 3 | -12/+41 |
| |\ |
|
| | * | Remove side-effects from TextEntryState•••Change-Id: Ib98eea9e791e426435cfdfd0c9ab3ed9061664aa
| Jean Chalard | 2011-12-12 | 3 | -12/+41 |
| * | | Add special handling for "Phone number" layout.•••Bug: 5743584
Change-Id: I821b837a2078afb64b460191c98b28f7733cf2c1
| Tadashi G. Takaoka | 2011-12-12 | 1 | -0/+6 |
