| Commit message (Expand) | Author | Age | Files | Lines |
|---|
| ... | |
| | * | | Never pass negative values to setSelection.•••Bug: 13136079
Change-Id: Ieae6bafbd5339a033f0f342ba9af7dcc4ce209fa
|   Jean Chalard | 2014-02-24 | 1 | -2/+6 |
| | |/ |
|
| * | | Merge "Revert "Prepare for changing text color for functional keys"" |   Tadashi G. Takaoka | 2014-02-24 | 3 | -26/+7 |
| |\ \
| |/
|/| |
|
| | * | Revert "Prepare for changing text color for functional keys"•••This reverts commit 194e004e81f74c4124184ad8597d68e3837ea560.
Bug: 10786040
Change-Id: I4c5287d46cabe287abce5cba77635cf26d2cd192
| Tadashi G. Takaoka | 2014-02-24 | 3 | -26/+7 |
| * | | Disconnect app data search client after fetching all data.•••Bug: 13138201
Change-Id: Ibaa3c2c22a4fe44ea23e92ce8576141bbad09b12
|   Keisuke Kuroyanagi | 2014-02-24 | 2 | -0/+11 |
| |/ |
|
| * | Merge "Change a heuristic and add a log." | Jean Chalard | 2014-02-21 | 2 | -3/+5 |
| |\ |
|
| | * | Change a heuristic and add a log.•••The heuristic in RichInputConnection makes little sense
when textLength > mExpectedSelStart but we have
more than 1024 characters of text. If there are that many,
it's about 100% sure that 1024 is not the correct cursor
position. With no good guess, we'll just continue trusting
the app, even though we know it's lying : at least it will
make the problem visible to the app author.
Also, there have been a lot of confusion about initialSelStart
and initialSelEnd. The keyboard should log them so that
it helps us and editor authors debug more easily these
common problems.
Issue #65170 in AOSP and
Bug: 12772035
Change-Id: I6665a16c9f2832d33ee323f033bb38bcc092a3b4
| Jean Chalard | 2014-02-20 | 2 | -3/+5 |
| * | | Merge "Change make-keyboard-text -java option to point LatinIME/java directory" | Tadashi G. Takaoka | 2014-02-21 | 1 | -2/+3 |
| |\ \ |
|
| | * | | Change make-keyboard-text -java option to point LatinIME/java directory•••Change-Id: I812713da5918049c0e504e48bd0693df2f7bf46d
| Tadashi G. Takaoka | 2014-02-21 | 1 | -2/+3 |
| * | | | Merge "Fix: file descriptor leaking." | Keisuke Kuroyanagi | 2014-02-21 | 2 | -22/+32 |
| |\ \ \ |
|
| | * | | | Fix: file descriptor leaking.•••File descriptors will be closed in
BinaryDictionary.finalize(); but, this leads to unit test fails.
Bug: 13066902
Change-Id: I2b0d3e54ee91fa844530df54596f86bbbbac81a5
| Keisuke Kuroyanagi | 2014-02-21 | 2 | -22/+32 |
| | | |/
| |/| |
|
| * | | | Merge "Don't trim newer inputpointers with old data" | Jean Chalard | 2014-02-21 | 1 | -0/+2 |
| |\ \ \
| |_|/
|/| | |
|
| | * | | Don't trim newer inputpointers with old data•••We already have a mechanism to avoid this crash, but it wasn't
used every time it needed to. It's possible that ending a batch
input and starting a batch input happen while suggestions
are being pulled out, which would result in pointers that have
been reset being passed for trimming.
Just increasing the sequence number should get rid of the
problem.
Bug: 12178124
Change-Id: I36ef3bc8a78679bc09daa39e665f5ce1bab50c2a
| Jean Chalard | 2014-02-21 | 1 | -0/+2 |
| | |/ |
|
| * | | Merge "Remove corrupted ver4 dictionaries." | Keisuke Kuroyanagi | 2014-02-21 | 2 | -10/+38 |
| |\ \ |
|
| | * | | Remove corrupted ver4 dictionaries.•••Bug: 12916055
Change-Id: I2c390ab1dc483915691b47a605772cbc2dfeaf09
| Keisuke Kuroyanagi | 2014-02-21 | 2 | -10/+38 |
| * | | | Add ImportantNoticeDialog•••Change-Id: Icaeb7dddd16362cd4a6384d295f89c7fbabc8b35
| Tadashi G. Takaoka | 2014-02-21 | 2 | -45/+93 |
| * | | | Support versioned important notice•••This change must be checked in together with If38a754d00.
Bug: 10587358
Change-Id: I91580f9468bc5ee7ed1694d7852a60dc6793dac0
| Tadashi G. Takaoka | 2014-02-21 | 2 | -17/+30 |
| | |/
|/| |
|
| * | | Merge "Fix a bug where suggestions would not be updated." | Jean Chalard | 2014-02-20 | 1 | -14/+33 |
| |\ \ |
|
| | * | | Fix a bug where suggestions would not be updated.•••Also fix a small cosmetic bug where the suggestion strip
would flash.
Bug: 12951777
Change-Id: I68b7bb9175571de9c718f737eebd9f67ea04a931
| Jean Chalard | 2014-02-20 | 1 | -14/+33 |
| * | | | Merge "Don't distrust the cursor pos so much as to bug on IPC delay" | Jean Chalard | 2014-02-20 | 2 | -17/+6 |
| |\ \ \
| |_|/
|/| | |
|
| | * | | Don't distrust the cursor pos so much as to bug on IPC delay•••When the cursor is moved by the user, the RichInputConnection
is told about it. However, to work around a framework bug, it
also looks at how many characters are in the buffer before the
cursor, and if that's more than the value it's been passed, it
deduces that's a framework bug and there are at least as many
characters as seen before the cursor, so it puts the expected
cursor position there.
When you move the cursor, TextView calls onUpdateSelection,
and when you move it fast, you'll get rapid-fire calls to
onUpdateSelection. This is fine, the RIC is equipped to
deal with that.
However, these calls take some time to make it to the IME. In
this instance, when the first call gets through and the IME
calls TextView (synchronously) for text before the cursor, the
cursor has already moved in the app, and TextView returns more
characters than the cursor position was declared to be in this
instance, so the RIC sets that as the expected cursor position.
Sure enough, a split second later, the second call to
onUpdateSelection arrives, with the new cursor position set
where the RIC had found it too early. The RIC takes that as an
"expected" cursor move, and the input does not get reset.
Luckily, we have a way out. As far as we know, the framework bug
only manifests itself upon rotation, which means we should only
have to adjust for it in onStartInputView. Doing it in
onUpdateSelection is too zealous (and probably too distrustful of
the app to send the correct cursor positions).
So we should just take care of the rotation case (by calling
tryFixLyingCursorPosition in onStartInputView) and remove the
compensating code in resetCachesUponCursorMoves.
Bug: 12982502
Change-Id: Ic3c1408a1ec45deaea63b01d98376a79ae567d77
| Jean Chalard | 2014-02-20 | 2 | -17/+6 |
| | |/ |
|
| * | | Add test only methods to test personalized dicts.•••Bug: 11122480
Change-Id: I79a4a73ff09a2d34d4ca094d705e901fb4bc855c
| Keisuke Kuroyanagi | 2014-02-20 | 2 | -2/+28 |
| * | | Merge "Add final and volatile for members of InputLogic." | Keisuke Kuroyanagi | 2014-02-20 | 1 | -2/+3 |
| |\ \ |
|
| | * | | Add final and volatile for members of InputLogic.•••Bug: 13107471
Change-Id: I47df79bc6f015c212d1b6d2f63b2efc5da24294e
| Keisuke Kuroyanagi | 2014-02-20 | 1 | -2/+3 |
| * | | | Merge "Add user history dictionary decaying test." | Keisuke Kuroyanagi | 2014-02-20 | 1 | -2/+2 |
| |\ \ \ |
|
| | * | | | Add user history dictionary decaying test.•••Bug: 10667710
Change-Id: Ib2be57d8c4cbbb34f64555d84ea6fd571cfdd247
| Keisuke Kuroyanagi | 2014-02-20 | 1 | -2/+2 |
| * | | | | Merge "Check all enabled IME's subtypes to enable personalization." | Keisuke Kuroyanagi | 2014-02-20 | 2 | -6/+22 |
| |\ \ \ \ |
|
| | * | | | | Check all enabled IME's subtypes to enable personalization.•••Bug: 13067743
Change-Id: I6fc68b5151430a5ab51777f4c381e20f5a657924
| Keisuke Kuroyanagi | 2014-02-20 | 2 | -6/+22 |
| | |/ / / |
|
| * | | | | Merge "Throw IOException when dict header cannot be read." | Keisuke Kuroyanagi | 2014-02-20 | 1 | -0/+4 |
| |\ \ \ \
| |_|_|/
|/| | | |
|
| | * | | | Throw IOException when dict header cannot be read.•••Bug: 13106638
Change-Id: Ib48ef0a191a436552c49b6e817dfa13fe1567ae8
| Keisuke Kuroyanagi | 2014-02-20 | 1 | -0/+4 |
| | |/ / |
|
| * | | | Merge "Comments improvements" | Jean Chalard | 2014-02-20 | 1 | -2/+2 |
| |\ \ \ |
|
| | * | | | Comments improvements•••Typo fixes and clarifications
Change-Id: I0f7e0b6e665232bb995172fff10521c7f17599eb
| Jean Chalard | 2014-02-20 | 1 | -2/+2 |
| * | | | | Change important notice version preference file•••This CL also reset the notice version to 1.
This CL must be checked in together with Iea8d9ff038.
Change-Id: I838f7b5b295388d64d6aba90f50b06654eba16e5
| Tadashi G. Takaoka | 2014-02-20 | 4 | -46/+36 |
| * | | | | Fix build due to Ib4c472756f•••Change-Id: I27aad91d3f821b5c0d6a3c6405b4a9d03c5bd814
| Tadashi G. Takaoka | 2014-02-20 | 1 | -1/+1 |
| * | | | | Merge "Remove a call to a deprecated method" | Jean Chalard | 2014-02-20 | 4 | -7/+5 |
| |\ \ \ \ |
|
| | * | | | | Remove a call to a deprecated method•••...that would cause a crash
Bug: 13082186
Change-Id: Ie12575c27dfdd2029bc9d5f0647e444f69770afc
| Jean Chalard | 2014-02-20 | 4 | -7/+5 |
| | |/ / / |
|
| * | | | | Merge "Revert "Turn off personalization default settings"" | Tadashi G. Takaoka | 2014-02-20 | 2 | -2/+2 |
| |\ \ \ \
| |_|/ /
|/| | | |
|
| | * | | | Revert "Turn off personalization default settings"•••This reverts commit 0a4ac795d6fdd117b590902d7f5901f0db12d25c.
Bug: 10587358
Change-Id: Ib4c472756fb9a6ebba4a66d34a9652f1b5afc714
| Tadashi G. Takaoka | 2014-02-20 | 2 | -2/+2 |
| * | | | | Call PersonalizationDictionarySessionRegistrar.init().•••Wrongly removed in I1f50cb137b6054dc9.
Bug: 13067743
Change-Id: I27cd221cb7f6e403c3fc128d65d14dbf628b6f55
| Keisuke Kuroyanagi | 2014-02-19 | 1 | -0/+4 |
| * | | | | Remove personalization dicts for multilingual users.•••Bug: 13067743
Change-Id: I1f50cb137b6054dc9442237586b70fc0aa2bf427
| Keisuke Kuroyanagi | 2014-02-19 | 3 | -13/+26 |
| * | | | | Use AlertDialog.setOnDismissListener•••AlertDialog.Builder.setOnDismissListener is supported from API 17.
Bug: 10587358
Change-Id: Ie8ce8e283b803f7f6bb58ced446e676339f980eb
| Tadashi G. Takaoka | 2014-02-19 | 1 | -2/+2 |
| * | | | | Merge "Turn personalization on when important notice dialog is displayed" | Tadashi G. Takaoka | 2014-02-19 | 5 | -23/+77 |
| |\ \ \ \
| |_|/ /
|/| | | |
|
| | * | | | Turn personalization on when important notice dialog is displayed•••This change must be checked in together with Ifde70b1d3b.
Bug: 10587358
Change-Id: I9dc48f9d521e0e6f6269e4f184389ba805f3053f
| Tadashi G. Takaoka | 2014-02-19 | 5 | -23/+77 |
| | |/ / |
|
| * | | | Merge "Fix IllegalStateException raied by monkey" | Tadashi G. Takaoka | 2014-02-19 | 4 | -33/+36 |
| |\ \ \ |
|
| | * | | | Fix IllegalStateException raied by monkey•••Bug: 13082467
Change-Id: I9290974821d22067e7ddd60dce441b11ca533a0f
| Tadashi G. Takaoka | 2014-02-19 | 4 | -33/+36 |
| * | | | | Merge "Throw exception when the header cannot be read." | Keisuke Kuroyanagi | 2014-02-19 | 1 | -0/+3 |
| |\ \ \ \
| | |_|/
| |/| | |
|
| | * | | | Throw exception when the header cannot be read.•••Bug: 13066902
Change-Id: I8fd0f361a4ca55aaab8a2bd2e11f48f92b87fc93
| Keisuke Kuroyanagi | 2014-02-19 | 1 | -0/+3 |
| * | | | | Merge "Turn off personalization default settings" | Tadashi G. Takaoka | 2014-02-19 | 2 | -2/+2 |
| |\ \ \ \
| |/ / /
|/| | /
| | |/
| |/| |
|
| | * | | Turn off personalization default settings•••Because the previous personalization settings default value was on,
this CL changes the preference key of the personalization settings.
Bug: 10587358
Change-Id: I80233e8af4b532d8c67d8fb184c2865862bb35dd
| Tadashi G. Takaoka | 2014-02-19 | 2 | -2/+2 |
| | |/ |
|
| * / | Fix: Use old suggest after reloading.•••Change-Id: Icb2821f61c4203254b7d573cad5ce71fbf0ed841
| Keisuke Kuroyanagi | 2014-02-19 | 1 | -1/+3 |
| |/ |
|
| * | Merge "Straighten out database cursors behavior." | Jean Chalard | 2014-02-18 | 8 | -136/+178 |
| |\ |
|
