aboutsummaryrefslogtreecommitdiffstats
path: root/java/src (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Fix a bug with auto-caps entries from personalizationJean Chalard2014-02-271-3/+6
| | | | | Bug: 13215163 Change-Id: I00099cb4927c96de46e57e14ab906d41c9c2151a
* Merge "Add keyboard layout set tests"Tadashi G. Takaoka2014-02-271-1/+1
|\
| * Add keyboard layout set testsTadashi G. Takaoka2014-02-261-1/+1
| | | | | | | | | | | | | | | | This CL is a ground work to add keyboard layout labels and more keys tests. Bug: 13017434 Change-Id: Ief028e8ab563d79bc0b0f9c06f1fe1d645a6469d
* | Merge "Set additional attributes in dictionary facilitator."Keisuke Kuroyanagi2014-02-261-1/+11
|\ \
| * | Set additional attributes in dictionary facilitator.Keisuke Kuroyanagi2014-02-261-1/+11
| | | | | | | | | | | | | | | Bug: 13197276 Change-Id: I206cf4e599ca9cdf40d669358a1067a2954d11e3
* | | Merge "Add a method to create dict with additional attributes."Keisuke Kuroyanagi2014-02-261-1/+12
|\| |
| * | Add a method to create dict with additional attributes.Keisuke Kuroyanagi2014-02-261-1/+12
| | | | | | | | | | | | | | | Bug: 13197276 Change-Id: I80311a51d9e98bfeb8c0dd9cd4adde93af366d54
* | | Merge "Use NOT_A_PROBABILITY for adding OOV words."Keisuke Kuroyanagi2014-02-261-3/+3
|\ \ \
| * | | Use NOT_A_PROBABILITY for adding OOV words.Keisuke Kuroyanagi2014-02-261-3/+3
| | |/ | |/| | | | | | | | | | Bug: 13197276 Change-Id: I23f453c2c1deea70eab552f8d433fe264adf68b3
* | | Merge "[IL110] Remove an unused interface function"Jean Chalard2014-02-262-4/+1
|\ \ \
| * | | [IL110] Remove an unused interface functionJean Chalard2014-02-262-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | ...and make a method private. Bug: 8636060 Change-Id: If16f7e8ef3779f77a9db23fb7c54e7c23b043b86
* | | | Merge "Read and write forgetting curve header attributes."Keisuke Kuroyanagi2014-02-261-0/+4
|\ \ \ \ | |/ / / |/| | / | | |/ | |/|
| * | Read and write forgetting curve header attributes.Keisuke Kuroyanagi2014-02-261-0/+4
| |/ | | | | | | | | Bug: 13197276 Change-Id: I6c38a127e1745903594b7bf0ec80ef179e794feb
* / Remove useless args and processing.Jean Chalard2014-02-262-24/+10
|/ | | | | Bug: 13062385 Change-Id: I426545d1fe8fd76bcf4d1dce19e6b571a55c79ae
* [QRP6] Fix: recorrection top candidate is displayed in boldJean Chalard2014-02-251-2/+4
| | | | | Bug: 10385162 Change-Id: Icf9471d474a3a8ed8f38c46c7948c66f9131691e
* [QRP5] Fix boldness for predictions, and small refactoringJean Chalard2014-02-253-5/+6
| | | | | | | | | This is more correct. When predictions, the typed word should always be null unless explicitly passed. The text color should be that of a valid typed word only if it's actually the typed word. Bug: 13170509 Change-Id: I769ae100e112c37c6f02064fe9ef2f81372ca9e5
* [QRP4] Simplification & small correctness fix.Jean Chalard2014-02-251-6/+6
| | | | | | | | | This fixes the color of the predictions when running on a theme that has different colors for typed and suggested words (GB theme). Also, this is easier to understand and to modify from now on. Change-Id: Ifdc6d86a1695e83e16103041b06a2451f8d52cc4
* [QRP3] RefactoringJean Chalard2014-02-251-13/+15
| | | | | | | Rename some variables for clarity and use constants instead of immediates. Change-Id: Ie07fbfcc3738ac4e67aefddc339fc54259172c39
* [QRP2] Small refactorJean Chalard2014-02-251-3/+4
| | | | | Bug: 13170509 Change-Id: Ib9f10b8a137fc773ab0e5dc903e577038e29a9e2
* [QRP1] Fix a bug where the wrong value would get passedJean Chalard2014-02-251-3/+3
| | | | | | | | | | In the practice it works because this never tries to access inside the suggestion strip, and the worst that can happen is a wrong text color for a suggestion. But since the two colors that would be swapped are the same, nobody ever notices -- unless they are using the GingerBread theme. Change-Id: Ic8c70d8b3cdddf92946dfefbbc6d061572626c7a
* Add Key.getIconId for testabilityTadashi G. Takaoka2014-02-252-3/+7
| | | | | Bug: 13017434 Change-Id: I94ff45da3f58b74cc9dd4d38179670fbcf619d92
* Merge "Correctly read the header of APK-embedded dicts"Jean Chalard2014-02-245-17/+28
|\
| * Correctly read the header of APK-embedded dictsJean Chalard2014-02-245-17/+28
| | | | | | | | | | Bug: 13164518 Change-Id: I8768ad887af8b89ad9f29637f606c3c68629c7ca
* | Merge "Use an executor to serialize opening dictionaries."Jean Chalard2014-02-241-3/+3
|\ \
| * | Use an executor to serialize opening dictionaries.Jean Chalard2014-02-241-3/+3
| | | | | | | | | | | | | | | Bug: 13082957 Change-Id: I25570ab4da94337ed60330c0869fe47657096626
* | | Merge "Create a utils class for executors."Tadashi G. Takaoka2014-02-242-49/+75
|\| |
| * | Create a utils class for executors.Jean Chalard2014-02-242-49/+75
| |/ | | | | | | | | | | | | Preliminary refactoring to fix Bug: 13082957 Change-Id: I9f1283c37089bc96140b774b1c559d58031de004
* | Merge "Remove hack from EmojiPalettesView.startEmojiPalettes"Tadashi G. Takaoka2014-02-245-21/+33
|\ \
| * | Remove hack from EmojiPalettesView.startEmojiPalettesTadashi G. Takaoka2014-02-245-21/+33
| |/ | | | | | | | | Bug: 12115967 Change-Id: I91c567a9577012ec28c08430c55e56e9c2e25b5f
* | Merge "Never pass negative values to setSelection."Jean Chalard2014-02-241-2/+6
|\ \ | |/ |/|
| * Never pass negative values to setSelection.Jean Chalard2014-02-241-2/+6
| | | | | | | | | | Bug: 13136079 Change-Id: Ieae6bafbd5339a033f0f342ba9af7dcc4ce209fa
* | Merge "Revert "Prepare for changing text color for functional keys""Tadashi G. Takaoka2014-02-243-26/+7
|\ \ | |/ |/|
| * Revert "Prepare for changing text color for functional keys"Tadashi G. Takaoka2014-02-243-26/+7
| | | | | | | | | | | | | | This reverts commit 194e004e81f74c4124184ad8597d68e3837ea560. Bug: 10786040 Change-Id: I4c5287d46cabe287abce5cba77635cf26d2cd192
* | Disconnect app data search client after fetching all data.Keisuke Kuroyanagi2014-02-242-0/+11
|/ | | | | Bug: 13138201 Change-Id: Ibaa3c2c22a4fe44ea23e92ce8576141bbad09b12
* Merge "Change a heuristic and add a log."Jean Chalard2014-02-212-3/+5
|\
| * Change a heuristic and add a log.Jean Chalard2014-02-202-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The heuristic in RichInputConnection makes little sense when textLength > mExpectedSelStart but we have more than 1024 characters of text. If there are that many, it's about 100% sure that 1024 is not the correct cursor position. With no good guess, we'll just continue trusting the app, even though we know it's lying : at least it will make the problem visible to the app author. Also, there have been a lot of confusion about initialSelStart and initialSelEnd. The keyboard should log them so that it helps us and editor authors debug more easily these common problems. Issue #65170 in AOSP and Bug: 12772035 Change-Id: I6665a16c9f2832d33ee323f033bb38bcc092a3b4
* | Merge "Change make-keyboard-text -java option to point LatinIME/java directory"Tadashi G. Takaoka2014-02-211-2/+3
|\ \
| * | Change make-keyboard-text -java option to point LatinIME/java directoryTadashi G. Takaoka2014-02-211-2/+3
| | | | | | | | | | | | Change-Id: I812713da5918049c0e504e48bd0693df2f7bf46d
* | | Merge "Fix: file descriptor leaking."Keisuke Kuroyanagi2014-02-212-22/+32
|\ \ \
| * | | Fix: file descriptor leaking.Keisuke Kuroyanagi2014-02-212-22/+32
| | |/ | |/| | | | | | | | | | | | | | | | | | | File descriptors will be closed in BinaryDictionary.finalize(); but, this leads to unit test fails. Bug: 13066902 Change-Id: I2b0d3e54ee91fa844530df54596f86bbbbac81a5
* | | Merge "Don't trim newer inputpointers with old data"Jean Chalard2014-02-211-0/+2
|\ \ \ | |_|/ |/| |
| * | Don't trim newer inputpointers with old dataJean Chalard2014-02-211-0/+2
| |/ | | | | | | | | | | | | | | | | | | | | | | | | We already have a mechanism to avoid this crash, but it wasn't used every time it needed to. It's possible that ending a batch input and starting a batch input happen while suggestions are being pulled out, which would result in pointers that have been reset being passed for trimming. Just increasing the sequence number should get rid of the problem. Bug: 12178124 Change-Id: I36ef3bc8a78679bc09daa39e665f5ce1bab50c2a
* | Merge "Remove corrupted ver4 dictionaries."Keisuke Kuroyanagi2014-02-212-10/+38
|\ \
| * | Remove corrupted ver4 dictionaries.Keisuke Kuroyanagi2014-02-212-10/+38
| | | | | | | | | | | | | | | Bug: 12916055 Change-Id: I2c390ab1dc483915691b47a605772cbc2dfeaf09
* | | Add ImportantNoticeDialogTadashi G. Takaoka2014-02-212-45/+93
| | | | | | | | | | | | Change-Id: Icaeb7dddd16362cd4a6384d295f89c7fbabc8b35
* | | Support versioned important noticeTadashi G. Takaoka2014-02-212-17/+30
| |/ |/| | | | | | | | | | | This change must be checked in together with If38a754d00. Bug: 10587358 Change-Id: I91580f9468bc5ee7ed1694d7852a60dc6793dac0
* | Merge "Fix a bug where suggestions would not be updated."Jean Chalard2014-02-201-14/+33
|\ \
| * | Fix a bug where suggestions would not be updated.Jean Chalard2014-02-201-14/+33
| | | | | | | | | | | | | | | | | | | | | | | | Also fix a small cosmetic bug where the suggestion strip would flash. Bug: 12951777 Change-Id: I68b7bb9175571de9c718f737eebd9f67ea04a931
* | | Merge "Don't distrust the cursor pos so much as to bug on IPC delay"Jean Chalard2014-02-202-17/+6
|\ \ \ | |_|/ |/| |
| * | Don't distrust the cursor pos so much as to bug on IPC delayJean Chalard2014-02-202-17/+6
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the cursor is moved by the user, the RichInputConnection is told about it. However, to work around a framework bug, it also looks at how many characters are in the buffer before the cursor, and if that's more than the value it's been passed, it deduces that's a framework bug and there are at least as many characters as seen before the cursor, so it puts the expected cursor position there. When you move the cursor, TextView calls onUpdateSelection, and when you move it fast, you'll get rapid-fire calls to onUpdateSelection. This is fine, the RIC is equipped to deal with that. However, these calls take some time to make it to the IME. In this instance, when the first call gets through and the IME calls TextView (synchronously) for text before the cursor, the cursor has already moved in the app, and TextView returns more characters than the cursor position was declared to be in this instance, so the RIC sets that as the expected cursor position. Sure enough, a split second later, the second call to onUpdateSelection arrives, with the new cursor position set where the RIC had found it too early. The RIC takes that as an "expected" cursor move, and the input does not get reset. Luckily, we have a way out. As far as we know, the framework bug only manifests itself upon rotation, which means we should only have to adjust for it in onStartInputView. Doing it in onUpdateSelection is too zealous (and probably too distrustful of the app to send the correct cursor positions). So we should just take care of the rotation case (by calling tryFixLyingCursorPosition in onStartInputView) and remove the compensating code in resetCachesUponCursorMoves. Bug: 12982502 Change-Id: Ic3c1408a1ec45deaea63b01d98376a79ae567d77