aboutsummaryrefslogtreecommitdiffstats
path: root/java/src (follow)
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Merge "Fix: file descriptor leaking."Keisuke Kuroyanagi2014-02-212-22/+32
|\ \ \
| * | | Fix: file descriptor leaking.Keisuke Kuroyanagi2014-02-212-22/+32
| | |/ | |/| | | | | | | | | | | | | | | | | | | File descriptors will be closed in BinaryDictionary.finalize(); but, this leads to unit test fails. Bug: 13066902 Change-Id: I2b0d3e54ee91fa844530df54596f86bbbbac81a5
* | | Merge "Don't trim newer inputpointers with old data"Jean Chalard2014-02-211-0/+2
|\ \ \ | |_|/ |/| |
| * | Don't trim newer inputpointers with old dataJean Chalard2014-02-211-0/+2
| |/ | | | | | | | | | | | | | | | | | | | | | | | | We already have a mechanism to avoid this crash, but it wasn't used every time it needed to. It's possible that ending a batch input and starting a batch input happen while suggestions are being pulled out, which would result in pointers that have been reset being passed for trimming. Just increasing the sequence number should get rid of the problem. Bug: 12178124 Change-Id: I36ef3bc8a78679bc09daa39e665f5ce1bab50c2a
* | Merge "Remove corrupted ver4 dictionaries."Keisuke Kuroyanagi2014-02-212-10/+38
|\ \
| * | Remove corrupted ver4 dictionaries.Keisuke Kuroyanagi2014-02-212-10/+38
| | | | | | | | | | | | | | | Bug: 12916055 Change-Id: I2c390ab1dc483915691b47a605772cbc2dfeaf09
* | | Add ImportantNoticeDialogTadashi G. Takaoka2014-02-212-45/+93
| | | | | | | | | | | | Change-Id: Icaeb7dddd16362cd4a6384d295f89c7fbabc8b35
* | | Support versioned important noticeTadashi G. Takaoka2014-02-212-17/+30
| |/ |/| | | | | | | | | | | This change must be checked in together with If38a754d00. Bug: 10587358 Change-Id: I91580f9468bc5ee7ed1694d7852a60dc6793dac0
* | Merge "Fix a bug where suggestions would not be updated."Jean Chalard2014-02-201-14/+33
|\ \
| * | Fix a bug where suggestions would not be updated.Jean Chalard2014-02-201-14/+33
| | | | | | | | | | | | | | | | | | | | | | | | Also fix a small cosmetic bug where the suggestion strip would flash. Bug: 12951777 Change-Id: I68b7bb9175571de9c718f737eebd9f67ea04a931
* | | Merge "Don't distrust the cursor pos so much as to bug on IPC delay"Jean Chalard2014-02-202-17/+6
|\ \ \ | |_|/ |/| |
| * | Don't distrust the cursor pos so much as to bug on IPC delayJean Chalard2014-02-202-17/+6
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the cursor is moved by the user, the RichInputConnection is told about it. However, to work around a framework bug, it also looks at how many characters are in the buffer before the cursor, and if that's more than the value it's been passed, it deduces that's a framework bug and there are at least as many characters as seen before the cursor, so it puts the expected cursor position there. When you move the cursor, TextView calls onUpdateSelection, and when you move it fast, you'll get rapid-fire calls to onUpdateSelection. This is fine, the RIC is equipped to deal with that. However, these calls take some time to make it to the IME. In this instance, when the first call gets through and the IME calls TextView (synchronously) for text before the cursor, the cursor has already moved in the app, and TextView returns more characters than the cursor position was declared to be in this instance, so the RIC sets that as the expected cursor position. Sure enough, a split second later, the second call to onUpdateSelection arrives, with the new cursor position set where the RIC had found it too early. The RIC takes that as an "expected" cursor move, and the input does not get reset. Luckily, we have a way out. As far as we know, the framework bug only manifests itself upon rotation, which means we should only have to adjust for it in onStartInputView. Doing it in onUpdateSelection is too zealous (and probably too distrustful of the app to send the correct cursor positions). So we should just take care of the rotation case (by calling tryFixLyingCursorPosition in onStartInputView) and remove the compensating code in resetCachesUponCursorMoves. Bug: 12982502 Change-Id: Ic3c1408a1ec45deaea63b01d98376a79ae567d77
* | Add test only methods to test personalized dicts.Keisuke Kuroyanagi2014-02-202-2/+28
| | | | | | | | | | Bug: 11122480 Change-Id: I79a4a73ff09a2d34d4ca094d705e901fb4bc855c
* | Merge "Add final and volatile for members of InputLogic."Keisuke Kuroyanagi2014-02-201-2/+3
|\ \
| * | Add final and volatile for members of InputLogic.Keisuke Kuroyanagi2014-02-201-2/+3
| | | | | | | | | | | | | | | Bug: 13107471 Change-Id: I47df79bc6f015c212d1b6d2f63b2efc5da24294e
* | | Merge "Add user history dictionary decaying test."Keisuke Kuroyanagi2014-02-201-2/+2
|\ \ \
| * | | Add user history dictionary decaying test.Keisuke Kuroyanagi2014-02-201-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Bug: 10667710 Change-Id: Ib2be57d8c4cbbb34f64555d84ea6fd571cfdd247
* | | | Merge "Check all enabled IME's subtypes to enable personalization."Keisuke Kuroyanagi2014-02-202-6/+22
|\ \ \ \
| * | | | Check all enabled IME's subtypes to enable personalization.Keisuke Kuroyanagi2014-02-202-6/+22
| |/ / / | | | | | | | | | | | | | | | | | | | | Bug: 13067743 Change-Id: I6fc68b5151430a5ab51777f4c381e20f5a657924
* | | | Merge "Throw IOException when dict header cannot be read."Keisuke Kuroyanagi2014-02-201-0/+4
|\ \ \ \ | |_|_|/ |/| | |
| * | | Throw IOException when dict header cannot be read.Keisuke Kuroyanagi2014-02-201-0/+4
| |/ / | | | | | | | | | | | | Bug: 13106638 Change-Id: Ib48ef0a191a436552c49b6e817dfa13fe1567ae8
* | | Merge "Comments improvements"Jean Chalard2014-02-201-2/+2
|\ \ \
| * | | Comments improvementsJean Chalard2014-02-201-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Typo fixes and clarifications Change-Id: I0f7e0b6e665232bb995172fff10521c7f17599eb
* | | | Change important notice version preference fileTadashi G. Takaoka2014-02-204-46/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL also reset the notice version to 1. This CL must be checked in together with Iea8d9ff038. Change-Id: I838f7b5b295388d64d6aba90f50b06654eba16e5
* | | | Fix build due to Ib4c472756fTadashi G. Takaoka2014-02-201-1/+1
| | | | | | | | | | | | | | | | Change-Id: I27aad91d3f821b5c0d6a3c6405b4a9d03c5bd814
* | | | Merge "Remove a call to a deprecated method"Jean Chalard2014-02-204-7/+5
|\ \ \ \
| * | | | Remove a call to a deprecated methodJean Chalard2014-02-204-7/+5
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | ...that would cause a crash Bug: 13082186 Change-Id: Ie12575c27dfdd2029bc9d5f0647e444f69770afc
* | | | Merge "Revert "Turn off personalization default settings""Tadashi G. Takaoka2014-02-202-2/+2
|\ \ \ \ | |_|/ / |/| | |
| * | | Revert "Turn off personalization default settings"Tadashi G. Takaoka2014-02-202-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0a4ac795d6fdd117b590902d7f5901f0db12d25c. Bug: 10587358 Change-Id: Ib4c472756fb9a6ebba4a66d34a9652f1b5afc714
* | | | Call PersonalizationDictionarySessionRegistrar.init().Keisuke Kuroyanagi2014-02-191-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Wrongly removed in I1f50cb137b6054dc9. Bug: 13067743 Change-Id: I27cd221cb7f6e403c3fc128d65d14dbf628b6f55
* | | | Remove personalization dicts for multilingual users.Keisuke Kuroyanagi2014-02-193-13/+26
| | | | | | | | | | | | | | | | | | | | Bug: 13067743 Change-Id: I1f50cb137b6054dc9442237586b70fc0aa2bf427
* | | | Use AlertDialog.setOnDismissListenerTadashi G. Takaoka2014-02-191-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | AlertDialog.Builder.setOnDismissListener is supported from API 17. Bug: 10587358 Change-Id: Ie8ce8e283b803f7f6bb58ced446e676339f980eb
* | | | Merge "Turn personalization on when important notice dialog is displayed"Tadashi G. Takaoka2014-02-195-23/+77
|\ \ \ \ | |_|/ / |/| | |
| * | | Turn personalization on when important notice dialog is displayedTadashi G. Takaoka2014-02-195-23/+77
| |/ / | | | | | | | | | | | | | | | | | | This change must be checked in together with Ifde70b1d3b. Bug: 10587358 Change-Id: I9dc48f9d521e0e6f6269e4f184389ba805f3053f
* | | Merge "Fix IllegalStateException raied by monkey"Tadashi G. Takaoka2014-02-194-33/+36
|\ \ \
| * | | Fix IllegalStateException raied by monkeyTadashi G. Takaoka2014-02-194-33/+36
| | | | | | | | | | | | | | | | | | | | Bug: 13082467 Change-Id: I9290974821d22067e7ddd60dce441b11ca533a0f
* | | | Merge "Throw exception when the header cannot be read."Keisuke Kuroyanagi2014-02-191-0/+3
|\ \ \ \ | | |_|/ | |/| |
| * | | Throw exception when the header cannot be read.Keisuke Kuroyanagi2014-02-191-0/+3
| | | | | | | | | | | | | | | | | | | | Bug: 13066902 Change-Id: I8fd0f361a4ca55aaab8a2bd2e11f48f92b87fc93
* | | | Merge "Turn off personalization default settings"Tadashi G. Takaoka2014-02-192-2/+2
|\ \ \ \ | |/ / / |/| | / | | |/ | |/|
| * | Turn off personalization default settingsTadashi G. Takaoka2014-02-192-2/+2
| |/ | | | | | | | | | | | | | | Because the previous personalization settings default value was on, this CL changes the preference key of the personalization settings. Bug: 10587358 Change-Id: I80233e8af4b532d8c67d8fb184c2865862bb35dd
* / Fix: Use old suggest after reloading.Keisuke Kuroyanagi2014-02-191-1/+3
|/ | | | Change-Id: Icb2821f61c4203254b7d573cad5ce71fbf0ed841
* Merge "Straighten out database cursors behavior."Jean Chalard2014-02-188-136/+178
|\
| * Straighten out database cursors behavior.Jean Chalard2014-02-188-136/+178
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some were never closed, other closed twice. This change makes all Cursor instances behave, having the #close() call in a finally{} clause, and puts the burden of closing the cursor squarely on the creator rather than in the called methods. There is however one exception that is beyond the scope of this change: UserDictionarySettings have a Cursor member, it's never closed, and fixing the problem is not obvious. This change adds a TODO for now. It's not very clear if this change actually helps with bug#12670151, but it may be related and it's a good think to do anyway. Bug: 12670151 Change-Id: I87cc44387e7dee3da1488671b93a28d9d73f7dc0
* | Merge "Fix a bug where the cache would be out of sync"Jean Chalard2014-02-181-1/+17
|\ \
| * | Fix a bug where the cache would be out of syncJean Chalard2014-02-181-1/+17
| |/ | | | | | | | | | | | | | | | | | | | | | | | | During recorrection, the cursor position when calling commitText is not necessarily at the end of the composing text. Besides, RichInputConnection assumes the cursor is always after any composing text. This is not correct, but in the practice, it seems all code paths work. We should fix this in the future. Bug: 13060691 Change-Id: I15f71fff62d36e80cf6e4a022c5e78af634b199d
* | Merge "Cleanup."Jean Chalard2014-02-182-18/+3
|\ \
| * | Cleanup.Jean Chalard2014-02-182-18/+3
| |/ | | | | | | | | | | | | Less code, less chance of stuff escaping, and a bit of a clarification. Yay. Change-Id: I3193fd8ad7ac28195260cbc231c4e498a63a460c
* | Merge "Some cosmetic fixes in LatinIME.java"Ken Wakasa2014-02-181-40/+38
|\ \ | |/ |/|
| * Some cosmetic fixes in LatinIME.javaKen Wakasa2014-02-181-40/+38
| | | | | | | | Change-Id: Ia2d04ab992f5a0cc736150b2691b2f8ae8f0955d
* | Avoid crashing when the Content URL is not found.Jean Chalard2014-02-181-0/+10
|/ | | | | | | | | I'm not sure when this can happen, but it seems it does at least on older versions of the platform. Let's avoid crashing. Bug: 11618402 Change-Id: If730b5bd8f20e0f60b884eab5900099116afc5f0
generated by cgit v1.2.3-83-g751a (git 2.47.1) at 2025-05-07 09:00:26 +0000