aboutsummaryrefslogtreecommitdiffstats
path: root/java/src (follow)
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Tiny refactoring (A73)Jean Chalard2012-07-091-3/+1
| | | | | | | | | | | | | | | | | | | | | If !mWordComposer.isComposingWord(), then mWordComposer.getTypedWord() will always return an empty string. Change-Id: Ife66d0abc44c743cbc30d31724e833cda168fd5c
* | | Cleanup again (A72)Jean Chalard2012-07-091-5/+3
| | | | | | | | | | | | Change-Id: Id3765bf9826cc2c7ca70158cda53c75dc58f51c6
* | | Simplification (A71)Jean Chalard2012-07-091-6/+6
| | | | | | | | | | | | Change-Id: I7a91d84291bea581ecc8ec5b29b9a87ccec76e7d
* | | Defer testing composition to a later time (A70)Jean Chalard2012-07-091-17/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is not exactly the same logically speaking, because it's theoretically possible that the composing state changed in between the message enqueueing and it's retrieval. However in the practice, if the composing state changed the message *must* have been cancelled and resent, else the behavior breaks. So this actually is more robust, and removes some obscure requirements on the calling code. In the practice, it should also make the cancelUpdateSuggestionStrip message useless, although this change does not yet remove it. Change-Id: I75141920ce64e38e2f92e9c02b6c979936eee9a9
* | | Code simplification (A69)Jean Chalard2012-07-091-9/+9
| | | | | | | | | | | | Change-Id: I2a77e437795fbbea47fd2e604ee6c26f8d0e458a
* | | Consolidate two methods (A68)Jean Chalard2012-07-091-48/+17
| | | | | | | | | | | | Change-Id: I4b91414190b3786065ebd962a76299b605e5797e
* | | Pass the value we really want to pass to update functions (A67)Jean Chalard2012-07-091-10/+25
| | | | | | | | | | | | Change-Id: Ica9b875d119dea2f8dc237fd63e5b4eaa5e1c400
* | | Preparative change to pass a boolean with known value (A66)Jean Chalard2012-07-091-12/+14
| | | | | | | | | | | | Change-Id: Iff03fe7c4a8eec17c00a2fe99197e0cf21a0630a
* | | Merge "Remove useless processing (A65)"Jean Chalard2012-07-081-2/+2
|\ \ \ | |/ / |/| |
| * | Remove useless processing (A65)Jean Chalard2012-07-061-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We just resetted the composing state - updating suggestions is sure to yield no results. We may as well not call updateSuggestions at all. We should however still cancel any lingering timer from a previous input field, to avoid this useless processing. Change-Id: Ic1a19d577903d792bb797c837cc517ea8d430e75
* | | Remove unused WordComposer.init methodTadashi G. Takaoka2012-07-061-5/+1
| | | | | | | | | | | | Change-Id: I46c6a6e1c1536599cb909bf81297001b238f2ec8
* | | Merge "Extend onTextInput to be able to inject suggestions"Tadashi G. Takaoka2012-07-063-1/+62
|\ \ \
| * | | Extend onTextInput to be able to inject suggestionsTadashi G. Takaoka2012-07-063-1/+62
| | | | | | | | | | | | | | | | Change-Id: I1061da0edfdb05c64c5711717d4ef9fa9681e568
* | | | Merge "Fix a bug where spaces would be forgotten"Jean Chalard2012-07-061-1/+2
|\ \ \ \ | |_|/ / |/| | |
| * | | Fix a bug where spaces would be forgottenJean Chalard2012-07-061-1/+2
| | | | | | | | | | | | | | | | | | | | Bug: 6785706 Change-Id: Ic7bf242ef058d116b986d47ad197b6d2802e2342
* | | | Refinement (A64)Jean Chalard2012-07-061-1/+1
| | | | | | | | | | | | | | | | Change-Id: I7c16e28ffce4fe0965b756bf2b00ee63b77dd039
* | | | Remove useless code (A63)Jean Chalard2012-07-061-5/+0
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the separator is not a space, then we will always call setPunctuationSuggestions and reset the suggestion strip anyway. If the separator is a space, then the cursor has a space on the left, which means isCursorTouchingWord depends only on whether it touches a word on the right. If we were displaying the "add to dictionary hint", it means a suggestion was just chosen, so it had to be displayed, and that requires a composing word and no non-separator at the right of the cursor. In the end, if we go through this postUpdateSuggestions call, we are sure we will reset the suggestions later in this method, either by calling postUpdateBigramPredictions, or setPunctuationSuggestions. Change-Id: I95d5f77a5d0ac6d1a6ced8d67d6ac8f650db4a32
* | | Simplification (A62)Jean Chalard2012-07-061-9/+4
|/ / | | | | | | Change-Id: I606270a0387787445b7cd6b94e4830bfc144b49e
* | Remove useless code (A61)Jean Chalard2012-07-061-3/+0
| | | | | | | | | | | | | | | | Just after this, clear() will be called, removing the suggestion strip from the screen. It will later be displayed again through onStartInputView, which will update its content. Change-Id: I15c23ad2adecab76b0791d7fc222d15b6533f3bd
* | Simplification (A60)Jean Chalard2012-07-061-9/+3
| | | | | | | | Change-Id: I99e912d3edfc7dd3f17ee835331d5fcba976750c
* | Simplification & UI improvement (A59)Jean Chalard2012-07-061-6/+2
| | | | | | | | | | | | | | | | | | The responsivity is better like this. This does not seem to feel slow as the previous comment seemed to indicate. Also remove a stale comment. Change-Id: I4e7bf9fe28716e112db182e44b3fa88ee4526bb4
* | Show predictions in the right cases (A58)Jean Chalard2012-07-061-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After reverting an auto-correct we always have a separator after the previously inserted word, and the cursor is never touching a word. Showing predictions is the right thing to do, while calling postUpdateSuggestions will invariably yield an invariably blank suggestion strip, which is not very helpful. Likewise, after we pick a suggestion, we should be showing the predictions unless showing the addToDictionary hint. There was a bug here in the corner case that the word would be a candidate for user dictionary, but the user dictionary provider is not available: in this case we should be showing predictions, but we were showing an unhelpful empty suggestion bar. Change-Id: I287bb5eb4af762bd5a433e85e185fab6d203e91a
* | Cleanup (A57)Jean Chalard2012-07-062-18/+11
| | | | | | | | | | | | | | We stopped cancelling manual picks a few weeks ago. This code is dead. Change-Id: I4032fcc3c95e9379f1839fe860a1b8a9bd7d0bc7
* | Merge "Fix a bug where the caps mode would not be changed"Jean Chalard2012-07-052-8/+19
|\ \
| * | Fix a bug where the caps mode would not be changedJean Chalard2012-07-062-8/+19
| | | | | | | | | | | | | | | Bug: 6766059 Change-Id: I378f9d35c4904c4f373260bda5863235d833eb31
* | | Simplification (A56)Jean Chalard2012-07-051-14/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If suggestion and prediction messages both happen to be in the queue, the latest one will win (update the suggestion strip later than the other, overwriting any previous suggestions). So when we enqueue either one, it is always safe to cancel all messages of both types. Change-Id: Iad9dd06d08c49f60cac16b88edcc9531a18ec02e
* | | Remove an unused method (A55)Jean Chalard2012-07-052-30/+0
| | | | | | | | | | | | Change-Id: I9974b88923b85cd6bec74f7607067c660f36f040
* | | Merge "Remove a useless method, rename another. (A54)"Jean Chalard2012-07-052-7/+3
|\ \ \
| * | | Remove a useless method, rename another. (A54)Jean Chalard2012-07-052-7/+3
| | | | | | | | | | | | | | | | Change-Id: If36b5375b04f68deeb72bcece3cb8d37aed57f59
* | | | Merge "Initialize SubtypeLocale from Settings"Tadashi G. Takaoka2012-07-052-1/+11
|\ \ \ \
| * | | | Initialize SubtypeLocale from SettingsTadashi G. Takaoka2012-07-052-1/+11
| | | | | | | | | | | | | | | | | | | | | | | | | Bug: 6781106 Change-Id: I22f04af4fabf93346ab6f72c1841f096afaccb96
* | | | | Merge "Remove a redundant test (A53)"Jean Chalard2012-07-051-11/+4
|\ \ \ \ \ | | |/ / / | |/| | |
| * | | | Remove a redundant test (A53)Jean Chalard2012-07-051-11/+4
| | | | | | | | | | | | | | | | | | | | Change-Id: If711074fdcb586e35d02e421c845f2c9024ca718
* | | | | Merge "Small simplification (A52)"Jean Chalard2012-07-051-8/+4
|\| | | |
| * | | | Small simplification (A52)Jean Chalard2012-07-051-8/+4
| | | | | | | | | | | | | | | | | | | | Change-Id: I56bc5b9b584de5a14b41fc32c19f7fefb3b12e88
* | | | | Merge "Put some more code in common (A51)"Jean Chalard2012-07-051-23/+18
|\| | | |
| * | | | Put some more code in common (A51)Jean Chalard2012-07-051-23/+18
| | | | | | | | | | | | | | | | | | | | Change-Id: If1589e29728df20713c75e08df7f47f0de9202d4
* | | | | Merge "Pull up a common variable into the wrapping method (A50)"Jean Chalard2012-07-051-8/+10
|\| | | |
| * | | | Pull up a common variable into the wrapping method (A50)Jean Chalard2012-07-051-8/+10
| | | | | | | | | | | | | | | | | | | | Change-Id: I0b62098308169b5c44ced25ffb902766e3732fbf
* | | | | Merge "Factorize some common code (A49)"Jean Chalard2012-07-051-30/+16
|\| | | | | |/ / / |/| | |
| * | | Factorize some common code (A49)Jean Chalard2012-07-051-30/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Also add some comment to clarify what's happening inside those methods Change-Id: I5b9b1e105b3145f0b050f35d12c5b6ca6e4a4d8c
* | | | Merge "Fix tab key's navigation behavior"Tadashi G. Takaoka2012-07-054-13/+4
|\ \ \ \
| * | | | Fix tab key's navigation behaviorTadashi G. Takaoka2012-07-054-13/+4
| | | | | | | | | | | | | | | | | | | | | | | | | Bug: 6435484 Change-Id: Iffe459c117ad438e96ec6f5c7e64fb80b32d227e
* | | | | Merge "Fix upper case Eszett more key"Tadashi G. Takaoka2012-07-051-3/+11
|\ \ \ \ \ | |_|/ / / |/| | | |
| * | | | Fix upper case Eszett more keyTadashi G. Takaoka2012-07-051-3/+11
| |/ / / | | | | | | | | | | | | | | | | Bug: 6773873 Change-Id: I1a533c729c312a53663fb142cb6fcb4915b53206
* | | | Merge "Add a wrapper to updateSuggestions / Predictions (A48)"Jean Chalard2012-07-041-7/+15
|\ \ \ \ | |/ / / |/| | |
| * | | Add a wrapper to updateSuggestions / Predictions (A48)Jean Chalard2012-07-051-7/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The goal is to have those converge, as they contain almost 100% duplicated code. Change-Id: I6921791d47efce9fb396efd9626839d706664a91
* | | | Merge "Fix Keyboard.getKey as thread safe"Tadashi G. Takaoka2012-07-041-10/+12
|\ \ \ \ | |/ / / |/| | |
| * | | Fix Keyboard.getKey as thread safeTadashi G. Takaoka2012-07-051-10/+12
| |/ / | | | | | | | | | | | | | | | This is a follow up of Id962e670. Change-Id: I9e8542bff9e8faf57f934051fe612463c99ad61f
* / / Refactoring which will help with future changes (A47)Jean Chalard2012-07-051-2/+5
|/ / | | | | | | Change-Id: Ibc2d28f9f95966f77d4d7bdf9ae4688baaed5989
generated by cgit v1.2.3-83-g751a (git 2.47.1) at 2025-05-07 01:37:38 +0000