aboutsummaryrefslogtreecommitdiffstats
path: root/java/src (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Merge "Fix a long-standing race condition."Jean Chalard2011-12-131-15/+15
|\
| * Fix a long-standing race condition.Jean Chalard2011-12-141-15/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Upon autocorrection, there is visual feedback in the text view that quickly flashes the background of the text that just changed. This fixes a race condition that happens upon autocorrection when typing fast, and that results in flashing one character too far left (typically, the flashing area includes the whitespace before the corrected word and not the last character of the corrected word). This happens because the call to commitCorrection may happen before or after the IPC sent by sendKeyChar, but the arguments are fit only for the case where it arrives first. Change-Id: I9b5442a665aad5a9bc66cd49228075b9056b37fa
* | Merge "Decouple member logic from control flow"Jean Chalard2011-12-131-4/+8
|\ \
| * | Decouple member logic from control flowJean Chalard2011-12-131-4/+8
| |/ | | | | | | | | | | | | | | | | This place is very confusing because a member variable with a consistent meaning is hijacked for the duration of a function to mean something else. This is in the way of easy-to-understand refactoring. Change-Id: If79bc771950d6bfc0ad5f0e9c51c7ef1dbb45b66
* / Various mini-cleanupsJean Chalard2011-12-134-10/+11
|/ | | | | | | | | | - Stop the word composer from escaping - take a page from the law of Demeter and only report what is actually needed. - Fix typos in comments. - Add a comment for a fishy processing. - Remove a useless local variable. Change-Id: I5fa78901cbb5483fc9683bfb7094f47244b85df6
* Merge "Remove the input connection sidework from handleCharacter"Jean Chalard2011-12-131-6/+10
|\
| * Remove the input connection sidework from handleCharacterJean Chalard2011-12-131-6/+10
| | | | | | | | Change-Id: I3d376dfda3acd8864274390de3ff5752b18456e0
* | Move mBestWord to the word composer.Jean Chalard2011-12-132-19/+55
|/ | | | | | | | | | mBestWord has a confusing name - it's actually an auto-correction. It's cleaner if it lives in the word composer because an auto-correction should be tied to a specific user input, and should be reset each time the user input changes to avoid race conditions. Change-Id: I718d29395bc747372067e6440e090c6a181994ae
* Merge "Tighten conditions for space-related cancelling"Jean Chalard2011-12-131-4/+10
|\
| * Tighten conditions for space-related cancellingJean Chalard2011-12-131-4/+10
| | | | | | | | | | | | Instead of ignoring silently a found bug, throw an exception. Change-Id: I0aa96d0cab022b6a5e7cffe8a592dcc443c3c7a8
* | Merge "Consolidate underlining code under one function."Jean Chalard2011-12-131-18/+17
|\ \
| * | Consolidate underlining code under one function.Jean Chalard2011-12-131-18/+17
| |/ | | | | | | Change-Id: I4393ff1ec28a6b3118d1344dd6d82d04899dea42
* | Merge "Introduce KeyboardSet to hold related KeyboardIds"Tadashi G. Takaoka2011-12-132-80/+144
|\ \
| * | Introduce KeyboardSet to hold related KeyboardIdsTadashi G. Takaoka2011-12-132-80/+144
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change moves * KeyboardSwitcher.getKeyboardId to KeyboardSet.<init> and KeyboardSet.getKeyboardId. * KeyboardSwitcher.getF2KeyMode to KeyboardSet. This is the first step to get rid of shift state from Keyboard. Bug: 5002108 Bug: 5679585 Change-Id: I2a5a97e5e89277bc606916d45c1afbc8d105d773
* | | Merge "Extract the jni library name"satok2011-12-132-2/+28
|\ \ \ | |/ / |/| |
| * | Extract the jni library namesatok2011-12-132-2/+28
| |/ | | | | | | Change-Id: Icc58ccea1178d9f35f5be0dceebab67bbb965b7f
* | Merge "Remove KeyboardSwitcher.updateShiftLockState method"Tadashi G. Takaoka2011-12-131-15/+7
|\ \ | |/ |/|
| * Remove KeyboardSwitcher.updateShiftLockState methodTadashi G. Takaoka2011-12-131-15/+7
| | | | | | | | Change-Id: I032fc50a62a573ba4258530e695c8c88467783c6
* | Remove a useless returnJean Chalard2011-12-131-3/+0
| | | | | | | | Change-Id: Iefe10e94e2d88171387351a5b6cab52e281d0f76
* | Merge "Simplification"Jean Chalard2011-12-121-4/+2
|\ \
| * | SimplificationJean Chalard2011-12-131-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | Both tests have the same meaning. They should be merged. Also, if "deleteLast()" deletes more than one char (which never happens in the current implementation, but it's not guaranteed), the new code is more correct. Change-Id: I216df7cd45f4a7d76d1d5d6aa7f8d7f9a6e35ea3
* | | Merge "Refactoring"Jean Chalard2011-12-121-21/+18
|\| |
| * | RefactoringJean Chalard2011-12-131-21/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | If mHasUncommittedTypedChars is true, then mWordSavedForAutoCorrectCancellation must always be null, and spaceState must always be SPACE_STATE_NONE. Hence, this change is supposed to be very no-op. Change-Id: I2716f7372d996cc4dec40a4b7ac1ee7f5f4afe91
* | | Merge changes I7888797c,I57b2232fJean Chalard2011-12-121-11/+8
|\| | | |/ |/| | | | | | | * changes: Refactor + small bugfix Refactoring
| * Refactor + small bugfixJean Chalard2011-12-131-4/+3
| | | | | | | | | | | | | | | | | | postUpdateShiftKeyState used to be called also when mEnteredText is not null => this is a bugfix. The rest does not change the logic, as posting a message can be done anywhere within the function with no impact. Change-Id: I7888797c0778702d64f96701e35b611a55a6a259
| * RefactoringJean Chalard2011-12-131-7/+5
| | | | | | | | Change-Id: I57b2232f7fde32df5f6e1925aad1df988def34f9
* | Remove current keyboard id variableTadashi G. Takaoka2011-12-131-5/+3
|/ | | | Change-Id: Iec19af98209e1ea8ecd176d3be04d628d4b38950
* Merge "Fix a bug where revert auto-correct would revert too much"Jean Chalard2011-12-121-8/+24
|\
| * Fix a bug where revert auto-correct would revert too muchJean Chalard2011-12-121-8/+24
| | | | | | | | | | | | | | | | | | | | If there are no uncommitted chars, we shouldn't enter any of the tests that follow. We didn't use to, but a change today made it possible - it should not happen. There is no point in doing the rest of the tests, they are sure to fail. Change-Id: I580dd104aff3585de72a93b38989bfd9713f615b
* | Remove a useless function callJean Chalard2011-12-121-1/+0
|/ | | | Change-Id: I1a775cbf90dca301e1e6b596ddac64fdbc023199
* Merge "Move a settings var to the settings class"Jean Chalard2011-12-122-2/+3
|\
| * Move a settings var to the settings classJean Chalard2011-12-122-2/+3
| | | | | | | | Change-Id: I1331ad6dec3a9d64a77e314f8a1f4c29282df31b
* | Remove a useless variableJean Chalard2011-12-121-3/+2
| | | | | | | | | | | | This can be just read when it's needed. Change-Id: I00753fe55645c244db5d4a96e7fdb8f5325475d9
* | Remove a messy and unused class.Jean Chalard2011-12-122-225/+0
|/ | | | | | Today is a happy day Change-Id: I3ef484bd258d5a59815bfcb0bd35ea3606b32430
* Merge "Remove side-effects from TextEntryState"Jean Chalard2011-12-123-12/+41
|\
| * Remove side-effects from TextEntryStateJean Chalard2011-12-123-12/+41
| | | | | | | | Change-Id: Ib98eea9e791e426435cfdfd0c9ab3ed9061664aa
* | Add special handling for "Phone number" layout.Tadashi G. Takaoka2011-12-121-0/+6
| | | | | | | | | | Bug: 5743584 Change-Id: I821b837a2078afb64b460191c98b28f7733cf2c1
* | Merge "Add unit test of KeyboardState"Tadashi G. Takaoka2011-12-121-3/+3
|\ \
| * | Add unit test of KeyboardStateTadashi G. Takaoka2011-12-121-3/+3
| | | | | | | | | | | | | | | Bug: 5708602 Change-Id: I1a8a9f4320948bb500a96df8773b0bfa1a1d4167
* | | Remove a useless variable.Jean Chalard2011-12-121-5/+1
| |/ |/| | | | | Change-Id: Iea5ce5cfc05bad8b1d9085438e90147bd54b7e9c
* | Merge "Straighten out logic for revert word paths"Jean Chalard2011-12-111-30/+67
|\ \
| * | Straighten out logic for revert word pathsJean Chalard2011-12-121-30/+67
| | | | | | | | | | | | | | | | | | | | | This also includes a new memorized string with simpler logic that will allow to remove other members Change-Id: I0b97243084902e68fcb835b6163c86fef8190ebc
* | | Merge "Assign Key.mCode from the label only when outputText is not specified"Tadashi G. Takaoka2011-12-111-1/+8
|\ \ \
| * | | Assign Key.mCode from the label only when outputText is not specifiedTadashi G. Takaoka2011-12-121-1/+8
| | | | | | | | | | | | | | | | | | | | Bug: 5742827 Change-Id: I72b55ce246b14a2d8f4fd16211b71dc716db30b2
* | | | Merge "Move KeyDetector.printableCode to Keyboard"Tadashi G. Takaoka2011-12-113-10/+23
|\ \ \ \ | |_|/ / |/| | |
| * | | Move KeyDetector.printableCode to KeyboardTadashi G. Takaoka2011-12-123-10/+23
| |/ / | | | | | | | | | Change-Id: I9cde21fbb45c1e5f1a568bb97b1b1a76524f4bf2
* | | Merge "Remove a duplicated variable."Jean Chalard2011-12-113-37/+27
|\ \ \ | |_|/ |/| |
| * | Remove a duplicated variable.Jean Chalard2011-12-123-37/+27
| |/ | | | | | | | | | | This is awesome cleanup. Change-Id: I35ce8940a13f3084630dc26d6e7e397acfdaac36
* / Remove unused Keyboard.CODE_CANCELTadashi G. Takaoka2011-12-122-6/+0
|/ | | | Change-Id: Ic2eab17e525901a1cf7096ebe7d24ae78624ed2e
* Build God Mode keyboard with API level 14Ken Wakasa2011-12-102-1/+46
| | | | Change-Id: I29ab9e9041c9faac91dc303175625221bfdb3af8