aboutsummaryrefslogtreecommitdiffstats
path: root/java (follow)
Commit message (Collapse)AuthorAgeFilesLines
...
| * | Remove useless code (A42)Jean Chalard2012-07-021-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If allowsAutoCorrected is false, there is no point in making hasAutoCorrection true, since in the only place where we use it again, it's &&'ed with allowsAutoCorrected ! Well that was extremely obscure, good thing refactoring allowed to realize this was useless >.> Change-Id: I34936d445f1ced17c7bd04a9524bf608f9e8b9c8
* | | Merge "Clarify some code and fix a bug (A41)"Jean Chalard2012-07-021-10/+13
|\| |
| * | Clarify some code and fix a bug (A41)Jean Chalard2012-07-021-10/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The test against hasMainDictionary is a test to know if we should auto-correct or not. Its result should be recorded in hasAutoCorrection, not in allowsToBeAutoCorrected. Actually, this value being inserted in allowsToBeAutoCorrected was causing a bug that nobody noticed: when typing in a language with no dictionary, the word in the middle of the suggestion strip would always be bold, as if it was going to auto-correct to itself ! This change fixes this bug. Change-Id: Ia1f08efd7089b9c5cbede910c5b0951d83e698d2
* | | Import translations. DO NOT MERGEEric Fischer2012-07-021-1/+1
| | | | | | | | | | | | | | | Change-Id: I13c7109bb886ef2860cbb4fc24650dd2b8badbcb Auto-generated-cl: translation import
* | | Merge "Fix a bug with the user dictionary locale."Jean Chalard2012-07-021-2/+10
|\ \ \ | |/ / |/| |
| * | Fix a bug with the user dictionary locale.Jean Chalard2012-07-021-2/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We internally use the string "zz" to mean no locale, but the user dictionary service does not understand that and words added with this locale pitifully end being added to a "zz" user dictionary, which makes no sense to the user. This change fixes things so that words added when the keyboard is in a "no locale" layout, the words are added to the global, all-locales user dictionary. Bug: 6645306 Change-Id: Iec3cdd1fe3d5bc43427a43ef9ae9bf89e12be1f2
* | | Small refactoring (A39)Jean Chalard2012-07-021-14/+14
| | | | | | | | | | | | Change-Id: I3c45b5a6571f986acc7adb3a8fe17b210303f7ea
* | | Match calls for future consolidation (A38)Jean Chalard2012-07-021-3/+3
| | | | | | | | | | | | Change-Id: I2b2ab99e801fa8b4b30eab16a8aefb8cfe104ba9
* | | Make the autocorrection scheme more straightforward (A37)Jean Chalard2012-07-022-6/+7
|/ / | | | | | | Change-Id: I4833ca7e057b8c1f1f22390673cbca0d2433b1bd
* | Merge "Remove a duplicate method (A36)"Jean Chalard2012-07-012-5/+1
|\ \
| * | Remove a duplicate method (A36)Jean Chalard2012-07-022-5/+1
| | | | | | | | | | | | | | | Bug: 6705473 Change-Id: Ib6260034b09739b60071e90a018b2dc6be3815d7
* | | Merge "Update log and make a variable private (A35)."Jean Chalard2012-07-012-3/+2
|\| |
| * | Update log and make a variable private (A35).Jean Chalard2012-07-022-3/+2
| | | | | | | | | | | | Change-Id: Ib4a8f41dc5941bce46402e1a41a6c21dccb0601f
* | | Merge "Update dictionaries."Jean Chalard2012-07-012-0/+0
|\ \ \ | |/ / |/| |
| * | Update dictionaries.Jean Chalard2012-06-292-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - English : some words caught through regression tests - English : some words externally reported - French : some words externally reported - French : finished review of all accented words Bug: 6726969 Bug: 6730031 Change-Id: I37d0dc310db2c79e03ac7ad452391e92d9b13357
* | | Import translations. DO NOT MERGEYing Wang2012-06-2947-188/+94
| | | | | | | | | | | | | | | Change-Id: I1c7b1b7877fdbf6963b7a034a8ec197004f97b0e Auto-generated-cl: translation import
* | | Remove old debug code that has been long broken (A34)Jean Chalard2012-06-291-3/+2
| | | | | | | | | | | | Change-Id: I9b5a0e34529724984aad1e2bf99b3e00f8ed0dd7
* | | Merge "Add input pointers"Satoshi Kataoka2012-06-295-33/+155
|\ \ \
| * | | Add input pointersSatoshi Kataoka2012-06-295-33/+155
| | | | | | | | | | | | | | | | Change-Id: I95300bf0a847fb86d026e846ff4ad723bb45284f
* | | | Merge "Add a more synthetic variable (A33)"Jean Chalard2012-06-291-1/+3
|\ \ \ \
| * | | | Add a more synthetic variable (A33)Jean Chalard2012-06-291-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The goal here is to disambiguate TypedWordValid and HasAutoCorrectionCandidate. Ultimately, HasAutoCorrectionCandidate will disappear. Bug: 6705473 Change-Id: I1acbd0a5efc7f4bf7b0bdb12839fe3d84e9d1dda
* | | | | Merge "Remove cruft (A32)"Jean Chalard2012-06-291-7/+1
|\| | | |
| * | | | Remove cruft (A32)Jean Chalard2012-06-291-7/+1
| | | | | | | | | | | | | | | | | | | | Change-Id: I35c2ba4caf6be4ba0449e11c0597ae8e468c0e6e
* | | | | Merge "Simplification (A31)"Jean Chalard2012-06-291-6/+2
|\| | | |
| * | | | Simplification (A31)Jean Chalard2012-06-291-6/+2
| | | | | | | | | | | | | | | | | | | | Change-Id: I9e4d030974ccec1a6256de6ca87610870e404149
* | | | | Merge "Small refactoring (A30)"Jean Chalard2012-06-291-4/+4
|\| | | |
| * | | | Small refactoring (A30)Jean Chalard2012-06-291-4/+4
| | | | | | | | | | | | | | | | | | | | Change-Id: I41b413986a3c5bb6697bb7bbced17ed1e361913c
* | | | | Merge "Use SparseArray<E> instead of HashMap<Integer,E>"Tadashi G. Takaoka2012-06-297-51/+55
|\ \ \ \ \ | |/ / / / |/| | | |
| * | | | Use SparseArray<E> instead of HashMap<Integer,E>Tadashi G. Takaoka2012-06-297-51/+55
| | | | | | | | | | | | | | | | | | | | Change-Id: Id962e670ee1a5164e6c69deb84625139bf5e7974
* | | | | Remove a useless parameter (A29)Jean Chalard2012-06-294-6/+1
| | | | | | | | | | | | | | | | | | | | Change-Id: I52625e707abf61da9b95e542f0814c66b532f483
* | | | | Remove a useless variable (A28)Jean Chalard2012-06-292-5/+0
| | | | | | | | | | | | | | | | | | | | Change-Id: I1058123d233540fb72a94028987a43740224f635
* | | | | Fix a small bug (A27)Jean Chalard2012-06-291-1/+1
| |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | TypedWordValid and AllowsToBeAutoCorrected are almost the same thing; the difference is whether the word is also a whitelist entry or not. In this case, TypedWordValid was the right one to test. Change-Id: I695fe5b9f6bbe9d3ba314c646da3a25742c9f4ed
* | | | Optimization (A26)Jean Chalard2012-06-291-9/+2
| | | | | | | | | | | | | | | | Change-Id: I1d7790289635729645995fb8c38868259ab1b3be
* | | | Remove useless code (A25)Jean Chalard2012-06-291-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | isWhitelistedOrNotAWord takes an 'ignoreCase' argument. By looking at the contents of the wordcomposer here, there is only one case where its output will be different : when the word is typed with a capital, but the lower case version exists in the dictionary. E.g. the user typed "This". In this case, isWhitelistedOrNotAWord in line 235 will return false instead of true, so the test will score a true instead of a false, so hasAutoCorrection may be true instead of false in this specific case and that's the only case where it's different. But in this case, allowsToBeAutoCorrected is certain to be false, which means the result will not have changed if hasAutoCorrection was true in the first place. So in the end this change is sure not to change the behavior. Change-Id: Ic41cf959c20c19165f84d9b8ff006731fa595d84
* | | | Add a few comments for future reference (A24)Jean Chalard2012-06-291-0/+6
| | | | | | | | | | | | | | | | Change-Id: Ia356130b8a95ec9cf676bc6be05d801c13f14b64
* | | | Rename a method for readability (A23)Jean Chalard2012-06-292-2/+2
| | | | | | | | | | | | | | | | Change-Id: I6f569322e645d36bc82fddf4ec2fd621972e3b47
* | | | Revert a test for readability (A22)Jean Chalard2012-06-291-14/+12
| | | | | | | | | | | | | | | | Change-Id: I1df4cef5ae2736a22273843dce67f0012181bfd3
* | | | Remove a useless variable (A21)Jean Chalard2012-06-291-4/+4
| | | | | | | | | | | | | | | | Change-Id: I901e6b0e2b994128da19d68233b9f68bb308cb95
* | | | Remove a useless variable (A20)Jean Chalard2012-06-291-6/+4
| | | | | | | | | | | | | | | | Change-Id: Ifc37462f5243563693c8cd7cbeb401ff054daa52
* | | | Rename a method for readability (A19)Jean Chalard2012-06-292-3/+3
| | | | | | | | | | | | | | | | Change-Id: I0b8c06d1fd0bfb3caf363c048acc7048abed1752
* | | | Remove a useless test (A18)Jean Chalard2012-06-291-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | allowsToBeAutoCorrected always returns false if the word is empty. This is because the whitelist never contains an empty string, and isValidWord returns false if the word is empty. Change-Id: I34ecc2a1563aea6db5b2f12796f251f6598576a2
* | | | Inline a method (A17)Jean Chalard2012-06-292-8/+2
| | | | | | | | | | | | | | | | | | | | | | | | This will allow us to remove unnecessary processing Change-Id: I251dfdaffb077906186686ebe65fd82e1e360bd2
* | | | Make a function a one-liner (A16)Jean Chalard2012-06-291-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | ...to better inline it Change-Id: I88496b8f18b81f0c05e4bbf2d1039de1f93e0c25
* | | | Inline a simple method (A15)Jean Chalard2012-06-292-5/+1
| | | | | | | | | | | | | | | | Change-Id: Ib74fcbf33c680bf02c39a9896e30e3afbcfd149a
* | | | Inline a method (A14)Jean Chalard2012-06-292-23/+14
|/ / / | | | | | | | | | | | | | | | | | | The new code is worse than the old one, but this is a necessary step to make things prettier. Change-Id: If6e8a139bb85e6920c749743c78792a22a8acb45
* | | Don't special-case 1-letter words (A13)Jean Chalard2012-06-291-8/+6
| | | | | | | | | | | | | | | | | | | | | There is no reason to prevent 1-letter words to auto-correct to themselves, or to dictionary words. Don't do it. Change-Id: Iceada847ae632336026ada29afed0353cd9c51b5
* | | Fix a theoretical bug (A12)Jean Chalard2012-06-291-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | If a word is a dictionary word but still has no suggestion, this method should return true. In the practice, it makes no difference since a word without suggestion won't be changed anyway. Change-Id: Ib1f5ef254b7da7e5cedb2f973529ad431beb93f9
* | | Rename a terribly-named method for clarity (A11)Jean Chalard2012-06-291-2/+3
| | | | | | | | | | | | Change-Id: Id180000404dc6929d80f98c0e9cd2026230ad2d1
* | | Merge "Small readability improvement (A10)"Jean Chalard2012-06-281-1/+3
|\ \ \
| * | | Small readability improvement (A10)Jean Chalard2012-06-291-1/+3
| |/ / | | | | | | | | | Change-Id: Iba326921711e1c4eab38264e66b6b44a64fec398
generated by cgit v1.2.3-83-g751a (git 2.47.1) at 2025-05-23 17:46:45 +0000