From 41ec3ec2f3a95f0af2697da92cee4920e6156763 Mon Sep 17 00:00:00 2001 From: Jean Chalard Date: Thu, 26 May 2011 12:31:52 +0900 Subject: Enable choosing a bigram prediction several times in a row. This change fixes a bug that prevented to choose a prediction several times in a row because the predictions would be replaced right away by punctuations. Please note several things about this change: - Recorrection is pretty much in the middle of being refactored. This change has no effect on recorrection itself, but may make existing strange behavior more obvious when moving the cursor for example. - The part of this change in Recorrection.java is not used in master at the moment because ongoing changes on recorrection result in the control never landing there, but would have been needed in the past and may be needed in the future. - This change may have adverse effects on performance which need to be evaluated. A comment in the code has also been written to this effect. - This does not fix bug 4466199, only addresses a pinpoint case of it to help evaluating the bigram predictions feature. Bug: 4466199 Change-Id: I7219e5aeb74dff9251d12b2a72f94448dbb3e63f --- .../inputmethod/deprecated/recorrection/Recorrection.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'java/src/com/android/inputmethod/deprecated') diff --git a/java/src/com/android/inputmethod/deprecated/recorrection/Recorrection.java b/java/src/com/android/inputmethod/deprecated/recorrection/Recorrection.java index 7f88066b6..d40728d25 100644 --- a/java/src/com/android/inputmethod/deprecated/recorrection/Recorrection.java +++ b/java/src/com/android/inputmethod/deprecated/recorrection/Recorrection.java @@ -218,10 +218,10 @@ public class Recorrection implements SharedPreferences.OnSharedPreferenceChangeL mService.showSuggestions(builder.build(), entries.getOriginalWord()); } - public void setRecorrectionSuggestions(VoiceProxy voiceProxy, CandidateView candidateView, - Suggest suggest, KeyboardSwitcher keyboardSwitcher, WordComposer word, - boolean hasUncommittedTypedChars, int lastSelectionStart, int lastSelectionEnd, - String wordSeparators) { + public void fetchAndDisplayRecorrectionSuggestions(VoiceProxy voiceProxy, + CandidateView candidateView, Suggest suggest, KeyboardSwitcher keyboardSwitcher, + WordComposer word, boolean hasUncommittedTypedChars, int lastSelectionStart, + int lastSelectionEnd, String wordSeparators) { if (!InputConnectionCompatUtils.RECORRECTION_SUPPORTED) return; if (SuggestionSpanUtils.SUGGESTION_SPAN_IS_SUPPORTED || !mRecorrectionEnabled) return; voiceProxy.setShowingVoiceSuggestions(false); @@ -249,7 +249,7 @@ public class Recorrection implements SharedPreferences.OnSharedPreferenceChangeL ic.endBatchEdit(); } else { abortRecorrection(true); - mService.setPunctuationSuggestions(); // Show the punctuation suggestions list + mService.updateBigramPredictions(); } } else { abortRecorrection(true); -- cgit v1.2.3-83-g751a