From 03cb8f751a7f35e9159c724a2d25528b86287b57 Mon Sep 17 00:00:00 2001 From: Keisuke Kuroyanagi Date: Tue, 1 Oct 2013 11:41:39 +0900 Subject: Quit blocking getSuggestion during GC. Bug: 10831272 Change-Id: I995c619dc18a9120a47f547d31045cb73a9353ec --- .../latin/ExpandableBinaryDictionary.java | 24 +++++++++++++++++++--- 1 file changed, 21 insertions(+), 3 deletions(-) (limited to 'java/src/com/android/inputmethod/latin/ExpandableBinaryDictionary.java') diff --git a/java/src/com/android/inputmethod/latin/ExpandableBinaryDictionary.java b/java/src/com/android/inputmethod/latin/ExpandableBinaryDictionary.java index 2d1ca51e2..306c1a253 100644 --- a/java/src/com/android/inputmethod/latin/ExpandableBinaryDictionary.java +++ b/java/src/com/android/inputmethod/latin/ExpandableBinaryDictionary.java @@ -273,6 +273,24 @@ abstract public class ExpandableBinaryDictionary extends Dictionary { lastModifiedTime); } + private void runGCIfRequired() { + if (!ENABLE_BINARY_DICTIONARY_DYNAMIC_UPDATE) return; + if (mBinaryDictionary.needsToRunGC(true /* mindsBlockByGC */)) { + if (setIsRegeneratingIfNotRegenerating()) { + getExecutor(mFilename).execute(new Runnable() { + @Override + public void run() { + try { + mBinaryDictionary.flushWithGC(); + } finally { + mFilenameDictionaryUpdateController.mIsRegenerating.set(false); + } + } + }); + } + } + } + /** * Dynamically adds a word unigram to the dictionary. May overwrite an existing entry. */ @@ -282,7 +300,7 @@ abstract public class ExpandableBinaryDictionary extends Dictionary { Log.w(TAG, "addWordDynamically is called for non-updatable dictionary: " + mFilename); return; } - + runGCIfRequired(); getExecutor(mFilename).execute(new Runnable() { @Override public void run() { @@ -306,7 +324,7 @@ abstract public class ExpandableBinaryDictionary extends Dictionary { + mFilename); return; } - + runGCIfRequired(); getExecutor(mFilename).execute(new Runnable() { @Override public void run() { @@ -330,7 +348,7 @@ abstract public class ExpandableBinaryDictionary extends Dictionary { + mFilename); return; } - + runGCIfRequired(); getExecutor(mFilename).execute(new Runnable() { @Override public void run() { -- cgit v1.2.3-83-g751a