From aa161eb371d8042ef4c1f9207648b3aeacb65e4e Mon Sep 17 00:00:00 2001 From: Jean Chalard Date: Fri, 20 Dec 2013 16:34:38 +0900 Subject: [IL24] Move mDisplayOrientation to SettingsValues. Bug: 8636060 Change-Id: Id57ced0cca9dc9e5e85c3a53683588feb28c1402 --- .../inputmethod/latin/settings/SettingsValues.java | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) (limited to 'java/src/com/android/inputmethod/latin/settings/SettingsValues.java') diff --git a/java/src/com/android/inputmethod/latin/settings/SettingsValues.java b/java/src/com/android/inputmethod/latin/settings/SettingsValues.java index c0e8a0301..3307de8ae 100644 --- a/java/src/com/android/inputmethod/latin/settings/SettingsValues.java +++ b/java/src/com/android/inputmethod/latin/settings/SettingsValues.java @@ -101,6 +101,7 @@ public final class SettingsValues { public final int mSuggestionVisibility; public final boolean mBoostPersonalizationDictionaryForDebug; public final boolean mUseOnlyPersonalizationDictionaryForDebug; + public final int mDisplayOrientation; private final AsyncResultHolder mAppWorkarounds; // Setting values for additional features @@ -184,6 +185,7 @@ public final class SettingsValues { Settings.readBoostPersonalizationDictionaryForDebug(prefs); mUseOnlyPersonalizationDictionaryForDebug = Settings.readUseOnlyPersonalizationDictionaryForDebug(prefs); + mDisplayOrientation = res.getConfiguration().orientation; mAppWorkarounds = new AsyncResultHolder(); final PackageInfo packageInfo = TargetPackageInfoGetterTask.getCachedPackageInfo( mInputAttributes.mTargetApplicationPackageName); @@ -241,6 +243,7 @@ public final class SettingsValues { mIsInternal = false; mBoostPersonalizationDictionaryForDebug = false; mUseOnlyPersonalizationDictionaryForDebug = false; + mDisplayOrientation = Configuration.ORIENTATION_PORTRAIT; mAppWorkarounds = new AsyncResultHolder(); mAppWorkarounds.set(null); } @@ -254,16 +257,15 @@ public final class SettingsValues { return mInputAttributes.mApplicationSpecifiedCompletionOn; } - public boolean isSuggestionsRequested(final int displayOrientation) { + public boolean isSuggestionsRequested() { return mInputAttributes.mIsSettingsSuggestionStripOn - && (mCorrectionEnabled - || isSuggestionStripVisibleInOrientation(displayOrientation)); + && (mCorrectionEnabled || isSuggestionStripVisible()); } - public boolean isSuggestionStripVisibleInOrientation(final int orientation) { + public boolean isSuggestionStripVisible() { return (mSuggestionVisibility == SUGGESTION_VISIBILITY_SHOW_VALUE) || (mSuggestionVisibility == SUGGESTION_VISIBILITY_SHOW_ONLY_PORTRAIT_VALUE - && orientation == Configuration.ORIENTATION_PORTRAIT); + && mDisplayOrientation == Configuration.ORIENTATION_PORTRAIT); } public boolean isWordSeparator(final int code) { @@ -306,6 +308,10 @@ public final class SettingsValues { return mInputAttributes.isSameInputType(editorInfo); } + public boolean hasSameOrientation(final Configuration configuration) { + return mDisplayOrientation == configuration.orientation; + } + public boolean isBeforeJellyBean() { final AppWorkaroundsUtils appWorkaroundUtils = mAppWorkarounds.get(null, TIMEOUT_TO_GET_TARGET_PACKAGE); -- cgit v1.2.3-83-g751a