From 5f4598831c59b0f6116ea5e63f453e07b57c2571 Mon Sep 17 00:00:00 2001 From: Ziqi Chen Date: Wed, 11 Dec 2024 02:39:55 -0800 Subject: Fix crash: NPE in SuggestionStripView in LatinIME The first parameter in `GestureDetector.OnGestureListener#onScroll` might be null, which indicates an incomplete event stream or error state. https://developer.android.com/reference/android/view/GestureDetector.OnGestureListener#onScroll(android.view.MotionEvent,%20android.view.MotionEvent,%20float,%20float) Bug: 383053077 Change-Id: I6e49ae353beafb6585184fa729041570991f240c --- .../com/android/inputmethod/latin/suggestions/SuggestionStripView.java | 3 +++ 1 file changed, 3 insertions(+) (limited to 'java/src/com/android/inputmethod/latin/suggestions/SuggestionStripView.java') diff --git a/java/src/com/android/inputmethod/latin/suggestions/SuggestionStripView.java b/java/src/com/android/inputmethod/latin/suggestions/SuggestionStripView.java index 840a4aa3d..5dba4928b 100644 --- a/java/src/com/android/inputmethod/latin/suggestions/SuggestionStripView.java +++ b/java/src/com/android/inputmethod/latin/suggestions/SuggestionStripView.java @@ -343,6 +343,9 @@ public final class SuggestionStripView extends RelativeLayout implements OnClick new GestureDetector.SimpleOnGestureListener() { @Override public boolean onScroll(MotionEvent down, MotionEvent me, float deltaX, float deltaY) { + if (down == null) { + return false; + } final float dy = me.getY() - down.getY(); if (deltaY > 0 && dy < 0) { return showMoreSuggestions(); -- cgit v1.2.3-83-g751a