From 96d019f183fc15585a5642155b9a00e9ec3637a4 Mon Sep 17 00:00:00 2001 From: Kurt Partridge Date: Wed, 20 Feb 2013 11:29:55 -0800 Subject: [TestPrep18] Make class public for testing Change-Id: I4b457f44dd6a5a595c61a62061ea02c251fa9ab1 --- java/src/com/android/inputmethod/research/LogUnit.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'java/src/com/android/inputmethod/research/LogUnit.java') diff --git a/java/src/com/android/inputmethod/research/LogUnit.java b/java/src/com/android/inputmethod/research/LogUnit.java index e91976a03..c1258f496 100644 --- a/java/src/com/android/inputmethod/research/LogUnit.java +++ b/java/src/com/android/inputmethod/research/LogUnit.java @@ -45,7 +45,7 @@ import java.util.List; * will not violate the user's privacy. Checks for this may include whether other LogUnits have * been published recently, or whether the LogUnit contains numbers, etc. */ -/* package */ class LogUnit { +public class LogUnit { private static final String TAG = LogUnit.class.getSimpleName(); private static final boolean DEBUG = false && ProductionFlag.IS_EXPERIMENTAL_DEBUG; -- cgit v1.2.3-83-g751a From 5cd50faacab931959b22eda559b8a75da2d886a6 Mon Sep 17 00:00:00 2001 From: Kurt Partridge Date: Tue, 19 Feb 2013 16:12:44 -0800 Subject: [TestPrep20] Clean up import statement Change-Id: Ifcfec09b669d8b2012b1c960bd4b1471c7946870 --- java/src/com/android/inputmethod/research/LogUnit.java | 1 - 1 file changed, 1 deletion(-) (limited to 'java/src/com/android/inputmethod/research/LogUnit.java') diff --git a/java/src/com/android/inputmethod/research/LogUnit.java b/java/src/com/android/inputmethod/research/LogUnit.java index c1258f496..839e2b7ba 100644 --- a/java/src/com/android/inputmethod/research/LogUnit.java +++ b/java/src/com/android/inputmethod/research/LogUnit.java @@ -16,7 +16,6 @@ package com.android.inputmethod.research; -import android.content.SharedPreferences; import android.os.SystemClock; import android.text.TextUtils; import android.util.JsonWriter; -- cgit v1.2.3-83-g751a From 220b271dfa59eeeeba6771175934464a48ac5466 Mon Sep 17 00:00:00 2001 From: Jean Chalard Date: Thu, 14 Feb 2013 14:18:55 -0800 Subject: [Lazy4] Remove useless debug code This code is cluttering readability and getting in the way of future updates. Future updates will make it much easier to debug and to test this code, so this needs to disappear. Change-Id: I32e28ec608587b6b7c07250a2692b13e8fc98465 --- .../com/android/inputmethod/research/LogUnit.java | 33 ---------------------- 1 file changed, 33 deletions(-) (limited to 'java/src/com/android/inputmethod/research/LogUnit.java') diff --git a/java/src/com/android/inputmethod/research/LogUnit.java b/java/src/com/android/inputmethod/research/LogUnit.java index 839e2b7ba..61b6df0f4 100644 --- a/java/src/com/android/inputmethod/research/LogUnit.java +++ b/java/src/com/android/inputmethod/research/LogUnit.java @@ -119,22 +119,6 @@ public class LogUnit { */ public synchronized void publishTo(final ResearchLog researchLog, final boolean canIncludePrivateData) { - // Prepare debugging output if necessary - final StringWriter debugStringWriter; - final JsonWriter debugJsonWriter; - if (DEBUG) { - debugStringWriter = new StringWriter(); - debugJsonWriter = new JsonWriter(debugStringWriter); - debugJsonWriter.setIndent(" "); - try { - debugJsonWriter.beginArray(); - } catch (IOException e) { - Log.e(TAG, "Could not open array in JsonWriter", e); - } - } else { - debugStringWriter = null; - debugJsonWriter = null; - } // Write out any logStatement that passes the privacy filter. final int size = mLogStatementList.size(); if (size != 0) { @@ -157,29 +141,12 @@ public class LogUnit { outputLogUnitStart(jsonWriter, canIncludePrivateData); } logStatement.outputToLocked(jsonWriter, mTimeList.get(i), mValuesList.get(i)); - if (DEBUG) { - logStatement.outputToLocked(debugJsonWriter, mTimeList.get(i), - mValuesList.get(i)); - } } if (jsonWriter != null) { // We must have called logUnitStart earlier, so emit a logUnitStop. outputLogUnitStop(jsonWriter); } } - if (DEBUG) { - try { - debugJsonWriter.endArray(); - debugJsonWriter.flush(); - } catch (IOException e) { - Log.e(TAG, "Could not close array in JsonWriter", e); - } - final String bigString = debugStringWriter.getBuffer().toString(); - final String[] lines = bigString.split("\n"); - for (String line : lines) { - Log.d(TAG, line); - } - } } private static final String WORD_KEY = "_wo"; -- cgit v1.2.3-83-g751a