From 1c2f33223995d8a6c069a85655f790388cd4e581 Mon Sep 17 00:00:00 2001 From: "Tadashi G. Takaoka" Date: Mon, 27 Aug 2012 14:43:39 +0900 Subject: Optimize gesture preview trail drawing a bit This change also change the fading out duration of the gesture preview trail to 800msec from 1,000msec Change-Id: Icfd5b1ecad66db4f978249486f5fe362a3ae9640 --- .../keyboard/internal/GesturePreviewTrail.java | 25 +++++++++++++--------- 1 file changed, 15 insertions(+), 10 deletions(-) (limited to 'java/src') diff --git a/java/src/com/android/inputmethod/keyboard/internal/GesturePreviewTrail.java b/java/src/com/android/inputmethod/keyboard/internal/GesturePreviewTrail.java index 747627b7d..e814d8009 100644 --- a/java/src/com/android/inputmethod/keyboard/internal/GesturePreviewTrail.java +++ b/java/src/com/android/inputmethod/keyboard/internal/GesturePreviewTrail.java @@ -32,6 +32,7 @@ class GesturePreviewTrail { private final ResizableIntArray mEventTimes = new ResizableIntArray(DEFAULT_CAPACITY); private int mCurrentStrokeId = -1; private long mCurrentDownTime; + private int mTrailStartIndex; // Use this value as imaginary zero because x-coordinates may be zero. private static final int DOWN_EVENT_MARKER = -128; @@ -80,7 +81,7 @@ class GesturePreviewTrail { if (isNewStroke) { final int elapsedTime = (int)(downTime - mCurrentDownTime); final int[] eventTimes = mEventTimes.getPrimitiveArray(); - for (int i = 0; i < trailSize; i++) { + for (int i = mTrailStartIndex; i < trailSize; i++) { eventTimes[i] -= elapsedTime; } @@ -122,13 +123,14 @@ class GesturePreviewTrail { final int lingeringDuration = mPreviewParams.mFadeoutStartDelay + mPreviewParams.mFadeoutDuration; int startIndex; - for (startIndex = 0; startIndex < trailSize; startIndex++) { + for (startIndex = mTrailStartIndex; startIndex < trailSize; startIndex++) { final int elapsedTime = sinceDown - eventTimes[startIndex]; // Skip too old trail points. if (elapsedTime < lingeringDuration) { break; } } + mTrailStartIndex = startIndex; if (startIndex < trailSize) { int lastX = getXCoordValue(xCoords[startIndex]); @@ -147,15 +149,18 @@ class GesturePreviewTrail { } } - // TODO: Implement ring buffer to avoid moving points. - // Discard faded out points. final int newSize = trailSize - startIndex; - System.arraycopy(eventTimes, startIndex, eventTimes, 0, newSize); - System.arraycopy(xCoords, startIndex, xCoords, 0, newSize); - System.arraycopy(yCoords, startIndex, yCoords, 0, newSize); - mEventTimes.setLength(newSize); - mXCoordinates.setLength(newSize); - mYCoordinates.setLength(newSize); + if (newSize < startIndex) { + mTrailStartIndex = 0; + if (newSize > 0) { + System.arraycopy(eventTimes, startIndex, eventTimes, 0, newSize); + System.arraycopy(xCoords, startIndex, xCoords, 0, newSize); + System.arraycopy(yCoords, startIndex, yCoords, 0, newSize); + } + mEventTimes.setLength(newSize); + mXCoordinates.setLength(newSize); + mYCoordinates.setLength(newSize); + } return newSize > 0; } } -- cgit v1.2.3-83-g751a