From e86054e5c2e4734d87d2fbf1eeba8c75fc888df0 Mon Sep 17 00:00:00 2001 From: Jean Chalard Date: Fri, 8 Jun 2012 22:21:20 +0900 Subject: Consolidate a test. Stop using the numerical value, use the actual method Change-Id: Iffa7f2d21a0471c7862afd3234cc9c5dd86feb2e --- java/src/com/android/inputmethod/latin/LatinIME.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'java/src') diff --git a/java/src/com/android/inputmethod/latin/LatinIME.java b/java/src/com/android/inputmethod/latin/LatinIME.java index 4670bedb4..899c98067 100644 --- a/java/src/com/android/inputmethod/latin/LatinIME.java +++ b/java/src/com/android/inputmethod/latin/LatinIME.java @@ -391,6 +391,8 @@ public class LatinIME extends InputMethodService implements KeyboardActionListen Utils.GCUtils.getInstance().reset(); boolean tryGC = true; + // Shouldn't this be removed? I think that from Honeycomb on, the GC is now actually working + // as expected and this code is useless. for (int i = 0; i < Utils.GCUtils.GC_TRY_LOOP_MAX && tryGC; ++i) { try { initSuggest(); @@ -762,6 +764,7 @@ public class LatinIME extends InputMethodService implements KeyboardActionListen composingSpanEnd, mExpectingUpdateSelection, expectingUpdateSelectionFromLogger, mConnection); if (expectingUpdateSelectionFromLogger) { + // TODO: Investigate. Quitting now sounds wrong - we won't do the resetting work return; } } @@ -1626,7 +1629,7 @@ public class LatinIME extends InputMethodService implements KeyboardActionListen public boolean isSuggestionsRequested() { // TODO: move this method to mSettingsValues return mInputAttributes.mIsSettingsSuggestionStripOn - && (mCurrentSettings.mCorrectionMode > 0 || isShowingSuggestionsStrip()); + && (mCurrentSettings.isCorrectionOn() || isShowingSuggestionsStrip()); } public boolean isShowingPunctuationList() { -- cgit v1.2.3-83-g751a