From f4131e3f531b20c6f9105ef1836f1ff8b004499c Mon Sep 17 00:00:00 2001 From: Yohei Yukawa Date: Wed, 25 Jul 2018 14:38:58 -0700 Subject: Deprecate host-side C++ test in LatinIME Host-side C++ test in LatinIME is no longer actively used and is actually not compatible with Android Studio build. Let's just remove this for now. Bug: 13754552 Bug: 110741422 Test: compile Change-Id: I3e81285fe559022e1a296051036e74d2f2afbf9c --- native/jni/Android.mk | 3 --- native/jni/HostUnitTests.mk | 63 --------------------------------------------- 2 files changed, 66 deletions(-) delete mode 100644 native/jni/HostUnitTests.mk (limited to 'native') diff --git a/native/jni/Android.mk b/native/jni/Android.mk index 53846485f..893a60dde 100644 --- a/native/jni/Android.mk +++ b/native/jni/Android.mk @@ -95,9 +95,6 @@ include $(BUILD_SHARED_LIBRARY) #################### Clean up the tmp vars include $(LOCAL_PATH)/CleanupNativeFileList.mk -#################### Unit test on host environment -include $(LOCAL_PATH)/HostUnitTests.mk - #################### Unit test on target environment include $(LOCAL_PATH)/TargetUnitTests.mk //LOCAL_CFLAGS += -Wall -Werror diff --git a/native/jni/HostUnitTests.mk b/native/jni/HostUnitTests.mk deleted file mode 100644 index 94cd764b4..000000000 --- a/native/jni/HostUnitTests.mk +++ /dev/null @@ -1,63 +0,0 @@ -# Copyright (C) 2014 The Android Open Source Project -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -# Host build is never supported in unbundled (NDK/tapas) build -ifeq (,$(TARGET_BUILD_APPS)) - -# HACK: Temporarily disable host tool build on Mac until the build system is ready for C++11. -LATINIME_HOST_OSNAME := $(shell uname -s) -ifneq ($(LATINIME_HOST_OSNAME), Darwin) # TODO: Remove this - -LOCAL_PATH := $(call my-dir) - -###################################### -include $(CLEAR_VARS) - -include $(LOCAL_PATH)/NativeFileList.mk - -#################### Host library for unit test -LATIN_IME_SRC_DIR := src -LOCAL_ADDRESS_SANITIZER := true -LOCAL_CFLAGS += -Wno-unused-parameter -Wno-unused-function -Wall -Werror -LOCAL_CXX_STL := libc++ -LOCAL_C_INCLUDES += $(LOCAL_PATH)/$(LATIN_IME_SRC_DIR) -LOCAL_MODULE := liblatinime_host_static_for_unittests -LOCAL_MODULE_TAGS := optional -LOCAL_SRC_FILES := $(addprefix $(LATIN_IME_SRC_DIR)/, $(LATIN_IME_CORE_SRC_FILES)) -include $(BUILD_HOST_STATIC_LIBRARY) - -#################### Host native tests -include $(CLEAR_VARS) -LATIN_IME_TEST_SRC_DIR := tests -LOCAL_ADDRESS_SANITIZER := true -LOCAL_CFLAGS += -Wno-unused-parameter -Wno-unused-function -LOCAL_CFLAGS += -Wall -Werror -LOCAL_CXX_STL := libc++ -LOCAL_C_INCLUDES += $(LOCAL_PATH)/$(LATIN_IME_SRC_DIR) -LOCAL_MODULE := liblatinime_host_unittests -LOCAL_MODULE_TAGS := tests -LOCAL_SRC_FILES := $(addprefix $(LATIN_IME_TEST_SRC_DIR)/, $(LATIN_IME_CORE_TEST_FILES)) -LOCAL_STATIC_LIBRARIES += liblatinime_host_static_for_unittests -include $(BUILD_HOST_NATIVE_TEST) - -include $(LOCAL_PATH)/CleanupNativeFileList.mk - -endif # Darwin - TODO: Remove this - -endif # TARGET_BUILD_APPS - -#################### Clean up the tmp vars -LATINIME_HOST_OSNAME := -LATIN_IME_SRC_DIR := -LATIN_IME_TEST_SRC_DIR := -- cgit v1.2.3-83-g751a