diff options
| author |   Jean Chalard <jchalard@google.com> | 2014-01-09 15:38:39 +0900 |
|---|---|---|
| committer | Jean Chalard <jchalard@google.com> | 2014-01-10 15:21:20 +0900 |
| commit | 6fbe83be7af6b15df3ed915b408c8179ca01c0cd (patch) | |
| tree | 81a6200d58e879273b8b5cd19c4aa97985fcd5cc /java/src/com/android/inputmethod/dictionarypack/CommonPreferences.java | |
| parent | 958e4520250e8f2ddcbbbd56afc713262bf1a9f1 (diff) | |
| download | latinime-6fbe83be7af6b15df3ed915b408c8179ca01c0cd.tar.gz latinime-6fbe83be7af6b15df3ed915b408c8179ca01c0cd.tar.xz latinime-6fbe83be7af6b15df3ed915b408c8179ca01c0cd.zip | |
[IL53] Fix a wrong test.
This test was intended only for cases without a selection, and as
a safety net for cases where the app would pretend the cursor
is at N but we can get P chars from the editor where P > N.
When there is a selection, this is wrong. In the practice it works
because these values are not used in this case, but it's still wrong.
The case where P > N is arguable, but actually I see little reason
to trust the getTextBeforeCursor() method more than the
onUpdate selection method. Plus in the practice, I don't think
we are aware of any app with this bug, and it's probably not a
great idea to be too robust about this as it may encourage wrong
values sent to onUpdateSelection.
Change-Id: I42f2065d7aee668074e6b8e40b259da7e88e16e1
Diffstat (limited to 'java/src/com/android/inputmethod/dictionarypack/CommonPreferences.java')
0 files changed, 0 insertions, 0 deletions