diff options
author | 2013-01-09 21:08:58 +0900 | |
---|---|---|
committer | 2013-01-09 21:08:58 +0900 | |
commit | ae74b8cf67ca569b5686214276d56b992cf4557e (patch) | |
tree | a5b9a58d9294ce04776542e9fb2995c992e8ba19 /java/src/com/android/inputmethod/event/HardwareKeyboardEventDecoder.java | |
parent | 8315e8168b135599237f5493f72e667f39503006 (diff) | |
download | latinime-ae74b8cf67ca569b5686214276d56b992cf4557e.tar.gz latinime-ae74b8cf67ca569b5686214276d56b992cf4557e.tar.xz latinime-ae74b8cf67ca569b5686214276d56b992cf4557e.zip |
Abandon the idea of an Event pool and make Event immutable (B1)
Change-Id: I750a07c0c564a95ceac734afa873ca3da9626a7f
Diffstat (limited to 'java/src/com/android/inputmethod/event/HardwareKeyboardEventDecoder.java')
-rw-r--r-- | java/src/com/android/inputmethod/event/HardwareKeyboardEventDecoder.java | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/java/src/com/android/inputmethod/event/HardwareKeyboardEventDecoder.java b/java/src/com/android/inputmethod/event/HardwareKeyboardEventDecoder.java index 2dbc9f00b..554319e51 100644 --- a/java/src/com/android/inputmethod/event/HardwareKeyboardEventDecoder.java +++ b/java/src/com/android/inputmethod/event/HardwareKeyboardEventDecoder.java @@ -38,7 +38,6 @@ public class HardwareKeyboardEventDecoder implements HardwareEventDecoder { @Override public Event decodeHardwareKey(final KeyEvent keyEvent) { - final Event event = Event.obtainEvent(); // KeyEvent#getUnicodeChar() does not exactly returns a unicode char, but rather a value // that includes both the unicode char in the lower 21 bits and flags in the upper bits, // hence the name "codePointAndFlags". {@see KeyEvent#getUnicodeChar()} for more info. @@ -48,22 +47,20 @@ public class HardwareKeyboardEventDecoder implements HardwareEventDecoder { // the key for 'A' or Space, but also Backspace or Ctrl or Caps Lock. final int keyCode = keyEvent.getKeyCode(); if (KeyEvent.KEYCODE_DEL == keyCode) { - event.setCommittableEvent(Constants.CODE_DELETE); - return event; + return Event.createCommittableEvent(Constants.CODE_DELETE); } if (keyEvent.isPrintingKey() || KeyEvent.KEYCODE_SPACE == keyCode || KeyEvent.KEYCODE_ENTER == keyCode) { if (0 != (codePointAndFlags & KeyCharacterMap.COMBINING_ACCENT)) { // A dead key. - event.setDeadEvent(codePointAndFlags & KeyCharacterMap.COMBINING_ACCENT_MASK); + return Event.createDeadEvent(codePointAndFlags & KeyCharacterMap.COMBINING_ACCENT_MASK); } else { // A committable character. This should be committed right away, taking into // account the current state. - event.setCommittableEvent(codePointAndFlags); + return Event.createCommittableEvent(codePointAndFlags); } } else { - event.setNotHandledEvent(); + return Event.createNotHandledEvent(); } - return event; } } |