aboutsummaryrefslogtreecommitdiffstats
path: root/java/src/com/android/inputmethod/latin/userdictionary/UserDictionarySettings.java
diff options
context:
space:
mode:
authorJean Chalard <jchalard@google.com>2014-02-20 14:18:14 +0900
committerJean Chalard <jchalard@google.com>2014-02-20 14:40:38 +0900
commitc44b7312ad60c76ddd1c303d10b4f8e66ea9e605 (patch)
treece068989eef02e3d0eff34717400ab4c99253343 /java/src/com/android/inputmethod/latin/userdictionary/UserDictionarySettings.java
parent3a7ed5fdfe5e2ceaabe80532a75380e2c6c1e012 (diff)
downloadlatinime-c44b7312ad60c76ddd1c303d10b4f8e66ea9e605.tar.gz
latinime-c44b7312ad60c76ddd1c303d10b4f8e66ea9e605.tar.xz
latinime-c44b7312ad60c76ddd1c303d10b4f8e66ea9e605.zip
Remove a call to a deprecated method
...that would cause a crash Bug: 13082186 Change-Id: Ie12575c27dfdd2029bc9d5f0647e444f69770afc
Diffstat (limited to 'java/src/com/android/inputmethod/latin/userdictionary/UserDictionarySettings.java')
-rw-r--r--java/src/com/android/inputmethod/latin/userdictionary/UserDictionarySettings.java5
1 files changed, 4 insertions, 1 deletions
diff --git a/java/src/com/android/inputmethod/latin/userdictionary/UserDictionarySettings.java b/java/src/com/android/inputmethod/latin/userdictionary/UserDictionarySettings.java
index 220efb5d3..cf2014a1a 100644
--- a/java/src/com/android/inputmethod/latin/userdictionary/UserDictionarySettings.java
+++ b/java/src/com/android/inputmethod/latin/userdictionary/UserDictionarySettings.java
@@ -141,7 +141,10 @@ public class UserDictionarySettings extends ListFragment {
mLocale = locale;
// WARNING: The following cursor is never closed! TODO: don't put that in a member, and
- // make sure all cursors are correctly closed.
+ // make sure all cursors are correctly closed. Also, this comes from a call to
+ // Activity#managedQuery, which has been deprecated for a long time (and which FORBIDS
+ // closing the cursor, so take care when resolving this TODO). We should either use a
+ // regular query and close the cursor, or switch to a LoaderManager and a CursorLoader.
mCursor = createCursor(locale);
TextView emptyView = (TextView) getView().findViewById(android.R.id.empty);
emptyView.setText(R.string.user_dict_settings_empty_text);