aboutsummaryrefslogtreecommitdiffstats
path: root/java/src/com/android/inputmethod/research/ResearchLogger.java
diff options
context:
space:
mode:
authorKurt Partridge <kep@google.com>2013-05-14 12:01:55 -0700
committerKurt Partridge <kep@google.com>2013-05-14 12:20:27 -0700
commit993acbaaa27505c8b1b95b66caf70ee98145b55c (patch)
treebf95c3e0ea083be53010ef0408005eb8029dbcbc /java/src/com/android/inputmethod/research/ResearchLogger.java
parent7b0a14895100c4af8b6ed8b33f8885f77cccf62c (diff)
downloadlatinime-993acbaaa27505c8b1b95b66caf70ee98145b55c.tar.gz
latinime-993acbaaa27505c8b1b95b66caf70ee98145b55c.tar.xz
latinime-993acbaaa27505c8b1b95b66caf70ee98145b55c.zip
Remove unnecessary commit/uncommit
When the user reverts a commit, this causes the committed word to be changed. The user usually then goes back to edit that word. Going back to edit causes an uncommit, so that the editing actions are added onto the LogUnit containing the operations used to construct the word. But currently, reverting also involves its own commit/uncommit pair, with the caller performing the uncommit, and the commit happening inside the revert command. This may have been necessary in the past, when revert was called in different situations, but is unnecessary now. Furthermore, the guarding conditions are currently such that the uncommit doesn't always undo the effects of the commit, corrupting the log output. Change-Id: I74af41f4f1db2fcabfa496dcc4a2d7bd0af19b3a
Diffstat (limited to 'java/src/com/android/inputmethod/research/ResearchLogger.java')
-rw-r--r--java/src/com/android/inputmethod/research/ResearchLogger.java1
1 files changed, 0 insertions, 1 deletions
diff --git a/java/src/com/android/inputmethod/research/ResearchLogger.java b/java/src/com/android/inputmethod/research/ResearchLogger.java
index 8b8ea21e9..c5a6f6bae 100644
--- a/java/src/com/android/inputmethod/research/ResearchLogger.java
+++ b/java/src/com/android/inputmethod/research/ResearchLogger.java
@@ -1418,7 +1418,6 @@ public class ResearchLogger implements SharedPreferences.OnSharedPreferenceChang
logUnit.setContainsCorrection();
}
researchLogger.mStatistics.recordRevertCommit(SystemClock.uptimeMillis());
- researchLogger.commitCurrentLogUnitAsWord(originallyTypedWord, Long.MAX_VALUE, isBatchMode);
}
/**