diff options
author | 2013-06-26 11:32:07 +0900 | |
---|---|---|
committer | 2013-06-26 15:28:42 +0900 | |
commit | 7fcf304c974d52a816b3375f22e714798fe308e5 (patch) | |
tree | 975aeaf5cd6d2e765143e296dcc202f3292dae00 /java/src/com/android/inputmethod | |
parent | fd0945b0da3e53109afc346432a7a8b40d715a0f (diff) | |
download | latinime-7fcf304c974d52a816b3375f22e714798fe308e5.tar.gz latinime-7fcf304c974d52a816b3375f22e714798fe308e5.tar.xz latinime-7fcf304c974d52a816b3375f22e714798fe308e5.zip |
Fixing follow-up to I548d899b
I548d899b introduced a new method to fix a sync miss between
the cursor position and the cached cursor position, but did not
take into account that it should also update the cached text
before and after the cursor in this case and that there was
already a method for doing this.
Change-Id: I31bd741893207c822827304e77791b1159774e1a
Diffstat (limited to 'java/src/com/android/inputmethod')
-rw-r--r-- | java/src/com/android/inputmethod/latin/LatinIME.java | 8 | ||||
-rw-r--r-- | java/src/com/android/inputmethod/latin/RichInputConnection.java | 8 |
2 files changed, 7 insertions, 9 deletions
diff --git a/java/src/com/android/inputmethod/latin/LatinIME.java b/java/src/com/android/inputmethod/latin/LatinIME.java index 6fcac9a65..9ef273918 100644 --- a/java/src/com/android/inputmethod/latin/LatinIME.java +++ b/java/src/com/android/inputmethod/latin/LatinIME.java @@ -968,6 +968,13 @@ public class LatinIME extends InputMethodService implements KeyboardActionListen // text, but that is probably too expensive to do, so we decided to leave things // as is. resetEntireInputState(newSelStart); + } else { + // resetEntireInputState calls resetCachesUponCursorMove, but with the second + // argument as true. But in all cases where we don't reset the entire input state, + // we still want to tell the rich input connection about the new cursor position so + // that it can update its caches. + mConnection.resetCachesUponCursorMove(newSelStart, + false /* shouldFinishComposition */); } // We moved the cursor. If we are touching a word, we need to resume suggestion, @@ -975,7 +982,6 @@ public class LatinIME extends InputMethodService implements KeyboardActionListen if (isSuggestionsStripVisible()) { mHandler.postResumeSuggestions(); } - mConnection.userMovedCursor(newSelEnd); // Reset the last recapitalization. mRecapitalizeStatus.deactivate(); mKeyboardSwitcher.updateShiftState(); diff --git a/java/src/com/android/inputmethod/latin/RichInputConnection.java b/java/src/com/android/inputmethod/latin/RichInputConnection.java index 6e3e7b218..5391b1303 100644 --- a/java/src/com/android/inputmethod/latin/RichInputConnection.java +++ b/java/src/com/android/inputmethod/latin/RichInputConnection.java @@ -730,14 +730,6 @@ public final class RichInputConnection { } /** - * The user moved the cursor by hand. Take a note of it. - * @param newCursorPosition The new cursor position. - */ - public void userMovedCursor(final int newCursorPosition) { - mCurrentCursorPosition = newCursorPosition; - } - - /** * Looks at the text just before the cursor to find out if it looks like a URL. * * The weakest point here is, if we don't have enough text bufferized, we may fail to realize |