diff options
author | 2012-07-11 16:47:22 +0900 | |
---|---|---|
committer | 2012-07-12 14:30:30 +0900 | |
commit | 3b57631b60c696d407a73e7594f6ab2418932229 (patch) | |
tree | aecbc7c586f3cc6ea041bbe6687d6cb4febb629e /java/src | |
parent | 18d76afa911f5b236901eed6eba48a801dfdaafa (diff) | |
download | latinime-3b57631b60c696d407a73e7594f6ab2418932229.tar.gz latinime-3b57631b60c696d407a73e7594f6ab2418932229.tar.xz latinime-3b57631b60c696d407a73e7594f6ab2418932229.zip |
Resolve a TODO: bury some implementation detail in native (A110)
The fact that prediction does not accept a null argument is an
implementation detail, it should not be visible to Java code.
Change-Id: I3a156b323b6db9353de898d33f3f7c81751cecb1
Diffstat (limited to 'java/src')
-rw-r--r-- | java/src/com/android/inputmethod/latin/BinaryDictionary.java | 2 | ||||
-rw-r--r-- | java/src/com/android/inputmethod/latin/Suggest.java | 10 |
2 files changed, 4 insertions, 8 deletions
diff --git a/java/src/com/android/inputmethod/latin/BinaryDictionary.java b/java/src/com/android/inputmethod/latin/BinaryDictionary.java index 3b3315d3a..feff2f2c9 100644 --- a/java/src/com/android/inputmethod/latin/BinaryDictionary.java +++ b/java/src/com/android/inputmethod/latin/BinaryDictionary.java @@ -122,8 +122,6 @@ public class BinaryDictionary extends Dictionary { } } - // TODO: move this test to native code. - if (composerSize <= 1 && TextUtils.isEmpty(prevWord)) return null; final InputPointers ips = composer.getInputPointers(); final int codesSize = isGesture ? ips.getPointerSize() : composerSize; // proximityInfo and/or prevWordForBigrams may not be null. diff --git a/java/src/com/android/inputmethod/latin/Suggest.java b/java/src/com/android/inputmethod/latin/Suggest.java index 31c6000e3..bbd415f68 100644 --- a/java/src/com/android/inputmethod/latin/Suggest.java +++ b/java/src/com/android/inputmethod/latin/Suggest.java @@ -194,12 +194,10 @@ public class Suggest { } if (wordComposerForLookup.size() <= 1) { // At first character typed, search only the bigrams - if (!TextUtils.isEmpty(prevWordForBigram)) { - for (final String key : mDictionaries.keySet()) { - final Dictionary dictionary = mDictionaries.get(key); - suggestionsSet.addAll(dictionary.getSuggestions(wordComposerForLookup, - prevWordForBigram, proximityInfo)); - } + for (final String key : mDictionaries.keySet()) { + final Dictionary dictionary = mDictionaries.get(key); + suggestionsSet.addAll(dictionary.getSuggestions( + wordComposerForLookup, prevWordForBigram, proximityInfo)); } } else { // At second character typed, search the unigrams (scores being affected by bigrams) |