aboutsummaryrefslogtreecommitdiffstats
path: root/java/src
diff options
context:
space:
mode:
authorSatoshi Kataoka <satok@google.com>2013-10-08 03:12:41 -0700
committerAndroid Git Automerger <android-git-automerger@android.com>2013-10-08 03:12:41 -0700
commit67aa1a93f8376d73511ca6d08052298326eb3b44 (patch)
tree3c7d3bf704bef15c6596fc05ebb8c5221579ad67 /java/src
parent87f060338043ed57e8064594d632be450536ee73 (diff)
parent2d3e121014a97b7de90f287f1ef82fa98f37007c (diff)
downloadlatinime-67aa1a93f8376d73511ca6d08052298326eb3b44.tar.gz
latinime-67aa1a93f8376d73511ca6d08052298326eb3b44.tar.xz
latinime-67aa1a93f8376d73511ca6d08052298326eb3b44.zip
am 2d3e1210: Fix memory leak in EmojiPaletteView
* commit '2d3e121014a97b7de90f287f1ef82fa98f37007c': Fix memory leak in EmojiPaletteView
Diffstat (limited to 'java/src')
-rw-r--r--java/src/com/android/inputmethod/keyboard/EmojiPalettesView.java9
1 files changed, 6 insertions, 3 deletions
diff --git a/java/src/com/android/inputmethod/keyboard/EmojiPalettesView.java b/java/src/com/android/inputmethod/keyboard/EmojiPalettesView.java
index ef9448c2f..5c518b8f1 100644
--- a/java/src/com/android/inputmethod/keyboard/EmojiPalettesView.java
+++ b/java/src/com/android/inputmethod/keyboard/EmojiPalettesView.java
@@ -694,13 +694,16 @@ public final class EmojiPalettesView extends LinearLayout implements OnTabChange
@Override
public void destroyItem(final ViewGroup container, final int position,
final Object object) {
- ScrollKeyboardView keyboardView = mActiveKeyboardViews.get(position);
+ final ScrollKeyboardView keyboardView = mActiveKeyboardViews.get(position);
if (keyboardView != null) {
keyboardView.deallocateMemory();
mActiveKeyboardViews.remove(position);
}
- container.removeView(keyboardView);
- keyboardView = null;
+ if (object instanceof View) {
+ container.removeView((View)object);
+ } else {
+ Log.w(TAG, "Warning!!! Emoji palette may be leaking. " + object);
+ }
}
}