aboutsummaryrefslogtreecommitdiffstats
path: root/java
diff options
context:
space:
mode:
authorJean Chalard <jchalard@google.com>2014-10-23 12:36:42 +0900
committerJean Chalard <jchalard@google.com>2014-10-23 12:36:42 +0900
commit4097a20b36c7a6678f2b7486d587b7c43852c2e1 (patch)
tree3f3b7b008adb9ed87d0475c6e91c08b7e82668be /java
parentd3a4c5132422b189c8dbb94dbbe84a9b9761b0a8 (diff)
downloadlatinime-4097a20b36c7a6678f2b7486d587b7c43852c2e1.tar.gz
latinime-4097a20b36c7a6678f2b7486d587b7c43852c2e1.tar.xz
latinime-4097a20b36c7a6678f2b7486d587b7c43852c2e1.zip
Fix a concurrency bug that ends up in a crash.
Bug: 18085768 Change-Id: I016bec997787839526ddfc521ebb99d0c7b05189
Diffstat (limited to 'java')
-rw-r--r--java/src/com/android/inputmethod/latin/RichInputConnection.java4
1 files changed, 3 insertions, 1 deletions
diff --git a/java/src/com/android/inputmethod/latin/RichInputConnection.java b/java/src/com/android/inputmethod/latin/RichInputConnection.java
index be1523f63..69f0b3eb3 100644
--- a/java/src/com/android/inputmethod/latin/RichInputConnection.java
+++ b/java/src/com/android/inputmethod/latin/RichInputConnection.java
@@ -367,7 +367,9 @@ public final class RichInputConnection implements PrivateCommandPerformer {
}
// This never calls InputConnection#getCapsMode - in fact, it's a static method that
// never blocks or initiates IPC.
- return CapsModeUtils.getCapsMode(mCommittedTextBeforeComposingText, inputType,
+ // TODO: don't call #toString() here. Instead, all accesses to
+ // mCommittedTextBeforeComposingText should be done on the main thread.
+ return CapsModeUtils.getCapsMode(mCommittedTextBeforeComposingText.toString(), inputType,
spacingAndPunctuations, hasSpaceBefore);
}