| Commit message (Expand) | Author | Age | Files | Lines |
* | Use Java 7 diamond operator•••Change-Id: If16ef50ae73147594615d0f49d6a22621eaf1aef
|  Tadashi G. Takaoka | 2014-05-24 | 1 | -3/+2 |
* | Check the md5 checksum of the copied file.•••If it doesn't match, mark it broken. It means the dictionary pack
will try to install it again next time it updates. We may want to
rethink this.
Bug: 13125743
Change-Id: I0eb547aa7066bed8cb00c009debbafe9181c37ad
|  Jean Chalard | 2014-05-22 | 1 | -2/+12 |
* | Arrange to send the rawChecksum to LatinIME.•••Bug: 13125743
Change-Id: I5d111336e6a0f5ab4e93ff333654a7a1f8f46480
|  Jean Chalard | 2014-05-22 | 1 | -1/+2 |
* | Straighten out database cursors behavior.•••Some were never closed, other closed twice. This change
makes all Cursor instances behave, having the #close()
call in a finally{} clause, and puts the burden of closing
the cursor squarely on the creator rather than in the
called methods.
There is however one exception that is beyond the scope
of this change: UserDictionarySettings have a Cursor
member, it's never closed, and fixing the problem is not
obvious. This change adds a TODO for now.
It's not very clear if this change actually helps with
bug#12670151, but it may be related and it's a good
think to do anyway.
Bug: 12670151
Change-Id: I87cc44387e7dee3da1488671b93a28d9d73f7dc0
|  Jean Chalard | 2014-02-18 | 1 | -11/+12 |
* | Reset to 9bd6dac4708ad94fd0257c53e977df62b152e20c•••The bulk merge from -bayo to klp-dev should not have been merged to master.
Change-Id: I527a03a76f5247e4939a672f27c314dc11cbb854
|  Ken Wakasa | 2013-12-13 | 1 | -8/+18 |
* | Move settings related classes to "settings"•••Change-Id: Id170dbfe2dcfc93130b7be4a84615940403ec37f
|  Ken Wakasa | 2013-07-22 | 1 | -0/+1 |
* | Add a trace.•••Emit a trace when a new dictionary is copied to LatinIME
successfully, not just when it fails. That will help diagnosing
some problems by being able to ensure this step succeeded
looking at the log.
This does not happen often (like, maybe 3 times at device
activation, and once every few weeks afterwards), so I think
the extra line in the log is more than acceptable.
Change-Id: I1674bc22d950a7be801076c5aa7e8bbebccab14b
|  Jean Chalard | 2013-07-05 | 1 | -0/+1 |
* | Fix a bug where AOSP Latin IME would not fill dictionaries•••There is no reason not to contact the dictionary provider
when we don't have internet permission or when the URL
is empty. It knows how to handle both these cases.
Bug: 9388602
Change-Id: I30c4540551ad2f5e527d3acd1842bbd749feca89
|  Jean Chalard | 2013-06-28 | 1 | -1/+0 |
* | Move util classes to the latin/utils directory•••Change-Id: I1c5b27c8edf231680edb8d96f63b9d04cfc6a6fa
|  Ken Wakasa | 2013-06-24 | 1 | -1/+4 |
* | Merge "Catch a permission exception" |  Kurt Partridge | 2013-05-31 | 1 | -1/+7 |
|\ |
|
| * | Catch a permission exception•••This change catches a SecurityException if the DictionaryProvider is
unavailable.
Change-Id: I4f2d87327c40765383d8847fd4e934b3cf799488
|  Kurt Partridge | 2013-05-30 | 1 | -1/+7 |
* | | Fix two strict mode warnings.•••Bug: 9052555
Change-Id: I86e90488679a78a9f6e901b640025619293765a0
|  Jean Chalard | 2013-05-30 | 1 | -14/+27 |
|/ |
|
* | Cleanup an unused return value•••Change-Id: I974964aa3cc24b5480e57bd38c197fe7a49acaa4
|  Ken Wakasa | 2013-04-30 | 1 | -18/+10 |
* | Add an additional ID to the client info.•••Bug: 8651863
Change-Id: I748f35726d72ede926d5b06ed87ff029317f1ac3
|  Jean Chalard | 2013-04-23 | 1 | -0/+3 |
* | Add a class to encapsulate getting the metadata URI•••Bug: 8376173
Change-Id: Icaac8ad412e0180c44e6a955943e3b208981b2ea
|  Jean Chalard | 2013-04-11 | 1 | -1/+1 |
* | Ask the client to make itself known when it's not•••Upon invoking the settings of the dictionary pack with an unknown
client, we now launch an intent to ask the client to make itself known.
This change also includes the code that receives this intent and
acts upon it.
Bug: 8492879
Change-Id: I2c6496dea845646961ecafcf64e282cb93ee91dc
|  Jean Chalard | 2013-04-01 | 1 | -0/+21 |
* | Break dependencies to allow offdevice tests to build•••Change-Id: Ia9a2e8f0672b3f72943f26fb15de1d3c7c5ce7f1
|  Jean Chalard | 2013-03-19 | 1 | -2/+2 |
* | Implement getting data files with protocol v2•••This also does it for deleting them
Bug: 8167342
Bug: 6789534
Change-Id: I1823f98508881f109a667146d3608003f87aa4cb
|  Jean Chalard | 2013-02-15 | 1 | -26/+55 |
* | Determine the protocol version of the dictionary pack•••...for query.
Bug: 8167342
Change-Id: Ieb8e5b31c4b62bf507593c4631e31799aad5f267
|  Jean Chalard | 2013-02-13 | 1 | -14/+44 |
* | Clean up dictionary pack presence test.•••This method is much cleaner and much more readable.
Change-Id: I8055c169ef7c4453ab45c463704bd56a6080da4f
|  Jean Chalard | 2013-02-12 | 1 | -39/+21 |
* | Some cleanups•••Improve a slew of logging statements, and put commands that we don't
expect to need protecting against exceptions out of a try {} block.
This is a followup to Id3dc510a
Change-Id: Idc6f419ac095b5b0f2d6862d58926ef888cb34e6
|  Jean Chalard | 2013-02-11 | 1 | -18/+21 |
* | Remove unnecessary whitespace•••This is a cleanup followup to Id3dc510a
Change-Id: Ie64395eb4b6218fd8c73cacddeed2fba1df65d26
|  Jean Chalard | 2013-02-11 | 1 | -1/+1 |
* | Don't try to issue delete() commands on missing provider•••Bug: 8173622
Change-Id: Id3dc510ae3535169b5290e87075cb2f433a1f603
|  Jean Chalard | 2013-02-11 | 1 | -21/+50 |
* | [B14] Implement sending the dictionary list.•••Bug: 7005813
Change-Id: Ic3ef69510d2b385d0d403191b2f701b6527d0166
|  Jean Chalard | 2013-02-06 | 1 | -1/+17 |
* | [B11] Implement reset and passing of the URL to the dict pack•••Bug: 7601410
Bug: 7595195
Change-Id: I78cf04dce7c1e64de6725d32317de288a83bd39d
|  Jean Chalard | 2013-02-06 | 1 | -1/+27 |
* | [B9] Pass the client id parameter for dict info requests•••Bug: 6789534
Change-Id: Ie3ea75b19ae4da2dea531e0077c58742a9502bc6
|  Jean Chalard | 2013-02-02 | 1 | -1/+12 |
* | Make some strings private•••Change-Id: I0ffdbcf6bede86a3cdcb3a0e4ec263398502617c
|  Jean Chalard | 2013-02-02 | 1 | -5/+5 |
* | Refactoring•••This creates a new DictionaryInfoUtils class and moves a bunch
of static methods there for later usage.
Change-Id: Iecb0643e6029a7be36bd6cb36aa918c40e6d8c6a
|  Jean Chalard | 2013-01-29 | 1 | -1/+1 |
* | Fix Apache license comment•••Change-Id: Ic56167f952a7f4449da366e1e81610e72c966086
|  Tadashi G. Takaoka | 2013-01-21 | 1 | -8/+8 |
* | [AD4] Actually copy the file in place.•••This finally makes it work.
Bug: 7702011
Change-Id: I3508c88567f79598e4d1dff561b6ba7dc5c3808f
|  Jean Chalard | 2013-01-21 | 1 | -12/+12 |
* | am 18ff5612: am f592270a: am 7648b37d: Merge "Make sure all FDs are correctly...•••* commit '18ff56125345746e288118d177fcabf3c079ead3':
Make sure all FDs are correctly closed.
|  Jean Chalard | 2012-11-13 | 1 | -11/+19 |
|\ |
|
| * | Make sure all FDs are correctly closed.•••In this kind of series of calls, it's possible that an outer call to a
constructor fails, but the inner succeeded.
Example:
try {
is = new A(new B());
} finally {
if (null != is) is.close();
}
In this case, if new B() succeeds but new A() throws an
exception, is stays null and the intermediate object is never
closed. This is what was happening in this instance.
Bug: 7377336
Change-Id: I3fae9fec1135244982fcf5098c76d93f3e0f2add
|  Jean Chalard | 2012-11-13 | 1 | -11/+19 |
* | | Fix the build.•••It seems this change snuck out from a previous version.
Change-Id: I9c33d51273732b1d55bfd60f0957184c86fa88ab
|  Jean Chalard | 2012-10-23 | 1 | -1/+7 |
* | | Add reader and writer for the combined dict format.•••This introduces a new textual format for the dictionary that combines
words, bigrams and shortcuts to avoid complexity. It is also extensible
to n-grams to fool-prof for the future, and easier to read than XML.
Bug: 7388540
Change-Id: I942bbad51bd0c905a5a54c278667563fd6dd66ec
|  Jean Chalard | 2012-10-23 | 1 | -7/+1 |
* | | Make a better choice for the temporary file•••Change-Id: I745bb285b6b52875c8d2b3a94deb962352f9754e
|  Jean Chalard | 2012-10-12 | 1 | -1/+7 |
|/ |
|
* | Put temporary files under a separate directory.•••Bug: 7328003
Change-Id: Ibe5278ea209d149f87fd08785c77b17e3859948e
|  Jean Chalard | 2012-10-11 | 1 | -2/+3 |
* | Unlink an old file before moving the new file over it•••This is unlikely to be relevant to this bug, but just in case.
Bug: 7274972
Change-Id: I56b31b377af16cc2c15ceb90a19792bed3aab367
|  Jean Chalard | 2012-10-04 | 1 | -0/+1 |
* | Cleanup: Make some classes as final•••Change-Id: I6009b3c1950ba32b7f1e205a3db2307fe0cd688e
|  Tadashi G. Takaoka | 2012-09-27 | 1 | -2/+1 |
* | Add CollectionUtils class to create generic collection easily•••Change-Id: I6b4de9187e122298e5e9cd8ddc9070d062df6a89
|  Tadashi G. Takaoka | 2012-08-22 | 1 | -2/+2 |
* | Fix a bad interaction with mmap•••Bug: 6761221
Change-Id: I7e6d98dc9d7cb34a6163c3957e401ff97abb975c
|  Jean Chalard | 2012-07-04 | 1 | -4/+14 |
* | Notify the dictionary pack about copy failures•••Bug: 6532896
Change-Id: I57f7b1a400222c89776f9bff652a7da4470232c5
|  Jean Chalard | 2012-05-23 | 1 | -5/+13 |
* | Remove an updated dictionary that changed locales•••When a dictionary changes locale, we need to remove the file
that corresponds to the old version. It has a different path
than the new one, so we have to search for it explicitly.
Bug: 6540631
Change-Id: Ie9d63ba636651fe90f8fbb9627b7265ac7b34ccd
|  Jean Chalard | 2012-05-23 | 1 | -0/+1 |
* | Allow using a format version 2 word list in LatinIME•••Change-Id: I73a4df3a83e49be6e8d3a7d14eb027cfe10f1a23
|  Jean Chalard | 2012-04-20 | 1 | -7/+13 |
* | Pass a parameter to the dict pack if we don't have a default dict•••Also, optimize quite a bit the code that decides whether we have
a default dict or not.
Bug: 5705834
Change-Id: Ied20fbcbbc42cbe8c01759d11b1804d1156c6960
|  Jean Chalard | 2012-04-12 | 1 | -8/+19 |
* | Fix some obvious compiler warnings•••Change-Id: I10a634f7492b45d5a72345f14d36cf341946387d
|  Tadashi G. Takaoka | 2012-03-29 | 1 | -1/+1 |
* | Correctly close the gzip stream•••I had gotten the chain call in reverse.
Bug: 6177523
Change-Id: Ic5b76425de2d5d05d5132f8d2c7ade0d79c14ccc
|  Jean Chalard | 2012-03-21 | 1 | -2/+2 |
* | Cleanup unused import•••This change also gets rid of several compiler warnings.
Change-Id: I23962edaadad18a6e0395d528af17b909dcf5dad
|  Tadashi G. Takaoka | 2011-10-04 | 1 | -2/+0 |
* | Check the magic number of a decoded file•••Checking the magic number of a file upon decoding is necessary,
because if the file is corrupt and we don't check it, we will
fall back to a simple copy of the corrupted file. Latin IME
would realize this and would not crash, but would not use the
corrupted dictionary. If this happened to be a main dictionary,
then the user would lose the ability to use the correct
built-in dictionary.
Not the same, but kinda similar to
Bug: 5223031
Change-Id: Ic2783dc9dd5f3dcf2865623d9452765fe3778db7
|  Jean Chalard | 2011-08-31 | 1 | -6/+36 |
* | Allow sharing dictionaries between similar locales.•••Bug: 5058488
Change-Id: Ib12013f58afad957a8205b439f87480cc12ea06f
|  Jean Chalard | 2011-08-25 | 1 | -15/+24 |
* | Add a debug variable•••...that was missing
Change-Id: Ia3b17909f295e0a93dee633c8d67c0e03840023e
|  Jean Chalard | 2011-08-24 | 1 | -0/+1 |