| Commit message (Expand) | Author | Age | Files | Lines |
* | Guard against wrong auto-correction cancellation (A6)•••This deactivates the cancellation at each separator pressed while
not composing a word. The net effect is to fix
Bug: 5875776
Change-Id: I67aa3f842ddff250828c60596ad5a7e466c1ddaa
|  Jean Chalard | 2012-01-26 | 1 | -2/+9 |
* | Straighten out resuming suggestion on kept word (A5)•••This is cleanup.
This also introduces a "deactivated" state to the last committed
word, that can be used for
Bug: 5875776
Change-Id: I1855adb8ac8123f6d2c5365b0ae899145e5c3ba1
|  Jean Chalard | 2012-01-26 | 1 | -10/+11 |
* | Remove mCommittedWordSavedForSuggestionResuming (A4)•••Change-Id: Ia62ef33b5c777a258b02280bda1b8368780a7eef
|  Jean Chalard | 2012-01-26 | 1 | -2/+2 |
* | Move some functionality into LastComposedWord (A3)•••Change-Id: Ie0ea02a061dd0cb84db5f33113ff433584636bc7
|  Jean Chalard | 2012-01-26 | 1 | -9/+24 |
* | Add a class for previously composed data (A1)•••Change-Id: I87498799e6a48b8fa65924a098bb0ceb7626dce1
|  Jean Chalard | 2012-01-26 | 1 | -4/+4 |
* | Merge "Warn deprecated privateImeOptions, "nm" and "forceAscii"" |  Tadashi G. Takaoka | 2012-01-25 | 1 | -1/+11 |
|\ |
|
| * | Warn deprecated privateImeOptions, "nm" and "forceAscii"•••Public API EditorInfo.IME_FLAG_FORCE_ASCII has been supported by
I6665b483.
Change-Id: I0ffdee15d8177d126cd8fe86a6bc4ab21be58c36
|  Tadashi G. Takaoka | 2012-01-26 | 1 | -1/+11 |
* | | Merge "Add a guard against OOB." |  Jean Chalard | 2012-01-25 | 1 | -3/+7 |
|\ \ |
|
| * | | Add a guard against OOB.•••...and avoid crashing in one case where the application may
change the text while we are typing.
Bug: 5685922
Change-Id: I4a22c63168986f43ac84f512aaa4267023d536e3
|  Jean Chalard | 2012-01-26 | 1 | -3/+7 |
| |/ |
|
* / | Small cleanup•••All calls to this method are done with the same parameter,
and it's really hard to understand if we call upon this
member inside.
Change-Id: I787664bb59053ab0fe666ed812fb12b2b9090918
|  Jean Chalard | 2012-01-26 | 1 | -1/+1 |
|/ |
|
* | Add a test for auto-correction.•••Fix two related subtle bugs:
- Stop singling out fat-finger-only corrections for rejection
when touch coordinates are not available.
- Remove a racy check that would happen only in debug mode
Change-Id: Ic904f9b27c091ca6b369052c4e65a630bff81257
|  Jean Chalard | 2012-01-25 | 1 | -3/+2 |
* | Fix a bug where backspace would not delete the selection•••Bug: 5699301
Change-Id: I6c5a8470464d045349ac38e191c859b5c34cbeee
|  Jean Chalard | 2012-01-24 | 1 | -5/+27 |
* | Fix a typo•••Change-Id: I358350c959d5610214a752b14d7744fe83eb3821
|  Jean Chalard | 2012-01-24 | 1 | -4/+4 |
* | Merge "Fix a bug where a check would fail" |  Jean Chalard | 2012-01-20 | 1 | -3/+3 |
|\ |
|
| * | Fix a bug where a check would fail•••Bug: 5894393
Change-Id: I810de58730f2cabcaf7b8dc1d85b3725f959094b
|  Jean Chalard | 2012-01-20 | 1 | -3/+3 |
* | | Fix a bug where the user typed word would not be passed.•••Bug: 5894271
Change-Id: I4f02ff322697159e08f5e898608c0aff11dacb2f
|  Jean Chalard | 2012-01-20 | 1 | -4/+4 |
|/ |
|
* | Merge "Fix a bug with backspace happening after a manual pick." |  Jean Chalard | 2012-01-19 | 1 | -6/+11 |
|\ |
|
| * | Fix a bug with backspace happening after a manual pick.•••Bug: 5884397
Change-Id: I01f462075bcbf7da38e9af2084ecd37143923e8b
|  Jean Chalard | 2012-01-19 | 1 | -6/+11 |
* | | Small code simplification.•••I'm pretty sure the test here was useless.
Change-Id: Iaece641fbd5455406533b19555f2b639759a525f
|  Jean Chalard | 2012-01-19 | 1 | -5/+1 |
|/ |
|
* | Remove KeyboardSwicther.toggleCapslock•••Change-Id: Id613c06e2df770659095d78d42637aed063d0c70
|  Tadashi G. Takaoka | 2012-01-17 | 1 | -1/+1 |
* | Rename KeyboardActionListener methods•••* Rename KeyboardActionListener.onPress to onPressKey
* Rename KeyboardActionListener.onRelease to onReleaseKey
* Merge KeyboardSwicther.onPressShift, onPressSymbol, and onPressOtherKey to onPressKey.
* Merge KeyboardSwitcher.onReleaseShift and onReleaseSymbol to onReleaseKey.
* Merge KeyboardState.onPressShift, onPressSymbol, and onPressOtherKey to onPressKey.
* Merge KeyboardState.onReleaseShift and onReleaseSymbol to onReleaseKey.
Change-Id: Icf28fd18e238c5e534c292893e4ab5b6b98e72f8
|  Tadashi G. Takaoka | 2012-01-17 | 1 | -17/+5 |
* | Merge "Remove toggleShift and toggleAlphabetAndSymbols from KeyboardSwitcher" |  Tadashi G. Takaoka | 2012-01-17 | 1 | -16/+5 |
|\ |
|
| * | Remove toggleShift and toggleAlphabetAndSymbols from KeyboardSwitcher•••Change-Id: I9bb8f78b0a766cd7937d5cbe1c1e5e35898b2997
|  Tadashi G. Takaoka | 2012-01-17 | 1 | -16/+5 |
* | | Merge "Fix a bug where words disappear on inserting separators" |  Jean Chalard | 2012-01-16 | 1 | -1/+7 |
|\ \ |
|
| * | | Fix a bug where words disappear on inserting separators•••The basic idea is that in some situations, we would restart
suggestions, but before evaluating them we would bail out
because suggestions were not requested. This would lead to
the "correction" set to null, so we would commit a null word.
This fix does two things:
- Do not restart suggestions when not requested.
- If we still end up with a composing word when suggestions
are not requested, we select the typed word as the
correct version.
Bug: 5846646
Change-Id: Ic35351841d0cb20afa99092ef681ecb7bd68bec6
|  Jean Chalard | 2012-01-17 | 1 | -1/+7 |
* | | | Merge "Fix a bug where suggestion would restart at a bad time" |  Jean Chalard | 2012-01-16 | 1 | -3/+16 |
|\ \ \
| |_|/
|/| | |
|
| * | | Fix a bug where suggestion would restart at a bad time•••Bug: 5846646
Change-Id: I7c907d0a9478e0878b92ead94173caefc21b627b
|  Jean Chalard | 2012-01-17 | 1 | -3/+16 |
| |/ |
|
* / | Support EditorInfo.IME_FLAG_FORCE_ASCII•••Bug: 5850605
Change-Id: I6665b483f775094903f2e26f5584e4b141592ab5
|  Tadashi G. Takaoka | 2012-01-17 | 1 | -0/+4 |
|/ |
|
* | Small cleanup•••The method deleteWordAtCursor would call finishComposingText,
which is a very unexpected state change and would probably cause
surprising bugs to any parent that would call it.
As it happens, it's not used anywhere any more so let's just
remove it.
Change-Id: Iaa9200866e40b4e914f76baa987279948300679c
|  Jean Chalard | 2012-01-17 | 1 | -1/+1 |
* | Add some comments about resuming auto-suggestion•••Bug: 5846646
Change-Id: Ib2c76ec173972eb7acadbfaae7e930849d546721
|  Jean Chalard | 2012-01-17 | 1 | -0/+5 |
* | Don't cache resource value that depends on orientation•••Bug: 5794655
Change-Id: Ib324366c772e20bb54aba63c2f4540dc0f9de515
|  Tadashi G. Takaoka | 2012-01-16 | 1 | -1/+4 |
* | Merge "Fix a bug where last candidate would not be reset" |  Jean Chalard | 2012-01-11 | 1 | -0/+6 |
|\ |
|
| * | Fix a bug where last candidate would not be reset•••Bug: 5851148
Change-Id: Ic270318842d8e16bc62d78d5fe0d6be0ca1fb532
|  Jean Chalard | 2012-01-12 | 1 | -0/+6 |
* | | Remove an excessive parens•••Change-Id: If8aa4253ab0f664e628ed7f4d7a3adc02a898cc7
|  Jean Chalard | 2012-01-12 | 1 | -1/+1 |
* | | Fix a crash where revertSwap would be wrongly called•••This would crash the program when inputting a punctuation
symbol that should not swap with a weak space through the
suggestion strip, then press backspace.
Those include all two-part punctuation symbols in French for
example, as well as magic space strippers like the dash in
English. For English all suggestion strips symbols happen to
be magic space swappers so this would not happen in English
by default.
Also fix a typo.
Change-Id: Ia40678c264e978509b5786290a75a3c57181648e
|  Jean Chalard | 2012-01-12 | 1 | -2/+3 |
|/ |
|
* | Get rid of Keyboard.CODE_DUMMY•••Change-Id: Id2320f4d9b5f22f0ac844ab20ce42b0c4e7c6880
|  Tadashi G. Takaoka | 2012-01-10 | 1 | -1/+1 |
* | Call KeyboardState.onUpdateShiftState from onCodeInput if code is a normal le...•••This will be helpful to write unit test code.
Change-Id: Ib61cc46ac547084e0dc9ecd3a50814fecf08ace2
|  Tadashi G. Takaoka | 2012-01-10 | 1 | -2/+0 |
* | Fix a bug with wrong auto-correct cancellation•••Auto-correct cancellation would sometimes kick in at
wrong times, causing crashes.
Bug: 5784542
Change-Id: I68dd6b8d9237ce9b66af2dc63e77ba6dd5fd69dd
|  Jean Chalard | 2011-12-21 | 1 | -6/+10 |
* | Reorganize the auto-correction memory•••Change-Id: I31cce9db471dcd4a7b3477bcb037a8ff482b7696
|  Jean Chalard | 2011-12-19 | 1 | -19/+12 |
* | Remove LatinKeyboard class•••Change-Id: I68c667b00dadf2ed9f1c62fb7da37d2cf499cd81
|  Tadashi G. Takaoka | 2011-12-18 | 1 | -11/+10 |
* | Move spacebar drawing code from LatinKeyboard to LatinKeyboardView•••Also this change moves LatinKeyboard attributes,
autoCorrectionSpacebarLedEnabled, autoCorrectionSpacebarLedIcon,
spacebarTextRatio, spacebarTextColor, and spacebarTextShadowColor to
LatinKeyboardView.
Change-Id: I7cc27ce1fc550e9f620a9ed0fbe4b8172902d5a1
|  Tadashi G. Takaoka | 2011-12-18 | 1 | -5/+3 |
* | Get rid of Key.needsSpecialPopupHint and related•••Change-Id: I28e87ea3af9581f12094770b42f113e9018886c4
|  Tadashi G. Takaoka | 2011-12-18 | 1 | -1/+1 |
* | Merge "Pretty print for InputAttributes" |  Jean Chalard | 2011-12-16 | 1 | -4/+1 |
|\ |
|
| * | Pretty print for InputAttributes•••Change-Id: I5e4b2b6f3cd943c8f6187aaed21d67ec786bf5df
|  Jean Chalard | 2011-12-16 | 1 | -4/+1 |
* | | Remove a write-only variable.•••Change-Id: I825307a429f46b31ed9bd940b5a97d2713127dfe
|  Jean Chalard | 2011-12-16 | 1 | -10/+1 |
* | | Merge "Use the WordComposer to check if we are composing a word" |  Jean Chalard | 2011-12-16 | 1 | -18/+14 |
|\ \
| |/
|/| |
|
| * | Use the WordComposer to check if we are composing a word•••...instead of the hard-to-understand mHasUncommittedTypedChars.
This is possible because now the word composer is actually aware
of commits.
Change-Id: I36b664ce8402a280f801e87b9ebe161f416b0853
|  Jean Chalard | 2011-12-16 | 1 | -18/+14 |
* | | General cleanup.•••Move variables around, inline useless functions, remove
useless local variables.
Change-Id: Icb89d8b211a2ad4bc3619137c2276a649c2a5e34
|  Jean Chalard | 2011-12-16 | 1 | -7/+2 |
* | | Initialize input attributes in the InputAttribute class•••Change-Id: I103d6851f54f47cbffdb567fb0f4c505c4697b05
|  Jean Chalard | 2011-12-16 | 1 | -80/+2 |
* | | Make applicationSpecifiedCompletionOn final.•••This is the last one (whew)
Also move a somewhat unrelated initialization out of the
input attribute initialization function.
Change-Id: Icc77b32fd16b112ab43786715061b1c9dca31c04
|  Jean Chalard | 2011-12-16 | 1 | -4/+6 |