| Commit message (Expand) | Author | Age | Files | Lines |
* | Remove logic related to dictionary loading from LatinIME.•••Make mSuggest final and give DictionaryFacilitator the
responsibility to manage dictionary loading state.
This can simplify the logic to decide how to deal with
additional dictionaries when loading settings or language
switching.
Bug: 13273534
Change-Id: I9f3d328272f25addfa186fbeedaaf8417455ba99
|  Keisuke Kuroyanagi | 2014-03-25 | 1 | -76/+51 |
* | Merge "[CB10] Add an event for string input" |  Jean Chalard | 2014-03-20 | 1 | -1/+3 |
|\ |
|
| * | [CB10] Add an event for string input•••Change-Id: Ie5da6c73d4df4553067c58cd0dce9abb34534250
|  Jean Chalard | 2014-03-20 | 1 | -1/+3 |
* | | [IL127] Move the double space countdown to InputLogic•••Bug: 8636060
Change-Id: Ie193b747bd9d0b5ba6a986b9a3c746c2182742ed
|  Jean Chalard | 2014-03-19 | 1 | -19/+0 |
|/ |
|
* | [IL126] Move a setting value to SettingsValues•••Bug: 8636060
Change-Id: I7cb082df13a10cf5a3aa5786e6a9599376652dee
|  Jean Chalard | 2014-03-19 | 1 | -4/+1 |
* | [IL125] Remove arg to onPickSuggestionManually•••Bug: 8636060
Change-Id: I55332c22897e97148621cbd367acf5175b5b3d04
|  Jean Chalard | 2014-03-19 | 1 | -11/+17 |
* | [CB07] Small refactoring•••Bug: 8689779
Change-Id: I2cf10c690c7e4a9c6bf27211d1fccc1f9d4a9249
|  Jean Chalard | 2014-03-17 | 1 | -3/+1 |
* | [CB06] Fix a design error.•••The event interpreter should intervene later, after decoding.
Decoding should happen first, and then the Event should
be passed to the InputLogic.
For the time being, we will leave the (unused) EventInterpreter
class and its friends, because we'll use them again later.
Bug: 13406701
Change-Id: I7582d486724311e39e6692e606cca50c78800643
|  Jean Chalard | 2014-03-17 | 1 | -9/+28 |
* | [CB02] Pass an Event to onCodeInput.•••Bug: 13406701
Change-Id: Id82e9aab6544ca308e6ac6dee2cfa018b9ce2d8f
|  Jean Chalard | 2014-03-13 | 1 | -1/+19 |
* | [IL124] Remove the KeyboardSwitcher arg to onCodeInput•••Bug: 8636060
Change-Id: I29ce4c82ea880a937b1c9e5daf494fcdbbdd1336
|  Jean Chalard | 2014-03-06 | 1 | -2/+13 |
* | [IL120] Cleanup•••Remove useless arguments, local vars, make stuff private
Change-Id: I7cc6c19e9c1703304d593e02be31eb9569cc7b4e
|  Jean Chalard | 2014-03-04 | 1 | -4/+4 |
* | [IL118] Factorize a method•••If we can't get the right locale from the subtype switcher, we
should fallback in all cases.
Change-Id: I46a53a67927a793d9d3592a996a5a4392a36c6ff
|  Jean Chalard | 2014-03-04 | 1 | -1/+1 |
* | [IL117] Simplification•••Change-Id: Id4d4f30ecdc80dd59543f90fe2525f4bcc5afb9d
|  Jean Chalard | 2014-03-04 | 1 | -12/+12 |
* | [IL116] Inline a method•••Change-Id: I6af8f2bd6b4917f9b119ff78a0f299b2f6fb921e
|  Jean Chalard | 2014-03-04 | 1 | -15/+10 |
* | [IL114] Move a method to InputLogic•••Bug: 8636060
Change-Id: I0d8f93985ddc6e93ce9af0d92a8056620351a498
|  Jean Chalard | 2014-03-04 | 1 | -22/+0 |
* | [IL113] More cleanup•••We should not test punctuation with this equality test any more.
Also, whether the suggestion strip is displayed or not, or whether
the hint is displayed or not, has nothing to do with this method
and should be handled elsewhere rather than here -- and as a
matter of fact, it is, which makes this useless.
Bug: 8636060
Change-Id: I6a54ee87e4e9f81bc33158acf4a264c3abd5829d
|  Jean Chalard | 2014-03-04 | 1 | -9/+5 |
* | [IL112] Cleanup•••Bug: 8636060
Change-Id: Ic7c2dec2521613d52707457463691bec383177ff
|  Jean Chalard | 2014-03-04 | 1 | -6/+1 |
* | [IL111] Remove a member.•••...and improve encapsulation and readability.
Bug: 8636060
Change-Id: I36407630b307df0721ea7fdb7e7a22cdf2b018b3
|  Jean Chalard | 2014-03-04 | 1 | -6/+0 |
* | Merge changes I20ce61c4,I2edab4e3•••* changes:
Remove "Use only personalization dictionary".
Remove redundant creation of dictionary facilitator.
|  Keisuke Kuroyanagi | 2014-03-03 | 1 | -23/+27 |
|\ |
|
| * | Remove redundant creation of dictionary facilitator.•••Change-Id: I2edab4e3ba4ea0b9b13f9bb224aac86cac9b9f31
|  Keisuke Kuroyanagi | 2014-02-27 | 1 | -23/+27 |
* | | Add missing null checks for getOwnerInstance()•••It may just return null.
Change-Id: I778fb48262ef8af28a4af50b70bb94ace75a488c
|  Ken Wakasa | 2014-02-28 | 1 | -11/+33 |
* | | [IL110] Remove an unused interface function•••...and make a method private.
Bug: 8636060
Change-Id: If16f7e8ef3779f77a9db23fb7c54e7c23b043b86
|  Jean Chalard | 2014-02-26 | 1 | -3/+1 |
* | | Remove useless args and processing.•••Bug: 13062385
Change-Id: I426545d1fe8fd76bcf4d1dce19e6b571a55c79ae
|  Jean Chalard | 2014-02-26 | 1 | -16/+10 |
|/ |
|
* | Merge "Change a heuristic and add a log." |  Jean Chalard | 2014-02-21 | 1 | -0/+2 |
|\ |
|
| * | Change a heuristic and add a log.•••The heuristic in RichInputConnection makes little sense
when textLength > mExpectedSelStart but we have
more than 1024 characters of text. If there are that many,
it's about 100% sure that 1024 is not the correct cursor
position. With no good guess, we'll just continue trusting
the app, even though we know it's lying : at least it will
make the problem visible to the app author.
Also, there have been a lot of confusion about initialSelStart
and initialSelEnd. The keyboard should log them so that
it helps us and editor authors debug more easily these
common problems.
Issue #65170 in AOSP and
Bug: 12772035
Change-Id: I6665a16c9f2832d33ee323f033bb38bcc092a3b4
|  Jean Chalard | 2014-02-20 | 1 | -0/+2 |
* | | Add ImportantNoticeDialog•••Change-Id: Icaeb7dddd16362cd4a6384d295f89c7fbabc8b35
|  Tadashi G. Takaoka | 2014-02-21 | 1 | -45/+15 |
* | | Support versioned important notice•••This change must be checked in together with If38a754d00.
Bug: 10587358
Change-Id: I91580f9468bc5ee7ed1694d7852a60dc6793dac0
|  Tadashi G. Takaoka | 2014-02-21 | 1 | -3/+16 |
|/ |
|
* | Merge "Don't distrust the cursor pos so much as to bug on IPC delay" |  Jean Chalard | 2014-02-20 | 1 | -3/+6 |
|\ |
|
| * | Don't distrust the cursor pos so much as to bug on IPC delay•••When the cursor is moved by the user, the RichInputConnection
is told about it. However, to work around a framework bug, it
also looks at how many characters are in the buffer before the
cursor, and if that's more than the value it's been passed, it
deduces that's a framework bug and there are at least as many
characters as seen before the cursor, so it puts the expected
cursor position there.
When you move the cursor, TextView calls onUpdateSelection,
and when you move it fast, you'll get rapid-fire calls to
onUpdateSelection. This is fine, the RIC is equipped to
deal with that.
However, these calls take some time to make it to the IME. In
this instance, when the first call gets through and the IME
calls TextView (synchronously) for text before the cursor, the
cursor has already moved in the app, and TextView returns more
characters than the cursor position was declared to be in this
instance, so the RIC sets that as the expected cursor position.
Sure enough, a split second later, the second call to
onUpdateSelection arrives, with the new cursor position set
where the RIC had found it too early. The RIC takes that as an
"expected" cursor move, and the input does not get reset.
Luckily, we have a way out. As far as we know, the framework bug
only manifests itself upon rotation, which means we should only
have to adjust for it in onStartInputView. Doing it in
onUpdateSelection is too zealous (and probably too distrustful of
the app to send the correct cursor positions).
So we should just take care of the rotation case (by calling
tryFixLyingCursorPosition in onStartInputView) and remove the
compensating code in resetCachesUponCursorMoves.
Bug: 12982502
Change-Id: Ic3c1408a1ec45deaea63b01d98376a79ae567d77
|  Jean Chalard | 2014-02-20 | 1 | -3/+6 |
* | | Add test only methods to test personalized dicts.•••Bug: 11122480
Change-Id: I79a4a73ff09a2d34d4ca094d705e901fb4bc855c
|  Keisuke Kuroyanagi | 2014-02-20 | 1 | -2/+10 |
* | | Merge "Check all enabled IME's subtypes to enable personalization." |  Keisuke Kuroyanagi | 2014-02-20 | 1 | -1/+1 |
|\ \
| |/
|/| |
|
| * | Check all enabled IME's subtypes to enable personalization.•••Bug: 13067743
Change-Id: I6fc68b5151430a5ab51777f4c381e20f5a657924
|  Keisuke Kuroyanagi | 2014-02-20 | 1 | -1/+1 |
* | | Change important notice version preference file•••This CL also reset the notice version to 1.
This CL must be checked in together with Iea8d9ff038.
Change-Id: I838f7b5b295388d64d6aba90f50b06654eba16e5
|  Tadashi G. Takaoka | 2014-02-20 | 1 | -30/+15 |
|/ |
|
* | Call PersonalizationDictionarySessionRegistrar.init().•••Wrongly removed in I1f50cb137b6054dc9.
Bug: 13067743
Change-Id: I27cd221cb7f6e403c3fc128d65d14dbf628b6f55
|  Keisuke Kuroyanagi | 2014-02-19 | 1 | -0/+4 |
* | Remove personalization dicts for multilingual users.•••Bug: 13067743
Change-Id: I1f50cb137b6054dc9442237586b70fc0aa2bf427
|  Keisuke Kuroyanagi | 2014-02-19 | 1 | -9/+20 |
* | Use AlertDialog.setOnDismissListener•••AlertDialog.Builder.setOnDismissListener is supported from API 17.
Bug: 10587358
Change-Id: Ie8ce8e283b803f7f6bb58ced446e676339f980eb
|  Tadashi G. Takaoka | 2014-02-19 | 1 | -2/+2 |
* | Merge "Turn personalization on when important notice dialog is displayed" |  Tadashi G. Takaoka | 2014-02-19 | 1 | -19/+43 |
|\ |
|
| * | Turn personalization on when important notice dialog is displayed•••This change must be checked in together with Ifde70b1d3b.
Bug: 10587358
Change-Id: I9dc48f9d521e0e6f6269e4f184389ba805f3053f
|  Tadashi G. Takaoka | 2014-02-19 | 1 | -19/+43 |
* | | Fix: Use old suggest after reloading.•••Change-Id: Icb2821f61c4203254b7d573cad5ce71fbf0ed841
|  Keisuke Kuroyanagi | 2014-02-19 | 1 | -1/+3 |
|/ |
|
* | Merge "Cleanup." |  Jean Chalard | 2014-02-18 | 1 | -7/+1 |
|\ |
|
| * | Cleanup.•••Less code, less chance of stuff escaping, and a bit of a clarification.
Yay.
Change-Id: I3193fd8ad7ac28195260cbc231c4e498a63a460c
|  Jean Chalard | 2014-02-18 | 1 | -7/+1 |
* | | Some cosmetic fixes in LatinIME.java•••Change-Id: Ia2d04ab992f5a0cc736150b2691b2f8ae8f0955d
|  Ken Wakasa | 2014-02-18 | 1 | -40/+38 |
|/ |
|
* | Cosmetic fixes•••Change-Id: I6c755565ba7689357d02d26cc0e92a93031953e8
|  Ken Wakasa | 2014-02-18 | 1 | -23/+30 |
* | Set neutral suggestions should be called after load settings•••Bug: 13058751
Change-Id: Iba49e86b90d595473d91753827d499e551dad45c
|  Tadashi G. Takaoka | 2014-02-18 | 1 | -33/+33 |
* | Update important notice version even when user select Settings•••Bug: 13060852
Change-Id: I463fdf3d51cacf99693fcde2998ea751046d1cc5
|  Tadashi G. Takaoka | 2014-02-18 | 1 | -1/+1 |
* | Merge "Don't show important notice on password field" |  Tadashi G. Takaoka | 2014-02-17 | 1 | -4/+6 |
|\ |
|
| * | Don't show important notice on password field•••Bug: 10587358
Change-Id: Ieff7960e5e2b8609fddeb173af578a5d9b2c4d98
|  Tadashi G. Takaoka | 2014-02-17 | 1 | -4/+6 |
* | | Add go to "Settings" button to important notice dialog•••This CL also
- removes icons on important notice title.
- changes the "Personalized suggestions" summary text.
This change must be checked in together with Id115d89ba9.
Bug: 10587358
Change-Id: I52ff26fa8ae12445e9014ba08253f69e1be609f4
|  Tadashi G. Takaoka | 2014-02-17 | 1 | -10/+11 |
|/ |
|
* | Add PunctuationSuggestions class•••This change must be checked in together with I366c477516.
Bug: 12640318
Change-Id: I8d3864b9d9649c9e3306e82b01a6327b11281b1f
|  Tadashi G. Takaoka | 2014-02-14 | 1 | -3/+1 |
* | Merge "Show the suggestion strip for the important notice" |  Jean Chalard | 2014-02-14 | 1 | -1/+4 |
|\ |
|