| Commit message (Expand) | Author | Age | Files | Lines |
|---|
| * | Update personalized dict only when single subtype is used.•••Bug: 12424891
Change-Id: If041d1ab45988dbf9b878ae3367fee0fbc8a8988
|   Keisuke Kuroyanagi | 2014-01-07 | 1 | -2/+6 |
| * | [IL52] Remove a useless method.•••This old method doesn't even re-read the old suggestions. It used to
recompute them without the coordinates.
Re-using the recorrection code, which is much more advanced, is
the right thing to do here.
Also, refining the test. It's no use trying to resume suggestion
if we don't have a suggestion strip, since we aren't going to
auto-correct anything anyway.
Not the motivation for this change, but this also fixes
Bug: 11620256
Change-Id: Id49efa32e293c49837c61fdc752c86bbac1d2c88
|   Jean Chalard | 2013-12-27 | 1 | -1/+2 |
| * | [IL50] Move the InputUpdater out of LatinIME.•••...at last
Bug: 8636060
Change-Id: If5e27a9d28ff64d318dd76792f55edfc8a78d2d7
| Jean Chalard | 2013-12-27 | 1 | -161/+11 |
| * | [IL49] Move InputLogic-related init code to InputLogic.•••Bug: 8636060
Change-Id: Ie5027512f066d9c530a686ac559e4649a39bf439
| Jean Chalard | 2013-12-27 | 1 | -17/+3 |
| * | Merge "[IL48] Move onEndBatchInputAsyncInternal to InputLogic." | Jean Chalard | 2013-12-27 | 1 | -35/+2 |
| |\ |
|
| | * | [IL48] Move onEndBatchInputAsyncInternal to InputLogic.•••Bug: 8636060
Change-Id: Idfabf7231a80e21786ce1910b5140bb3dddcac7d
| Jean Chalard | 2013-12-27 | 1 | -35/+2 |
| * | | Merge "[IL47] Inline getSuggestedWordsGestureLocked" | Jean Chalard | 2013-12-27 | 1 | -23/+10 |
| |\| |
|
| | * | [IL47] Inline getSuggestedWordsGestureLocked•••This method is confusing with the *Locked convention, and
the two-step call creates a useless callback object. This is
better inlined both for readability and for performance.
Bug: 8636060
Change-Id: I7c427c3ca4e831388a6d54de6728b32206a45d80
| Jean Chalard | 2013-12-27 | 1 | -23/+10 |
| * | | Merge "[IL46] Remove a useless message passing." | Jean Chalard | 2013-12-27 | 1 | -20/+2 |
| |\| |
|
| | * | [IL46] Remove a useless message passing.•••The only point of this message is to send the processing on another
thread. However, this will be accomplished later.
Here is the exact call graph:
0. onUpdateBatchInput
1. -> MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP
2. -> updateBatchInputSync
3. -> getSuggestedWordsGestureLocked
4. -> MSG_GET_SUGGESTED_WORDS
5. -> LatinIME#getSuggestedWords
The point of both step 1. and step 4. is to make sure the processing
is happening on the InputUpdater thread. Thus, it's useless to do
it twice.
Bug: 11326092
Bug: 8636060
Change-Id: Iceebb9e8879a8f15b73c987f5fd3489f27699be4
| Jean Chalard | 2013-12-27 | 1 | -20/+2 |
| * | | Merge "[IL45] Remove lingering messages" | Jean Chalard | 2013-12-27 | 1 | -4/+9 |
| |\| |
|
| | * | [IL45] Remove lingering messages•••Bug: 8636060
And possibly bug: 12085864
Change-Id: I867036bc3d8bd255dc8ceebdd30e28b4b3dc4b2d
| Jean Chalard | 2013-12-27 | 1 | -4/+9 |
| * | | Merge "[IL44] Some factorization" | Jean Chalard | 2013-12-27 | 1 | -26/+62 |
| |\| |
|
| | * | [IL44] Some factorization•••This sheds some light on what's happening here. Some
comments were at least misleading, maybe indicating something
is not sequenced as intended.
Bug: 8636060
Change-Id: Ia74feb457a39fe4a672c27fe4203264fda940f04
| Jean Chalard | 2013-12-27 | 1 | -26/+62 |
| * | | Merge "Make setAdditionalDictionaries private." | Keisuke Kuroyanagi | 2013-12-27 | 1 | -15/+22 |
| |\ \
| |/
|/| |
|
| | * | Make setAdditionalDictionaries private.•••Bug: 8187060
Change-Id: I17be7b77ff89972d3ca6823b087b7bf35105af56
| Keisuke Kuroyanagi | 2013-12-27 | 1 | -15/+22 |
| * | | [IL43] Small cleanup•••All calls are already passing this
Bug: 8636060
Change-Id: I13accefd7c17039dc5ec12dc9e8133ebc86451ad
| Jean Chalard | 2013-12-26 | 1 | -8/+7 |
| * | | [IL42] Inline getSuggestedWordsOrOlderSuggestionsAsync•••Bug: 8636060
Change-Id: I5c47370a3ea5962caff4d40db2faa62accfc7147
| Jean Chalard | 2013-12-26 | 1 | -17/+7 |
| * | | [IL41] Remove a useless call and trampoline.•••No point in calling maybeRetrieveOlderSuggestions now that the
same work is done right here. The callback is also useless now.
Bug: 8636060
Change-Id: Ic14849cb6f6e6293a42cfe068f5c6b18b7677bc0
| Jean Chalard | 2013-12-26 | 1 | -14/+14 |
| |/ |
|
| * | Extract dict operations from Suggest to a new class.•••Bug: 8187060
Change-Id: I77775aa50763158d99753c2312fa11fe14267aef
| Keisuke Kuroyanagi | 2013-12-26 | 1 | -12/+17 |
| * | [IL39] Change a test.•••I don't see why we would want to remove other suggestions just because
the only suggestion happens to be a dictionary word. That's just
inconsistent.
Bug: 8636060
Change-Id: Ie2d990e5785273d625e6e5518026364165a8f2df
| Jean Chalard | 2013-12-26 | 1 | -5/+5 |
| * | [IL38] Fix a wrong double call•••This only gives bad results if a gesture results in only one suggestion.
Change-Id: I5a2f27f83f6901a5a9ecf22f02bdfc9cca6d9f1d
| Jean Chalard | 2013-12-26 | 1 | -7/+7 |
| * | [IL37] Small simplification•••Bug: 8636060
Change-Id: I08a6c04986a0bd86ce4c232893e804766ebeebb9
| Jean Chalard | 2013-12-26 | 1 | -4/+3 |
| * | [IL36] Inline setAutoCorrection•••There are far too many one-use methods.
Bug: 8636060
Change-Id: I84e0669b8d2cc5a2817c42b089e874dc60e84769
| Jean Chalard | 2013-12-26 | 1 | -14/+9 |
| * | [IL35] Preparative cleanup•••Bug: 8636060
Change-Id: Id6791085816891c78289b0223bf0807db2da6300
| Jean Chalard | 2013-12-25 | 1 | -11/+7 |
| * | Use SettingsValues instead of Settings in Suggest.•••Bug: 8187060
Change-Id: Idba1e708d67c036072b728949d17f8bd98ae0115
| Keisuke Kuroyanagi | 2013-12-25 | 1 | -5/+3 |
| * | Move dict operations to Suggest.•••Bug: 8187060
Change-Id: Iabe13abcd43b381360f7080b3f4ee0533f246160
| Keisuke Kuroyanagi | 2013-12-25 | 1 | -8/+5 |
| * | Remove personalized dicts when the option is turned off.•••Bug: 11757851
Change-Id: I94f32859d862fe41e39845ab2bfc2d396c6aea0f
| Keisuke Kuroyanagi | 2013-12-25 | 1 | -5/+12 |
| * | [IL33] Opportunistically remove some KeyboardSwitcher•••Bug: 8636060
Change-Id: I0480ac03b9902e940f566b5558b8499647983968
| Jean Chalard | 2013-12-24 | 1 | -1/+3 |
| * | [IL31] Move *BatchInput to InputLogic•••Bug: 8636060
Change-Id: If0309be038518a71d735108b78ac9efbfe38c82b
| Jean Chalard | 2013-12-20 | 1 | -107/+18 |
| * | [IL30] Minor refactoring•••Change-Id: I8a8aa9f703c6fca5e25ec573b41f325680ac92dc
| Jean Chalard | 2013-12-20 | 1 | -3/+3 |
| * | [IL29] Move retryResetCaches and tryFixLyingCursorPosition•••Bug: 8636060
Change-Id: I45b322e4844f023e91b80f9c2e0f7fa0166bcc59
| Jean Chalard | 2013-12-20 | 1 | -66/+5 |
| * | [IL28] Remove useless code•••I don't understand why this was checked in. The tests are completely
useless, that makes the variables write-only, and the only side effect
is useless as the keyboard commits suicide upon exiting debug
settings.
Change-Id: I4eb25295183f43a2e947a6a0467ea168d023c18a
| Jean Chalard | 2013-12-20 | 1 | -25/+0 |
| * | [IL27] Some refactoring•••Bug: 8636060
Change-Id: Iedfdf71350f5fe3ab451fc5ec6e3c9901f71e50f
| Jean Chalard | 2013-12-20 | 1 | -4/+6 |
| * | [IL26] Move restartSuggestionsOnWordTouchedByCursor•••Bug: 8636060
Change-Id: I373874585f4fa663b4207b9a02d751805259eb36
| Jean Chalard | 2013-12-20 | 1 | -111/+8 |
| * | [IL25] Inline handleClose•••Only ever used here.
Bug: 8636060
Change-Id: Ia98c8bbe1c63ad4d057efe1cee87829b06124479
| Jean Chalard | 2013-12-20 | 1 | -12/+6 |
| * | [IL24] Move mDisplayOrientation to SettingsValues.•••Bug: 8636060
Change-Id: Id57ced0cca9dc9e5e85c3a53683588feb28c1402
| Jean Chalard | 2013-12-20 | 1 | -14/+15 |
| * | [IL22] Move onTextInput to InputLogic.•••Also pull the TLD specific processing
Bug: 8636060
Change-Id: I20931ac6fc6c55a05aa8f8b97b0210c07d230ea2
| Jean Chalard | 2013-12-20 | 1 | -46/+1 |
| * | [IL21] Move the workaround utils to a better place.•••Bug: 8636060
Change-Id: I566f9e109ebcabe3a6a778118434ce79d02d1113
| Jean Chalard | 2013-12-20 | 1 | -27/+11 |
| * | [IL20] Remove some useless processing.•••If we have the same text field, then the target app is
necessarily the same. No need to re-evaluate it.
Bug: 8636060
Change-Id: I66eb194c4cd08a6c1d47b26b99bd7f420130097e
| Jean Chalard | 2013-12-20 | 1 | -8/+7 |
| * | [IL19] Resolve a TODO.•••Bug: 8636060
Change-Id: Iec7c1001c46cf8e9a44422e3f9008e437cc5cab6
| Jean Chalard | 2013-12-20 | 1 | -2/+1 |
| * | [IL18] Move and rename updateSuggestionStrip•••Bug: 8636060
Change-Id: I3d00095cd0e83d1ee3834b37ff188b5aa9806fcb
| Jean Chalard | 2013-12-20 | 1 | -55/+6 |
| * | [IL17] Move commitChosenWord to InputLogic.•••Also not-cache a value whose documentation says not to cache
it. That makes it write only, so remove it.
Bug: 8636060
Change-Id: I39798a039cebf79ad78a41fe457c9d9764a3f275
| Jean Chalard | 2013-12-20 | 1 | -75/+8 |
| * | [IL16] Improve getTextWithSuggestionSpan•••Dynamically test for the presence of main dict suggestions. This
is much more potent and more accurate than the vaguely defined
boolean.
Also, resolve a TODO and avoid creating an object uselessly.
Not directly related, but helpful with:
Bug: 8636060
Change-Id: Ib1745f77ee6d9ec7cd8bbfa5a548652ec84ec902
| Jean Chalard | 2013-12-20 | 1 | -1/+1 |
| * | [IL15] Some small refactoring•••Bug: 8636060
Change-Id: I4bfdf1628c9b55a79bd2d88ee30bf10b08a49232
| Jean Chalard | 2013-12-20 | 1 | -3/+2 |
| * | [IL14] Move getCurrent*Caps* to InputLogic•••Bug: 8636060
Change-Id: I6338dcee0f7a80f2181ba0369f71350cb21d231a
| Jean Chalard | 2013-12-20 | 1 | -23/+12 |
| * | [IL12] move restartSuggestions* to InputLogic•••Bug: 8636060
Change-Id: I99474248e8fa35eb3053b5520abc8716805fdfb4
| Jean Chalard | 2013-12-19 | 1 | -34/+0 |
| * | [IL11] Cleanup•••Make some methods private and add comments.
Bug: 8636060
Change-Id: I6c7d13dca8a22dd1a6f110e8b18d52864429579f
| Jean Chalard | 2013-12-19 | 1 | -1/+1 |
| * | [IL10] Move revertCommit to InputLogic•••Bug: 8636060
Change-Id: Ia5788b365f05ae880bad957cbef00ecc93abb5d1
| Jean Chalard | 2013-12-19 | 1 | -60/+2 |
| * | [IL9] Move commitCurrentAutoCorrection to InputLogic•••Bug: 8636060
Change-Id: I405c4a537858a6d5ab0b29502a2792e8c3b2564e
| Jean Chalard | 2013-12-19 | 1 | -43/+5 |
