| Commit message (Expand) | Author | Age | Files | Lines |
* | [QRP6] Fix: recorrection top candidate is displayed in bold•••Bug: 10385162
Change-Id: Icf9471d474a3a8ed8f38c46c7948c66f9131691e
|  Jean Chalard | 2014-02-25 | 1 | -2/+4 |
* | Don't trim newer inputpointers with old data•••We already have a mechanism to avoid this crash, but it wasn't
used every time it needed to. It's possible that ending a batch
input and starting a batch input happen while suggestions
are being pulled out, which would result in pointers that have
been reset being passed for trimming.
Just increasing the sequence number should get rid of the
problem.
Bug: 12178124
Change-Id: I36ef3bc8a78679bc09daa39e665f5ce1bab50c2a
|  Jean Chalard | 2014-02-21 | 1 | -0/+2 |
* | Merge "Fix a bug where suggestions would not be updated." |  Jean Chalard | 2014-02-20 | 1 | -14/+33 |
|\ |
|
| * | Fix a bug where suggestions would not be updated.•••Also fix a small cosmetic bug where the suggestion strip
would flash.
Bug: 12951777
Change-Id: I68b7bb9175571de9c718f737eebd9f67ea04a931
|  Jean Chalard | 2014-02-20 | 1 | -14/+33 |
* | | Add final and volatile for members of InputLogic.•••Bug: 13107471
Change-Id: I47df79bc6f015c212d1b6d2f63b2efc5da24294e
|  Keisuke Kuroyanagi | 2014-02-20 | 1 | -2/+3 |
|/ |
|
* | Cleanup.•••Less code, less chance of stuff escaping, and a bit of a clarification.
Yay.
Change-Id: I3193fd8ad7ac28195260cbc231c4e498a63a460c
|  Jean Chalard | 2014-02-18 | 1 | -11/+2 |
* | Don't resume suggestion on links.•••Bug: 11447084
Change-Id: I5bd558b9dd85d1505aa918f44e8ac3e52ec42d97
|  Jean Chalard | 2014-02-17 | 1 | -0/+4 |
* | Add PunctuationSuggestions class•••This change must be checked in together with I366c477516.
Bug: 12640318
Change-Id: I8d3864b9d9649c9e3306e82b01a6327b11281b1f
|  Tadashi G. Takaoka | 2014-02-14 | 1 | -2/+2 |
* | Backward compatibility hack : send delete when empty.•••Some apps depend on the keyboard sending something to them
when the text is empty. This is BROKEN. Your app must not lie
to the keyboard about what is before the cursor. If there is something
to delete, you must not pretend there is not and try to catch some
delete event. This will result in a bad user experience. This will not
work with all IMEs. If your app needs this broken behavior, you're
doing it wrong. Seriously guys, we're not in the era of typewriters
any more, there are touch screens, there are gestures, there is
accessibility, there are many innovative IMEs that don't have
keys. Do *NOT* rely on key events.
This change implements an ugly hack so that these broken apps
may continue half-working with LatinIME. We are very unhappy
about this.
Bug: 12998568
Change-Id: Ia62ae2fbee4fee65b463acf3a79aafcfd0defa1d
|  Jean Chalard | 2014-02-13 | 1 | -1/+7 |
* | Fix a test.•••This fixes two separate problems:
- The word finds itself with two separate suggestion spans.
This is fine for LatinIME, but it's hard to predict whether it's
fine for other interested parties (other keyboards).
- The test for the blue underline was incorrect.
Change-Id: I3ecc849676851bf25a25238d694adaa956521a26
|  Jean Chalard | 2014-02-13 | 1 | -17/+29 |
* | Revert "Display predictions when the cursor is moved after a word."•••This change is lacking some comments and break some unit tests.
It needs more work.
This reverts commit 38d31a5e79c64e706e1698d2d24adb51c4ac53aa.
Change-Id: I675854fd0729f2d01b7751e35c6d0117f4f88993 |  Jean Chalard | 2014-02-10 | 1 | -8/+1 |
* | Display predictions when the cursor is moved after a word.•••Bug: 12951777
Change-Id: I744b98df6679edd34ca3c1392e38597325935932
|  Jean Chalard | 2014-02-10 | 1 | -1/+8 |
* | Conditionally store the raw suggestions.•••Bug: 12913520
Change-Id: Ie15f97d90c142c51089280252b35b5ad1d226e19
|  Jean Chalard | 2014-02-06 | 1 | -1/+2 |
* | Merge "Fix a flash in the wrong place" |  Jean Chalard | 2014-02-05 | 1 | -3/+2 |
|\ |
|
| * | Fix a flash in the wrong place•••Bug: 7226099
Change-Id: I8f74802b3ae24018fc4176fb2fff2c777ae170b0
|  Jean Chalard | 2014-02-05 | 1 | -3/+2 |
* | | [IL109] Move more code to InputLogic•••Bug: 8636060
Change-Id: Ib12eacc836e8d39c4165c97a2a287f32f6bf5405
|  Jean Chalard | 2014-02-05 | 1 | -1/+113 |
* | | [IL108] Remove some uses of LatinIME in input logic.•••Access the suggestion strip through the interface instead.
Bug: 8636060
Change-Id: Ia8bd705c230f943e309d677ef683b1a2cbe68036
|  Jean Chalard | 2014-02-05 | 1 | -7/+11 |
|/ |
|
* | Check isEligibleForAutoCommit when batch input is ended.•••Bug: 11951198
Change-Id: Ibbe09fa38eaa3ebf8f9b69f744a29db7ac598975
|  Keisuke Kuroyanagi | 2014-02-05 | 1 | -1/+4 |
* | Don't resume suggestions if suggestions are not requested.•••Bug: 12832614
Change-Id: I6a9b6d128d7e0324ba59a43cf153a3b54e1d35bf
|  Jean Chalard | 2014-02-03 | 1 | -0/+2 |
* | [IL106] Inline a now useless method.•••Bug: 8636060
Change-Id: Ic8e0225206358680aa0de421f17ab443c888036d
|  Jean Chalard | 2014-01-29 | 1 | -3/+4 |
* | [IL105] Remove more useless arguments•••Bug: 8636060
Change-Id: I9e817bb9622c84544a5ca8708e5c1fccad1ed447
|  Jean Chalard | 2014-01-29 | 1 | -3/+2 |
* | [IL104] Remove useless arguments•••Bug: 8636060
Change-Id: I97a371fe0c6227eb0f03d3e391a33726e6280322
|  Jean Chalard | 2014-01-29 | 1 | -5/+2 |
* | [IL103] Save the typed word separately in SuggestedWords.•••This helps managing the cases where the typed word is not
in the suggestions. This happens during recorrection.
Bug: 8636060
Change-Id: I6784feb793cae96272a7f1d123a0e3bbb8f03143
|  Jean Chalard | 2014-01-29 | 1 | -3/+2 |
* | Merge "Fix inconsistent behavior with the back-to-the-main-keyboard key" |  Yohei Yukawa | 2014-01-28 | 1 | -0/+4 |
|\ |
|
| * | Fix inconsistent behavior with the back-to-the-main-keyboard key•••With this patch, the back-to-the-main-keyboard in the Emoji
palette will be registered as a key-release action instead of
a key-press action, like switch-to-the-emoji-palette in the
main layout. This provides mroe consistent UX when the layout is
switched from the main layout to the Emoji palette then
switched back to the main layout.
BUG: 12464067
Change-Id: Ia0d0185db43234dfcfb7cee2677f3d199fe6ed96
|  Yohei Yukawa | 2014-01-28 | 1 | -0/+4 |
* | | [IL102] Rename a method•••Bug: 8636060
Change-Id: Ia54afdfab9124aa5c35699e357e63eae66a7557f
|  Jean Chalard | 2014-01-28 | 1 | -3/+2 |
* | | [IL101] Remove a method•••Bug: 8636060
Change-Id: Ic9c12fc6970987b0e1912e8ae85bed55260d66b5
|  Jean Chalard | 2014-01-28 | 1 | -3/+6 |
* | | [IL99] Migrate some code to InputLogic.•••Bug: 8636060
Change-Id: Ibf1f9c7bdc3fdd872d6c15447fa555434485cc52
|  Jean Chalard | 2014-01-28 | 1 | -0/+19 |
|/ |
|
* | Merge "[IL86] Simplification and correctness fix." |  Jean Chalard | 2014-01-27 | 1 | -5/+1 |
|\ |
|
| * | [IL86] Simplification and correctness fix.•••This should be what was intended.
Bug: 8636060
Change-Id: I20a1cc4f0b1fb9444fb6f9a20ef727e3d1a3a880
|  Jean Chalard | 2014-01-27 | 1 | -5/+1 |
* | | Merge "[IL84] Remove a useless call and rename a method" |  Jean Chalard | 2014-01-27 | 1 | -2/+2 |
|\| |
|
| * | [IL84] Remove a useless call and rename a method•••Bug: 8636060
Change-Id: I5cac787953a3c71b6402520c2f5c70619d4a40a8
|  Jean Chalard | 2014-01-27 | 1 | -2/+2 |
* | | Merge "[IL81] Remove a useless test." |  Jean Chalard | 2014-01-27 | 1 | -12/+3 |
|\| |
|
| * | [IL81] Remove a useless test.•••It seems the comments were right all along. This seems to really
be useless.
Bug: 8636060
Change-Id: Ie030e9cb73007334380d023abeaa4ce52a863a34
|  Jean Chalard | 2014-01-27 | 1 | -12/+3 |
* | | Merge "Try to figure out whether d.quotes open or close." |  Jean Chalard | 2014-01-27 | 1 | -5/+21 |
|\ \
| |/
|/| |
|
| * | Try to figure out whether d.quotes open or close.•••Bug: 8911672
Change-Id: I5d5635949530a67f95e5208986907251b7bce903
|  Jean Chalard | 2014-01-27 | 1 | -5/+21 |
* | | [IL80] Reverse a test for clarity.•••Bug: 8636060
Change-Id: I5092942ab4fd6aaf37023083040cadbc18583fd1
|  Jean Chalard | 2014-01-27 | 1 | -50/+49 |
* | | [IL79] Some refactoring•••Bug: 8636060
Change-Id: I931c553f68a1f15d22711a661dbffd4e5d421979
|  Jean Chalard | 2014-01-27 | 1 | -18/+10 |
* | | [IL78] Move most of onUpdateSelection to InputLogic.•••Bug: 8636060
Change-Id: I7290250637e37bf6964bab71d2141e19f20a5459
|  Jean Chalard | 2014-01-27 | 1 | -0/+79 |
* | | [IL77] Remove refs to Settings from InputLogic•••Bug: 8636060
Change-Id: I4ce5c9b62181ce8593a453ce222ae7d1fdc08f07
|  Jean Chalard | 2014-01-27 | 1 | -9/+3 |
* | | [IL75] Move the SubtypeSwitcher out of InputLogic.•••Bug: 8636060
Change-Id: I2a5da27e73cf378e55bd80ab2054c1ba8b13f6ec
|  Jean Chalard | 2014-01-27 | 1 | -5/+4 |
|/ |
|
* | Merge "[IL76] Remove a SuggestionStripView dependency" |  Jean Chalard | 2014-01-23 | 1 | -3/+2 |
|\ |
|
| * | [IL76] Remove a SuggestionStripView dependency•••This constant is better located in SuggestedWords.
Or it could be in Constants, that would be fine too.
Bug: 8636060
Change-Id: I3e721bb1e2559f028dce8929eceadfe0478c5924
|  Jean Chalard | 2014-01-23 | 1 | -3/+2 |
* | | [IL66.1] Add a comment•••Followup to IL66
Change-Id: I067e72c36f483cc3e3b24736c01843531298b507
|  Jean Chalard | 2014-01-23 | 1 | -1/+1 |
|/ |
|
* | [IL70] Remove unused arguments•••Bug: 8636060
Change-Id: Iec56bce362ebfc52fedab02b127978abb4f3c7f9
|  Jean Chalard | 2014-01-23 | 1 | -11/+7 |
* | [IL69] Oust Keyboard from WordComposer#setComposingWord•••Bug: 8636060
Change-Id: I624a45500603dfad355ee3b8b794b2d895219c0b
|  Jean Chalard | 2014-01-23 | 1 | -6/+9 |
* | [IL67] Externalize a call to the keyboard switcher•••Bug: 8636060
Change-Id: Ib13a54854e30afb79217a0a1f2aeca50a95ba155
|  Jean Chalard | 2014-01-23 | 1 | -9/+6 |
* | [IL66] Remove two accesses to KeyboardSwitcher.•••Bug: 8636060
Change-Id: I3b144993e2bcd552f9b292b8f057c9db4216125c
|  Jean Chalard | 2014-01-23 | 1 | -7/+7 |
* | [IL64] Pull up X,Y processing, step 3•••Bug: 8636060
Change-Id: Ic051e5d5514d270101b0571a2d30e2caa8f85bc1
|  Jean Chalard | 2014-01-22 | 1 | -20/+4 |
* | [IL63] Pull up X,Y processing, step 2•••This also fixes the coordinates passed to logOnDelete and
log onSeparator.
Bug: 8636060
Change-Id: I4703d61ad7de76b501adca18df3a69e06450c9a1
|  Jean Chalard | 2014-01-22 | 1 | -20/+20 |