| Commit message (Expand) | Author | Age | Files | Lines |
* | Merge "[IL133] Avoid calling a dangerous method from outside." |  Jean Chalard | 2014-04-10 | 1 | -3/+6 |
|\ |
|
| * | [IL133] Avoid calling a dangerous method from outside.•••We want to remove all calls to this as it lets internal values
escape, but there is some refactoring to do to finish this.
Bug: 8636060
Change-Id: Iedba6afe4719bc0add868714a1ee5a04b7ead33e
|  Jean Chalard | 2014-04-03 | 1 | -3/+6 |
* | | Fix some flaky tests.•••In tests, we create many instances of LatinIME, but we never
destroy them. That means we never close the dictionaries nor
the handlers.
This change calls onDestroy, which closes all dictionaries, and
adds some code to finish the handlers.
Change-Id: I942517a2a940c54256b08763f6b38f5b55809f55
|  Jean Chalard | 2014-04-10 | 1 | -0/+11 |
* | | [CB23] Merge add and deleteLast•••Bug: 13406701
Change-Id: Id9a2e4144b1908ad27d78228ee19e6fc4d4d669f
|  Jean Chalard | 2014-04-07 | 1 | -2/+2 |
* | | Merge "[IL132] Remove some calls that let a value escape." |  Jean Chalard | 2014-04-04 | 1 | -3/+3 |
|\| |
|
| * | [IL132] Remove some calls that let a value escape.•••Bug: 8636060
Change-Id: I696514934586ee71e734fd974026af8b2c866127
|  Jean Chalard | 2014-04-03 | 1 | -3/+3 |
* | | Fix a bug with double-space-to-period•••Bug: 13778001
Change-Id: I3ebd57950cdfacbbcdc64ed214c0590519a0665c
|  Jean Chalard | 2014-04-03 | 1 | -7/+5 |
|/ |
|
* | [IL131] Cleanup some cruft•••Bug: 8636060
Change-Id: I169618b50532df68e973e14b3f114c6c19714c84
|  Jean Chalard | 2014-04-03 | 1 | -9/+1 |
* | [IL130] Remove a useless local•••Bug: 8636060
Change-Id: I36ba3e00630bef644fc4671d0714490b5982f6a1
|  Jean Chalard | 2014-04-02 | 1 | -3/+1 |
* | [IL129] Change some confusing method names.•••Bug: 8636060
Change-Id: I2f55fc23d7e05b63582a3f0660b58635eae5ec59
|  Jean Chalard | 2014-04-02 | 1 | -2/+2 |
* | Merge "[IL128] Remove passing some handlers." |  Jean Chalard | 2014-03-31 | 1 | -21/+16 |
|\ |
|
| * | [IL128] Remove passing some handlers.•••Bug: 8636060
Change-Id: I088be9a7555265ca097667523defd73be4cbe37f
|  Jean Chalard | 2014-03-27 | 1 | -21/+16 |
* | | Do not create a handler thread for each session•••Bug: 13710224
Bug: 12821388
Bug: 12667742
Change-Id: I6188e0240193d2bca789110e7660a0f31bbafc62
|  Jean Chalard | 2014-03-31 | 1 | -4/+6 |
* | | Fix a bug where LatinIME would leak pipes.•••Bug: 12667742
Bug: 12821388
Change-Id: Ic0bad56fb96e54ac032759adffc8ea320c06dff2
|  Jean Chalard | 2014-03-28 | 1 | -0/+1 |
* | | Some cleanup•••Change-Id: Ia11d656a70623168b091763ac6524750f9cca8d8
|  Jean Chalard | 2014-03-28 | 1 | -4/+2 |
|/ |
|
* | Merge "[CB14] Implement backspace in the combiner chain" |  Jean Chalard | 2014-03-25 | 1 | -1/+1 |
|\ |
|
| * | [CB14] Implement backspace in the combiner chain•••Bug: 13622107
Bug: 13406701
Change-Id: I0023b398c4451253f9f717e2bd990b8a054004bc
|  Jean Chalard | 2014-03-25 | 1 | -1/+1 |
* | | Remove logic related to dictionary loading from LatinIME.•••Make mSuggest final and give DictionaryFacilitator the
responsibility to manage dictionary loading state.
This can simplify the logic to decide how to deal with
additional dictionaries when loading settings or language
switching.
Bug: 13273534
Change-Id: I9f3d328272f25addfa186fbeedaaf8417455ba99
|  Keisuke Kuroyanagi | 2014-03-25 | 1 | -29/+10 |
|/ |
|
* | Merge "[CB10] Add an event for string input" |  Jean Chalard | 2014-03-20 | 1 | -2/+3 |
|\ |
|
| * | [CB10] Add an event for string input•••Change-Id: Ie5da6c73d4df4553067c58cd0dce9abb34534250
|  Jean Chalard | 2014-03-20 | 1 | -2/+3 |
* | | Merge "[IL127] Move the double space countdown to InputLogic" |  Jean Chalard | 2014-03-20 | 1 | -13/+26 |
|\ \
| |/
|/| |
|
| * | [IL127] Move the double space countdown to InputLogic•••Bug: 8636060
Change-Id: Ie193b747bd9d0b5ba6a986b9a3c746c2182742ed
|  Jean Chalard | 2014-03-19 | 1 | -13/+26 |
* | | [CB08] Create a combiner chain in the word composer.•••Bug: 13406701
Change-Id: I3b9f75de9283f76366d1bef7e14a8f22f2186669
|  Jean Chalard | 2014-03-20 | 1 | -1/+0 |
|/ |
|
* | [IL125] Remove arg to onPickSuggestionManually•••Bug: 8636060
Change-Id: I55332c22897e97148621cbd367acf5175b5b3d04
|  Jean Chalard | 2014-03-19 | 1 | -11/+25 |
* | [CB07] Small refactoring•••Bug: 8689779
Change-Id: I2cf10c690c7e4a9c6bf27211d1fccc1f9d4a9249
|  Jean Chalard | 2014-03-17 | 1 | -0/+9 |
* | [CB06] Fix a design error.•••The event interpreter should intervene later, after decoding.
Decoding should happen first, and then the Event should
be passed to the InputLogic.
For the time being, we will leave the (unused) EventInterpreter
class and its friends, because we'll use them again later.
Bug: 13406701
Change-Id: I7582d486724311e39e6692e606cca50c78800643
|  Jean Chalard | 2014-03-17 | 1 | -3/+0 |
* | [CB04] Add an event array to WordComposer.•••Bug: 13406701
Change-Id: I9ecd2709c8f1c678a85b0cfaf7c5ed4f78459821
|  Jean Chalard | 2014-03-14 | 1 | -2/+1 |
* | [CB03] Pass whole events to the various input logic handlers.•••Bug: 13406701
Change-Id: I0a0e4e0b3357f116e1b915c548dee4575e300c92
|  Jean Chalard | 2014-03-13 | 1 | -123/+127 |
* | [CB02] Pass an Event to onCodeInput.•••Bug: 13406701
Change-Id: Id82e9aab6544ca308e6ac6dee2cfa018b9ce2d8f
|  Jean Chalard | 2014-03-13 | 1 | -8/+13 |
* | Merge "[IL124] Remove the KeyboardSwitcher arg to onCodeInput" |  Jean Chalard | 2014-03-06 | 1 | -16/+12 |
|\ |
|
| * | [IL124] Remove the KeyboardSwitcher arg to onCodeInput•••Bug: 8636060
Change-Id: I29ce4c82ea880a937b1c9e5daf494fcdbbdd1336
|  Jean Chalard | 2014-03-06 | 1 | -16/+12 |
* | | Merge "Correctly update the suggestion strip on non-resumable word" |  Jean Chalard | 2014-03-06 | 1 | -1/+4 |
|\ \
| |/
|/| |
|
| * | Correctly update the suggestion strip on non-resumable word•••Bug: 13303965
Change-Id: Iedc5d38f70af76fbebb99e59a0d17c1e226c810d
|  Jean Chalard | 2014-03-05 | 1 | -1/+4 |
* | | [IL123] Put the settings values inside the transaction•••A transaction should always operate with a consistent set
of settings. It's better to have it reference them than to
always pass them along.
Bug: 8636060
Change-Id: I3c642dfea6be30712fc6cbb279c64f3185895791
|  Jean Chalard | 2014-03-06 | 1 | -53/+51 |
* | | [IL122] Put the code, x and y in the transaction•••Bug: 8636060
Change-Id: Icdf87995dedec410b54c306e8d312ba7ec25cea6
|  Jean Chalard | 2014-03-06 | 1 | -83/+77 |
* | | [IL121] Introduce InputTransaction•••We probably can't put this off any longer
Bug: 8636060
Change-Id: I1e5d3cf62d719f4d064ced3282bebf2e822f6baa
|  Jean Chalard | 2014-03-05 | 1 | -29/+49 |
|/ |
|
* | [IL120] Cleanup•••Remove useless arguments, local vars, make stuff private
Change-Id: I7cc6c19e9c1703304d593e02be31eb9569cc7b4e
|  Jean Chalard | 2014-03-04 | 1 | -36/+19 |
* | [IL119] Make fields private.•••Change-Id: Ia84d3e5a102e1056e3d7467be07df89390f17617
|  Jean Chalard | 2014-03-04 | 1 | -3/+3 |
* | [IL115] Cleanup continues•••Bug: 8636060
Change-Id: I944b10ec9798eec57d986e1075ba348aa0892cae
|  Jean Chalard | 2014-03-04 | 1 | -28/+25 |
* | [IL114] Move a method to InputLogic•••Bug: 8636060
Change-Id: I0d8f93985ddc6e93ce9af0d92a8056620351a498
|  Jean Chalard | 2014-03-04 | 1 | -3/+31 |
* | [IL111] Remove a member.•••...and improve encapsulation and readability.
Bug: 8636060
Change-Id: I36407630b307df0721ea7fdb7e7a22cdf2b018b3
|  Jean Chalard | 2014-03-04 | 1 | -7/+6 |
* | [QRP6] Fix: recorrection top candidate is displayed in bold•••Bug: 10385162
Change-Id: Icf9471d474a3a8ed8f38c46c7948c66f9131691e
|  Jean Chalard | 2014-02-25 | 1 | -2/+4 |
* | Don't trim newer inputpointers with old data•••We already have a mechanism to avoid this crash, but it wasn't
used every time it needed to. It's possible that ending a batch
input and starting a batch input happen while suggestions
are being pulled out, which would result in pointers that have
been reset being passed for trimming.
Just increasing the sequence number should get rid of the
problem.
Bug: 12178124
Change-Id: I36ef3bc8a78679bc09daa39e665f5ce1bab50c2a
|  Jean Chalard | 2014-02-21 | 1 | -0/+2 |
* | Merge "Fix a bug where suggestions would not be updated." |  Jean Chalard | 2014-02-20 | 1 | -14/+33 |
|\ |
|
| * | Fix a bug where suggestions would not be updated.•••Also fix a small cosmetic bug where the suggestion strip
would flash.
Bug: 12951777
Change-Id: I68b7bb9175571de9c718f737eebd9f67ea04a931
|  Jean Chalard | 2014-02-20 | 1 | -14/+33 |
* | | Add final and volatile for members of InputLogic.•••Bug: 13107471
Change-Id: I47df79bc6f015c212d1b6d2f63b2efc5da24294e
|  Keisuke Kuroyanagi | 2014-02-20 | 1 | -2/+3 |
|/ |
|
* | Cleanup.•••Less code, less chance of stuff escaping, and a bit of a clarification.
Yay.
Change-Id: I3193fd8ad7ac28195260cbc231c4e498a63a460c
|  Jean Chalard | 2014-02-18 | 1 | -11/+2 |
* | Don't resume suggestion on links.•••Bug: 11447084
Change-Id: I5bd558b9dd85d1505aa918f44e8ac3e52ec42d97
|  Jean Chalard | 2014-02-17 | 1 | -0/+4 |
* | Add PunctuationSuggestions class•••This change must be checked in together with I366c477516.
Bug: 12640318
Change-Id: I8d3864b9d9649c9e3306e82b01a6327b11281b1f
|  Tadashi G. Takaoka | 2014-02-14 | 1 | -2/+2 |
* | Backward compatibility hack : send delete when empty.•••Some apps depend on the keyboard sending something to them
when the text is empty. This is BROKEN. Your app must not lie
to the keyboard about what is before the cursor. If there is something
to delete, you must not pretend there is not and try to catch some
delete event. This will result in a bad user experience. This will not
work with all IMEs. If your app needs this broken behavior, you're
doing it wrong. Seriously guys, we're not in the era of typewriters
any more, there are touch screens, there are gestures, there is
accessibility, there are many innovative IMEs that don't have
keys. Do *NOT* rely on key events.
This change implements an ugly hack so that these broken apps
may continue half-working with LatinIME. We are very unhappy
about this.
Bug: 12998568
Change-Id: Ia62ae2fbee4fee65b463acf3a79aafcfd0defa1d
|  Jean Chalard | 2014-02-13 | 1 | -1/+7 |