| Commit message (Expand) | Author | Age | Files | Lines |
|---|
| * | Fix Binary dict tests•••There are two problems here. The first one is the tests would send
an invalid unicode character. Although we could want dicttool to
handle this more gracefully, it's fine for now.
The second problem is much more serious. If a node has more than
128 children, then the java code will crash trying to read the
dictionary back because of a bug that this change fixes. In
theory, it's possible that happens when we try to load the user
history dictionary back from the disk - native code is not affected
so there is no other point that may cause a problem.
In the practice, that means you'd need to have 129 words with a
common prefix (including empty string) but all different after
this. It's almost impossible with Google Keyboard since there are
only so many keys on the keyboard that you can make a word out
of, and then again you'd have to do it repeatedly until it
actually enters the user history dictionary, wait for it to get
saved on the disk.
The bad news is, if you manage to get this far, the keyboard will
crash every time and won't be able to get up until you clear
data for the package.
The good news is, the dictionary itself is not corrupted and only
the reading code is wrong. So updating to a newer version would
actually even recover from this situation.
All in all, considering how almost-impossible this is to trigger,
I don't think even a single user actually did hit this bug.
Bug: 8583091
Change-Id: Iabb2a7f47cbd9ed3193d2a3487318d280753e071
|   Jean Chalard | 2013-04-15 | 1 | -4/+4 |
| * | Fix Apache license comment•••Change-Id: Ic56167f952a7f4449da366e1e81610e72c966086
|   Tadashi G. Takaoka | 2013-01-21 | 1 | -8/+8 |
| * | Small code cleanups•••Multi-project commit with I249d5fbe
Change-Id: Ia28c4e970992aa1299a30e604eaa5d096655c3a5
|   Ken Wakasa | 2013-01-07 | 1 | -0/+1 |
| * | Remove a useless member•••Change-Id: Id13e0aeec6ec3655d6bb0edc7f8f7821e7dc5a36
| Jean Chalard | 2012-12-11 | 1 | -2/+0 |
| * | Remove a couple Eclipse and Android Lint warnings•••Change-Id: I0c29c5d2abcbf80759b996d34b534deb083cd7d3
| Jean Chalard | 2012-12-06 | 1 | -0/+2 |
| * | Remove warnings•••Thanks Eclipse
Change-Id: I88e3979ed22be5d8be5a5accdde417c6b1a8bf2d
| Jean Chalard | 2012-10-29 | 1 | -8/+4 |
| * | Add auto detection and decoding of dictionary files. (A2)•••Bug: 7388852
Change-Id: I25e755fc15f5b383acc046f668e9681efa4f0c2f
| Jean Chalard | 2012-10-25 | 1 | -2/+9 |
| * | Return the correct bigram frequency•••The "correct" bigram frequency is now returned by the reading
code. However, as the binary format represents the frequency
in a lossy manner, the frequency is not guaranteed to be the
exact same as the one in the source text format - only a close
enough value. It is however the exact same value seen by the
native code.
Bug: 7395653
Change-Id: I49199ef18901c671189912b3550623e9643baedd
| Jean Chalard | 2012-10-23 | 1 | -12/+21 |
| * | Add @UsedForTesting and @ExternallyReferenced annotations•••Bug: 7268357
Change-Id: I0b7e0c19f04af9ae30874d0a4c26ad81bc80be8c
| Tadashi G. Takaoka | 2012-10-22 | 1 | -0/+2 |
| * | Add insertWord.•••bug: 6669677
Change-Id: Ide55a4931071de9cd42c1cddae63ddd531d2feba
|   Yuichiro Hanada | 2012-10-04 | 1 | -1/+2 |
| * | Add writeNode.•••Change-Id: I088bb6ea43ce0841d725e48b677d429e1155569d
| Yuichiro Hanada | 2012-10-04 | 1 | -4/+17 |
| * | Add updateParentAddresses.•••Change-Id: Iac210131b7c003ef363e1138bf22f777a37c6a89
| Yuichiro Hanada | 2012-10-03 | 1 | -1/+1 |
| * | Add isDeletedGroup.•••Change-Id: I83f09c068868e5e6e1b46f494a6ef957f0b466d8
| Yuichiro Hanada | 2012-10-03 | 1 | -0/+8 |
| * | Add MAX_BIGRAMS_IN_A_GROUP.•••Change-Id: I128d5deb8e523045d7ad77d7a8fd3db944f71238
| Yuichiro Hanada | 2012-10-03 | 1 | -1/+5 |
| * | Add makeCharGroupFlags.•••Change-Id: Id2c580f21b77f66a97c5fbdf4542fdafe6c43614
| Yuichiro Hanada | 2012-10-03 | 1 | -41/+48 |
| * | Add writeCharGroup.•••bug: 6669677
Change-Id: I36792ba9c511a5148c963096cc93ca8c2e0ee04e
| Yuichiro Hanada | 2012-10-01 | 1 | -4/+5 |
| * | Add updateChildrenAddress.•••Change-Id: Ic06a755d85612476e719e580469dc1cd9447286c
| Yuichiro Hanada | 2012-09-28 | 1 | -4/+3 |
| * | Cleanup: Make some classes as final•••Change-Id: I6009b3c1950ba32b7f1e205a3db2307fe0cd688e
| Tadashi G. Takaoka | 2012-09-27 | 1 | -2/+2 |
| * | Add moved char groups.•••bug: 6669677
Change-Id: I372f841044fe8e076a50a80ac10b715e5f8fd4eb
| Yuichiro Hanada | 2012-09-26 | 1 | -2/+21 |
| * | add capacity to FusionDictionaryBufferInterface.•••bug: 6669677
Change-Id: I4627093811a19c46ce13fe351d1db63cbd78cf4a
| Yuichiro Hanada | 2012-09-25 | 1 | -0/+6 |
| * | Make children addresses and parent addresses use signed addresses.•••Signed addresses are used only in version 3 with dynamic update.
bug: 6669677
Change-Id: Iadaeab199b5019d2330b4573c24da74d64f0945e
| Yuichiro Hanada | 2012-09-25 | 1 | -59/+153 |
| * | Combine mHasParentAddress with mHasLinkedListNode into mSupportsDynamicUpdate.•••bug: 6669677
Change-Id: I82799af199358420f09ac34fc005091e202c5d3b
| Yuichiro Hanada | 2012-09-24 | 1 | -18/+17 |
| * | Add deleteWord.•••bug: 6669677
Change-Id: I1a5b90ee05e5cffd74a5c140384a3e37c79e7e70
| Yuichiro Hanada | 2012-09-21 | 1 | -1/+1 |
| * | Add getTerminalPosition.•••Change-Id: If04d779db23b1aea2cc12e5e9b8cecfcb35a5737
| Yuichiro Hanada | 2012-09-20 | 1 | -2/+3 |
| * | Make BinaryDictIOUtils.•••Change-Id: I45830235ee738233e8eb2bd91d659705b698f58c
| Yuichiro Hanada | 2012-09-19 | 1 | -102/+5 |
| * | Make readNode read linked list nodes.•••Change-Id: Ia5eaae0653179b2eb74c53b0823beaf80377a389
| Yuichiro Hanada | 2012-09-19 | 1 | -32/+50 |
| * | add limit to FusionDictionaryBufferInterface.•••Change-Id: Ic9ff717a9751023d47b02ff3b9d1fbf3115c2501
| Yuichiro Hanada | 2012-09-19 | 1 | -0/+6 |
| * | Add a new flag for linked list nodes.•••Change-Id: Ib2f194775cfe5ab05481ac95cd709d6e8e8dd3c6
| Yuichiro Hanada | 2012-09-18 | 1 | -2/+4 |
| * | Make writePlacedNode write the linked-list node.•••Change-Id: I60feda815ea08cf73300fccca1ae12b97550f116
| Yuichiro Hanada | 2012-09-18 | 1 | -4/+19 |
| * | Remove populateOptions(final ByteBuffer buffer).•••Change-Id: Ifc4c64c9cffe4f343c5a604c192db010a1792acc
| Yuichiro Hanada | 2012-09-18 | 1 | -5/+0 |
| * | Refactor BinaryDictInputOutput.•••Change-Id: Idb4b635fcac70cc988e0dd3ce3bf121fba12099c
| Yuichiro Hanada | 2012-09-14 | 1 | -6/+0 |
| * | Move FormatOptions and FileHeader to FormatSpec.•••Change-Id: I232e35598635113bf2c81825669c744aadc79efe
| Yuichiro Hanada | 2012-09-13 | 1 | -34/+2 |
| * | Move constants and comments.•••Change-Id: Ifd66bda7d528827ba61c60531121ea206a2325be
| Yuichiro Hanada | 2012-09-13 | 1 | -281/+123 |
| * | Add put method to FusionDictionaryBufferInterface.•••Change-Id: Iac0b35d2da05e81237d105e8fe13c56d16038de1
| Yuichiro Hanada | 2012-09-12 | 1 | -0/+6 |
| * | Add new binary dictionary format.•••Change-Id: Ia99411d4009857d5e420ca87ef8acf1f1826d3ed
| Yuichiro Hanada | 2012-09-10 | 1 | -55/+202 |
| * | Check the length of the word when add to FusionDictionary.•••Change-Id: Id98d18e90a8b83b597507728b467f56888c8fd12
| Yuichiro Hanada | 2012-09-10 | 1 | -1/+2 |
| * | Add FormatOptions.•••Change-Id: Ibad05a5f9143de1156b2c897593ec89b0a0b07e7
| Yuichiro Hanada | 2012-09-05 | 1 | -22/+50 |
| * | Merge "Reinstate the shortcut-only attribute" into jb-mr1-dev | Jean Chalard | 2012-09-02 | 1 | -5/+21 |
| |\ |
|
| | * | Reinstate the shortcut-only attribute•••Also add the blacklist attribute
Bug: 7005742
Bug: 2704000
Change-Id: Icbe60bdf25bfb098d9e3f20870be30d6aef07c9d
| Jean Chalard | 2012-08-31 | 1 | -5/+21 |
| * | | add UserHistoryDictIOUtils.•••Change-Id: I8a70e43b23f65b5fd5f0ee0b30a94ad8f5ef8a8a
| Yuichiro Hanada | 2012-08-31 | 1 | -11/+2 |
| * | | add readUnigramsAndBigramsBinary.•••Change-Id: I7967f11211221d4877bf0a0c30183af885f45390
| Yuichiro Hanada | 2012-08-31 | 1 | -9/+114 |
| |/ |
|
| * | add readHeader.•••Change-Id: I5be5d62a63ca897e36fe93200ffdca6befb363aa
| Yuichiro Hanada | 2012-08-30 | 1 | -20/+45 |
| * | Add FusionDictionaryBufferInterface.•••Change-Id: I8640c994231d5f46bc6e074ce8a5bf5344fed0aa
| Yuichiro Hanada | 2012-08-29 | 1 | -68/+107 |
| * | Use ByteBuffer when reading FusionDictionary from file.•••Change-Id: Ia71561648e17f846d277c22309ac37c21c67a537
| Yuichiro Hanada | 2012-08-24 | 1 | -89/+134 |
| * | Hack to skip reading an outdated binary file.•••Bug: 7005813
Change-Id: Ie0d8d4b2d5eb147838ca23bdd5ec1cecd4f01151
| Jean Chalard | 2012-08-20 | 1 | -6/+17 |
| * | Merge "add reconstructBigramFrequency" into jb-mr1-dev | Ken Wakasa | 2012-08-17 | 1 | -0/+18 |
| |\ |
|
| | * | add reconstructBigramFrequency•••Change-Id: Iff20dcb9ca0d6064bb118247887fe24b812c0c61
| Yuichiro Hanada | 2012-08-17 | 1 | -0/+18 |
| * | | Reword a confusing comment•••Bug: 7005645
Change-Id: Ifd942b3ce242aeeec512e132e1cee31329e994b1
| Jean Chalard | 2012-08-17 | 1 | -4/+4 |
| |/ |
|
| * | Small performance tweak•••Change-Id: Icd540742073d49d12e70b2d8bd99aaf7ccb5802d
| Jean Chalard | 2012-06-08 | 1 | -3/+3 |
| * | Remove a slew of Eclipse warnings.•••Change-Id: I03236386aea13fbd4fb8eaeee18e0008aa136502
| Jean Chalard | 2012-06-08 | 1 | -1/+1 |
