| Commit message (Expand) | Author | Age | Files | Lines |
|---|
| * | Merge "Use dynamic operations to construct all ver4 dicts." |   Keisuke Kuroyanagi | 2014-02-28 | 9 | -414/+150 |
| |\ |
|
| | * | Use dynamic operations to construct all ver4 dicts.•••Bug: 8187060
Bug: 13127350
Change-Id: I081ee904c41898128efa8ba7a1bf3fa0a46c6231
| Keisuke Kuroyanagi | 2014-02-27 | 9 | -414/+150 |
| * | | Merge "Added a method and run GC for testing." | Keisuke Kuroyanagi | 2014-02-28 | 4 | -12/+38 |
| |\ \ |
|
| | * | | Added a method and run GC for testing.•••Bug: 13231889
Change-Id: If64b7422967c3e4107c845072b64a7bb26a35f7e
| Keisuke Kuroyanagi | 2014-02-28 | 4 | -12/+38 |
| | |/ |
|
| * / | Add missing null checks for getOwnerInstance()•••It may just return null.
Change-Id: I778fb48262ef8af28a4af50b70bb94ace75a488c
|   Ken Wakasa | 2014-02-28 | 1 | -11/+33 |
| |/ |
|
| * | Fix a bug with auto-caps entries from personalization•••Bug: 13215163
Change-Id: I00099cb4927c96de46e57e14ab906d41c9c2151a
|   Jean Chalard | 2014-02-27 | 1 | -3/+6 |
| * | Merge "Set additional attributes in dictionary facilitator." | Keisuke Kuroyanagi | 2014-02-26 | 1 | -1/+11 |
| |\ |
|
| | * | Set additional attributes in dictionary facilitator.•••Bug: 13197276
Change-Id: I206cf4e599ca9cdf40d669358a1067a2954d11e3
| Keisuke Kuroyanagi | 2014-02-26 | 1 | -1/+11 |
| * | | Merge "Add a method to create dict with additional attributes." | Keisuke Kuroyanagi | 2014-02-26 | 1 | -1/+12 |
| |\| |
|
| | * | Add a method to create dict with additional attributes.•••Bug: 13197276
Change-Id: I80311a51d9e98bfeb8c0dd9cd4adde93af366d54
| Keisuke Kuroyanagi | 2014-02-26 | 1 | -1/+12 |
| * | | Merge "Use NOT_A_PROBABILITY for adding OOV words." | Keisuke Kuroyanagi | 2014-02-26 | 1 | -3/+3 |
| |\ \ |
|
| | * | | Use NOT_A_PROBABILITY for adding OOV words.•••Bug: 13197276
Change-Id: I23f453c2c1deea70eab552f8d433fe264adf68b3
| Keisuke Kuroyanagi | 2014-02-26 | 1 | -3/+3 |
| * | | | Merge "[IL110] Remove an unused interface function" | Jean Chalard | 2014-02-26 | 2 | -4/+1 |
| |\ \ \ |
|
| | * | | | [IL110] Remove an unused interface function•••...and make a method private.
Bug: 8636060
Change-Id: If16f7e8ef3779f77a9db23fb7c54e7c23b043b86
| Jean Chalard | 2014-02-26 | 2 | -4/+1 |
| * | | | | Merge "Read and write forgetting curve header attributes." | Keisuke Kuroyanagi | 2014-02-26 | 1 | -0/+4 |
| |\ \ \ \
| |/ / /
|/| | /
| | |/
| |/| |
|
| | * | | Read and write forgetting curve header attributes.•••Bug: 13197276
Change-Id: I6c38a127e1745903594b7bf0ec80ef179e794feb
| Keisuke Kuroyanagi | 2014-02-26 | 1 | -0/+4 |
| | |/ |
|
| * / | Remove useless args and processing.•••Bug: 13062385
Change-Id: I426545d1fe8fd76bcf4d1dce19e6b571a55c79ae
| Jean Chalard | 2014-02-26 | 1 | -16/+10 |
| |/ |
|
| * | [QRP6] Fix: recorrection top candidate is displayed in bold•••Bug: 10385162
Change-Id: Icf9471d474a3a8ed8f38c46c7948c66f9131691e
| Jean Chalard | 2014-02-25 | 1 | -2/+4 |
| * | [QRP5] Fix boldness for predictions, and small refactoring•••This is more correct. When predictions, the typed word should
always be null unless explicitly passed. The text color should be
that of a valid typed word only if it's actually the typed word.
Bug: 13170509
Change-Id: I769ae100e112c37c6f02064fe9ef2f81372ca9e5
| Jean Chalard | 2014-02-25 | 3 | -5/+6 |
| * | [QRP4] Simplification & small correctness fix.•••This fixes the color of the predictions when running
on a theme that has different colors for typed and
suggested words (GB theme).
Also, this is easier to understand and to modify from
now on.
Change-Id: Ifdc6d86a1695e83e16103041b06a2451f8d52cc4 | Jean Chalard | 2014-02-25 | 1 | -6/+6 |
| * | [QRP3] Refactoring•••Rename some variables for clarity and use constants
instead of immediates.
Change-Id: Ie07fbfcc3738ac4e67aefddc339fc54259172c39
| Jean Chalard | 2014-02-25 | 1 | -13/+15 |
| * | [QRP2] Small refactor•••Bug: 13170509
Change-Id: Ib9f10b8a137fc773ab0e5dc903e577038e29a9e2
| Jean Chalard | 2014-02-25 | 1 | -3/+4 |
| * | [QRP1] Fix a bug where the wrong value would get passed•••In the practice it works because this never tries to access
inside the suggestion strip, and the worst that can happen
is a wrong text color for a suggestion. But since the two
colors that would be swapped are the same, nobody ever
notices -- unless they are using the GingerBread theme.
Change-Id: Ic8c70d8b3cdddf92946dfefbbc6d061572626c7a
| Jean Chalard | 2014-02-25 | 1 | -3/+3 |
| * | Merge "Correctly read the header of APK-embedded dicts" | Jean Chalard | 2014-02-24 | 5 | -17/+28 |
| |\ |
|
| | * | Correctly read the header of APK-embedded dicts•••Bug: 13164518
Change-Id: I8768ad887af8b89ad9f29637f606c3c68629c7ca
| Jean Chalard | 2014-02-24 | 5 | -17/+28 |
| * | | Merge "Use an executor to serialize opening dictionaries." | Jean Chalard | 2014-02-24 | 1 | -3/+3 |
| |\ \ |
|
| | * | | Use an executor to serialize opening dictionaries.•••Bug: 13082957
Change-Id: I25570ab4da94337ed60330c0869fe47657096626
| Jean Chalard | 2014-02-24 | 1 | -3/+3 |
| * | | | Merge "Create a utils class for executors." |   Tadashi G. Takaoka | 2014-02-24 | 2 | -49/+75 |
| |\| | |
|
| | * | | Create a utils class for executors.•••Preliminary refactoring to fix
Bug: 13082957
Change-Id: I9f1283c37089bc96140b774b1c559d58031de004
| Jean Chalard | 2014-02-24 | 2 | -49/+75 |
| | |/ |
|
| * / | Never pass negative values to setSelection.•••Bug: 13136079
Change-Id: Ieae6bafbd5339a033f0f342ba9af7dcc4ce209fa
| Jean Chalard | 2014-02-24 | 1 | -2/+6 |
| |/ |
|
| * | Disconnect app data search client after fetching all data.•••Bug: 13138201
Change-Id: Ibaa3c2c22a4fe44ea23e92ce8576141bbad09b12
| Keisuke Kuroyanagi | 2014-02-24 | 2 | -0/+11 |
| * | Merge "Change a heuristic and add a log." | Jean Chalard | 2014-02-21 | 2 | -3/+5 |
| |\ |
|
| | * | Change a heuristic and add a log.•••The heuristic in RichInputConnection makes little sense
when textLength > mExpectedSelStart but we have
more than 1024 characters of text. If there are that many,
it's about 100% sure that 1024 is not the correct cursor
position. With no good guess, we'll just continue trusting
the app, even though we know it's lying : at least it will
make the problem visible to the app author.
Also, there have been a lot of confusion about initialSelStart
and initialSelEnd. The keyboard should log them so that
it helps us and editor authors debug more easily these
common problems.
Issue #65170 in AOSP and
Bug: 12772035
Change-Id: I6665a16c9f2832d33ee323f033bb38bcc092a3b4
| Jean Chalard | 2014-02-20 | 2 | -3/+5 |
| * | | Merge "Fix: file descriptor leaking." | Keisuke Kuroyanagi | 2014-02-21 | 2 | -22/+32 |
| |\ \ |
|
| | * | | Fix: file descriptor leaking.•••File descriptors will be closed in
BinaryDictionary.finalize(); but, this leads to unit test fails.
Bug: 13066902
Change-Id: I2b0d3e54ee91fa844530df54596f86bbbbac81a5
| Keisuke Kuroyanagi | 2014-02-21 | 2 | -22/+32 |
| | |/ |
|
| * | | Merge "Don't trim newer inputpointers with old data" | Jean Chalard | 2014-02-21 | 1 | -0/+2 |
| |\ \ |
|
| | * | | Don't trim newer inputpointers with old data•••We already have a mechanism to avoid this crash, but it wasn't
used every time it needed to. It's possible that ending a batch
input and starting a batch input happen while suggestions
are being pulled out, which would result in pointers that have
been reset being passed for trimming.
Just increasing the sequence number should get rid of the
problem.
Bug: 12178124
Change-Id: I36ef3bc8a78679bc09daa39e665f5ce1bab50c2a
| Jean Chalard | 2014-02-21 | 1 | -0/+2 |
| | |/ |
|
| * | | Merge "Remove corrupted ver4 dictionaries." | Keisuke Kuroyanagi | 2014-02-21 | 2 | -10/+38 |
| |\ \ |
|
| | * | | Remove corrupted ver4 dictionaries.•••Bug: 12916055
Change-Id: I2c390ab1dc483915691b47a605772cbc2dfeaf09
| Keisuke Kuroyanagi | 2014-02-21 | 2 | -10/+38 |
| * | | | Add ImportantNoticeDialog•••Change-Id: Icaeb7dddd16362cd4a6384d295f89c7fbabc8b35
| Tadashi G. Takaoka | 2014-02-21 | 2 | -45/+93 |
| * | | | Support versioned important notice•••This change must be checked in together with If38a754d00.
Bug: 10587358
Change-Id: I91580f9468bc5ee7ed1694d7852a60dc6793dac0
| Tadashi G. Takaoka | 2014-02-21 | 2 | -17/+30 |
| | |/
|/| |
|
| * | | Merge "Fix a bug where suggestions would not be updated." | Jean Chalard | 2014-02-20 | 1 | -14/+33 |
| |\ \ |
|
| | * | | Fix a bug where suggestions would not be updated.•••Also fix a small cosmetic bug where the suggestion strip
would flash.
Bug: 12951777
Change-Id: I68b7bb9175571de9c718f737eebd9f67ea04a931
| Jean Chalard | 2014-02-20 | 1 | -14/+33 |
| * | | | Merge "Don't distrust the cursor pos so much as to bug on IPC delay" | Jean Chalard | 2014-02-20 | 2 | -17/+6 |
| |\ \ \
| |_|/
|/| | |
|
| | * | | Don't distrust the cursor pos so much as to bug on IPC delay•••When the cursor is moved by the user, the RichInputConnection
is told about it. However, to work around a framework bug, it
also looks at how many characters are in the buffer before the
cursor, and if that's more than the value it's been passed, it
deduces that's a framework bug and there are at least as many
characters as seen before the cursor, so it puts the expected
cursor position there.
When you move the cursor, TextView calls onUpdateSelection,
and when you move it fast, you'll get rapid-fire calls to
onUpdateSelection. This is fine, the RIC is equipped to
deal with that.
However, these calls take some time to make it to the IME. In
this instance, when the first call gets through and the IME
calls TextView (synchronously) for text before the cursor, the
cursor has already moved in the app, and TextView returns more
characters than the cursor position was declared to be in this
instance, so the RIC sets that as the expected cursor position.
Sure enough, a split second later, the second call to
onUpdateSelection arrives, with the new cursor position set
where the RIC had found it too early. The RIC takes that as an
"expected" cursor move, and the input does not get reset.
Luckily, we have a way out. As far as we know, the framework bug
only manifests itself upon rotation, which means we should only
have to adjust for it in onStartInputView. Doing it in
onUpdateSelection is too zealous (and probably too distrustful of
the app to send the correct cursor positions).
So we should just take care of the rotation case (by calling
tryFixLyingCursorPosition in onStartInputView) and remove the
compensating code in resetCachesUponCursorMoves.
Bug: 12982502
Change-Id: Ic3c1408a1ec45deaea63b01d98376a79ae567d77
| Jean Chalard | 2014-02-20 | 2 | -17/+6 |
| | |/ |
|
| * | | Add test only methods to test personalized dicts.•••Bug: 11122480
Change-Id: I79a4a73ff09a2d34d4ca094d705e901fb4bc855c
| Keisuke Kuroyanagi | 2014-02-20 | 2 | -2/+28 |
| * | | Merge "Add final and volatile for members of InputLogic." | Keisuke Kuroyanagi | 2014-02-20 | 1 | -2/+3 |
| |\ \ |
|
| | * | | Add final and volatile for members of InputLogic.•••Bug: 13107471
Change-Id: I47df79bc6f015c212d1b6d2f63b2efc5da24294e
| Keisuke Kuroyanagi | 2014-02-20 | 1 | -2/+3 |
| * | | | Merge "Add user history dictionary decaying test." | Keisuke Kuroyanagi | 2014-02-20 | 1 | -2/+2 |
| |\ \ \ |
|
| | * | | | Add user history dictionary decaying test.•••Bug: 10667710
Change-Id: Ib2be57d8c4cbbb34f64555d84ea6fd571cfdd247
| Keisuke Kuroyanagi | 2014-02-20 | 1 | -2/+2 |
