| Commit message (Expand) | Author | Age | Files | Lines |
|---|
| * | Merge "Change expandable binary dict write to a temp file first." |   Tom Ouyang | 2012-04-24 | 1 | -1/+4 |
| |\ |
|
| | * | Change expandable binary dict write to a temp file first.•••Bug: 6380724
Change-Id: Ic1d0d902dc45ecb41a1792f33a60ab85e606fcef
| Tom Ouyang | 2012-04-24 | 1 | -1/+4 |
| * | | Merge "Fix binary reading code performance." |   Jean Chalard | 2012-04-23 | 1 | -1/+10 |
| |\ \ |
|
| | * | | Fix binary reading code performance.•••This is not the Right fix ; the Right fix would be to read
the file in a buffered way. However this delivers tolerable
performance for a minimal amount of code changes.
We may want to skip submitting this patch, but keep it around
in case we need to use the functionality until we have a good
patch.
Change-Id: I1ba938f82acfd9436c3701d1078ff981afdbea60
| Jean Chalard | 2012-04-24 | 1 | -1/+10 |
| * | | | Merge "Make the "Touch again to save" hint text touchable." |   Tadashi G. Takaoka | 2012-04-23 | 1 | -7/+18 |
| |\ \ \ |
|
| | * | | | Make the "Touch again to save" hint text touchable.•••Bug: 6355346
Change-Id: I96933719cc94f25e6c7ecb1d6345c11b6acc4134
| Tadashi G. Takaoka | 2012-04-24 | 1 | -7/+18 |
| * | | | | Merge "Fix a bug where a node size would be seen as increasing." | Jean Chalard | 2012-04-23 | 1 | -5/+25 |
| |\ \ \ \ |
|
| | * | | | | Fix a bug where a node size would be seen as increasing.•••The core reason for this is quite shrewd. When a word is a bigram
of itself, the corresponding chargroup will have a bigram referring
to itself. When computing bigram offsets, we use cached addresses of
chargroups, but we compute the size of the node as we go. Hence, a
discrepancy may happen between the base offset as seen by the bigram
(which uses the recomputed value) and the target offset (which uses
the cached value).
When this happens, the cached node address is too large. The relative
offset is negative, which is expected, since it points to this very
charnode whose start is a few bytes earlier. But since the cached
address is too large, the offset is computed as smaller than it should
be.
On the next pass, the cache has been refreshed with the newly computed
size and the seen offset is now correct (or at least, much closer to
correct). The correct value is larger than the previously computed
offset, which was too small. If it happens that it crosses the -255 or
-65335 boundary, the address will be seen as needing 1 more byte than
previously computed. If this is the only change in size of this node,
the node will be seen as having a larger size than previously, which
is unexpected. Debug code was catching this and crashing the program.
So this case is very rare, but in an even rarer occurence, it may
happen that in the same node, another chargroup happens to decrease
it size by the same amount. In this case, the node may be seen as
having not been modified. This is probably extremely rare. If on
top of this, it happens that no other node has been modified, then
the file may be seen as complete, and the discrepancy left as is
in the file, leading to a broken file. The probability that this
happens is abyssally low, but the bug exists, and the current debug
code would not have caught this.
To further catch similar bugs, this change also modifies the test
that decides if the node has changed. On grounds that all components
of a node may only decrease in size with each successive pass, it's
theoritically safe to assume that the same size means the node
contents have not changed, but in case of a bug like the bug above
where a component wrongly grows while another shrinks and both cancel
each other out, the new code will catch this. Also, this change adds
a check against the number of passses, to avoid infinite loops in
case of a bug in the computation code.
This change fixes this bug by updating the cached address of each
chargroup as we go. This eliminates the discrepancy and fixes the
bug.
Bug: 6383103
Change-Id: Ia3f450e22c87c4c193cea8ddb157aebd5f224f01
| Jean Chalard | 2012-04-24 | 1 | -5/+25 |
| | | |/ /
| |/| | |
|
| * | | | | Fix NPE in AdditionalSubtypeSettings•••Bug: 6384416
Change-Id: I878071b8b78acce51649f9637b59830ab681c696
| Tadashi G. Takaoka | 2012-04-24 | 1 | -0/+1 |
| | |/ /
|/| | |
|
| * | | | Merge "Fix a bug where two spaces would be added instead of one" | Jean Chalard | 2012-04-23 | 1 | -15/+16 |
| |\ \ \
| |/ /
|/| | |
|
| | * | | Fix a bug where two spaces would be added instead of one•••Bug: 6378291
Change-Id: Id2453333ae16146f816faf0eb68baa8ea1dd106a
| Jean Chalard | 2012-04-23 | 1 | -15/+16 |
| * | | | Merge "Fix a bug where a batch edit would not be started." | Jean Chalard | 2012-04-23 | 1 | -1/+3 |
| |\| | |
|
| | * | | Fix a bug where a batch edit would not be started.•••This would end up in TextView sometimes calling onUpdateSelection
multiple times (this is the correct behavior for TextView). We now
commit the space and the word in a batch edit, and we only get
onUpdateSelection once.
Bug: 6300527
Change-Id: I9579f3d8f5320c1cc24a7a42f19db8e105eb090d
| Jean Chalard | 2012-04-23 | 1 | -1/+3 |
| * | | | Merge "Pass words as int[] to the native code." | Jean Chalard | 2012-04-23 | 1 | -6/+6 |
| |\ \ \
| |_|/
|/| | |
|
| | * | | Pass words as int[] to the native code.•••We need to get the bigrams during the call to getSuggestions for
bug#6313806. We already give an int[] to getSuggestions and we
wanted to get rid of char[]'s anyway because it doesn't work with
surrogate pairs, so here we go.
Bug: 6313806
Change-Id: I56ce99f1db6b3302cdf42f0527343bded837091e
| Jean Chalard | 2012-04-23 | 1 | -6/+6 |
| * | | | Merge "Binary bigram lookup checks both uppercase and lowercase when previous... | Tom Ouyang | 2012-04-23 | 2 | -14/+37 |
| |\ \ \
| |_|/
|/| | |
|
| | * | | Binary bigram lookup checks both uppercase and lowercase when previous word i...•••Bug: 6363029
Change-Id: I71a1ed5b88f54fcc15bfaf89d3645b8f17ebb821
| Tom Ouyang | 2012-04-22 | 2 | -14/+37 |
| * | | | Merge "Fix using keyboard layout display name in custom input style spinner" | Tadashi G. Takaoka | 2012-04-22 | 1 | -9/+8 |
| |\ \ \
| |_|/
|/| | |
|
| | * | | Fix using keyboard layout display name in custom input style spinner•••Change-Id: I80626591574aa9995011202cf868f9c2c5168303
| Tadashi G. Takaoka | 2012-04-23 | 1 | -9/+8 |
| | |/ |
|
| * / | Use the best matching cached dictionary for each category•••Bug: 6327270
Change-Id: I5a0e732c8a3fd55fd8ac3c8fe1c58e7f91555d97
| Jean Chalard | 2012-04-23 | 1 | -9/+62 |
| |/ |
|
| * | Remove unused methods and classes•••Change-Id: I1a82bf2202d436efa4c5135d705a048fe45a0257
|   Ken Wakasa | 2012-04-22 | 1 | -75/+0 |
| * | Remove an unused method•••Change-Id: I3abbf6462c31b11167e356fe77b8afca2514a869
| Ken Wakasa | 2012-04-22 | 1 | -24/+0 |
| * | Merge "Predefined keyboard layouts are configurable via XML resource" | Tadashi G. Takaoka | 2012-04-20 | 4 | -35/+46 |
| |\ |
|
| | * | Predefined keyboard layouts are configurable via XML resource•••Bug: 4460018
Change-Id: Ia03ec826fb3853ea814d9764686903dbe31a6507
| Tadashi G. Takaoka | 2012-04-20 | 4 | -35/+46 |
| * | | Allow using a format version 2 word list in LatinIME•••Change-Id: I73a4df3a83e49be6e8d3a7d14eb027cfe10f1a23
| Jean Chalard | 2012-04-20 | 1 | -7/+13 |
| |/ |
|
| * | Support Dvorak layout•••Bug: 4460018
Change-Id: I08a9b556720f6c4f7089a8838c0869c9f88f479c
| Tadashi G. Takaoka | 2012-04-20 | 2 | -2/+10 |
| * | Don't allow cancelling manual pick.•••Bug: 6347202
Change-Id: I30b53256e83c534436b0f0ff594fd4aaabf4558c
| Jean Chalard | 2012-04-20 | 1 | -0/+2 |
| * | Merge "remove unnecessary KeyboardState logging" |   Kurt Partridge | 2012-04-19 | 1 | -114/+0 |
| |\ |
|
| | * | remove unnecessary KeyboardState logging•••Bug: 6188932
Change-Id: Iafbb1825777122a1810fa3339853263aced3077e
| Kurt Partridge | 2012-04-19 | 1 | -114/+0 |
| * | | Merge "researchLogger detail on IME sessions" | Kurt Partridge | 2012-04-19 | 2 | -55/+104 |
| |\| |
|
| | * | researchLogger detail on IME sessions•••log device type, screen size, etc. also simplification inside ResearchLogger
to use exceptions better, and fix ResearchLoggerTests to not change
preferences to specify the logfile.
multi-project change with Idfd193b16260215cca32886e288f03a0c12b2781
Bug: 6188932
Change-Id: Idd3ca6eb8e8e3934f68234b241c7fd7d0cc3bcd5
| Kurt Partridge | 2012-04-19 | 2 | -55/+104 |
| * | | Merge "Change binary dictionary output buffer size to match dictionary size." | Tom Ouyang | 2012-04-19 | 1 | -32/+65 |
| |\ \
| |/
|/| |
|
| | * | Change binary dictionary output buffer size to match dictionary size.•••Bug: 6355943
Change-Id: Iaab7bc16ba0dbc7bfde70b06e7bd355519838831
| Tom Ouyang | 2012-04-19 | 1 | -32/+65 |
| * | | Move main dictionary availability check to LatinIME•••Change-Id: Ib6183fec833d87bc32514b03bb691fec0a1e6ff8
| Tadashi G. Takaoka | 2012-04-19 | 2 | -19/+18 |
| * | | Fix SubtypeSwitcher to honor subtype•••Bug: 6364170
Change-Id: I31f9a7c9b6b4ca04a1c78a4210dcaae0db9825db
| Tadashi G. Takaoka | 2012-04-19 | 2 | -136/+46 |
| * | | Fix stack overflow•••Change-Id: I977b240ea462b40852ba9504282312d5fa4e2885
| Tadashi G. Takaoka | 2012-04-19 | 1 | -1/+1 |
| * | | Remove LatinIME reference from DictionaryFactor class•••Change-Id: Iad10e71baa81a1b4eb3c84ead47d658d567b8201
| Tadashi G. Takaoka | 2012-04-19 | 1 | -7/+8 |
| * | | Add Constants class to hold public constants•••This change also gets rid of compiler warnings about "deprecations".
Change-Id: Id9b83483c453a81ebac34b684656db05e3599657
| Tadashi G. Takaoka | 2012-04-19 | 7 | -71/+135 |
| * | | Add custom subtype settings•••Bug: 4460018
Change-Id: I4919d79516dcf574be2761bbaf9adcdc381b2ddc
| Tadashi G. Takaoka | 2012-04-19 | 6 | -31/+522 |
| * | | Change predefined additional subtype format in preference•••This change also refactor StringUtils class
Change-Id: Ie0b4d169b21c260bf238d6fcc9ab0ee8bfd6b508
| Tadashi G. Takaoka | 2012-04-19 | 5 | -47/+72 |
| |/ |
|
| * | Make predefined subtype configurable by XML resource•••Change-Id: I1f8486a1fb652f1e06789e7bfd2cc57273092234
| Tadashi G. Takaoka | 2012-04-18 | 4 | -15/+29 |
| * | Cleanup InputMethodManagerCompatWrapper•••Change-Id: Id3b84ee19bb504ed8fbb398e260cc663a5b5ae0d
| Tadashi G. Takaoka | 2012-04-18 | 4 | -54/+62 |
| * | Fix typo of some methods' name•••Also changes some methods' argument type from Locale to String.
Change-Id: Ib68b528a450dc68a01546483403230f76500bee4
| Tadashi G. Takaoka | 2012-04-18 | 6 | -20/+17 |
| * | researchLogging for inputConnection events•••Bug: 6188932
Change-Id: I596df68956abd879293cfb550e66e7d7d0ba74e9
| Kurt Partridge | 2012-04-17 | 2 | -13/+147 |
| * | Merge "Remove useless key event handling methods" | Tadashi G. Takaoka | 2012-04-17 | 2 | -49/+0 |
| |\ |
|
| | * | Remove useless key event handling methods•••Change-Id: I8c42fba79aba643ab7a145e6fd54ef23855a3ad0
| Tadashi G. Takaoka | 2012-04-18 | 2 | -49/+0 |
| * | | Merge "Pass the previous word down to native code in getSuggestions" | Jean Chalard | 2012-04-17 | 2 | -3/+21 |
| |\ \
| |/
|/| |
|
| | * | Pass the previous word down to native code in getSuggestions•••Change-Id: I477b631d81ef58461e44954f3ae5fd895928bb97
| Jean Chalard | 2012-04-17 | 2 | -3/+21 |
| * | | Add SubtypeUtils.setAditionalInputMethodSubtypes method•••Change-Id: Ia3043346ed87297e01d505980555fdf29ce4f96f
| Tadashi G. Takaoka | 2012-04-17 | 2 | -3/+12 |
| * | | Cache results of the spell checker•••Change-Id: Ie11cd1b07e069474b140fbaae65fca703adc056f
|   satok | 2012-04-17 | 1 | -2/+42 |
