| Commit message (Expand) | Author | Age | Files | Lines |
|---|
| * | Merge "Straighten out database cursors behavior." |   Jean Chalard | 2014-02-18 | 4 | -52/+64 |
| |\ |
|
| | * | Straighten out database cursors behavior.•••Some were never closed, other closed twice. This change
makes all Cursor instances behave, having the #close()
call in a finally{} clause, and puts the burden of closing
the cursor squarely on the creator rather than in the
called methods.
There is however one exception that is beyond the scope
of this change: UserDictionarySettings have a Cursor
member, it's never closed, and fixing the problem is not
obvious. This change adds a TODO for now.
It's not very clear if this change actually helps with
bug#12670151, but it may be related and it's a good
think to do anyway.
Bug: 12670151
Change-Id: I87cc44387e7dee3da1488671b93a28d9d73f7dc0
| Jean Chalard | 2014-02-18 | 4 | -52/+64 |
| * | | Merge "Fix a bug where the cache would be out of sync" | Jean Chalard | 2014-02-18 | 1 | -1/+17 |
| |\ \ |
|
| | * | | Fix a bug where the cache would be out of sync•••During recorrection, the cursor position when calling
commitText is not necessarily at the end of the
composing text.
Besides, RichInputConnection assumes the cursor is
always after any composing text. This is not correct,
but in the practice, it seems all code paths work.
We should fix this in the future.
Bug: 13060691
Change-Id: I15f71fff62d36e80cf6e4a022c5e78af634b199d
| Jean Chalard | 2014-02-18 | 1 | -1/+17 |
| | |/ |
|
| * | | Merge "Cleanup." | Jean Chalard | 2014-02-18 | 2 | -18/+3 |
| |\ \ |
|
| | * | | Cleanup.•••Less code, less chance of stuff escaping, and a bit of a clarification.
Yay.
Change-Id: I3193fd8ad7ac28195260cbc231c4e498a63a460c
| Jean Chalard | 2014-02-18 | 2 | -18/+3 |
| | |/ |
|
| * / | Some cosmetic fixes in LatinIME.java•••Change-Id: Ia2d04ab992f5a0cc736150b2691b2f8ae8f0955d
|   Ken Wakasa | 2014-02-18 | 1 | -40/+38 |
| |/ |
|
| * | Merge "Cosmetic fixes" | Ken Wakasa | 2014-02-18 | 1 | -23/+30 |
| |\ |
|
| | * | Cosmetic fixes•••Change-Id: I6c755565ba7689357d02d26cc0e92a93031953e8
| Ken Wakasa | 2014-02-18 | 1 | -23/+30 |
| * | | Merge "Refactor InputAttributes a bit" |   Tadashi G. Takaoka | 2014-02-18 | 1 | -117/+155 |
| |\ \
| |/
|/| |
|
| | * | Refactor InputAttributes a bit•••Change-Id: I43d65be6de64ba86f83e8528a138e20c4fa1e3ed
| Tadashi G. Takaoka | 2014-02-18 | 1 | -117/+155 |
| * | | Set neutral suggestions should be called after load settings•••Bug: 13058751
Change-Id: Iba49e86b90d595473d91753827d499e551dad45c
| Tadashi G. Takaoka | 2014-02-18 | 3 | -41/+51 |
| |/ |
|
| * | Update important notice version even when user select Settings•••Bug: 13060852
Change-Id: I463fdf3d51cacf99693fcde2998ea751046d1cc5
| Tadashi G. Takaoka | 2014-02-18 | 1 | -1/+1 |
| * | Merge "Don't resume suggestion on links." | Jean Chalard | 2014-02-17 | 4 | -3/+26 |
| |\ |
|
| | * | Don't resume suggestion on links.•••Bug: 11447084
Change-Id: I5bd558b9dd85d1505aa918f44e8ac3e52ec42d97
| Jean Chalard | 2014-02-17 | 4 | -3/+26 |
| * | | Stop overriding InputView.dispatchTouchEvent•••Bug: 11721001
Bug: 11976254
Change-Id: I950f13ec4084da7fd9c1c25fd7abed1e5d31ed4c
| Tadashi G. Takaoka | 2014-02-17 | 1 | -56/+63 |
| |/ |
|
| * | Merge "Stop overriding SuggestionStripView.dispatchTouchEvent" | Tadashi G. Takaoka | 2014-02-17 | 1 | -24/+23 |
| |\ |
|
| | * | Stop overriding SuggestionStripView.dispatchTouchEvent•••Bug: 11721001
Bug: 11976254
Change-Id: Idfdeafe45abb16ca54be529b4f4b2c38c22a7fac
| Tadashi G. Takaoka | 2014-02-17 | 1 | -24/+23 |
| * | | Merge "Add InputMethodSubtypeCompatUtils.isAsciiCapable()" | Tadashi G. Takaoka | 2014-02-17 | 1 | -4/+4 |
| |\ \ |
|
| | * | | Add InputMethodSubtypeCompatUtils.isAsciiCapable()•••Change-Id: I8145f090486f6fe30ef1e992db374cfba0c31012
| Tadashi G. Takaoka | 2014-02-17 | 1 | -4/+4 |
| | |/ |
|
| * | | Merge "Don't show important notice on password field" | Tadashi G. Takaoka | 2014-02-17 | 4 | -12/+27 |
| |\ \
| |/
|/| |
|
| | * | Don't show important notice on password field•••Bug: 10587358
Change-Id: Ieff7960e5e2b8609fddeb173af578a5d9b2c4d98
| Tadashi G. Takaoka | 2014-02-17 | 4 | -12/+27 |
| * | | Merge "Add go to "Settings" button to important notice dialog" | Tadashi G. Takaoka | 2014-02-17 | 2 | -17/+12 |
| |\ \ |
|
| | * | | Add go to "Settings" button to important notice dialog•••This CL also
- removes icons on important notice title.
- changes the "Personalized suggestions" summary text.
This change must be checked in together with Id115d89ba9.
Bug: 10587358
Change-Id: I52ff26fa8ae12445e9014ba08253f69e1be609f4
| Tadashi G. Takaoka | 2014-02-17 | 2 | -17/+12 |
| | |/ |
|
| * / | Remove key show up and dismiss animation•••Bug: 11518021
Change-Id: I4a5eb0732f399612141f7c22d83e2210da612d7e
| Tadashi G. Takaoka | 2014-02-17 | 2 | -0/+2 |
| |/ |
|
| * | Remove unused code.•••Bug: 12810574
Change-Id: I9c7fff60ae0e94d52f3bd19c3e88de5a53b917d7
|   Keisuke Kuroyanagi | 2014-02-15 | 11 | -592/+98 |
| * | Implement PatriciaTriePolicy::getNextWordAndNextToken().•••Bug: 12810574
Change-Id: Id1d44f90de9455d9cbe7b6e0a161cae91d6d422c
| Keisuke Kuroyanagi | 2014-02-15 | 2 | -18/+54 |
| * | Merge "Remove unused argument from readDictionaryBinary." | Keisuke Kuroyanagi | 2014-02-14 | 4 | -42/+13 |
| |\ |
|
| | * | Remove unused argument from readDictionaryBinary.•••Bug: 12810574
Change-Id: Ice415ebd8d11162facca3fe8927ef8a616b11424
| Keisuke Kuroyanagi | 2014-02-14 | 4 | -42/+13 |
| * | | Add PunctuationSuggestions class•••This change must be checked in together with I366c477516.
Bug: 12640318
Change-Id: I8d3864b9d9649c9e3306e82b01a6327b11281b1f
| Tadashi G. Takaoka | 2014-02-14 | 8 | -67/+178 |
| * | | Merge "Show the suggestion strip for the important notice" | Jean Chalard | 2014-02-14 | 3 | -6/+9 |
| |\ \ |
|
| | * | | Show the suggestion strip for the important notice•••Bug: 10587358
Change-Id: Ia060a9ca9dfc2e7fe0750536a9fea3b9cc5900c4
| Jean Chalard | 2014-02-12 | 3 | -6/+9 |
| * | | | Merge "Backward compatibility hack : send delete when empty." | Jean Chalard | 2014-02-13 | 1 | -1/+7 |
| |\ \ \ |
|
| | * | | | Backward compatibility hack : send delete when empty.•••Some apps depend on the keyboard sending something to them
when the text is empty. This is BROKEN. Your app must not lie
to the keyboard about what is before the cursor. If there is something
to delete, you must not pretend there is not and try to catch some
delete event. This will result in a bad user experience. This will not
work with all IMEs. If your app needs this broken behavior, you're
doing it wrong. Seriously guys, we're not in the era of typewriters
any more, there are touch screens, there are gestures, there is
accessibility, there are many innovative IMEs that don't have
keys. Do *NOT* rely on key events.
This change implements an ugly hack so that these broken apps
may continue half-working with LatinIME. We are very unhappy
about this.
Bug: 12998568
Change-Id: Ia62ae2fbee4fee65b463acf3a79aafcfd0defa1d
| Jean Chalard | 2014-02-13 | 1 | -1/+7 |
| * | | | | Merge "Fix UserHistoryDictionaryTests" | Tadashi G. Takaoka | 2014-02-13 | 2 | -25/+23 |
| |\ \ \ \ |
|
| | * | | | | Fix UserHistoryDictionaryTests•••Change-Id: I5f2f555f9c3f471545921ef80e4cf528976be837
| Tadashi G. Takaoka | 2014-02-13 | 2 | -25/+23 |
| * | | | | | Merge "Fix showing all suggestions when the top suggestion is long" | Tadashi G. Takaoka | 2014-02-13 | 2 | -37/+51 |
| |\ \ \ \ \
| |_|/ / /
|/| | | | |
|
| | * | | | | Fix showing all suggestions when the top suggestion is long•••This change also fixes Bug#12982404; displays the suggestion word
using entire suggestions strip if there is only one suggestion.
Bug: 12564279
Bug: 12982404
Change-Id: I51806b90c3ee34a2072880245d4e33f7be273c8f
| Tadashi G. Takaoka | 2014-02-13 | 2 | -37/+51 |
| | |/ / / |
|
| * | | | | Merge "Fix a test." | Jean Chalard | 2014-02-13 | 1 | -17/+29 |
| |\ \ \ \
| |/ / /
|/| | | |
|
| | * | | | Fix a test.•••This fixes two separate problems:
- The word finds itself with two separate suggestion spans.
This is fine for LatinIME, but it's hard to predict whether it's
fine for other interested parties (other keyboards).
- The test for the blue underline was incorrect.
Change-Id: I3ecc849676851bf25a25238d694adaa956521a26
| Jean Chalard | 2014-02-13 | 1 | -17/+29 |
| | |/ / |
|
| * | | | Merge "Refactor dictionary constructor" | Tadashi G. Takaoka | 2014-02-13 | 7 | -59/+34 |
| |\ \ \ |
|
| | * | | | Refactor dictionary constructor•••This change must be checked in together with I3923d5af2a.
Bug: 12994268
Change-Id: I19de6efbdfa3b6c6c69a20a836e53962fd5737de
| Tadashi G. Takaoka | 2014-02-13 | 7 | -59/+34 |
| | |/ / |
|
| * / / | Dump settings.•••Bug: 10315296
Change-Id: Ieb020a23886514b3ba97611d8a6001f32b322f63
| Jean Chalard | 2014-02-12 | 3 | -7/+108 |
| |/ / |
|
| * | | Make importance notice dialog cancel able•••Bug: 10587358
Change-Id: I7415a6f33e6b5542718164fea1555095d23233e5
| Tadashi G. Takaoka | 2014-02-12 | 1 | -1/+1 |
| * | | Revert "Display predictions when the cursor is moved after a word."•••This change is lacking some comments and break some unit tests.
It needs more work.
This reverts commit 38d31a5e79c64e706e1698d2d24adb51c4ac53aa.
Change-Id: I675854fd0729f2d01b7751e35c6d0117f4f88993 | Jean Chalard | 2014-02-10 | 1 | -8/+1 |
| * | | Display predictions when the cursor is moved after a word.•••Bug: 12951777
Change-Id: I744b98df6679edd34ca3c1392e38597325935932
| Jean Chalard | 2014-02-10 | 1 | -1/+8 |
| |/ |
|
| * | Merge "Show important notice strip" | Jean Chalard | 2014-02-10 | 3 | -15/+35 |
| |\ |
|
| | * | Show important notice strip•••Bug: 10587358
Change-Id: I1af3faa59afb2fc4cb90176acff1c2b0b1ba369c
| Tadashi G. Takaoka | 2014-02-10 | 3 | -15/+35 |
| * | | Merge "Remove unused code." | Keisuke Kuroyanagi | 2014-02-10 | 5 | -235/+76 |
| |\ \ |
|
| | * | | Remove unused code.•••Bug: 12810574
Change-Id: If0ef02a984469a3b6e0c00b1c3c8d98d0d2b5466
| Keisuke Kuroyanagi | 2014-02-10 | 5 | -235/+76 |
