| Commit message (Expand) | Author | Age | Files | Lines |
|---|
| * | Remove FeedbackLog instance variables.•••For a while, the ResearchLogger supported comprehensive recording of the
last few words in case the user wished to upload this data to give
developers feedback. However, this mechanism was not implemented well
(keeping a separate copy of the data), did not make the collected data
clear to the user, and was not working properly in the latest build (NPEs).
The mechanism in fact was deprecated in favor of the "userRecording"
mechanism in which the user explicitly turned on comprehensive recording,
demonstrated the issue they were experiencing, and then turned it off.
This change removes the vestiges of the FeedbackLogging mechanism.
A feedback log is still used to hold the user's message, but it is created
in a local variable as-needed, and not persisted in ResearchLogger.
Change-Id: I6a09d0ed36e1eddb6e57895e7428d22107f75f49
|   Kurt Partridge | 2013-05-13 | 1 | -42/+7 |
| * | Avoid JsonWriter multi-write error•••JsonWriter requires that its clients pass it only a single top-level object.
The existing implementation tries to make code cleaner by having mJsonWriter
never be null, and instead use a global static "NULL_JSON_WRITER" that just
discards data. But because JsonWriter complains if more than one top-level
object is passed, making this a global object does not work. This change
instead copes with mJsonWriter being null.
Change-Id: Ia37ccfc8646e91f11a64713dd92d2846eb86ac54
| Kurt Partridge | 2013-05-10 | 1 | -2/+10 |
| * | Merge "Remove unused code" | Kurt Partridge | 2013-05-10 | 1 | -11/+1 |
| |\ |
|
| | * | Remove unused code•••Change-Id: I192c67e9e8de44f073abc70ec85ebcdb36356c2e
| Kurt Partridge | 2013-05-09 | 1 | -11/+1 |
| * | | Merge "Remove ref to LatinImeLogger preference." | Kurt Partridge | 2013-05-10 | 1 | -5/+0 |
| |\ \ |
|
| | * | | Remove ref to LatinImeLogger preference.•••This is a bug; the ResearchLogger uses ResearchSettings.readResearchLoggerEnabledFlag() instead,
which the user cannot change. (We assume they will just switch to a different keyboard.)
Change-Id: Ib5731c9eeb2bc29d9cf8608033326674f5eb6f7b
| Kurt Partridge | 2013-05-09 | 1 | -5/+0 |
| | |/ |
|
| * / | Avoid NPE by fixing ResearchLogger initialization•••Previously, mMainResearchLog and mMainLogBuffer were set up
when the user moved to a new TextView, and set to null when
the user left the TextView. This change causes
mMainResearchLog, mMainLogBuffer, mFeedbackLog, and
mFeedbackLogBuffer to be non-null forever after init() is
called. start() no longer sets up these fields; instead
they are cleared and reset every time stop() is called.
Checks for null values are now removed.
The earlier code just didn't initialize these variables if
the user disabled logging, but since the new version
invariantly keeps these variables valid, we add a check for
whether the user has enabled logging in publishLogUnits().
Change-Id: Ifde3517f1cf924cfa33cda95fec24529b52b3c08
| Kurt Partridge | 2013-05-09 | 1 | -93/+62 |
| |/ |
|
| * | Allow LogUnits to hold >1 word•••LogUnits have been annotated with the autocorrected words, but
until now this was assumed to be a single word without spaces.
But spaceless typing can result in spaces in the LogUnit label. With this
change, the LogUnit inspects the autocorrected text to determine how many
words were inserted, and counts them accurately.
This change corrects a privacy problem, which was that if the word sampling
algorithm chose a LogUnit that actually contained multiple words, then more
than two successive words would be included in the log.
Change-Id: I7c01c3dd3ac33d7e96c00836256bae9c14b124ed
| Kurt Partridge | 2013-04-19 | 1 | -18/+21 |
| * | Merge "Label logUnits after LatinImeOnEndBatchInput" | Kurt Partridge | 2013-04-17 | 1 | -0/+3 |
| |\ |
|
| | * | Label logUnits after LatinImeOnEndBatchInput•••Previously only a commitText would cause a LogUnit to be
labeled with the word that the data generates. In the case
of gestured text, this information is available when
LatinIME#onEndBatchInput is called. Labeling the LogUnit
at this time means that the Log will have labeled words even
if stop() is called before commit.
Change-Id: Idb2f99a9c159a1b1aa00448a2ecddeca6c351c3e
| Kurt Partridge | 2013-04-17 | 1 | -0/+3 |
| * | | Merge "Fix NPE" | Kurt Partridge | 2013-04-17 | 1 | -1/+1 |
| |\ \ |
|
| | * | | Fix NPE•••Change-Id: I8a091fb63dab12a0d2ba69e2fe393249bc68d103
| Kurt Partridge | 2013-04-16 | 1 | -1/+1 |
| | |/ |
|
| * | | Merge "Fix logic error" | Kurt Partridge | 2013-04-17 | 1 | -1/+1 |
| |\ \ |
|
| | * | | Fix logic error•••Change-Id: Ia36660c66504ba2fbb7f125704926a08726df87a
| Kurt Partridge | 2013-04-16 | 1 | -1/+1 |
| | |/ |
|
| * | | Merge "Small dot in corner was not visible" | Kurt Partridge | 2013-04-17 | 1 | -1/+1 |
| |\ \ |
|
| | * | | Small dot in corner was not visible•••Framework change perhaps? Even if not, this makes it more visible
Change-Id: Ib6d36b5a30136c4516adac666bdff36d1cd9b337
| Kurt Partridge | 2013-04-16 | 1 | -1/+1 |
| | |/ |
|
| * / | Include nanoTime in filename•••System is fast enough that sometimes SystemClock.currentTimeMillis() is duplicated
when used to make a unique filename.
Change-Id: I9454fbb5e10265d36b8e17cba183a1591d52cc7b
| Kurt Partridge | 2013-04-16 | 1 | -3/+3 |
| |/ |
|
| * | Merge "Avoid NPE" | Kurt Partridge | 2013-04-12 | 1 | -3/+3 |
| |\ |
|
| | * | Avoid NPE•••Initialize FeedbackLog earlier to avoid NPE
Change-Id: I646944c68a7d092345def16060b2a4edd8c7dbef
| Kurt Partridge | 2013-03-26 | 1 | -3/+3 |
| * | | Restart suggestions when the cursor moves.•••This uses the old suggestions. It does not try to recompute
new suggestions if there are no old suggestions yet: this is
coming in a later change.
If there are no suggestions, this shows the word itself
as a suggestion.
Bug: 8084810
Change-Id: I4c2e25df0ff3673be1825f57a0c19a9d23d47a48
|   Jean Chalard | 2013-04-12 | 1 | -1/+1 |
| * | | Better isolate ResearchLogging data•••Calls to LatinIME#onStartInputViewInternal log important information
about the context in which an IME is used. This is reported as a
single LogStatement. Previously, this was not placed into a separate
LogUnit, and was mixed in with general word data. This change wraps
this LogStatement in its own LogUnit.
Change-Id: I0fecd41c8a1de622a764cc4b5d6902336697046c
| Kurt Partridge | 2013-04-10 | 1 | -0/+3 |
| * | | Better release build reporting•••The ResearchLogger reports whether a build is a release build or not
to avoid polluting data with IME debugging work by developers.
Previously this was done by checking a constant flag, which was also
serving the dual purpose of masking out debug code in release builds.
This change introduces a heuristic to determine whether a build was
created by a developer (using the package versionName), and annotating
the data sent to the server appropriately.
Change-Id: Icbad17c66b703cabf6d23d05e2c7c41bcceaae45
| Kurt Partridge | 2013-04-10 | 1 | -4/+21 |
| * | | Merge "[FileEncap18] Clean up uploading scheduling" | Kurt Partridge | 2013-04-09 | 1 | -29/+2 |
| |\ \ |
|
| | * | | [FileEncap18] Clean up uploading scheduling•••- Move scheduling logic from ResearchLogger.java to
UploaderService.java
- Switch to a one-shot timer. Previously the uploader was scheduled
on an inexact repeating schedule. It's better to reschedule the
next upload after the current one is finished to reduce the chances
of multiple uploads happening at the same time.
- Avoid double-execution
- Previously a scheduled upload might run right after an explicit
one if they occured at the same time. This change reduces the
chances of this.
- Some method extraction and naming
Change-Id: I9efda11be77d334c7f61bd40a36d65f0421ebde4
| Kurt Partridge | 2013-03-25 | 1 | -29/+2 |
| | |/ |
|
| * | | Merge "Allow logging while replaying" | Kurt Partridge | 2013-04-09 | 1 | -2/+1 |
| |\ \ |
|
| | * | | Allow logging while replaying•••Previously logging was disabled during replay. This makes it impossible to use logged data as a
regression test, since the new log was unavailable. This change corrects this problem.
Change-Id: I19dc31def2f2f87fd219dc561c739d18e4ab9c9c
| Kurt Partridge | 2013-04-01 | 1 | -2/+1 |
| * | | | Merge "Split LogUnits differently." | Kurt Partridge | 2013-04-01 | 1 | -2/+1 |
| |\ \ \
| |/ /
|/| | |
|
| | * | | Split LogUnits differently.•••Previously an autocorrection caused a new LogUnit to be started,
splitting off the previous LogUnit right at the autocorrection method
time. This change causes the split to happen before the MotionEvents
that led to the autocorrection being called.
Change-Id: I2504df8eb47ee77e5f46bac34a8450636c03fd9f
| Kurt Partridge | 2013-03-26 | 1 | -2/+1 |
| | |/ |
|
| * / | Close ResearchLogger upon onFinishInputView•••Previously, ResearchLogger#stop() was called both in
LatinIME#onFinishInputView() and in LatinIME#onWindowHidden(). This
resulted in multiple logs being written.
Since onFinishInputView is the more reliable of the two (it is called
in InputMethodService#onDestroy; onWindowHidden is not), the code now
uses onFinishInputView as a stopping signal.
Change-Id: Iae4b8c3bdab226027624eeab19b3737367e4a108
| Kurt Partridge | 2013-03-25 | 1 | -12/+14 |
| |/ |
|
| * | resolved conflicts for merge of 5b048292 to master•••Change-Id: I67ebab46954cd7b8e3e79e7fed523bafb15f8835
|   Tadashi G. Takaoka | 2013-03-19 | 1 | -9/+11 |
| |\ |
|
| | * | Rename ProductionFlag.IS_EXPERIMENTAL to USES_DEVELOPMENT_ONLY_DIAGNOSTICS•••bug: 8393568
Change-Id: Ie5edf44a3627aca9416145aff56bf05bbf2a05f3
|   Ken Wakasa | 2013-03-18 | 1 | -9/+11 |
| * | | [FileEncap9] Extract ResearchLogDirectory class•••Previously used a monotonically increasing int. Now uses uuid and nanoseconds.
squashed in:
[FileEncap11] Read preference from ResearchSettings
Change-Id: Ic779e0a69db6b16e92c6f4b63dbe7b7add566ab6
[FileEncap12] Simplify directory cleanup invocation
Change-Id: I688047409c0343d32b11447fb625dfb726c731ec
[FileEncap14] Change log filename syntax
Change-Id: I9243b20b2eb392f81ab8c5c3d19315211240e0bc
Change-Id: I5c9d70e0cb7b0965158e17dd71dfab796bd9a440
| Kurt Partridge | 2013-03-14 | 1 | -68/+25 |
| * | | [Lazy1] Switch to blocking log closures•••Change-Id: I4daec20b7b47b0d71c5aab6e17cd660015e19e71
| Jean Chalard | 2013-03-12 | 1 | -27/+13 |
| * | | Little cleanups•••Change-Id: I2ded3d0a29610941fac27c9b26168dd6c06ceccc
| Kurt Partridge | 2013-03-05 | 1 | -7/+4 |
| * | | Clean up initialization ordering•••This change is based on an earlier one that got stuck in Gerrit: Iab77504b
Change-Id: I27ad9dfb1bbb2300bd1e61d881a6ea0e116db066
| Kurt Partridge | 2013-03-05 | 1 | -29/+24 |
| * | | Clean up logic in onUserLoggingConsent•••- Make ResearchSetting for whether the user has seen the splash screen
- Inline #setLoggingAllowed, which is short and is now only called by
onUserLoggingConsent
Change-Id: Icdf4592777b80643807b6ccf1d3896459c503e02
| Kurt Partridge | 2013-03-04 | 1 | -17/+6 |
| * | | Clean up PREF_USABILITY_STUDY_MODE•••- Refer to a common default value in DebugSettings
- Make PREF_USABILITY_STUDY_MODE independent of the ResearchLogger
- ResearchLogger uses its own preference through ResearchSettings
multi-project commit with Ie0df836c9d779eba484b522666ec357f4e234823
Change-Id: I88547a2f619db6e7364abbbec12f9f76855dd11a
| Kurt Partridge | 2013-03-04 | 1 | -14/+4 |
| * | | Merge "Remove MainLogBuffer#setSuggest()" | Kurt Partridge | 2013-03-04 | 1 | -5/+10 |
| |\ \ |
|
| | * | | Remove MainLogBuffer#setSuggest()•••multi-project commit with Ia98b1406fc2ee11a96893c77ea58d800fece7624
Change-Id: I8bc3d07b83dbe7d8fc56a618de07dade7f510b13
| Kurt Partridge | 2013-03-01 | 1 | -5/+10 |
| * | | | Merge "Move UUID preference reading to ResearchSettings.java" | Kurt Partridge | 2013-03-02 | 1 | -19/+6 |
| |\ \ \
| |/ /
|/| | |
|
| | * | | Move UUID preference reading to ResearchSettings.java•••Change-Id: I8157249259cf8c3218c5c82a5729f4cbc1fb4eeb
| Kurt Partridge | 2013-02-28 | 1 | -19/+6 |
| * | | | [TestPrep22] Make variable package-private for testing•••Change-Id: I902a6a40df1c672c611672f34d2f3237b0d1821b
| Kurt Partridge | 2013-02-28 | 1 | -1/+1 |
| |/ / |
|
| * / | Ensure Preference listener is unregistered•••Change-Id: I1a4d1e7bc45fc30cb1b63ea6020f0eee6e804333
| Kurt Partridge | 2013-02-26 | 1 | -0/+6 |
| |/ |
|
| * | [TestPrep5] Parameterize MainLogBuffer•••Change-Id: I6d84f490922cd1f40e44ca4f95c9d950fba38290
| Kurt Partridge | 2013-02-20 | 1 | -4/+14 |
| * | [TestPrep1] Move MotionEvent.Action strings to LoggingUtils•••Change-Id: I7b9ed800552f2fd546ed21e9dc06ea1ff5798337
| Kurt Partridge | 2013-02-20 | 1 | -11/+1 |
| * | Merge "Add batchMode field to PickSuggestionManually" | Kurt Partridge | 2013-02-12 | 1 | -2/+2 |
| |\ |
|
| | * | Add batchMode field to PickSuggestionManually•••Change-Id: Iaaffc71378154240538bf90f0b85c3f17f3f78b3
| Kurt Partridge | 2013-02-08 | 1 | -2/+2 |
| * | | Close file properly•••Change-Id: Ied55b6a6f1e64bbca558316d8d3d207d7655cf91
| Kurt Partridge | 2013-02-08 | 1 | -4/+12 |
| |/ |
|
| * | Refactor LogStatement publishing method•••The method in LogUnit for publishing a LogStatement to a JsonWriter doesn't
depend on anything in the LogUnit.
multi-project commit with Id1d6ff4851148bba0e6b5a1ec6eec2b842d9c707
Change-Id: I323cec239d6ea1cee602c2ecf9b13713791e9283
| Kurt Partridge | 2013-02-05 | 1 | -3/+11 |
| * | Merge "[Rlog79b] Save channel name during internal use" | Kurt Partridge | 2013-02-04 | 1 | -4/+31 |
| |\ |
|
