| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Change-Id: I77e25fd4032b7fc3b4b565c9bab18a2824d7bb76
|
|
|
|
| |
Change-Id: I2c16134a24088dbc30b74ae7c5bc578a9d84a960
|
|
|
|
|
|
|
| |
Instead of CODE_RESEARCH, special outputText ".research." is used to
invoke a research feedback dialog.
Change-Id: Ic95c956ab4f2b5f0c3f2205c9bbcdcfb67db5d6e
|
|
|
|
| |
Change-Id: I06c30aab462ce5b17157ff71d5d76f9755178080
|
|
|
|
| |
Change-Id: I7290cd1fb675a1b85b9b6ac2d464c932b5bca1dd
|
|\ |
|
| |
| |
| |
| |
| |
| |
| | |
JsonUtils knows how to output MotionEvents into json; that mechanism
should be reused for SuddenJumpingTouchEventHandler.
Change-Id: Id4c36c05533a3a329bf43ba33d57c0830dc4d196
|
| |
| |
| |
| |
| | |
Bug: 9550800
Change-Id: I087205530a5dbcff4bf08f48f4aa7068aae93215
|
|/
|
|
|
|
| |
Range has grown a bit too big to stay an internal class.
Change-Id: Ic3fbc48a5d10776eedd7559c4d696e5926b88288
|
|\ |
|
| |
| |
| |
| | |
Change-Id: I5cad5d5814303d7ca4abadd3fca1c37bd1bc357e
|
|/
|
|
| |
Change-Id: I1c5b27c8edf231680edb8d96f63b9d04cfc6a6fa
|
|
|
|
|
|
| |
b/9422713
Change-Id: I4880fad6a5b10d09ca11b63311f14862bee724e5
|
|\ |
|
| |
| |
| |
| | |
Change-Id: I4f08632d97f182d312edc82bda3c3897a71099ad
|
|/
|
|
|
|
|
|
|
|
|
|
|
| |
If the logger feedback screen is up and the user hits the home button or the
keyboard otherwise closes, the system won't let the user enter feedback again,
because it is waiting for the user to finish the first one.
With this change, the state associated with the feedback screen is
cleared when the user closes the keyboard.
b/9398772
Change-Id: I832a82793ad42e31b6b3fdb04fabcea75facde7d
|
|
|
|
| |
Change-Id: I174eb8e92820fe6e7f8d3b89afae12d94063ef5d
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Now that separators are put into their own LogUnits, they must be handled
when going through a revert.
Bug: 9088919
Change-Id: Ibebd0752bb2fa38d74ac96001d63070dd419cee3
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
The period-generating double-space adds an extra LogUnit --
it must be removed when reverting.
Bug: 9088919
Change-Id: Ic148f40b4030a9b4a0651029bda87f7b94a52252
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
A LogUnit is only uncommitted if the LogUnit's word matches what is
expected. But a LogUnit never stores numbers, only scrubbed words that
replace numbers with a special character. So when uncommitting, the
text from the TextView must also be scrubbed for the comparison to pass
correctly.
Bug: 9088919
Change-Id: I9b56f10afce6d0cc84eb9ead3b9a9b1e061ae39c
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
Now that separators have their own LogUnits, they must be uncommitted
from the LogBuffer when backspacing over them.
Bug: 9088919
Change-Id: Ib36cc94939b93abe18850a06bced17caf8aaa5b9
|
|/
|
|
|
|
| |
Bug: 9088919
Change-Id: I17187aa0afc1c3e9d32269c65f66cfb3a08663cb
|
|\ |
|
| |
| |
| |
| |
| |
| | |
The removed method was used in old versions of ALK, never in master.
Change-Id: I607009d4fcca7c7c8493fee51ecd923e6a6b3890
|
|/
|
|
|
|
|
| |
This change renames containsCorrection to avoid confusion with
CorrectionInfo, and to better clarify its meaning.
Change-Id: I5d8f8e2b03133c15a60d4e8b0f395cda1fff5447
|
|
|
|
|
|
| |
Addresses b/9074239
Change-Id: I91a3bfcbd32b03e4891ff5f65be01383a3fb8975
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Word boundaries are currently logged, but only if all the
details of a word pass the privacy filter and are logged.
This change records when a word is committed in all cases,
but does not disclose the word contents or any data used in
its construction.
Addresses b/9070768
Change-Id: I573679d0685c088aca65af99e46337a2f429f816
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently isAllowedToLog only checks the state of the
ResearchLogger, and does not consider which log the data is
going to. This causes problems with the logs for Feedback.
The Feedback log should inhibit normal logging procedures,
but the system needs to be able to write specific data
directly to it.
This change renames to isAllowedToLogTo and adds the
destination ResearchLog as a parameter. A FeedbackLog is also
added as a new class so it can be distinguished from other
ResearchLogs.
Change-Id: I5a1eea05bb040c26bf816b89179f44b3024fa2ad
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Punctuation is currently put into the same LogUnit as the
following word. This is counter-intuitive and makes
post-processing more complicated.
This change causes punctuation to be put into its own
LogUnit.
A tricky case is the phantom space. A phantom space is
inserted right before other text, whose MotionEvents have
already been collected and inserted into mCurrentLogBuffer.
Phantom spaces are handled by creating their own LogUnit and
inserting it into the LogBuffer right before
mCurrentLogBuffer is shifted in.
Change-Id: I102d7cd93982ad37ba0abb6c1ac0f66b85b5f95d
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the user reverts a commit, this causes the committed
word to be changed. The user usually then goes back to edit
that word. Going back to edit causes an uncommit, so that
the editing actions are added onto the LogUnit containing
the operations used to construct the word.
But currently, reverting also involves its own
commit/uncommit pair, with the caller performing the
uncommit, and the commit happening inside the revert
command. This may have been necessary in the past, when
revert was called in different situations, but is
unnecessary now. Furthermore, the guarding conditions are
currently such that the uncommit doesn't always undo the
effects of the commit, corrupting the log output.
Change-Id: I74af41f4f1db2fcabfa496dcc4a2d7bd0af19b3a
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For a while, the ResearchLogger supported comprehensive recording of the
last few words in case the user wished to upload this data to give
developers feedback. However, this mechanism was not implemented well
(keeping a separate copy of the data), did not make the collected data
clear to the user, and was not working properly in the latest build (NPEs).
The mechanism in fact was deprecated in favor of the "userRecording"
mechanism in which the user explicitly turned on comprehensive recording,
demonstrated the issue they were experiencing, and then turned it off.
This change removes the vestiges of the FeedbackLogging mechanism.
A feedback log is still used to hold the user's message, but it is created
in a local variable as-needed, and not persisted in ResearchLogger.
Change-Id: I6a09d0ed36e1eddb6e57895e7428d22107f75f49
|
|
|
|
|
|
|
|
|
|
|
| |
JsonWriter requires that its clients pass it only a single top-level object.
The existing implementation tries to make code cleaner by having mJsonWriter
never be null, and instead use a global static "NULL_JSON_WRITER" that just
discards data. But because JsonWriter complains if more than one top-level
object is passed, making this a global object does not work. This change
instead copes with mJsonWriter being null.
Change-Id: Ia37ccfc8646e91f11a64713dd92d2846eb86ac54
|
|\ |
|
| |
| |
| |
| | |
Change-Id: I192c67e9e8de44f073abc70ec85ebcdb36356c2e
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| | |
This is a bug; the ResearchLogger uses ResearchSettings.readResearchLoggerEnabledFlag() instead,
which the user cannot change. (We assume they will just switch to a different keyboard.)
Change-Id: Ib5731c9eeb2bc29d9cf8608033326674f5eb6f7b
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, mMainResearchLog and mMainLogBuffer were set up
when the user moved to a new TextView, and set to null when
the user left the TextView. This change causes
mMainResearchLog, mMainLogBuffer, mFeedbackLog, and
mFeedbackLogBuffer to be non-null forever after init() is
called. start() no longer sets up these fields; instead
they are cleared and reset every time stop() is called.
Checks for null values are now removed.
The earlier code just didn't initialize these variables if
the user disabled logging, but since the new version
invariantly keeps these variables valid, we add a check for
whether the user has enabled logging in publishLogUnits().
Change-Id: Ifde3517f1cf924cfa33cda95fec24529b52b3c08
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LogUnits have been annotated with the autocorrected words, but
until now this was assumed to be a single word without spaces.
But spaceless typing can result in spaces in the LogUnit label. With this
change, the LogUnit inspects the autocorrected text to determine how many
words were inserted, and counts them accurately.
This change corrects a privacy problem, which was that if the word sampling
algorithm chose a LogUnit that actually contained multiple words, then more
than two successive words would be included in the log.
Change-Id: I7c01c3dd3ac33d7e96c00836256bae9c14b124ed
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously only a commitText would cause a LogUnit to be
labeled with the word that the data generates. In the case
of gestured text, this information is available when
LatinIME#onEndBatchInput is called. Labeling the LogUnit
at this time means that the Log will have labeled words even
if stop() is called before commit.
Change-Id: Idb2f99a9c159a1b1aa00448a2ecddeca6c351c3e
|
|\ \ |
|
| |/
| |
| |
| | |
Change-Id: I8a091fb63dab12a0d2ba69e2fe393249bc68d103
|
|\ \ |
|
| |/
| |
| |
| | |
Change-Id: Ia36660c66504ba2fbb7f125704926a08726df87a
|
|\ \ |
|