| Commit message (Expand) | Author | Age | Files | Lines |
* | Merge "Avoid NPE" |  Kurt Partridge | 2013-04-12 | 1 | -3/+3 |
|\ |
|
| * | Avoid NPE•••Initialize FeedbackLog earlier to avoid NPE
Change-Id: I646944c68a7d092345def16060b2a4edd8c7dbef
|  Kurt Partridge | 2013-03-26 | 1 | -3/+3 |
* | | Restart suggestions when the cursor moves.•••This uses the old suggestions. It does not try to recompute
new suggestions if there are no old suggestions yet: this is
coming in a later change.
If there are no suggestions, this shows the word itself
as a suggestion.
Bug: 8084810
Change-Id: I4c2e25df0ff3673be1825f57a0c19a9d23d47a48
|  Jean Chalard | 2013-04-12 | 1 | -1/+1 |
* | | Merge "Better isolate ResearchLogging data" |  Kurt Partridge | 2013-04-11 | 1 | -0/+3 |
|\ \ |
|
| * | | Better isolate ResearchLogging data•••Calls to LatinIME#onStartInputViewInternal log important information
about the context in which an IME is used. This is reported as a
single LogStatement. Previously, this was not placed into a separate
LogUnit, and was mixed in with general word data. This change wraps
this LogStatement in its own LogUnit.
Change-Id: I0fecd41c8a1de622a764cc4b5d6902336697046c
|  Kurt Partridge | 2013-04-10 | 1 | -0/+3 |
* | | | Merge "Preserve a class for testing" |  Kurt Partridge | 2013-04-10 | 1 | -0/+3 |
|\ \ \
| |/ /
|/| | |
|
| * | | Preserve a class for testing•••Addresses b/8583091
Change-Id: I89605223784312d9572dfc7c8aaa7e5eba44c4f6
|  Kurt Partridge | 2013-04-10 | 1 | -0/+3 |
* | | | Better release build reporting•••The ResearchLogger reports whether a build is a release build or not
to avoid polluting data with IME debugging work by developers.
Previously this was done by checking a constant flag, which was also
serving the dual purpose of masking out debug code in release builds.
This change introduces a heuristic to determine whether a build was
created by a developer (using the package versionName), and annotating
the data sent to the server appropriately.
Change-Id: Icbad17c66b703cabf6d23d05e2c7c41bcceaae45
|  Kurt Partridge | 2013-04-10 | 1 | -4/+21 |
|/ / |
|
* | | Merge "[FileEncap18] Clean up uploading scheduling" |  Kurt Partridge | 2013-04-09 | 3 | -31/+51 |
|\ \ |
|
| * | | [FileEncap18] Clean up uploading scheduling•••- Move scheduling logic from ResearchLogger.java to
UploaderService.java
- Switch to a one-shot timer. Previously the uploader was scheduled
on an inexact repeating schedule. It's better to reschedule the
next upload after the current one is finished to reduce the chances
of multiple uploads happening at the same time.
- Avoid double-execution
- Previously a scheduled upload might run right after an explicit
one if they occured at the same time. This change reduces the
chances of this.
- Some method extraction and naming
Change-Id: I9efda11be77d334c7f61bd40a36d65f0421ebde4
|  Kurt Partridge | 2013-03-25 | 3 | -31/+51 |
| |/ |
|
* | | Merge "Allow logging while replaying" |  Kurt Partridge | 2013-04-09 | 1 | -2/+1 |
|\ \ |
|
| * | | Allow logging while replaying•••Previously logging was disabled during replay. This makes it impossible to use logged data as a
regression test, since the new log was unavailable. This change corrects this problem.
Change-Id: I19dc31def2f2f87fd219dc561c739d18e4ab9c9c
|  Kurt Partridge | 2013-04-01 | 1 | -2/+1 |
* | | | Merge "Split LogUnits differently." |  Kurt Partridge | 2013-04-01 | 1 | -2/+1 |
|\ \ \
| |/ /
|/| | |
|
| * | | Split LogUnits differently.•••Previously an autocorrection caused a new LogUnit to be started,
splitting off the previous LogUnit right at the autocorrection method
time. This change causes the split to happen before the MotionEvents
that led to the autocorrection being called.
Change-Id: I2504df8eb47ee77e5f46bac34a8450636c03fd9f
|  Kurt Partridge | 2013-03-26 | 1 | -2/+1 |
| |/ |
|
* / | Close ResearchLogger upon onFinishInputView•••Previously, ResearchLogger#stop() was called both in
LatinIME#onFinishInputView() and in LatinIME#onWindowHidden(). This
resulted in multiple logs being written.
Since onFinishInputView is the more reliable of the two (it is called
in InputMethodService#onDestroy; onWindowHidden is not), the code now
uses onFinishInputView as a stopping signal.
Change-Id: Iae4b8c3bdab226027624eeab19b3737367e4a108
|  Kurt Partridge | 2013-03-25 | 1 | -12/+14 |
|/ |
|
* | resolved conflicts for merge of 5b048292 to master•••Change-Id: I67ebab46954cd7b8e3e79e7fed523bafb15f8835
|  Tadashi G. Takaoka | 2013-03-19 | 10 | -20/+32 |
|\ |
|
| * | Rename ProductionFlag.IS_EXPERIMENTAL to USES_DEVELOPMENT_ONLY_DIAGNOSTICS•••bug: 8393568
Change-Id: Ie5edf44a3627aca9416145aff56bf05bbf2a05f3
|  Ken Wakasa | 2013-03-18 | 9 | -19/+30 |
* | | [FileEncap9] Extract ResearchLogDirectory class•••Previously used a monotonically increasing int. Now uses uuid and nanoseconds.
squashed in:
[FileEncap11] Read preference from ResearchSettings
Change-Id: Ic779e0a69db6b16e92c6f4b63dbe7b7add566ab6
[FileEncap12] Simplify directory cleanup invocation
Change-Id: I688047409c0343d32b11447fb625dfb726c731ec
[FileEncap14] Change log filename syntax
Change-Id: I9243b20b2eb392f81ab8c5c3d19315211240e0bc
Change-Id: I5c9d70e0cb7b0965158e17dd71dfab796bd9a440
|  Kurt Partridge | 2013-03-14 | 5 | -82/+153 |
* | | Merge "[Lazy4] Remove useless debug code" |  Kurt Partridge | 2013-03-14 | 1 | -33/+0 |
|\ \ |
|
| * | | [Lazy4] Remove useless debug code•••This code is cluttering readability and getting in the way
of future updates.
Future updates will make it much easier to debug and to
test this code, so this needs to disappear.
Change-Id: I32e28ec608587b6b7c07250a2692b13e8fc98465
|  Jean Chalard | 2013-03-08 | 1 | -33/+0 |
* | | | [Lazy2] Pass a runnable to abort•••Change-Id: I721afbf426099753aa876a55323eb806b08c24d6
|  Jean Chalard | 2013-03-12 | 1 | -4/+11 |
* | | | [Lazy1] Switch to blocking log closures•••Change-Id: I4daec20b7b47b0d71c5aab6e17cd660015e19e71
|  Jean Chalard | 2013-03-12 | 2 | -42/+45 |
|/ / |
|
* | | [FileEncap8] Remove useless "success" variable•••Change-Id: Icf76bc0b795b6a9221d9a6d61c38df31af54ab7b
|  Kurt Partridge | 2013-03-07 | 1 | -13/+3 |
* | | [FileEncap7] Extract uploadContents method•••Change-Id: I018b2726533042dbcb25713ea039aec41c148db2
|  Kurt Partridge | 2013-03-07 | 1 | -8/+11 |
* | | [FileEncap6] Extract Uploader class•••Gerrit was stuck on original change I9ef4eb7450
Change-Id: I6d4ee686944074779aca5b09b018782c7033874d
|  Kurt Partridge | 2013-03-07 | 2 | -162/+197 |
* | | [FileEncap5] Move conditional logic to caller•••Change-Id: I6599539059f86dc8902210d325439c08035b2e2a
|  Kurt Partridge | 2013-03-06 | 1 | -3/+4 |
* | | [FileEncap4] Simplify logic•••Change-Id: Ibb8660d12812b867856259d3e5c04a31e281027d
|  Kurt Partridge | 2013-03-06 | 1 | -4/+5 |
* | | [FileEncap3] Extract isUploadingUnconditionally method•••- remove isUploadingUnconditionally local variable
Change-Id: I69be8708c1f306568cbb9c5cbefc9e42a87df497
|  Kurt Partridge | 2013-03-06 | 1 | -5/+8 |
* | | [FileEncap2] Remove mCanUpload instance variable•••Change-Id: I62a100c4d73bb64a14a7994f7dd9af7b6946d064
|  Kurt Partridge | 2013-03-06 | 1 | -6/+5 |
* | | [FileEncap1] Extract hasUploadingPermisssions method•••Change-Id: Ica1dabcf066cde6580035f12fa35a404cb32fb3f
|  Kurt Partridge | 2013-03-06 | 1 | -4/+7 |
* | | Little cleanups•••Change-Id: I2ded3d0a29610941fac27c9b26168dd6c06ceccc
|  Kurt Partridge | 2013-03-05 | 1 | -7/+4 |
* | | Clean up initialization ordering•••This change is based on an earlier one that got stuck in Gerrit: Iab77504b
Change-Id: I27ad9dfb1bbb2300bd1e61d881a6ea0e116db066
|  Kurt Partridge | 2013-03-05 | 1 | -29/+24 |
* | | Clean up logic in onUserLoggingConsent•••- Make ResearchSetting for whether the user has seen the splash screen
- Inline #setLoggingAllowed, which is short and is now only called by
onUserLoggingConsent
Change-Id: Icdf4592777b80643807b6ccf1d3896459c503e02
|  Kurt Partridge | 2013-03-04 | 2 | -17/+17 |
* | | Clean up PREF_USABILITY_STUDY_MODE•••- Refer to a common default value in DebugSettings
- Make PREF_USABILITY_STUDY_MODE independent of the ResearchLogger
- ResearchLogger uses its own preference through ResearchSettings
multi-project commit with Ie0df836c9d779eba484b522666ec357f4e234823
Change-Id: I88547a2f619db6e7364abbbec12f9f76855dd11a
|  Kurt Partridge | 2013-03-04 | 2 | -14/+15 |
* | | Merge "Remove MainLogBuffer#setSuggest()" |  Kurt Partridge | 2013-03-04 | 2 | -10/+13 |
|\ \ |
|
| * | | Remove MainLogBuffer#setSuggest()•••multi-project commit with Ia98b1406fc2ee11a96893c77ea58d800fece7624
Change-Id: I8bc3d07b83dbe7d8fc56a618de07dade7f510b13
|  Kurt Partridge | 2013-03-01 | 2 | -10/+13 |
* | | | Merge "Move UUID preference reading to ResearchSettings.java" |  Kurt Partridge | 2013-03-02 | 2 | -19/+45 |
|\ \ \
| |/ /
|/| | |
|
| * | | Move UUID preference reading to ResearchSettings.java•••Change-Id: I8157249259cf8c3218c5c82a5729f4cbc1fb4eeb
|  Kurt Partridge | 2013-02-28 | 2 | -19/+45 |
* | | | [TestPrep22] Make variable package-private for testing•••Change-Id: I902a6a40df1c672c611672f34d2f3237b0d1821b
|  Kurt Partridge | 2013-02-28 | 1 | -1/+1 |
* | | | [TestPrep20] Clean up import statement•••Change-Id: Ifcfec09b669d8b2012b1c960bd4b1471c7946870
|  Kurt Partridge | 2013-02-28 | 1 | -1/+0 |
|/ / |
|
* | | Merge "[TestPrep18] Make class public for testing" |  Kurt Partridge | 2013-02-28 | 1 | -1/+1 |
|\ \ |
|
| * | | [TestPrep18] Make class public for testing•••Change-Id: I4b457f44dd6a5a595c61a62061ea02c251fa9ab1
|  Kurt Partridge | 2013-02-26 | 1 | -1/+1 |
* | | | Merge "[TestPrep17] Allow fake dictionary for testing" |  Kurt Partridge | 2013-02-27 | 1 | -0/+13 |
|\| | |
|
| * | | [TestPrep17] Allow fake dictionary for testing•••Currently ResearchLog requires a full dictionary to perform privacy-related checks.
This makes testing difficult. This change allows a fake dictionary to be used instead.
Change-Id: Ifca5bd8647475a6b84e4324117e0faa0a35479ee
|  Kurt Partridge | 2013-02-26 | 1 | -0/+13 |
* | | | Merge "Ensure Preference listener is unregistered" |  Kurt Partridge | 2013-02-27 | 1 | -0/+6 |
|\ \ \
| |/ /
|/| | |
|
| * | | Ensure Preference listener is unregistered•••Change-Id: I1a4d1e7bc45fc30cb1b63ea6020f0eee6e804333
|  Kurt Partridge | 2013-02-26 | 1 | -0/+6 |
| |/ |
|
* | | [TestPrep11] Only use mHasWrittenData to control JsonWriter#endArray() call•••Change-Id: If2107e38575b009a4c372194ecd827e27bdbb2b4
|  Kurt Partridge | 2013-02-26 | 1 | -9/+5 |
* | | [TestPrep10] Add some comments•••Change-Id: Ia8e0bd72b0dc09bfc256ec5d1996637554376b5f
|  Kurt Partridge | 2013-02-26 | 1 | -4/+28 |
|/ |
|
* | [TestPrep8] Narrow try/catch scope•••Change-Id: If15f250feb81c2ad55ce1bc7dc3dafa57de87aef
|  Kurt Partridge | 2013-02-21 | 1 | -10/+9 |
* | [TestPrep7] Encapsulate JsonWriter creation•••Change-Id: I4e97fa28dd0bb1101edc0db03f024432fee6f6fe
|  Kurt Partridge | 2013-02-21 | 1 | -8/+19 |